zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused remote ice member from Connection

Browse Source 
Bug: none
Change-Id: Ia80c362ca8cf0fb0ef63427e05131199b4685c6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249982
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35837}
This commit is contained in:
Tommi
2022-01-30 19:58:39 +01:00
committed by WebRTC LUCI CQ
parent 2d218323c8
commit 1bea008f9f
4 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
p2p/base/connection.cc
View File

@ -293,7 +293,6 @@ Connection::Connection(Port* port,
connected_(true),
pruned_(false),
use_candidate_attr_(false),
remote_ice_mode_(ICEMODE_FULL),
requests_(port->thread()),
rtt_(DEFAULT_RTT),
last_ping_sent_(0),

4
p2p/base/connection.h
View File

@ -189,7 +189,6 @@ class Connection : public CandidatePairInterface,
// a nomination value. The controlling agent gets its `acked_nomination_` set
// when receiving a response to a nominating ping.
bool nominated() const { return acked_nomination_ || remote_nomination_; }
void set_remote_ice_mode(IceMode mode) { remote_ice_mode_ = mode; }
int receiving_timeout() const;
void set_receiving_timeout(absl::optional<int> receiving_timeout_ms) {
@ -272,8 +271,6 @@ class Connection : public CandidatePairInterface,
int num_pings_sent() const { return num_pings_sent_; }
IceMode remote_ice_mode() const { return remote_ice_mode_; }
uint32_t ComputeNetworkCost() const;
// Update the ICE password and/or generation of the remote candidate if the
@ -419,7 +416,6 @@ class Connection : public CandidatePairInterface,
// value will be 1 if the connection has been nominated.
uint32_t remote_nomination_ = 0;
IceMode remote_ice_mode_;
StunRequestManager requests_;
int rtt_;
int rtt_samples_ = 0;

1
p2p/base/p2p_transport_channel.cc
View File

@ -264,7 +264,6 @@ void P2PTransportChannel::AddAllocatorSession(
void P2PTransportChannel::AddConnection(Connection* connection) {
RTC_DCHECK_RUN_ON(network_thread_);
connection->set_remote_ice_mode(remote_ice_mode_);
connection->set_receiving_timeout(config_.receiving_timeout);
connection->set_unwritable_timeout(config_.ice_unwritable_timeout);
connection->set_unwritable_min_checks(config_.ice_unwritable_min_checks);

1
p2p/base/port_unittest.cc
View File

@ -284,7 +284,6 @@ class TestChannel : public sigslot::has_slots<> {
conn_ = port_->CreateConnection(remote_candidate, Port::ORIGIN_MESSAGE);
IceMode remote_ice_mode =
(ice_mode_ == ICEMODE_FULL) ? ICEMODE_LITE : ICEMODE_FULL;
conn_->set_remote_ice_mode(remote_ice_mode);
conn_->set_use_candidate_attr(remote_ice_mode == ICEMODE_FULL);
conn_->SignalStateChange.connect(this,
&TestChannel::OnConnectionStateChange);