zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Suppress TSan errors triggered when deadlock detection is enabled.

Browse Source 
These are problematic when running with the default TSan
settings which has deadlock detection enabled.
Our bots still run with it disabled but we want to be
able to turn it back on, thus this is needed.

BUG=3911,4456
TESTED=
Successfully executed:
GYP_DEFINES="tsan=1 release_extra_cflags=-g use_allocator=none" webrtc/build/gyp_webrtc
ninja -C out/Release rtc_unittests
out/Release/rtc_unittests

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44899004

Cr-Commit-Position: refs/heads/master@{#8879}
This commit is contained in:
Henrik Kjellander
2015-03-27 13:46:34 +01:00
parent 9ff73f5dbf
commit 1d36003181
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/build/sanitizers/tsan_suppressions_webrtc.cc
View File

@ -44,6 +44,7 @@ char kTSanDefaultSuppressions[] =
// rtc_unittest // rtc_unittest
// https://code.google.com/p/webrtc/issues/detail?id=3911 for details. // https://code.google.com/p/webrtc/issues/detail?id=3911 for details.
"race:rtc::AsyncInvoker::OnMessage\n"
"race:rtc::FireAndForgetAsyncClosure<FunctorB>::Execute\n" "race:rtc::FireAndForgetAsyncClosure<FunctorB>::Execute\n"
"race:rtc::MessageQueueManager::Clear\n" "race:rtc::MessageQueueManager::Clear\n"
"race:rtc::Thread::Clear\n" "race:rtc::Thread::Clear\n"
@ -51,6 +52,8 @@ char kTSanDefaultSuppressions[] =
"race:webrtc/base/logging.cc\n" "race:webrtc/base/logging.cc\n"
"race:webrtc/base/sharedexclusivelock_unittest.cc\n" "race:webrtc/base/sharedexclusivelock_unittest.cc\n"
"race:webrtc/base/signalthread_unittest.cc\n" "race:webrtc/base/signalthread_unittest.cc\n"
// https://code.google.com/p/webrtc/issues/detail?id=4456
"deadlock:rtc::MessageQueueManager::ClearInternal\n"
// libjingle_p2p_unittest // libjingle_p2p_unittest
// https://code.google.com/p/webrtc/issues/detail?id=2079 // https://code.google.com/p/webrtc/issues/detail?id=2079