zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't log a message that a field is missing if the field trial key starts with "_"

Browse Source 
Bug: None
Change-Id: I6967e8a43ce762e2c272ca9c25e359f23eaf2157
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205003
Commit-Queue: Ying Wang <yinwa@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33143}
This commit is contained in:
Ying Wang
2021-02-02 15:36:16 +01:00
committed by Commit Bot
parent 76a1041f0f
commit 22e37d8857
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
rtc_base/experiments/field_trial_parser.cc
View File

@ -83,7 +83,10 @@ void ParseFieldTrial(
RTC_LOG(LS_WARNING) << "Failed to read empty key field with value '"
<< key << "' in trial: \"" << trial_string << "\"";
}
} else {
} else if (key.empty() || key[0] != '_') {
// "_" is be used to prefix keys that are part of the string for
// debugging purposes but not neccessarily used.
// e.g. WebRTC-Experiment/param: value, _DebuggingString
RTC_LOG(LS_INFO) << "No field with key: '" << key
<< "' (found in trial: \"" << trial_string << "\")";
std::string valid_keys;

5
rtc_base/experiments/struct_parameters_parser.cc
View File

@ -107,7 +107,10 @@ void StructParametersParser::Parse(absl::string_view src) {
break;
}
}
if (!found) {
// "_" is be used to prefix keys that are part of the string for
// debugging purposes but not neccessarily used.
// e.g. WebRTC-Experiment/param: value, _DebuggingString
if (!found && (key.empty() || key[0] != '_')) {
RTC_LOG(LS_INFO) << "No field with key: '" << key
<< "' (found in trial: \"" << src << "\")";
}