zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

metrics: remove WebRTC.PeerConnection.IceServers.*

Browse Source 
which have shown that 32 is a reasonably safe limit and informed
  https://github.com/w3c/webrtc-pc/pull/2679/

BUG=webrtc:13265,chromium:1360224

Change-Id: I63155653862e4c12720b8655c51ed5f3bdc742f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277804
Reviewed-by: Johannes Kron <kron@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#38339}
This commit is contained in:
Philipp Hancke
2022-10-05 20:49:55 +02:00
committed by WebRTC LUCI CQ
parent 4b255b1756
commit 28fb04de62
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pc/peer_connection.cc
View File

@ -668,10 +668,6 @@ RTCError PeerConnection::Initialize(
},
delay_ms);
// Record the number of configured ICE servers for all connections.
RTC_HISTOGRAM_COUNTS_LINEAR("WebRTC.PeerConnection.IceServers.Configured",
configuration_.servers.size(), 0, 31, 32);
return RTCError::OK();
}
@ -1985,10 +1981,6 @@ void PeerConnection::ReportFirstConnectUsageMetrics() {
RTC_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.ProvisionalAnswer", pranswer,
kProvisionalAnswerMax);
// Record the number of configured ICE servers for connected connections.
RTC_HISTOGRAM_COUNTS_LINEAR("WebRTC.PeerConnection.IceServers.Connected",
configuration_.servers.size(), 0, 31, 32);
// Record the number of valid / invalid ice-ufrag. We do allow certain
// non-spec ice-char for backward-compat reasons. At this point we know
// that the ufrag/pwd consists of a valid ice-char or one of the four