zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Fix to make the start/stop functions for the Rtc Eventlog non-virtual. (patchset #2 id:40001 of https://codereview.webrtc.org/2107253002/ )

Browse Source 
Reason for revert:
Reverting all CLs related to moving the eventlog, as they break Chromium tests.

Original issue's description:
> Fix to make the start/stop functions for the Rtc Eventlog non-virtual.
>
> This is needed to prevent the Chromium import bot from breaking.
>
> BUG=
> R=tommi@webrtc.org
>
> Committed: https://crrev.com/df6ecea8ac7c4c3bddeda089d5fb9eccdf38a0a6
> Cr-Commit-Position: refs/heads/master@{#13324}

TBR=tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.webrtc.org/2111803002
Cr-Commit-Position: refs/heads/master@{#13339}
This commit is contained in:
ivoc
2016-06-30 00:57:33 -07:00
committed by Commit bot
parent bf02e2070f
commit 308c7b0b5a
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/api/peerconnectioninterface.h
View File

@ -495,15 +495,11 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// operation fails the file will be closed. The logging will stop
// automatically after 10 minutes have passed, or when the StopRtcEventLog
// function is called.
// TODO(ivoc): Make this pure virtual when Chrome is updated.
virtual bool StartRtcEventLog(rtc::PlatformFile file,
int64_t max_size_bytes) {
return false;
}
int64_t max_size_bytes) = 0;
// Stops logging the RtcEventLog.
// TODO(ivoc): Make this pure virtual when Chrome is updated.
virtual void StopRtcEventLog() {}
virtual void StopRtcEventLog() = 0;
// Terminates all media and closes the transport.
virtual void Close() = 0;