zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

New methods for registering network change callbacks in MediaTransport

Browse Source 
Adds methods AddNetworkChangeCallback and RemoveNetworkChangeCallback,
to replace SetNetworkChangeCallback. Needed because both VideoChannel
and VoiceChannel register such a callback.

This cl is step 1, it just adds the methods to the interface, without
calling them.

Bug: webrtc:9719
Change-Id: I39f1748706d4369ca71d594ca5e2f1380de5ce66
Reviewed-on: https://webrtc-review.googlesource.com/c/121462
Reviewed-by: Peter Slatala <psla@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Peter Slatala <psla@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26541}
This commit is contained in:
Niels Möller
2019-02-05 00:59:35 +01:00
committed by Commit Bot
parent 626015d7f8
commit 30b182aca0
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
api/media_transport_interface.cc
View File

@ -157,6 +157,12 @@ MediaTransportInterface::GetLatestTargetTransferRate() {
void MediaTransportInterface::SetNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback) {}
void MediaTransportInterface::AddNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback) {}
void MediaTransportInterface::RemoveNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback) {}
void MediaTransportInterface::SetFirstAudioPacketReceivedObserver(
AudioPacketReceivedObserver* observer) {}

6
api/media_transport_interface.h
View File

@ -433,8 +433,14 @@ class MediaTransportInterface {
// with the current network route.
// Before media transport is destroyed, the callback must be unregistered by
// setting it to nullptr.
// TODO(nisse): The SetNetworkChangeCallback is being replaced with Add/Remove
// methods, because both video channel and voice channel need to register.
virtual void SetNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback);
virtual void AddNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback);
virtual void RemoveNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback);
// Sets a state observer callback. Before media transport is destroyed, the
// callback must be unregistered by setting it to nullptr.