zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make ScalableVideoController::OnRatesUpdated pure virtual

Browse Source 
Bug: None
Change-Id: I3684359ef253b3e674eadbd1a6791cf627c296a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190283
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32496}
This commit is contained in:
Danil Chapovalov
2020-10-26 11:40:26 +01:00
committed by Commit Bot
parent 5a04ef6ca4
commit 347a3276a6
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/video_coding/svc/scalable_video_controller.h
View File

@ -84,9 +84,7 @@ class ScalableVideoController {
// Notifies Controller with updated bitrates per layer. In particular notifies
// when certain layers should be disabled.
// Controller shouldn't produce LayerFrameConfig for disabled layers.
// TODO(bugs.webrtc.org/11404): Make pure virtual when implemented by all
// structures.
virtual void OnRatesUpdated(const VideoBitrateAllocation& bitrates) {}
virtual void OnRatesUpdated(const VideoBitrateAllocation& bitrates) = 0;
// When `restart` is true, first `LayerFrameConfig` should have `is_keyframe`
// set to true.

2
modules/video_coding/svc/scalable_video_controller_no_layering.h
View File

@ -13,6 +13,7 @@
#include <vector>
#include "api/transport/rtp/dependency_descriptor.h"
#include "api/video/video_bitrate_allocation.h"
#include "common_video/generic_frame_descriptor/generic_frame_info.h"
#include "modules/video_coding/svc/scalable_video_controller.h"
@ -27,6 +28,7 @@ class ScalableVideoControllerNoLayering : public ScalableVideoController {
std::vector<LayerFrameConfig> NextFrameConfig(bool restart) override;
GenericFrameInfo OnEncodeDone(const LayerFrameConfig& config) override;
void OnRatesUpdated(const VideoBitrateAllocation& bitrates) override {}
private:
bool start_ = true;