zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix reporting of perf results on video full stack tests.

Browse Source 
For DualStreamsTest, the name of the metric reported
("dualstreams_moderately_restricted_screenshare") was repeated 4 times:
- Conference_Restricted/0
- Conference_Restricted/1
- ModeratelyRestricted_SlidesVp8_3TL_Simulcast_Video_Simulcast_High/0
- ModeratelyRestricted_SlidesVp8_3TL_Simulcast_Video_Simulcast_High/1

So only one of those tests (whichever ran last) has its metrics reported
to the perf dashboard, while the others have their metrics ignored.

I added the "/0" or "/1" as part of the metric name, to differentiate
between them.

Bug: webrtc:8566
Change-Id: I088807b66f9b7957571dccdb8fe3df0d87486bb0
Reviewed-on: https://webrtc-review.googlesource.com/36400
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21481}
This commit is contained in:
Edward Lemur
2017-12-27 18:54:47 +01:00
committed by Commit Bot
parent 731082ce7e
commit 35d2b7e9de
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
video/full_stack_tests.cc
View File

@ -944,8 +944,9 @@ TEST_P(DualStreamsTest,
// Call settings.
dual_streams.call.send_side_bwe = true;
dual_streams.call.dual_video = true;
dual_streams.analyzer = {"dualstreams_moderately_restricted_screenshare", 0.0,
0.0, kFullStackTestDurationSecs};
std::string test_label = "dualstreams_moderately_restricted_screenshare_" +
std::to_string(first_stream);
dual_streams.analyzer = {test_label, 0.0, 0.0, kFullStackTestDurationSecs};
dual_streams.pipe.loss_percent = 1;
dual_streams.pipe.link_capacity_kbps = 7500;
dual_streams.pipe.queue_length_packets = 30;
@ -975,8 +976,9 @@ TEST_P(DualStreamsTest, Conference_Restricted) {
// Call settings.
dual_streams.call.send_side_bwe = true;
dual_streams.call.dual_video = true;
dual_streams.analyzer = {"dualstreams_moderately_restricted_screenshare", 0.0,
0.0, kFullStackTestDurationSecs};
std::string test_label = "dualstreams_conference_restricted_screenshare_" +
std::to_string(first_stream);
dual_streams.analyzer = {test_label, 0.0, 0.0, kFullStackTestDurationSecs};
dual_streams.pipe.loss_percent = 1;
dual_streams.pipe.link_capacity_kbps = 5000;
dual_streams.pipe.queue_length_packets = 30;