zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unused member BasicPortAllocator::allow_tcp_listen_

Browse Source 
There's a similar member in the base class, PortAllocator, which
appears to be in use.

Bug: None
Change-Id: Ie82801a7d0ae62f1e2758b6f434485bd5f78e8ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164520
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30145}
This commit is contained in:
Niels Möller
2020-01-03 10:28:47 +01:00
committed by Commit Bot
parent 12e319aafe
commit 3828c30b06
2 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
p2p/client/basic_port_allocator.cc
View File

@ -163,7 +163,6 @@ BasicPortAllocator::BasicPortAllocator(
RTC_DCHECK(socket_factory_ != nullptr);
SetConfiguration(ServerAddresses(), std::vector<RelayServerConfig>(), 0,
webrtc::NO_PRUNE, customizer);
Construct();
}
BasicPortAllocator::BasicPortAllocator(rtc::NetworkManager* network_manager)
@ -171,7 +170,6 @@ BasicPortAllocator::BasicPortAllocator(rtc::NetworkManager* network_manager)
InitRelayPortFactory(nullptr);
RTC_DCHECK(relay_port_factory_ != nullptr);
RTC_DCHECK(network_manager_ != nullptr);
Construct();
}
BasicPortAllocator::BasicPortAllocator(rtc::NetworkManager* network_manager,
@ -188,11 +186,6 @@ BasicPortAllocator::BasicPortAllocator(rtc::NetworkManager* network_manager,
RTC_DCHECK(relay_port_factory_ != nullptr);
SetConfiguration(stun_servers, std::vector<RelayServerConfig>(), 0,
webrtc::NO_PRUNE, nullptr);
Construct();
}
void BasicPortAllocator::Construct() {
allow_tcp_listen_ = true;
}
void BasicPortAllocator::OnIceRegathering(PortAllocatorSession* session,

3
p2p/client/basic_port_allocator.h
View File

@ -77,8 +77,6 @@ class RTC_EXPORT BasicPortAllocator : public PortAllocator {
}
private:
void Construct();
void OnIceRegathering(PortAllocatorSession* session,
IceRegatheringReason reason);
@ -89,7 +87,6 @@ class RTC_EXPORT BasicPortAllocator : public PortAllocator {
rtc::NetworkManager* network_manager_;
rtc::PacketSocketFactory* socket_factory_;
bool allow_tcp_listen_;
int network_ignore_mask_ = rtc::kDefaultNetworkIgnoreMask;
// This is the factory being used.