zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AEC3: Disabling explicit handling of microphone gain changes

Browse Source 
Disables the faster filter adaptation in the event of
microphone gain changes as it sometimes impacted transparency
negatively.

Bug: webrtc:9526,chromium:863826
Change-Id: I48fb6dd45440518aaf94b6469d6bb891247ea4ab
Reviewed-on: https://webrtc-review.googlesource.com/95143
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24461}
This commit is contained in:
Gustaf Ullberg
2018-08-21 16:50:28 +02:00
committed by Commit Bot
parent 9ed9792def
commit 5cd81cbff7
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/audio_processing/aec3/main_filter_update_gain.cc
View File

@ -22,7 +22,6 @@ namespace webrtc {
namespace {
constexpr float kHErrorInitial = 10000.f;
constexpr float kHErrorGainChange = 10000.f;
constexpr int kPoorExcitationCounterInitial = 1000;
} // namespace
@ -48,7 +47,7 @@ MainFilterUpdateGain::~MainFilterUpdateGain() {}
void MainFilterUpdateGain::HandleEchoPathChange(
const EchoPathVariability& echo_path_variability) {
if (echo_path_variability.gain_change) {
H_error_.fill(kHErrorGainChange);
// TODO(bugs.webrtc.org/9526) Handle gain changes.
}
if (echo_path_variability.delay_change !=

2
modules/audio_processing/aec3/subtractor.cc
View File

@ -153,8 +153,6 @@ void Subtractor::HandleEchoPathChange(
}
if (echo_path_variability.gain_change && enable_agc_gain_change_response_) {
RTC_LOG(LS_WARNING) << "Resetting main filter adaptation speed due to "
"microphone gain change";
G_main_.HandleEchoPathChange(echo_path_variability);
}
}