zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[DVQA] Fix: cpu_usage was exported as cpu_usage_% before

Browse Source 
Bug: b/246095034
Change-Id: I082865fadf69f11ec05dec32e5ec22deaef98db7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276400
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38169}
This commit is contained in:
Artem Titov
2022-09-22 12:29:42 +02:00
committed by WebRTC LUCI CQ
parent 8e0fc17204
commit 6a49fb2d5f
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc
View File

@ -904,7 +904,7 @@ void DefaultVideoQualityAnalyzer::ReportResults() {
ImproveDirection::kSmallerIsBetter);
} else {
metrics_logger_->LogSingleValueMetric(
"cpu_usage", test_label_, GetCpuUsagePercent(), Unit::kPercent,
"cpu_usage_%", test_label_, GetCpuUsagePercent(), Unit::kUnitless,
ImprovementDirection::kSmallerIsBetter);
}
LogFrameCounters("Global", frame_counters_);

8
test/pc/e2e/analyzer/video/default_video_quality_analyzer_metric_names_test.cc
View File

@ -315,8 +315,8 @@ TEST(DefaultVideoQualityAnalyzerMetricNamesTest, MetricNamesForP2PAreCorrect) {
.unit = Unit::kCount,
.improvement_direction = ImprovementDirection::kBiggerIsBetter},
MetricValidationInfo{.test_case = "test_case",
.name = "cpu_usage",
.unit = Unit::kPercent,
.name = "cpu_usage_%",
.unit = Unit::kUnitless,
.improvement_direction =
ImprovementDirection::kSmallerIsBetter}));
}
@ -614,8 +614,8 @@ TEST(DefaultVideoQualityAnalyzerMetricNamesTest,
.unit = Unit::kCount,
.improvement_direction = ImprovementDirection::kBiggerIsBetter},
MetricValidationInfo{.test_case = "test_case",
.name = "cpu_usage",
.unit = Unit::kPercent,
.name = "cpu_usage_%",
.unit = Unit::kUnitless,
.improvement_direction =
ImprovementDirection::kSmallerIsBetter}));
}

4
test/pc/e2e/peer_connection_quality_test_metric_names_test.cc
View File

@ -426,8 +426,8 @@ TEST(PeerConnectionE2EQualityTestMetricNamesTest,
.improvement_direction = ImprovementDirection::kNeitherIsBetter},
MetricValidationInfo{
.test_case = "test_case",
.name = "cpu_usage",
.unit = Unit::kPercent,
.name = "cpu_usage_%",
.unit = Unit::kUnitless,
.improvement_direction = ImprovementDirection::kSmallerIsBetter},
// Metrics from StatsBasedNetworkQualityMetricsReporter