zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AEC3: Decrease the modelling of the reverb

Browse Source 
This CL lowers the default reverb decay to better match the standard
rooms where calls are made.

Bug: webrtc:9843
Change-Id: I46f1a629ecfdd72561829326d4fa58ede8107b6c
Reviewed-on: https://webrtc-review.googlesource.com/c/104740
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25061}
This commit is contained in:
Per Åhgren
2018-10-09 01:11:15 +02:00
committed by Commit Bot
parent d76a0fc5e9
commit 70045719ab
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/audio/echo_canceller3_config.h
View File

@ -78,7 +78,7 @@ struct EchoCanceller3Config {
float lf = 1.f;
float mf = 1.f;
float hf = 1.f;
float default_len = 0.88f;
float default_len = 0.83f;
bool reverb_based_on_render = true;
bool echo_can_saturate = true;
bool bounded_erl = false;

8
modules/audio_processing/aec3/echo_canceller3.cc
View File

@ -62,6 +62,10 @@ bool EnableUnityNonZeroRampupGain() {
return field_trial::IsEnabled("WebRTC-Aec3EnableUnityNonZeroRampupGain");
}
bool EnableLongReverb() {
return field_trial::IsEnabled("WebRTC-Aec3ShortReverbKillSwitch");
}
// Method for adjusting config parameter dependencies..
EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) {
EchoCanceller3Config adjusted_cfg = config;
@ -147,6 +151,10 @@ EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) {
adjusted_cfg.echo_removal_control.gain_rampup.first_non_zero_gain = 1.f;
}
if (EnableLongReverb()) {
adjusted_cfg.ep_strength.default_len = 0.88f;
}
return adjusted_cfg;
}