Removing warning suppression flags from test/.

Bug: webrtc:9251
Change-Id: Ibe3971adcc13d30d4a3360ecfe6d525e02428b28
Reviewed-on: https://webrtc-review.googlesource.com/81188
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23533}
This commit is contained in:
Mirko Bonadei
2018-06-05 15:22:02 +02:00
committed by Commit Bot
parent 1127fb9856
commit 7210af206c
2 changed files with 2 additions and 16 deletions

View File

@ -597,18 +597,6 @@ rtc_source_set("test_common") {
}
}
config("test_renderer_exported_config") {
if (is_win && is_clang) {
# GN orders flags on a target before flags from configs. The default config
# adds -Wall, and this flag have to be after -Wall -- so they need to
# come from a config and cannot be on the target directly.
cflags = [
"-Wno-bool-conversion",
"-Wno-delete-non-virtual-dtor",
]
}
}
rtc_source_set("test_renderer") {
public_deps = [
":test_renderer_generic",
@ -696,8 +684,6 @@ rtc_source_set("test_renderer_generic") {
]
}
public_configs = [ ":test_renderer_exported_config" ]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]

View File

@ -148,13 +148,13 @@ D3dRenderer* D3dRenderer::Create(const char* window_title,
wc_atom = RegisterClassA(&wc);
if (wc_atom == 0)
return false;
return nullptr;
}
D3dRenderer* d3d_renderer = new D3dRenderer(width, height);
if (!d3d_renderer->Init(window_title)) {
delete d3d_renderer;
return NULL;
return nullptr;
}
return d3d_renderer;