zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove video_codecs from RunParams (PC level framework).

Browse Source 
Bug: b/192821182
Change-Id: I17f728665a86d511c469dc8f29a29e56b2f28a25
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226321
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34486}
This commit is contained in:
Mirko Bonadei
2021-07-16 09:18:50 +02:00
committed by WebRTC LUCI CQ
parent 1f88aba9bd
commit 84b583f577
2 changed files with 3 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
api/test/peerconnection_quality_test_fixture.h
View File

@ -391,19 +391,6 @@ class PeerConnectionE2EQualityTestFixture {
// it will be shut downed.
TimeDelta run_duration;
// DEPRECATED: Instead of setting the codecs in RunParams (which apply to
// all the participants in the call, please set them with
// PeerConfigurer, this will allow more flexibility and let
// different Peers support different codecs.
//
// List of video codecs to use during the test. These codecs will be
// negotiated in SDP during offer/answer exchange. The order of these codecs
// during negotiation will be the same as in |video_codecs|. Codecs have
// to be available in codecs list provided by peer connection to be
// negotiated. If some of specified codecs won't be found, the test will
// crash.
// If list is empty Vp8 with no required_params will be used.
std::vector<VideoCodecConfig> video_codecs;
bool use_ulp_fec = false;
bool use_flex_fec = false;
// Specifies how much video encoder target bitrate should be different than

19
test/pc/e2e/peer_configurer.cc
View File

@ -92,22 +92,9 @@ void SetDefaultValuesForMissingParams(
}
if (p->video_codecs.empty()) {
// TODO(mbonadei): Remove the usage of RunParams to set codecs, this is
// only needed for backwards compatibility.
if (!run_params->video_codecs.empty()) {
p->video_codecs = run_params->video_codecs;
} else {
p->video_codecs.push_back(
PeerConnectionE2EQualityTestFixture::VideoCodecConfig(
cricket::kVp8CodecName));
run_params->video_codecs = {
PeerConnectionE2EQualityTestFixture::VideoCodecConfig(
cricket::kVp8CodecName)};
}
} else {
RTC_CHECK(run_params->video_codecs.empty())
<< "Setting video_codecs in both PeerConfigurer and RunParams is not "
"supported.";
p->video_codecs.push_back(
PeerConnectionE2EQualityTestFixture::VideoCodecConfig(
cricket::kVp8CodecName));
}
}
}