zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AGC2 adaptive digital false by default

Browse Source 
Avoid that the client code relies on the adaptive digital mode being
enabled by default (error prone).

Bug: webrtc:7494
Change-Id: I765fecf535cf31a2163e10595a42520473c233b6
Reviewed-on: https://webrtc-review.googlesource.com/c/111586
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25728}
This commit is contained in:
Alessio Bazzica
2018-11-21 10:50:58 +01:00
committed by Commit Bot
parent cfddbb7e14
commit 8da7b350cf
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_processing/gain_controller2_unittest.cc
View File

@ -261,6 +261,7 @@ TEST(GainController2, UsageSaturationMargin) {
// high. They should not be amplified at all, but only after convergence. GC2
// starts with a gain, and it takes time until it's down to 0 dB.
config.fixed_digital.gain_db = 0.f;
config.adaptive_digital.enabled = true;
config.adaptive_digital.extra_saturation_margin_db = 50.f;
gain_controller2.ApplyConfig(config);
@ -274,6 +275,7 @@ TEST(GainController2, UsageNoSaturationMargin) {
AudioProcessing::Config::GainController2 config;
// Check that some gain is applied if there is no margin.
config.fixed_digital.gain_db = 0.f;
config.adaptive_digital.enabled = true;
config.adaptive_digital.extra_saturation_margin_db = 0.f;
gain_controller2.ApplyConfig(config);

2
modules/audio_processing/include/audio_processing.h
View File

@ -276,7 +276,7 @@ class AudioProcessing : public rtc::RefCountInterface {
float gain_db = 0.f;
} fixed_digital;
struct {
bool enabled = true;
bool enabled = false;
LevelEstimator level_estimator = kRms;
bool use_saturation_protector = true;
float extra_saturation_margin_db = 2.f;