zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove webrtc deps from AppRTCMobile.

Browse Source 
We want the example app to only link agains the framework. This ensures
that we are actually testing the framework, and that AppRTCMobile
doesn't require any other parts of WebRTC not included in the framework.

Bug: webrtc:7759
Change-Id: Ib04aae0bc3ab2a1a508eaf4a4f15c2d37f521598
Reviewed-on: https://chromium-review.googlesource.com/522722
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18470}
This commit is contained in:
Kári Tristan Helgason
2017-06-02 14:05:56 +02:00
committed by Commit Bot
parent 1e15a994ac
commit 946923a21f
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
webrtc/examples/BUILD.gn
View File

@ -163,10 +163,14 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
public_configs = [ ":apprtc_common_config" ]
deps = [
"//webrtc/sdk:objc_common",
"//webrtc/system_wrappers:field_trial_default",
"//webrtc/system_wrappers:metrics_default",
]
if (is_ios) {
deps += [ ":AppRTCMobile_ios_frameworks" ]
} else {
deps += [ "//webrtc/sdk:objc_common" ]
}
}
config("apprtc_signaling_config") {
@ -231,9 +235,13 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
":apprtc_common",
":socketrocket",
]
public_deps = [
"//webrtc/sdk:objc_peerconnection",
]
if (is_ios) {
deps += [ ":AppRTCMobile_ios_frameworks" ]
} else {
public_deps = [
"//webrtc/sdk:objc_peerconnection",
]
}
libs = [ "QuartzCore.framework" ]
}
@ -260,9 +268,13 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
]
deps = [
":AppRTCMobile_ios_frameworks",
":apprtc_common",
":apprtc_signaling",
"//webrtc/modules/audio_device",
# TODO(kthelgason): Remove this dep when audio_device has been
# moved to sdk.
"//webrtc/modules/audio_device:audio_device",
]
}