zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary overloads of AudioProcessing::CreateAndAttachAecDump()

Browse Source 
Bug: webrtc:13579
Change-Id: I2e121b5fd30de4ac1813483f00a51184ff861760
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269623
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37723}
This commit is contained in:
Ali Tofigh
2022-08-09 09:21:17 +02:00
committed by WebRTC LUCI CQ
parent 7f0a7acb0a
commit 980ad0cd64
5 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/audio_processing/BUILD.gn
View File

@ -327,6 +327,7 @@ if (rtc_include_tests) {
":audio_processing_statistics",
"../../test:test_support",
]
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
}
if (!build_with_chromium) {

7
modules/audio_processing/audio_processing_impl.cc
View File

@ -1651,13 +1651,6 @@ int AudioProcessingImpl::recommended_stream_analog_level_locked() const {
return capture_.cached_stream_analog_level_;
}
bool AudioProcessingImpl::CreateAndAttachAecDump(const std::string& file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) {
return CreateAndAttachAecDump(absl::string_view(file_name),
max_log_size_bytes, worker_queue);
}
bool AudioProcessingImpl::CreateAndAttachAecDump(absl::string_view file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) {

3
modules/audio_processing/audio_processing_impl.h
View File

@ -71,9 +71,6 @@ class AudioProcessingImpl : public AudioProcessing {
int Initialize() override;
int Initialize(const ProcessingConfig& processing_config) override;
void ApplyConfig(const AudioProcessing::Config& config) override;
bool CreateAndAttachAecDump(const std::string& file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) override;
bool CreateAndAttachAecDump(absl::string_view file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) override;

10
modules/audio_processing/include/audio_processing.h
View File

@ -628,13 +628,13 @@ class RTC_EXPORT AudioProcessing : public rtc::RefCountInterface {
// implemented the absl::string_view version.
virtual bool CreateAndAttachAecDump(const std::string& file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) = 0;
rtc::TaskQueue* worker_queue) {
return CreateAndAttachAecDump(absl::string_view(file_name),
max_log_size_bytes, worker_queue);
}
virtual bool CreateAndAttachAecDump(absl::string_view file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) {
return CreateAndAttachAecDump(std::string(file_name), max_log_size_bytes,
worker_queue);
}
rtc::TaskQueue* worker_queue) = 0;
virtual bool CreateAndAttachAecDump(FILE* handle,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) = 0;

7
modules/audio_processing/include/mock_audio_processing.h
View File

@ -13,6 +13,7 @@
#include <memory>
#include "absl/strings/string_view.h"
#include "modules/audio_processing/include/aec_dump.h"
#include "modules/audio_processing/include/audio_processing.h"
#include "modules/audio_processing/include/audio_processing_statistics.h"
@ -156,6 +157,12 @@ class MockAudioProcessing : public AudioProcessing {
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue),
(override));
MOCK_METHOD(bool,
CreateAndAttachAecDump,
(absl::string_view file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue),
(override));
MOCK_METHOD(bool,
CreateAndAttachAecDump,
(FILE * handle,