zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable owners check in PRESUBMIT.py for chromium owned 3pp deps.

Browse Source 
Bug: webrtc:8366
Change-Id: I18a7117d13dfacc2b305c304037a0d3b55b6df3b
Reviewed-on: https://webrtc-review.googlesource.com/78284
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23352}
This commit is contained in:
Artem Titov
2018-05-22 16:44:23 +02:00
committed by Commit Bot
parent 43c707ada5
commit 9aef5dc2ab
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
PRESUBMIT.py
View File

@ -852,9 +852,23 @@ def CheckChangeOnUpload(input_api, output_api):
def CheckChangeOnCommit(input_api, output_api):
results = []
# We have to skip OWNERS check for chromium-specific third_party deps.
chromium_deps_file = input_api.os_path.join(
input_api.PresubmitLocalPath(),
'THIRD_PARTY_CHROMIUM_DEPS.json')
with open(chromium_deps_file, 'rb') as f:
chromium_deps = json.load(f).get('dependencies', [])
deps_blacklist = []
for dep in chromium_deps:
deps_blacklist.append(r'^third_party[\\\/]%s[\\\/].+' % dep)
deps_filter = lambda x: input_api.FilterSourceFile(
x, black_list=deps_blacklist)
results.extend(CommonChecks(input_api, output_api))
results.extend(VerifyNativeApiHeadersListIsValid(input_api, output_api))
results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
results.extend(input_api.canned_checks.CheckOwners(input_api, output_api,
source_file_filter=deps_filter))
results.extend(input_api.canned_checks.CheckChangeWasUploaded(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasDescription(