zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Re-enable a couple PortAllocator tests under ASAN

Browse Source 
Ran each test 10,000 times locally and could not detect any
flakiness.

Bug: webrtc:4743
Change-Id: Iecdf70d878ec8573b9ea5238bc25613c0f3cd171
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167422
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30440}
This commit is contained in:
Steve Anton
2020-01-24 16:13:23 -08:00
committed by Commit Bot
parent 82271217f1
commit 9d56b0113f
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
p2p/client/basic_port_allocator_unittest.cc
View File

@ -1373,10 +1373,6 @@ TEST_F(BasicPortAllocatorTest, TestDisableUdpTurn) {
EXPECT_TRUE(HasCandidate(candidates_, "local", "tcp", kClientAddr));
}
// Disable for asan, see
// https://code.google.com/p/webrtc/issues/detail?id=4743 for details.
#if !defined(ADDRESS_SANITIZER)
// Test that we can get OnCandidatesAllocationDone callback when all the ports
// are disabled.
TEST_F(BasicPortAllocatorTest, TestDisableAllPorts) {
@ -1402,8 +1398,6 @@ TEST_F(BasicPortAllocatorTest, TestGetAllPortsNoUdpSockets) {
EXPECT_TRUE(HasCandidate(candidates_, "local", "tcp", kClientAddr));
}
#endif // if !defined(ADDRESS_SANITIZER)
// Test that we don't crash or malfunction if we can't create UDP sockets or
// listen on TCP sockets. We still give out a local TCP address, since
// apparently this is needed for the remote side to accept our connection.