zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Expect false for typing detection in unittest for Android only.

Browse Source 
- Typing detection is disabled on android.

Bug: webrtc:13565
Change-Id: I55c07c4afd729c24ba11813e87ccae1569206503
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246443
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35722}
This commit is contained in:
Christoffer Jansson
2022-01-18 13:36:02 +01:00
committed by WebRTC LUCI CQ
parent 0428f95a00
commit 9defabbac5
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
media/engine/webrtc_voice_engine_unittest.cc
View File

@ -221,7 +221,11 @@ class WebRtcVoiceEngineTestFake : public ::testing::TestWithParam<bool> {
// Default Options.
VerifyEchoCancellationSettings(/*enabled=*/true);
EXPECT_TRUE(IsHighPassFilterEnabled());
#if defined(WEBRTC_ANDROID)
EXPECT_FALSE(IsTypingDetectionEnabled());
#else
EXPECT_TRUE(IsTypingDetectionEnabled());
#endif
EXPECT_TRUE(apm_config_.noise_suppression.enabled);
EXPECT_EQ(apm_config_.noise_suppression.level, kDefaultNsLevel);
VerifyGainControlEnabledCorrectly();
@ -3037,7 +3041,11 @@ TEST_P(WebRtcVoiceEngineTestFake, SetAudioOptions) {
if (!use_null_apm_) {
VerifyEchoCancellationSettings(/*enabled=*/true);
EXPECT_TRUE(IsHighPassFilterEnabled());
#if defined(WEBRTC_ANDROID)
EXPECT_FALSE(IsTypingDetectionEnabled());
#else
EXPECT_TRUE(IsTypingDetectionEnabled());
#endif
}
EXPECT_EQ(200u, GetRecvStreamConfig(kSsrcY).jitter_buffer_max_packets);
EXPECT_FALSE(GetRecvStreamConfig(kSsrcY).jitter_buffer_fast_accelerate);
@ -3060,7 +3068,11 @@ TEST_P(WebRtcVoiceEngineTestFake, SetAudioOptions) {
send_parameters_.options.typing_detection = true;
SetSendParameters(send_parameters_);
if (!use_null_apm_) {
#if defined(WEBRTC_ANDROID)
EXPECT_FALSE(IsTypingDetectionEnabled());
#else
EXPECT_TRUE(IsTypingDetectionEnabled());
#endif
}
// Turn echo cancellation off