zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete BasicPacketSocketFactory::CreateServerTcpSocket support for fake tls

Browse Source 
Bug: webrtc:13065, webrtc:10947
Change-Id: Ia60343de90006d17dce92d30a4820a3dca5428cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236300
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35261}
This commit is contained in:
Niels Möller
2021-10-25 16:55:13 +02:00
committed by WebRTC LUCI CQ
parent d30ece1804
commit aaa848e078
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
p2p/base/basic_packet_socket_factory.cc
View File

@ -62,6 +62,10 @@ AsyncListenSocket* BasicPacketSocketFactory::CreateServerTcpSocket(
return NULL;
}
if (opts & PacketSocketFactory::OPT_TLS_FAKE) {
RTC_LOG(LS_ERROR) << "Fake TLS not supported.";
return NULL;
}
Socket* socket =
socket_factory_->CreateSocket(local_address.family(), SOCK_STREAM);
if (!socket) {
@ -82,12 +86,6 @@ AsyncListenSocket* BasicPacketSocketFactory::CreateServerTcpSocket(
<< socket->GetError();
}
// If using fake TLS, wrap the TCP socket in a pseudo-SSL socket.
if (opts & PacketSocketFactory::OPT_TLS_FAKE) {
RTC_DCHECK(!(opts & PacketSocketFactory::OPT_TLS));
socket = new AsyncSSLSocket(socket);
}
RTC_CHECK(!(opts & PacketSocketFactory::OPT_STUN));
return new AsyncTcpListenSocket(absl::WrapUnique(socket));