zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove verbose logs from audio_coding_module.cc.

Browse Source 
PlayoutFrequency(), at least, is called ~200 times a second. The others
appear to not be in practice, but it's unclear what value they serve.

They were traces before https://chromium-review.googlesource.com/c/518133/,
which was more reasonable, as you could enable them for just audio
coding traces. But now that they are just logs, they make all VERBOSE
logging unusable.

Bug: webrtc:7959
Change-Id: I190a61c8ff4c0f047798087e80adbb41d791fc29
Reviewed-on: https://chromium-review.googlesource.com/563881
Reviewed-by: Minyue Li <minyue@webrtc.org>
Commit-Queue: Noah Richards <noahric@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18956}
This commit is contained in:
Noah Richards
2017-07-07 13:22:45 -07:00
committed by Commit Bot
parent a7a4535a35
commit bc8ee33658
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/modules/audio_coding/acm2/audio_coding_module.cc
View File

@ -636,11 +636,10 @@ rtc::Optional<CodecInst> AudioCodingModuleImpl::SendCodec() const {
// Get current send frequency. // Get current send frequency.
int AudioCodingModuleImpl::SendFrequency() const { int AudioCodingModuleImpl::SendFrequency() const {
LOG(LS_VERBOSE) << "SendFrequency()";
rtc::CritScope lock(&acm_crit_sect_); rtc::CritScope lock(&acm_crit_sect_);
if (!encoder_stack_) { if (!encoder_stack_) {
LOG(LS_VERBOSE) << "SendFrequency Failed, no codec is registered"; LOG(LS_ERROR) << "SendFrequency Failed, no codec is registered";
return -1; return -1;
} }
@ -966,7 +965,6 @@ int AudioCodingModuleImpl::ReceiveFrequency() const {
// Get current playout frequency. // Get current playout frequency.
int AudioCodingModuleImpl::PlayoutFrequency() const { int AudioCodingModuleImpl::PlayoutFrequency() const {
LOG(LS_VERBOSE) << "PlayoutFrequency()";
return receiver_.last_output_sample_rate_hz(); return receiver_.last_output_sample_rate_hz();
} }