zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove lint ignores and add WrongCall ignore directly to the test.

Browse Source 
Also removes some unused strings from AppRTCMobile strings.xml.

BUG=webrtc:6597
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2628833004
Cr-Commit-Position: refs/heads/master@{#16033}
This commit is contained in:
sakal
2017-01-12 06:19:40 -08:00
committed by Commit bot
parent 71b1c1fc1d
commit bca122e0d5
3 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/build/android/suppressions.xml
View File

@ -14,7 +14,6 @@
<issue id="LongLogTag" severity="ignore"/>
<issue id="Registered" severity="ignore"/>
<issue id="Recycle" severity="ignore"/>
<issue id="MissingPermission" severity="ignore"/>
<issue id="CommitPrefEdits" severity="ignore"/>
<issue id="UnusedResources" severity="ignore"/>
@ -24,7 +23,6 @@
<issue id="RelativeOverlap" severity="ignore"/>
<issue id="RtlCompat" severity="ignore"/>
<issue id="IconMissingDensityFolder" severity="ignore"/>
<issue id="WrongCall" severity="ignore"/>
<issue id="NewApi" severity="ignore"/>
<issue id="OldTargetApi" severity="ignore"/>

3
webrtc/examples/androidapp/res/values/strings.xml
View File

@ -162,12 +162,10 @@
<string name="pref_enable_datachannel_key">enable_datachannel_preference</string>
<string name="pref_enable_datachannel_title">Enable datachannel.</string>
<string name="pref_enable_datachannel_dlg">Enable datachannel.</string>
<string name="pref_enable_datachannel_default" translatable="false">true</string>
<string name="pref_ordered_key">ordered_preference</string>
<string name="pref_ordered_title">Order messages.</string>
<string name="pref_ordered_dlg">Order messages.</string>
<string name="pref_ordered_default" translatable="false">true</string>
<string name="pref_data_protocol_key">Subprotocol</string>
@ -177,7 +175,6 @@
<string name="pref_negotiated_key">negotiated_preference</string>
<string name="pref_negotiated_title">Negotiated.</string>
<string name="pref_negotiated_dlg">Negotiated.</string>
<string name="pref_negotiated_default" translatable="false">false</string>
<string name="pref_max_retransmit_time_ms_key">max_retransmit_time_ms_preference</string>

2
webrtc/sdk/android/instrumentationtests/src/org/webrtc/SurfaceViewRendererOnMeasureTest.java
View File

@ -13,6 +13,7 @@ package org.webrtc;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
import android.annotation.SuppressLint;
import android.graphics.Point;
import android.support.test.InstrumentationRegistry;
import android.support.test.annotation.UiThreadTest;
@ -60,6 +61,7 @@ public class SurfaceViewRendererOnMeasureTest {
/**
* Assert onMeasure() with given parameters will result in expected measured size.
*/
@SuppressLint("WrongCall")
private static void assertMeasuredSize(SurfaceViewRenderer surfaceViewRenderer,
RendererCommon.ScalingType scalingType, String frameDimensions, int expectedWidth,
int expectedHeight, int widthSpec, int heightSpec) {