zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix JSON format for reporting perf results.

Browse Source 
It is list_of_scalar_values, not list_of_scalars.
https://github.com/catapult-project/catapult/blob/master/dashboard/docs/data-format.md

R=phoglund@webrtc.org

Bug: webrtc:7156
Change-Id: I391d507d3e0fd9bf0e8a12a5aa6824278ccfb39c
Reviewed-on: https://webrtc-review.googlesource.com/37642
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21515}
This commit is contained in:
Edward Lemur
2018-01-05 15:06:59 +01:00
committed by Commit Bot
parent c643204321
commit c492bf1958
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/testsupport/perf_test.cc
View File

@ -82,7 +82,7 @@ class PerfResultsLogger {
std::ostringstream json_stream;
json_stream << '"' << trace_name << R"(":{)";
json_stream << R"("type":"list_of_scalars",)";
json_stream << R"("type":"list_of_scalar_values",)";
json_stream << R"("values":[)" << mean << "],";
json_stream << R"("std":)" << error << ',';
json_stream << R"("units":")" << units << R"("})";
@ -104,7 +104,7 @@ class PerfResultsLogger {
std::ostringstream json_stream;
json_stream << '"' << trace_name << R"(":{)";
json_stream << R"("type":"list_of_scalars",)";
json_stream << R"("type":"list_of_scalar_values",)";
json_stream << R"("values":)" << value_stream.str() << ',';
json_stream << R"("units":")" << units << R"("})";
rtc::CritScope lock(&crit_);

4
test/testsupport/perf_test_unittest.cc
View File

@ -26,13 +26,13 @@ const char* kJsonExpected = R"({
"units":"widgets"
},
"baz_me":{
"type":"list_of_scalars",
"type":"list_of_scalar_values",
"values":[1],
"std":2,
"units":"lemurs"
},
"baz_vl":{
"type":"list_of_scalars",
"type":"list_of_scalar_values",
"values":[1,2,3],
"units":"units"
}