zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RtpToNtpEstimator:: Add a DCHECK to avoid div-by-0

Browse Source 
The division that follows the added DCHECK should not be div-by-0,
since when params_.calculated is true, params_.frequency_khz would
have been updated (with something non-zero).

BUG=none

Review-Url: https://codereview.webrtc.org/3006003002
Cr-Commit-Position: refs/heads/master@{#19671}
This commit is contained in:
henrik.lundin
2017-09-04 09:02:15 -07:00
committed by Commit Bot
parent ba09f79ba3
commit d56ef80857
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc
View File

@ -10,6 +10,7 @@
#include "webrtc/system_wrappers/include/rtp_to_ntp_estimator.h"
#include "webrtc/rtc_base/checks.h"
#include "webrtc/rtc_base/logging.h"
#include "webrtc/system_wrappers/include/clock.h"
@ -162,6 +163,9 @@ bool RtpToNtpEstimator::Estimate(int64_t rtp_timestamp,
return false;
}
// params_.calculated should not be true unless params_.frequency_khz has been
// set to something non-zero.
RTC_DCHECK_NE(params_.frequency_khz, 0.0);
double rtp_ms =
(static_cast<double>(rtp_timestamp_unwrapped) - params_.offset_ms) /
params_.frequency_khz +