zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AEC3: Ensure that the usage of stationary signal properties is not unset

Browse Source 
This CL ensures that the default setting for the usage of stationary signal
properties is not overridden by mistake.

Bug: chromium:894243
Change-Id: I85ab65383ee82b5f3153864da7a0cede7776c146
Reviewed-on: https://webrtc-review.googlesource.com/c/105181
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25104}
This commit is contained in:
Per Åhgren
2018-10-11 00:03:01 +02:00
committed by Commit Bot
parent 23b2a25675
commit d6b079686f
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/audio_processing/aec3/echo_canceller3.cc
View File

@ -78,6 +78,11 @@ bool UseLegacyNormalSuppressorTuning() {
return field_trial::IsEnabled("WebRTC-Aec3UseLegacyNormalSuppressorTuning");
}
bool DeactivateStationarityProperties() {
return field_trial::IsEnabled(
"WebRTC-Aec3UseStationarityPropertiesKillSwitch");
}
// Method for adjusting config parameter dependencies..
EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) {
EchoCanceller3Config adjusted_cfg = config;
@ -194,6 +199,13 @@ EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) {
adjusted_cfg.suppressor.dominant_nearend_detection.hold_duration = 25;
}
// TODO(peah): Clean this up once upstream dependencies that forces this to
// zero are resolved.
adjusted_cfg.echo_audibility.use_stationary_properties = true;
if (DeactivateStationarityProperties()) {
adjusted_cfg.echo_audibility.use_stationary_properties = false;
}
return adjusted_cfg;
}