zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use field_trial::IsEnabled for FlexFEC.

Browse Source 
Also clarify some comments.

BUG=webrtc:5654

Review-Url: https://codereview.webrtc.org/2839883002
Cr-Commit-Position: refs/heads/master@{#17875}
This commit is contained in:
brandtr
2017-04-26 00:02:34 -07:00
committed by Commit bot
parent 81c79f51aa
commit dbb1be59ff
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
webrtc/media/engine/internalencoderfactory.cc
View File

@ -23,11 +23,12 @@ namespace {
// If this field trial is enabled, the "flexfec-03" codec will be advertised
// as being supported by the InternalEncoderFactory. This means that
// "flexfec-03" will appear in the default local SDP, and we therefore need to
// be ready to receive FlexFEC packets from the remote.
// "flexfec-03" will appear in the default SDP offer, and we therefore need to
// be ready to receive FlexFEC packets from the remote. It also means that
// FlexFEC SSRCs will be generated by MediaSession and added as "a=ssrc:" and
// "a=ssrc-group:" lines in the local SDP.
bool IsFlexfecAdvertisedFieldTrialEnabled() {
return webrtc::field_trial::FindFullName("WebRTC-FlexFEC-03-Advertised") ==
"Enabled";
return webrtc::field_trial::IsEnabled("WebRTC-FlexFEC-03-Advertised");
}
} // namespace

8
webrtc/media/engine/webrtcvideoengine2.cc
View File

@ -43,10 +43,12 @@ using DegradationPreference = webrtc::VideoSendStream::DegradationPreference;
namespace cricket {
namespace {
// If this field trial is enabled, we will enable sending FlexFEC and disable
// sending ULPFEC whenever the former has been negotiated. Receiving FlexFEC
// is enabled whenever FlexFEC has been negotiated.
// sending ULPFEC whenever the former has been negotiated.
// FlexFEC can only be negotiated when the "flexfec-03" SDP codec is enabled,
// which is done by enabling the "WebRTC-FlexFEC-03-Advertised" field trial; see
// internalencoderfactory.cc.
bool IsFlexfecFieldTrialEnabled() {
return webrtc::field_trial::FindFullName("WebRTC-FlexFEC-03") == "Enabled";
return webrtc::field_trial::IsEnabled("WebRTC-FlexFEC-03");
}
// If this field trial is enabled, we will report VideoContentType RTP extension