zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adopt absl::string_view in CopyOnWriteBuffer

Browse Source 
Bug: webrtc:13579
Change-Id: Ia2b99a28ed0c103215e8616da67a5c961b957199
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260465
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36832}
This commit is contained in:
Ali Tofigh
2022-05-09 13:33:36 +02:00
committed by WebRTC LUCI CQ
parent 6344bf10ac
commit e00d7d0ce6
5 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
logging/BUILD.gn
View File

@ -449,6 +449,7 @@ if (rtc_enable_protobuf) {
"../modules/audio_coding:audio_network_adaptor",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:checks",
"../rtc_base:copy_on_write_buffer",
"../rtc_base:ignore_wundef",
"../rtc_base:logging",
"../rtc_base:protobuf_utils",

4
logging/rtc_event_log/rtc_event_log_parser.cc
View File

@ -38,6 +38,7 @@
#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
#include "modules/rtp_rtcp/source/rtp_packet_received.h"
#include "rtc_base/checks.h"
#include "rtc_base/copy_on_write_buffer.h"
#include "rtc_base/logging.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/numerics/sequence_number_util.h"
@ -1637,7 +1638,8 @@ ParsedRtcEventLog::ParseStatus ParsedRtcEventLog::StoreParsedLegacyEvent(
// Use RtpPacketReceived instead of more generic RtpPacket because former
// has a buildin convertion to RTPHeader.
RtpPacketReceived rtp_header;
RTC_PARSE_CHECK_OR_RETURN(rtp_header.Parse(rtp_packet.header()));
RTC_PARSE_CHECK_OR_RETURN(
rtp_header.Parse(rtc::CopyOnWriteBuffer(rtp_packet.header())));
if (const RtpHeaderExtensionMap* extension_map = GetRtpHeaderExtensionMap(
rtp_packet.incoming(), rtp_header.Ssrc())) {

1
rtc_base/BUILD.gn
View File

@ -183,6 +183,7 @@ rtc_library("copy_on_write_buffer") {
"../api:scoped_refptr",
"system:rtc_export",
]
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
}
rtc_library("event_tracer") {

4
rtc_base/copy_on_write_buffer.cc
View File

@ -12,6 +12,8 @@
#include <stddef.h>
#include "absl/strings/string_view.h"
namespace rtc {
CopyOnWriteBuffer::CopyOnWriteBuffer() : offset_(0), size_(0) {
@ -28,7 +30,7 @@ CopyOnWriteBuffer::CopyOnWriteBuffer(CopyOnWriteBuffer&& buf)
RTC_DCHECK(IsConsistent());
}
CopyOnWriteBuffer::CopyOnWriteBuffer(const std::string& s)
CopyOnWriteBuffer::CopyOnWriteBuffer(absl::string_view s)
: CopyOnWriteBuffer(s.data(), s.length()) {}
CopyOnWriteBuffer::CopyOnWriteBuffer(size_t size)

3
rtc_base/copy_on_write_buffer.h
View File

@ -19,6 +19,7 @@
#include <type_traits>
#include <utility>
#include "absl/strings/string_view.h"
#include "api/scoped_refptr.h"
#include "rtc_base/buffer.h"
#include "rtc_base/checks.h"
@ -38,7 +39,7 @@ class RTC_EXPORT CopyOnWriteBuffer {
CopyOnWriteBuffer(CopyOnWriteBuffer&& buf);
// Construct a buffer from a string, convenient for unittests.
CopyOnWriteBuffer(const std::string& s);
explicit CopyOnWriteBuffer(absl::string_view s);
// Construct a buffer with the specified number of uninitialized bytes.
explicit CopyOnWriteBuffer(size_t size);