zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove crbug.com/904400 workaround.

Browse Source 
The bug is now fixed.

Bug: chromium:904400
Change-Id: I86e0766cec5ebc8f22af604ba7cc977a20a95ad6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127881
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27150}
This commit is contained in:
Mirko Bonadei
2019-03-14 16:37:19 +01:00
committed by Commit Bot
parent 154d839f3d
commit e07d3b432a
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
build_overrides/build.gni
View File

@ -41,12 +41,8 @@ if (host_os == "mac") {
_result = exec_script("//build/mac/should_use_hermetic_xcode.py",
[ target_os ],
"value")
# TODO(crbug.com/904400): Re-enable this once the hermetic toolchain runs on
# latest macOS release [Mojave].
# assert(_result != 2,
# "Do not allow building targets with the default " +
# "hermetic toolchain if the minimum OS version is not met.")
# use_system_xcode = _result == 0
use_system_xcode = _result != 1 # Remove when crbug.com/904400 is fixed.
assert(_result != 2,
"Do not allow building targets with the default " +
"hermetic toolchain if the minimum OS version is not met.")
use_system_xcode = _result == 0
}