zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Disabled two iOS tests due to bot breakage. Affected tests are (patchset #1 id:1 of https://codereview.webrtc.org/2652423002/ )

Browse Source 
Reason for revert:
This was false alarm. The next Chromium roll fixed the problem and the bot has been green for 3 builds.

Original issue's description:
> Disabled two iOS tests due to bot breakage. Affected tests are
> AudioDeviceTest.RunPlayoutWithFileAsSource and
> AudioDeviceTest.StartStopRecording
>
> NOTRY=True
> TBR=henrika@webrtc.org
> BUG=7056
>
> Review-Url: https://codereview.webrtc.org/2652423002
> Cr-Commit-Position: refs/heads/master@{#16286}
> Committed: 8e775e16eb

TBR=henrika@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=7056

Review-Url: https://codereview.webrtc.org/2656533005
Cr-Commit-Position: refs/heads/master@{#16289}
This commit is contained in:
aleloi
2017-01-26 01:50:46 -08:00
committed by Commit bot
parent 327c450f99
commit f3d622d4ad
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc
View File

@ -598,8 +598,7 @@ TEST_F(AudioDeviceTest, DISABLED_StartStopPlayout) {
// Tests that recording can be initiated, started and stopped. No audio callback
// is registered in this test.
// Disabled due to failure: bugs.webrtc.org/7056
TEST_F(AudioDeviceTest, DISABLED_StartStopRecording) {
TEST_F(AudioDeviceTest, StartStopRecording) {
StartRecording();
StopRecording();
StartRecording();
@ -734,8 +733,7 @@ TEST_F(AudioDeviceTest, StartPlayoutAndRecordingVerifyCallbacks) {
// Start playout and read audio from an external PCM file when the audio layer
// asks for data to play out. Real audio is played out in this test but it does
// not contain any explicit verification that the audio quality is perfect.
// Disabled due to failure: bugs.webrtc.org/7056
TEST_F(AudioDeviceTest, DISABLED_RunPlayoutWithFileAsSource) {
TEST_F(AudioDeviceTest, RunPlayoutWithFileAsSource) {
// TODO(henrika): extend test when mono output is supported.
EXPECT_EQ(1, playout_channels());
NiceMock<MockAudioTransportIOS> mock(kPlayout);