zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removes pause check from RoundRobinPacketQueue.

Browse Source 
This CL removes a check in RoundRobinPacketQueue::FinalizePop. This
check will trigger if a the pause state is changed in PacedSender while
a packet is sent. This is a rare occurrence but would yield flaky
behavior. The check should not be required for the code to function
since the paused state is not read in FinalizePop other than for this
check.

Bug: webrtc:9586
Change-Id: Ib9476168eb637dc2f9710d0592bed92c4b03dacb
Reviewed-on: https://webrtc-review.googlesource.com/92090
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24197}
This commit is contained in:
Sebastian Jansson
2018-08-02 17:31:29 +02:00
committed by Commit Bot
parent fd77b78821
commit f70bc5eeff
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/pacing/round_robin_packet_queue.cc
View File

@ -88,7 +88,6 @@ void RoundRobinPacketQueue::CancelPop(const Packet& packet) {
} }
void RoundRobinPacketQueue::FinalizePop(const Packet& packet) { void RoundRobinPacketQueue::FinalizePop(const Packet& packet) {
RTC_CHECK(!paused_);
if (!Empty()) { if (!Empty()) {
RTC_CHECK(pop_packet_ && pop_stream_); RTC_CHECK(pop_packet_ && pop_stream_);
Stream* stream = *pop_stream_; Stream* stream = *pop_stream_;