cleanup: get rid of basicdefs.h include

The ARRAY_SIZE macro it defines is not used anymore, as all the usages
were converted to arraysize macro from arraysize.h.

BUG=None
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1443273002

Cr-Commit-Position: refs/heads/master@{#10640}

webrtc/base/BUILD.gn

@@ -145,7 +145,6 @@ static_library("rtc_base_approved") {
 
   if (!build_with_chromium) {
     sources += [
-      "basictypes.h",
       "constructormagic.h",
       "logging.cc",
       "logging.h",

webrtc/base/base.gyp

@@ -31,7 +31,6 @@
       'sources': [
         'array_view.h',
         'atomicops.h',
-        'basictypes.h',
         'bitbuffer.cc',
         'bitbuffer.h',
         'buffer.cc',

webrtc/base/crc32.cc

@@ -11,7 +11,6 @@
 #include "webrtc/base/crc32.h"
 
 #include "webrtc/base/arraysize.h"
-#include "webrtc/base/basicdefs.h"
 
 namespace rtc {
 

webrtc/libjingle/xmpp/constants.cc

@@ -16,7 +16,6 @@
 #include "webrtc/libjingle/xmllite/xmlconstants.h"
 #include "webrtc/libjingle/xmllite/xmlelement.h"
 #include "webrtc/libjingle/xmpp/jid.h"
-#include "webrtc/base/basicdefs.h"
 
 namespace buzz {
 

webrtc/libjingle/xmpp/xmppclient.h

@@ -16,7 +16,6 @@
 #include "webrtc/libjingle/xmpp/xmppclientsettings.h"
 #include "webrtc/libjingle/xmpp/xmppengine.h"
 #include "webrtc/libjingle/xmpp/xmpptask.h"
-#include "webrtc/base/basicdefs.h"
 #include "webrtc/base/sigslot.h"
 #include "webrtc/base/task.h"
 

webrtc/libjingle/xmpp/xmppsocket.cc

@@ -15,7 +15,6 @@
 #endif
 
 #include <errno.h>
-#include "webrtc/base/basicdefs.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/thread.h"
 #ifdef FEATURE_ENABLE_SSL

webrtc/p2p/base/transportdescription.cc

@@ -11,7 +11,6 @@
 #include "webrtc/p2p/base/transportdescription.h"
 
 #include "webrtc/base/arraysize.h"
-#include "webrtc/base/basicdefs.h"
 #include "webrtc/base/stringutils.h"
 #include "webrtc/p2p/base/constants.h"
 

webrtc/p2p/client/httpportallocator.cc

@@ -13,7 +13,6 @@
 #include <algorithm>
 #include <map>
 
-#include "webrtc/base/basicdefs.h"
 #include "webrtc/base/common.h"
 #include "webrtc/base/helpers.h"
 #include "webrtc/base/httpcommon.h"