zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not use internal source in video send stream tests.

Browse Source 
Unless testing a behavior specific to video encoders with internal source.

Bug: None
Change-Id: Ia42177f2a0b7e658060208444870a7466c6779dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179362
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31740}
This commit is contained in:
Mirta Dvornicic
2020-07-15 14:10:31 +02:00
committed by Commit Bot
parent e51d6ac5d2
commit fca30875b6
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
video/video_send_stream_tests.cc
View File

@ -2280,13 +2280,15 @@ TEST_F(VideoSendStreamTest, CanReconfigureToUseStartBitrateAbovePreviousMax) {
StartBitrateObserver encoder; StartBitrateObserver encoder;
test::VideoEncoderProxyFactory encoder_factory(&encoder); test::VideoEncoderProxyFactory encoder_factory(&encoder);
// Since this test does not use a capturer, set |internal_source| = true.
// Encoder configuration is otherwise updated on the next video frame.
encoder_factory.SetHasInternalSource(true);
GetVideoSendConfig()->encoder_settings.encoder_factory = &encoder_factory; GetVideoSendConfig()->encoder_settings.encoder_factory = &encoder_factory;
CreateVideoStreams(); CreateVideoStreams();
// Start capturing and encoding frames to force encoder reconfiguration.
CreateFrameGeneratorCapturer(kDefaultFramerate, kDefaultWidth,
kDefaultHeight);
frame_generator_capturer_->Start();
EXPECT_TRUE(encoder.WaitForStartBitrate()); EXPECT_TRUE(encoder.WaitForStartBitrate());
EXPECT_EQ(GetVideoEncoderConfig()->max_bitrate_bps / 1000, EXPECT_EQ(GetVideoEncoderConfig()->max_bitrate_bps / 1000,
encoder.GetStartBitrateKbps()); encoder.GetStartBitrateKbps());