zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Making ContinueSSL synchronously set the state to "open".

Browse Source 
It was recently made asynchronous, and this broke some downstream tests.

BUG=webrtc:6387
TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/2381313003 .

Cr-Commit-Position: refs/heads/master@{#14463}
This commit is contained in:
Taylor Brandstetter
2016-09-30 17:34:32 -07:00
parent dd7fb43f28
commit fe69a74ba8
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
webrtc/base/opensslstreamadapter.cc
View File

@ -865,10 +865,12 @@ int OpenSSLStreamAdapter::ContinueSSL() {
// SE_OPEN. If we need a client certificate fingerprint and don't have
// it yet, we'll instead signal SE_OPEN in SetPeerCertificateDigest.
//
// Post the event asynchronously to unwind the stack. The
// caller of ContinueSSL may be the same object listening
// for these events and may not be prepared for reentrancy.
PostEvent(SE_OPEN | SE_READ | SE_WRITE, 0);
// TODO(deadbeef): Post this event asynchronously to unwind the stack.
// The caller of ContinueSSL may be the same object listening for these
// events and may not be prepared for reentrancy.
// PostEvent(SE_OPEN | SE_READ | SE_WRITE, 0);
StreamAdapterInterface::OnEvent(stream(), SE_OPEN | SE_READ | SE_WRITE,
0);
}
break;