16476ad1d2
Merge commit 'upstream-main' into master
...
Bug: 261600888
Test: none, build files to be updated in follow up cl
Change-Id: Ib520938290c6bbdee4a9f73b6419b6c947a96ec4
2022-12-27 23:04:04 -08:00
17887eb04a
Reland "[ACM] iSAC audio codec removed"
...
This is a reland of commit b46c4bf27ba5c417fcba7f200d80fa4634e7e1a1
Original change's description:
> [ACM] iSAC audio codec removed
>
> Note: this CL has to leave behind one part of iSAC, which is its VAD
> currently used by AGC1 in APM. The target visibility has been
> restricted and the VAD will be removed together with AGC1 when the
> time comes.
>
> Tested: see https://chromium-review.googlesource.com/c/chromium/src/+/4013319
>
> Bug: webrtc:14450
> Change-Id: I69cc518b16280eae62a1f1977cdbfa24c08cf5f9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282421
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38652}
Bug: webrtc:14450
Change-Id: Ia22c4d7724b6022238235fede93e36e570a49376
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283843
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38665}
2022-11-17 12:52:35 +00:00
5dd548261f
APM: Signal error on unsupported sample rates
...
This CL adds more explicit tests for unsupported sample rates in the WebRTC audio processing module (APM). Rates are restricted to the range [8000, 384000] Hz. Rates outside this range are handled as best as possible, depending on the format.
Tested: bitexact on a large number of aecdumps
Bug: chromium:1332484, chromium:1334991
Change-Id: I9639d03dc837e1fdff64d1f9d1fff0edc0fb299f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276920
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38663}
2022-11-17 12:12:04 +00:00
fbeb76ab51
Revert "[ACM] iSAC audio codec removed"
...
This reverts commit b46c4bf27ba5c417fcba7f200d80fa4634e7e1a1.
Reason for revert: breaks a downstream project
Original change's description:
> [ACM] iSAC audio codec removed
>
> Note: this CL has to leave behind one part of iSAC, which is its VAD
> currently used by AGC1 in APM. The target visibility has been
> restricted and the VAD will be removed together with AGC1 when the
> time comes.
>
> Tested: see https://chromium-review.googlesource.com/c/chromium/src/+/4013319
>
> Bug: webrtc:14450
> Change-Id: I69cc518b16280eae62a1f1977cdbfa24c08cf5f9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282421
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38652}
Bug: webrtc:14450
Change-Id: Ice138004e84e8c5f896684e8d01133d4b2a77bb7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283800
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38655}
2022-11-16 20:40:52 +00:00
b46c4bf27b
[ACM] iSAC audio codec removed
...
Note: this CL has to leave behind one part of iSAC, which is its VAD
currently used by AGC1 in APM. The target visibility has been
restricted and the VAD will be removed together with AGC1 when the
time comes.
Tested: see https://chromium-review.googlesource.com/c/chromium/src/+/4013319
Bug: webrtc:14450
Change-Id: I69cc518b16280eae62a1f1977cdbfa24c08cf5f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282421
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38652}
2022-11-16 16:42:55 +00:00
02c99982c8
Limit input size for the rtp video layers allocation fuzzer
...
Bug: chromium:1355892
Change-Id: Ib0c48d27fb1e79212d2354e0249511aeeb53f650
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272961
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37913}
2022-08-26 09:00:18 +00:00
de7ae5755b
Remove statistics tracking from FrameBuffer2
...
This was only set to nullptr in non-test environments and was thusly
unused. With this change, the stats callbacks are gaurenteed to only
come from the VideoStreamBufferController and so the thread checks can
be removed.
Bug: webrtc:14003
Change-Id: Iaf0e77aa7c45a317e38ae27739edcefd3123d832
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272021
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37816}
2022-08-18 09:13:28 +00:00
29d7292a34
Clean VideoReceiveStream2 includes
...
Moves FrameBuffer2 to its own GN target to reduce the binary size of the
video target.
Bug: None
Change-Id: I40e86a1eabc0c9e8e6fada3dcdb4e3a043c61c6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271286
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37803}
2022-08-16 15:20:14 +00:00
7fbab87b60
Report histograms in dtor of UlpfecReceiver.
...
The data that's used to report the histograms is owned by UlpfecReceiver
and moving the reporting there, simplifies things as configuration
changes happen in RtpVideoStreamReceiver2 (which currently require all
receive streams to be deleted+reconstructed).
Additional updates:
* Consistently using `Clock` for timestamps. Before there was
a mix of Clock and rtc::TimeMillis.
* Update code to use Timestamp and TimeDelta.
Bug: none
Change-Id: I89ca28ec7067a49d6b357315ae733b04e7c5a2e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271027
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37729}
2022-08-10 07:51:35 +00:00
e488a87753
Remove UlpfecReceiver virtual interface.
...
There's only one implementation.
Bug: none
Change-Id: I204c23e7f87102909fcf6ee8632ceeed84e901a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271026
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37725}
2022-08-09 18:31:22 +00:00
2ed6fc2217
In Vp9 encoder wrapper force key frame on svc controller request
...
Bug: chromium:1349761
Change-Id: I865a251ea87b0946ff0247cba5c3bf1e098dffab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270482
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37684}
2022-08-03 19:15:45 +00:00
3bd444ffdb
Clarify and extend test support for certain sample rates in audio processing
...
Sample rates not divisible by 100, in particular 11025 Hz and 22050 Hz, have long been used with APM in Chrome, but the support has never been stated explicitly.
This CL makes minor modifications to the APM API to clarify how rates are handled when 10 ms is not an integer number of samples. Unit tests are also extended to cover this case better.
This does not update all references to 10 ms and implicit floor(sample_rate/100) computations, but it does at least take us closer to a correct API.
Note that not all code needs to support these sample rates. For example, audio processing submodules only need to operate on the native APM rates 16000, 32000, 48000.
Bug: chromium:1332484
Change-Id: I1dad15468f6ccb9c0d4d09c5819fe87f8388d5b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268769
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37682}
2022-08-03 14:26:36 +00:00
bf607e2564
Speed up vp9 encoder reference fuzzer
...
Replace mock implmentation with manual noop implementaion.
libvpx interface is called a lot, and mock implementation of it adds
noticable overhead.
Bug: chromium:1281020
Change-Id: I7fe5cbfd08d5056a14d75e009acff368700c26a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269214
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37656}
2022-08-02 07:57:43 +00:00
03f8b8a241
In video replace non-owning pointer to rtc::TaskQueue with non-owning pointer to TaskQueueBase
...
rtc::TaskQueue is a simple wrapper over TaskQueueBase and adds no
extra features when task queue is used without passing ownership.
Reducing usage of the internal rtc::TaskQueue wrapper gives users more flexibility how TaskQueueBase* is stored.
Bug: webrtc:14169
Change-Id: If5c8827544c843502c7dfcef775ac558de79ec3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268189
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37549}
2022-07-18 13:59:32 +00:00
ae65b0e0d9
Fuzz APM sample rates
...
This CL adds a fuzzer for the audio processing module that exercises the handling of all user input sample rates logged by the UMA histogram WebAudio.AudioContext.HardwareSampleRate.
The fuzzer inherits a lot of structure from the audio_processing_configs_fuzzer, but is greatly simplified and therefore the only shared code is test::FuzzDataHelper.
Tested: Modified the build to explicitly trigger resampling issue and verified it exercises the code, then let an unmodified fuzzer run locally over the weekend without finding issues.
Bug: webrtc:14263
Change-Id: Id3f19adee53c8842e92b6bf31cd2f360e19244d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268192
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37540}
2022-07-18 09:29:31 +00:00
0ed3a2b6cb
Avoid exposing RemoteBitrateEstimator in ReceiveSideCongestionController
...
Making RemoteBitrateEstimator to be ReceiveSideCC implementation detail allows code to be cleaner.
Bug: None
Change-Id: I1d3327c44b364c6c2a1005391cf1dc468e0cc8ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266482
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37305}
2022-06-22 13:41:21 +00:00
105711e9ad
Move rtc::make_ref_counted to api/
...
Bug: webrtc:12701
Change-Id: If49095b101c1a1763c2a44a0284c0d670cce953f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265390
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37219}
2022-06-15 09:47:38 +00:00
306eee3d17
APM fuzzer: fuzz more sample rates, clean up input generation
...
APM has historically allowed sample rates not divisible by 100, but there is also code that explicitly states that such rates are not supported.
It is unclear how well rates like 22050 are handled in practice.
This CL adds support for fuzzing more sample rates, to help find issues.
We usually preserve fuzzer data reads to avoid invalidating unresolved fuzzer-found issues, but to make the code a little more readable this CL removes the discarded reads. This renders the only currently open bug non-reproducible, crbug.com/1299393.
Bug: webrtc:9413, chromium:1299393
Change-Id: I98ac1c653627c20adc73b8edede02f1526d80d9d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264504
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37114}
2022-06-03 13:00:43 +00:00
c4d253c1ed
Move VCMTiming into timing sub-folder
...
Bug: webrtc:14111
Change-Id: I9785b00012ea84f55789845a7e71fe26006d5067
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263581
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37061}
2022-05-31 13:01:24 +00:00
f6f4543304
Rename VideoReceiveStream to VideoReceiveStreamInterface
...
Bug: webrtc:7484
Change-Id: I653cfe46486e0396897dd333069a894d67e3c07b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262769
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36958}
2022-05-22 10:54:38 +00:00
65b2d8ad21
Move RunLoop test class to its own build target
...
To make it usable in tests without depending on all of CallTest.
Bug: None
Change-Id: Ie3102ab71bcfe3862dd6c35d3285098e961e54df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262807
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36932}
2022-05-19 15:51:39 +00:00
807328fec7
Move frame drop config to VideoCodec and VideoEncoderConfig.
...
Intend to delete corresponding codec-specific settings in a followup.
Bug: webrtc:6883
Change-Id: I78ab07729a5aee1055f80d39d8f7289beb6721e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262244
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36882}
2022-05-13 13:40:14 +00:00
42a829e623
Delete implicit conversion from rtc::scoped_refptr<T> to T*
...
Bug: webrtc:13464
Change-Id: I24c742c11a4ea5c4e307e170ee4fbd4e81cf1814
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260325
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36808}
2022-05-09 09:06:44 +00:00
8615bf0582
Move FrameBuffer3 to api/
...
The webrtc::VideoStreamDecoderInterface was basically created as a public version of FrameBuffer2, but to hide the complexity of FrameBuffer2 it was also combined with decoding so that the public API could be reasonably simple to use. FrameBuffer3 has a simple API with a clear purpose, so its API can be exposed directly.
Bug: webrtc:14026
Change-Id: I81dc84b869e4d16c5e02feb5c876fbcede3d4a25
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261181
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36781}
2022-05-05 14:34:48 +00:00
1bcd827e9b
Merged FrameBuffer3 {Next,Last}DecodableTemporalUnitRtpTimestamp() function.
...
Bug: webrtc:13343
Change-Id: Ic21eddd38466e6b5fd8b912b3ee2d9dc47a0ba35
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260981
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36756}
2022-05-04 11:29:57 +00:00
c3e6e3a3e8
Remove dependency on rtc_base_approved from most targets
...
Bug: webrtc:9838
Change-Id: Ibd0199803597eff48ca139a5cecdc3209c62c5d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259873
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36643}
2022-04-25 12:15:30 +00:00
ed4aadc0a2
Move copy_on_write_buffer out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: Ib9a9cd3bc868e716315594c436df7e2cce0d9a5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259311
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36636}
2022-04-24 09:51:50 +00:00
ceb7b36d3a
Move byte_buffer out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: Ic7e912cba1218f1eed794cb8c393ac148106b16c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259310
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36634}
2022-04-23 22:47:39 +00:00
f9c5984a1d
Move buffer out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: I14feff7b1f0182d031b6644d281be44122820ce7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259307
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36629}
2022-04-22 21:19:28 +00:00
71337f387e
Move random out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: I64a5ef18c19d446139354d04aa6cb2a76d18aad0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258762
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36572}
2022-04-19 14:00:47 +00:00
e0ac10db0a
Remove use of deprecated Json API
...
Bug: b/228975498
Change-Id: Ib8fafdd092669f1b430c1f02eeb522fe1b13b654
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258788
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36542}
2022-04-13 15:15:58 +00:00
39ad2d868c
AudioBuffer: Remove deprecated constructor
...
Removes webrtc::AudioBuffer deprecated constructor.
Bug: webrtc:5298
Change-Id: If8debe990c0358e58fbdc59bfdfb7e4af1f38f00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257305
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Lionel Koenig <lionelk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36518}
2022-04-11 10:06:07 +00:00
64cdcc0792
AEC3: Add multichannel configuration and multichannel detection
...
The features have two safety fallbacks:
- multichannel config has a killswitch WebRTC-Aec3SetupSpecificDefaultConfigDefaultsKillSwitch
- stereo detection has a killswitch WebRTC-Aec3StereoContentDetectionKillSwitch
Both features are enabled by default in the AEC3 config.
Tested: Bitexact on a large number of aecdumps.
Bug: chromium:1295710
Change-Id: I340cdc9140dacd4ca22d0911eb9f732b6cf8b226
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258129
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36482}
2022-04-07 14:58:02 +00:00
dd837e28fa
Remove //rtc_base:timeutils from public deps
...
Bug: webrtc:8603
Change-Id: Iaca9356d16275a02e8842c783f259131d72ef010
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257914
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36460}
2022-04-06 11:23:21 +00:00
57aa81bce7
Remove //rtc_base:stringutils from public deps
...
Bug: webrtc:8603
Change-Id: Ic2dfbe28d310cb4b35983b73e895fc95e8439669
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257913
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36453}
2022-04-05 22:42:19 +00:00
e10a9f609a
Remove //rtc_base:safe_conversions from public deps
...
Bug: webrtc:8603
Change-Id: I285ac30975039f8fe9882d1673cc8e4a615c8618
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257912
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36452}
2022-04-05 20:04:59 +00:00
f86f6f9afd
Remove //rtc_base:refcount from public deps
...
Bug: webrtc:8603
Change-Id: Ib27a107ae809df739492846175f0e9c4af40d21a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257910
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36447}
2022-04-05 15:32:29 +00:00
4467ad7835
Remove //rtc_base:macromagic from public deps
...
Bug: webrtc:8603
Change-Id: I9708df48c9bde9f86ba2d1a92a278bb0d09f3865
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257909
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36444}
2022-04-05 12:36:12 +00:00
0af55ba60d
Remove //rtc_base:logging from public deps
...
Bug: webrtc:8603
Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-05 10:31:19 +00:00
e62c2f2c77
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
...
rename WebRtcKeyValueConfig to FieldTrialsView
Bug: webrtc:10335
Change-Id: If725bd498c4c3daf144bee638230fa089fdde833
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 10:14:00 +00:00
8df1957885
Remove internal dependencies on rtc_pc_base
...
This explores the theory that targets that have no files, just
dependencies, are unnecessary.
Bug: webrtc:13805
Change-Id: I1feb50cf3886128031af8970eae361e35fb052c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256974
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36363}
2022-03-29 09:03:10 +00:00
e02f9eedb3
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 10/inf
...
This patch takes a stab at modules/video_coding,
but reaches only about half.
Bug: webrtc:10335
Change-Id: I0d47d0468b818145470c51ae4e8e75ff58d499ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256112
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36335}
2022-03-25 12:35:36 +00:00
2ea4d376cc
Break out remaining level-1 targets from rtc_pc_base
...
Bug: webrtc:13805
Change-Id: I39a28489ff121de57a8476da10d297db823db091
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254822
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36182}
2022-03-13 14:47:21 +00:00
c4ed5f0b1a
Adding fuzzer for G711/PCM u/A decoders and fixing a fuzzer problem
...
Bug: chromium:1279775
Change-Id: I8cc3f5fe25b9e707e9d171251026bd5a8bad5da5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251844
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36036}
2022-02-21 13:35:24 +00:00
ba2677061a
Add fuzzer test for G722 and fix a fuzzer problem
...
The problem was fixed by implementing the methid PacketDuration() in
AudioDecoderG722StereoImpl, which catches the issue in
AudioDecoder::Decode().
Bug: chromium:1280851
Change-Id: I31f974b9999f3c1c62b0e5dc39bb3e56a9a9388d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251842
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36034}
2022-02-21 10:16:47 +00:00
1db0a261ca
Reland "Reland "Remove unused APM voice activity detection sub-module""
...
This reverts commit 09aaf6f7bcfb4da644bd86c76896a04a41f776e1.
Reason for revert: downstream fixed (see https://chromium-review.googlesource.com/c/chromium/src/+/3461371 )
Original change's description:
> Revert "Reland "Remove unused APM voice activity detection sub-module""
>
> This reverts commit 54d1344d985b00d4d1580dd18057d4618c11ad1f.
>
> Reason for revert: Breaks chromium roll, see
> https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_tsan_rel_ng/1080583/overview
>
> https://chromium-review.googlesource.com/c/chromium/src/+/3461512
>
> Original change's description:
> > Reland "Remove unused APM voice activity detection sub-module"
> >
> > This reverts commit a751f167c68343f76528436defdbc61600a8d7b3.
> >
> > Reason for revert: dependency in a downstream project removed
> >
> > Original change's description:
> > > Revert "Remove unused APM voice activity detection sub-module"
> > >
> > > This reverts commit b4e06d032e6f82a65c52ed0c5364ae9e7c0a0215.
> > >
> > > Reason for revert: breaking downstream projects
> > >
> > > Original change's description:
> > > > Remove unused APM voice activity detection sub-module
> > > >
> > > > API changes:
> > > > - webrtc::AudioProcessing::Config::VoiceDetection removed
> > > > - webrtc::AudioProcessingStats::voice_detected deprecated
> > > > - cricket::AudioOptions::typing_detection deprecated
> > > > - webrtc::StatsReport::StatsValueName::
> > > > kStatsValueNameTypingNoiseState deprecated
> > > >
> > > > PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0
> > > >
> > > > Bug: webrtc:11226,webrtc:11292
> > > > Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666
> > > > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > > > Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> > > > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/main@{#35975}
> > >
> > > TBR=gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
> > >
> > > Change-Id: Iee01fdb874b4e0331277f3ffe60dacaabc3859a2
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:11226,webrtc:11292
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251600
> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > > Cr-Commit-Position: refs/heads/main@{#35977}
> >
> > # Not skipping CQ checks because this is a reland.
> >
> > Bug: webrtc:11226,webrtc:11292
> > Change-Id: I2fcbc5fdade16bfe6a0f0a02841a33a598d4f2ad
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251660
> > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35984}
>
> TBR=mbonadei@webrtc.org ,gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: Ib308a3af2dcce85a0074ef5a4680ccec3f82712f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:11226,webrtc:11292
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251688
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Auto-Submit: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35990}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:11226,webrtc:11292
Change-Id: Idfda6a517027ad323caf44c526a88468e5b52b65
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251762
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36012}
2022-02-16 08:41:30 +00:00
ac341df436
Adding fuzzer for PCM16b decoder and fixing a fuzzer problem
...
Bug: chromium:1280852
Change-Id: I7f6c5de86ceee01156743c0389c59f875e53bb5f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251580
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36005}
2022-02-15 15:59:01 +00:00
599002c905
Restrict frame id range in frame buffer 3 fuzzer
...
Bug: chromium:1293129
Change-Id: Icc9152447363e69b2be561bc90a23f411d64b11a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251385
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36001}
2022-02-15 09:18:51 +00:00
09aaf6f7bc
Revert "Reland "Remove unused APM voice activity detection sub-module""
...
This reverts commit 54d1344d985b00d4d1580dd18057d4618c11ad1f.
Reason for revert: Breaks chromium roll, see
https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_tsan_rel_ng/1080583/overview
https://chromium-review.googlesource.com/c/chromium/src/+/3461512
Original change's description:
> Reland "Remove unused APM voice activity detection sub-module"
>
> This reverts commit a751f167c68343f76528436defdbc61600a8d7b3.
>
> Reason for revert: dependency in a downstream project removed
>
> Original change's description:
> > Revert "Remove unused APM voice activity detection sub-module"
> >
> > This reverts commit b4e06d032e6f82a65c52ed0c5364ae9e7c0a0215.
> >
> > Reason for revert: breaking downstream projects
> >
> > Original change's description:
> > > Remove unused APM voice activity detection sub-module
> > >
> > > API changes:
> > > - webrtc::AudioProcessing::Config::VoiceDetection removed
> > > - webrtc::AudioProcessingStats::voice_detected deprecated
> > > - cricket::AudioOptions::typing_detection deprecated
> > > - webrtc::StatsReport::StatsValueName::
> > > kStatsValueNameTypingNoiseState deprecated
> > >
> > > PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0
> > >
> > > Bug: webrtc:11226,webrtc:11292
> > > Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666
> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> > > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > > Cr-Commit-Position: refs/heads/main@{#35975}
> >
> > TBR=gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
> >
> > Change-Id: Iee01fdb874b4e0331277f3ffe60dacaabc3859a2
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:11226,webrtc:11292
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251600
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35977}
>
> # Not skipping CQ checks because this is a reland.
>
> Bug: webrtc:11226,webrtc:11292
> Change-Id: I2fcbc5fdade16bfe6a0f0a02841a33a598d4f2ad
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251660
> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35984}
TBR=mbonadei@webrtc.org ,gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Ib308a3af2dcce85a0074ef5a4680ccec3f82712f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11226,webrtc:11292
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251688
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35990}
2022-02-14 12:25:51 +00:00
54d1344d98
Reland "Remove unused APM voice activity detection sub-module"
...
This reverts commit a751f167c68343f76528436defdbc61600a8d7b3.
Reason for revert: dependency in a downstream project removed
Original change's description:
> Revert "Remove unused APM voice activity detection sub-module"
>
> This reverts commit b4e06d032e6f82a65c52ed0c5364ae9e7c0a0215.
>
> Reason for revert: breaking downstream projects
>
> Original change's description:
> > Remove unused APM voice activity detection sub-module
> >
> > API changes:
> > - webrtc::AudioProcessing::Config::VoiceDetection removed
> > - webrtc::AudioProcessingStats::voice_detected deprecated
> > - cricket::AudioOptions::typing_detection deprecated
> > - webrtc::StatsReport::StatsValueName::
> > kStatsValueNameTypingNoiseState deprecated
> >
> > PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0
> >
> > Bug: webrtc:11226,webrtc:11292
> > Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35975}
>
> TBR=gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: Iee01fdb874b4e0331277f3ffe60dacaabc3859a2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:11226,webrtc:11292
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251600
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35977}
# Not skipping CQ checks because this is a reland.
Bug: webrtc:11226,webrtc:11292
Change-Id: I2fcbc5fdade16bfe6a0f0a02841a33a598d4f2ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251660
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35984}
2022-02-13 14:02:08 +00:00
