8967672f6d
dcsctp: Refactor send queue (1/2)
...
Let the OutgoingStream reference the parent instead of passing
references to individual items it needs, as follow-up CLs will add even
more items.
No functional change - pure refactoring.
Bug: webrtc:5696
Change-Id: I914e590c0d90e898d7d230a16170cf4faff2338c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264142
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37398}
2022-07-01 13:53:14 +00:00
74680c0234
Cleanup RemoteBitrateEstimate::LatestEstimate function
...
Return the bitrate estimate as DataRate type
Remove list of affected ssrcs as unused
Bug: None
Change-Id: Ie31dce591d861624736d834194f90eb6c93f70f6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267280
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37397}
2022-07-01 13:05:05 +00:00
5e21262a44
dcsctp: Add API for lifecycle events
...
This CL adds the API to enable message lifecycle events to be generated.
Those can in turn be used to generate metrics, e.g. latency metrics
tracking the time to send a message, the time until it's acknowledged,
and metrics tracking how often messages are expired.
This will be used to validate that message interleaving really improves
latency for high priority data channels.
The actual implementation of the API will be provided in follow-up CLs.
Bug: webrtc:5696
Change-Id: Ic06f8244d1c79a336975e35479130521dff17519
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264141
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37396}
2022-07-01 10:59:25 +00:00
3e4e05d28b
Use generate_stubs without //base dependency
...
For this I added a header called no_cfi_icall.h and use it.
Also, some files use the gio header, but if the //base dependency is
not used, compilation errors occur. So I added an explicit dependency
on gio.
Bug: webrtc:13662
Change-Id: If732ede202dd413be6702bf06bf024cd203fdae2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267340
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37395}
2022-07-01 10:50:54 +00:00
3b4134fcf6
Roll chromium_revision c4edcb406f..bac0ff1a2f (1019918:1020023)
...
Change log: c4edcb406f..bac0ff1a2fc4edcb406f..bac0ff1a2f55c683a9ae..5650bc6a1013924a1254..b09cdd74caab333a0835..90479fbd3fa6545e1c1a..cc7d6973e12f0cfbbf05..38968a908chttps://chromium.googlesource.com/catapult.git/+log/bd235b08d6..0f40847086
* src/third_party/depot_tools: 6628661eba..9af90cb59e7bcfdf24e8..f413bdf8353f4a0e6564..0b0dd91d7bc4edcb406f..bac0ff1a2fhttps://webrtc-review.googlesource.com/c/src/+/267381
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37394}
2022-07-01 10:34:37 +00:00
2bc41bc980
Detach RemoteBitrateEstimator interface from Module
...
Bug: webrtc:7219
Change-Id: I8302c5044582d73b0918013a0df89b9390788728
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267140
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37393}
2022-07-01 10:17:40 +00:00
1c951ecb32
video_replay: add flexfec support
...
which is useful for validating flexfec recovers frames correctly.
This can be tested by passing a keyframe covered by flexfec along
with the fec packets and removing one packet from the frame.
BUG=None
Change-Id: Icd73eca138f62b9387bf850a6efbd7db03b4b569
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261956
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37392}
2022-07-01 09:42:24 +00:00
3fe8b0d9a9
Do not allow simulcast to be turned off using SDP munging
...
This is an error that puts the PC into an inconsistent state, so
causing a crash is the right thing to do.
Bug: chromium:1341043
Change-Id: Ie1eb89400ad87f0c83634b7073236b07e92ec7ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267281
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37391}
2022-07-01 09:06:44 +00:00
de7fcffe0c
video_replay: add AV1 support to IVF filewriter
...
which is already supported in modules/video_coding/utility/ivf_file_reader.cc
BUG=None
Change-Id: I7b00659dc460d372312dff2eb53837a321ab16af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262246
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37390}
2022-07-01 08:55:44 +00:00
3c24c096ef
Add support for scalability modes L2T3 and S2T3
...
Bug: webrtc:11607
Change-Id: I1d0bd171564d2852f2f6ee2bbee26c7a1c0e1c3f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267103
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37389}
2022-07-01 08:17:04 +00:00
5b2556e9cd
dcsctp: Add metric for using message interleaving
...
There was also some refactoring to create the TCB at the same time,
to ensure the metric is always set.
Bug: webrtc:13052, webrtc:5696
Change-Id: I5557ad5f0fc4a0520de1eaaafa15459b3200c4f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262259
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37388}
2022-07-01 08:12:44 +00:00
11174e7058
Clarify how to reference WebRTC bugs in TODOs
...
Bug: None
No-Try: true
Change-Id: Iaa8b57dea096ef0588979faa5ba7c22dcff1dada
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267282
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37387}
2022-07-01 08:03:34 +00:00
0b655cbef7
Update WebRTC code version (2022-07-01T04:05:02).
...
Bug: None
Change-Id: I0032a42855bd06ba521160b32d6f335a2db27e0b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267325
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37386}
2022-07-01 05:44:04 +00:00
b4c63cb02a
Roll chromium_revision 4b737679fa..c4edcb406f (1019786:1019918)
...
Change log: 4b737679fa..c4edcb406f4b737679fa..c4edcb406fe58fcd7314..55c683a9ae8a45f558f0..13924a125462e3807647..ab333a0835cd963d3a73..a6545e1c1ae6a90d267b..2f0cfbbf050e5881fb4e..6628661ebahttps://aomedia.googlesource.com/aom.git/+log/42223eee85..7ace1184f1
* src/third_party/libvpx/source/libvpx: b355ab5046..711bef67402c4a70d951..7bcfdf24e8be263a53b0..3f4a0e65644b737679fa..c4edcb406fhttps://webrtc-review.googlesource.com/c/src/+/267323
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37385}
2022-07-01 02:50:34 +00:00
2cffde72b8
dcsctp: Restore from handover as separate methods
...
Before this CL, some components, e.g. the SendQueue, was first created
and then later restored from handover state, while some were created from
the handover state, as an optional parameter to their constructors.
This CL will make it consistent, by always creating the components in a
pristine state, and then modifying it when restoring them from handover
state. The name "RestoreFromState" was used to be consistent with SendQueue
and the socket.
This is just refactoring.
Bug: None
Change-Id: Ifad2d2e84a74a12a93abbfb0fe1027ebb9580e73
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267006
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37384}
2022-06-30 22:09:04 +00:00
45a933c27f
Roll chromium_revision f431ec7c65..4b737679fa (1018991:1019786)
...
Change log: f431ec7c65..4b737679faf431ec7c65..4b737679fa2f3d3763f3..e58fcd73141df60f6d93..8a45f558f038581d5247..62e38076477663e0cfff..cd963d3a734b0c114187..e6a90d267bhttps://chromium.googlesource.com/catapult.git/+log/c76626ec30..bd235b08d6
* src/third_party/depot_tools: a83ac9395c..0e5881fb4efe4a50df8e..6900494d90d8081faeb0..2c4a70d9516adbb78ead..be263a53b0f431ec7c65..4b737679fahttps://webrtc-review.googlesource.com/c/src/+/267320
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37383}
2022-06-30 20:44:33 +00:00
ed665521e4
in RtpRtcp configuration delete unused remote bitrate estimator
...
No code sets that configuration field.
Bug: None
Change-Id: Idd611d15ec54b3bd9115eac77d2222b97620d675
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267180
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37382}
2022-06-30 14:07:49 +00:00
de2ac5a6f3
Adopt absl::string_view in p2p/
...
Bug: webrtc:13579
Change-Id: Ia33afa2a9ad12d1a586087d49f581a93fddb565d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262766
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37381}
2022-06-30 13:19:18 +00:00
4b97928b30
Refactor RepeatingTaskHandle to use absl::AnyInvocable
...
Allow to use AnyInvocable in webrtc.
Demonstrate how AnyInvocable can make interface clearer to read and implement
Demonstrate that AnyInvocable can reduce binary size
Bug: None
Change-Id: I33cf33fac6ed3bf4c5e46077d1cd984ca0f253a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267165
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37380}
2022-06-30 12:22:17 +00:00
978cb6762f
Remove //test:field_trials from RTCEventLogs viewer.
...
This dependency is not needed.
Bug: b/237526033
Change-Id: Ief983a7cd08e919b0b120809f1aa1ec5bde8a8d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267168
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37379}
2022-06-30 12:01:48 +00:00
fb60796b64
fec: simplify fec generation
...
since the fec packets are initialized to 0 there is no need
to special-case the first packet since
A XOR 0
is the identity operator.
BUG=None
Change-Id: I0cb55283ecdca06f8e3a7b5856ec1f9fbbad1ffb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251522
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37378}
2022-06-30 11:53:58 +00:00
42b163f236
Remove unnecessary overloads
...
Bug: webrtc:13579
Change-Id: I6fbc1ea8fdc30b0d3e1084a941910027655c6feb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267062
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37377}
2022-06-30 09:39:28 +00:00
9ea1ef649f
Switch from junit_binary to robolectric_binary.
...
This was done in:
https://chromium-review.googlesource.com/c/chromium/src/+/3709093
https://chromium-review.googlesource.com/c/chromium/src/+/3732850
Bug: chromium:1336818, b/237612564
Change-Id: Ie1394ffa16a7c3322aa774e94aee93e6b1ac6ed6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267167
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37376}
2022-06-30 08:02:18 +00:00
d69a726989
Make WebRTC use third_party/libevent rather than base/third_party/libevent
...
Bug: chromium:1335194
Change-Id: I084b391b42e2496163ea625c0bdc9255177e5603
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266680
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37375}
2022-06-30 07:43:49 +00:00
fa1a81cba8
Update WebRTC code version (2022-06-30T04:06:24).
...
Bug: None
Change-Id: I603d3acd0c94f95a9ede972a0b81c9b97ccd5f0f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267261
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37374}
2022-06-30 06:08:26 +00:00
3db07436bb
Reland "Make the test library for field trials testonly."
...
This is a reland of commit c33f1a828c31412e7422e7bf11db7c9b61fab339
Original change's description:
> Make the test library for field trials testonly.
>
> Bug: None
> Change-Id: I703a82e0ca10908bdc56c0d4f1455e042ce74ac1
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267163
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37371}
Bug: None
Change-Id: I1a1a7732e50e838f00ee3c713c4cf4def9b543ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267166
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37373}
2022-06-29 23:34:18 +00:00
eefae3b7b7
Revert "Make the test library for field trials testonly."
...
This reverts commit c33f1a828c31412e7422e7bf11db7c9b61fab339.
Reason for revert: Breaks downstream project.
Original change's description:
> Make the test library for field trials testonly.
>
> Bug: None
> Change-Id: I703a82e0ca10908bdc56c0d4f1455e042ce74ac1
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267163
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37371}
Bug: None
Change-Id: I1d6d88ed9f32d5f1aab3159bbd1f279f164a079d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267164
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37372}
2022-06-29 15:53:48 +00:00
c33f1a828c
Make the test library for field trials testonly.
...
Bug: None
Change-Id: I703a82e0ca10908bdc56c0d4f1455e042ce74ac1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267163
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37371}
2022-06-29 15:43:08 +00:00
3afb8e2431
When VP9 SVC is used, use SvcConfig to set max bitrate for the stream.
...
Currently, a default max bitrate is determined within WebRtcVideoEngine,
which maxes out at 2.5Mbps - and that limits the max bitrate deteremined
by SvcConfig for resolutions above 720p.
This does not affect simulcast, as WebRtcVideoEngine already knows to
trust the rate allocation in simulcast.cc instead.
Bug: webrtc:14017
Change-Id: I0c310a6fd496e9e5a10eae45838900068aa1ae2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267160
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37370}
2022-06-29 14:23:08 +00:00
ba90d025a1
Revert "Temporarily disable video_capture_tests on linux"
...
This reverts commit 915d419eb94782ce424ae59c07d8b4366e88be74.
Reason for revert: The bots which can run this tests is now working
Original change's description:
> Temporarily disable video_capture_tests on linux
>
> No bots can run linux video_capture_tests for now.
>
> Bug: webrtc:14220
> Change-Id: I5dbdefdd104befff92648a0693bee331d2b50e88
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266660
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org >
> Reviewed-by: Andrey Logvin <landrey@webrtc.org >
> Reviewed-by: Jeremy Leconte <jleconte@google.com >
> Cr-Commit-Position: refs/heads/main@{#37312}
Bug: webrtc:14220
Change-Id: I0a7a82cf64b0692be62a38f3df6416a33917c3d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267105
Owners-Override: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37369}
2022-06-29 13:35:28 +00:00
7c2e06a2aa
Roll chromium_revision e4f1648f77..f431ec7c65 (1018898:1018991)
...
Change log: e4f1648f77..f431ec7c65e4f1648f77..f431ec7c6586c223aa35..2f3d3763f357d2f33f86..1df60f6d938679e5aad2..38581d5247a3f99ca9ba..7663e0cfff552d4272d0..4b0c114187ca89bed50d..b355ab50464ba9ce2bc3..d8081faeb0dce45192ba..6adbb78eade4f1648f77..f431ec7c65https://webrtc-review.googlesource.com/c/src/+/267093
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37368}
2022-06-29 09:41:08 +00:00
3a08d2a42d
Reland "Detach RemoteEstimatorProxy from RemoteBitrateEstimator interface"
...
This reverts commit 6769e95bbc0e4f29c482ee1356b3e250df1fde3b.
Reason for revert: downstream code adjusted
Original change's description:
> Revert "Detach RemoteEstimatorProxy from RemoteBitrateEstimator interface"
>
> This reverts commit 08c7e7589218da1f26e9621e703dd790b4e7e7d7.
>
> Reason for revert: breaks downstream tests
>
> Original change's description:
> > Detach RemoteEstimatorProxy from RemoteBitrateEstimator interface
> >
> > Bug: None
> > Change-Id: I47b7c83320b0c7327c0d2ee59f7a0a30704cd331
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266540
> > Reviewed-by: Philip Eliasson <philipel@webrtc.org >
> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#37354}
>
> Bug: None
> Change-Id: Ia355be085890856141fc943432f6e2edef1c0900
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267065
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37361}
Bug: None
Change-Id: Ifaf8ff84a37a768b388b1f79c8c7829390d1905e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267104
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37367}
2022-06-29 09:38:16 +00:00
1ec962e217
Update WebRTC code version (2022-06-29T04:05:05).
...
Bug: None
Change-Id: I9834e6e481352e5bdbf65ff7b128db5fa10f7b0a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267090
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37366}
2022-06-29 05:54:57 +00:00
9c35310d83
Roll chromium_revision fccb7167c1..e4f1648f77 (1018771:1018898)
...
Change log: fccb7167c1..e4f1648f77fccb7167c1..e4f1648f7727c1560171..86c223aa353b7c3aadd7..57d2f33f86b5f3d3b904..3007992fc7216ecba5c5..8679e5aad28f0f8c8039..a3f99ca9baac645d72b1..552d4272d03c4d401cbd..a83ac9395cb86aef09f3..880df5ede5c594998498..4ba9ce2bc304ee2035be..dce45192bafccb7167c1..e4f1648f77https://webrtc-review.googlesource.com/c/src/+/267088
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37365}
2022-06-29 00:43:37 +00:00
90af4c1b70
Change RTCEventLogFactory to have a const Create function
...
Conformant with naming rule:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/g3doc/implementation_basics.md;l=48?q=factory%20file:md$%20file:webrtc&ss=chromium
Bug: webrtc:14226
Change-Id: Ibec148fada6303e2ebdc5e6405fd527065f69d41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266360
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37364}
2022-06-28 23:48:37 +00:00
cc7bd85748
Don't add libopus to public_deps, its headers are only used directly
...
Bug: webrtc:8603
Change-Id: I2ce1f96a80dd23e420b3693b899d2b14382fd2d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266765
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Oleh Prypin <oprypin@google.com >
Cr-Commit-Position: refs/heads/main@{#37363}
2022-06-28 19:13:14 +00:00
b97ddd9fb1
Roll chromium_revision f591824604..fccb7167c1 (1018662:1018771)
...
Change log: f591824604..fccb7167c1f591824604..fccb7167c1374ba1e85b..27c1560171414d719418..3b7c3aadd7e9ad577af3..216ecba5c55cc521c392..8f0f8c8039d8653cfba2..ac645d72b18c074f877b..c594998498cb96a1b71d..04ee2035bef591824604..fccb7167c1https://webrtc-review.googlesource.com/c/src/+/267085
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37362}
2022-06-28 18:36:53 +00:00
6769e95bbc
Revert "Detach RemoteEstimatorProxy from RemoteBitrateEstimator interface"
...
This reverts commit 08c7e7589218da1f26e9621e703dd790b4e7e7d7.
Reason for revert: breaks downstream tests
Original change's description:
> Detach RemoteEstimatorProxy from RemoteBitrateEstimator interface
>
> Bug: None
> Change-Id: I47b7c83320b0c7327c0d2ee59f7a0a30704cd331
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266540
> Reviewed-by: Philip Eliasson <philipel@webrtc.org >
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37354}
Bug: None
Change-Id: Ia355be085890856141fc943432f6e2edef1c0900
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267065
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37361}
2022-06-28 17:07:44 +00:00
8783c678a5
delay estimator: Look for early reverberation
...
Look for first echo (and not only the strongest one) on the same matched
filter.
This change is bit exact with previous version when `pre_echo` is false.
Author: Jesús de Vicente Peña <devicentepena@webrtc.org >
Bug: webrtc:14205
Change-Id: I6782eaa1d690b0df78d00f6d425a85c951b2ca9d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266321
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Commit-Queue: Lionel Koenig <lionelk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37360}
2022-06-28 15:16:03 +00:00
7534ebd2bf
Revert "Reland "Reland "Delete old Android ADM."""
...
This reverts commit db30009304ab97a5fde02977ed1239aa249e2656.
Reason for revert: ... and it's out again :(
Original change's description:
> Reland "Reland "Delete old Android ADM.""
>
> This reverts commit 38a28603fd7b2eec46a362105b225dd6f08b4137.
>
> Reason for revert: Attempt to reland, now that WebRTC dependency cycle has been broken.
>
> Original change's description:
> > Revert "Reland "Delete old Android ADM.""
> >
> > This reverts commit 6e4d7e606c4327eaa9298193e22794fcb9b30218.
> >
> > Reason for revert: Still breaks downstream build (though in a different way this time)
> >
> > Original change's description:
> > > Reland "Delete old Android ADM."
> > >
> > > This is a reland of commit 4ec3e9c98873520b3171d40ab0426b2f05edbbd2
> > >
> > > Original change's description:
> > > > Delete old Android ADM.
> > > >
> > > > The schedule move Android ADM code to sdk directory have been around
> > > > for several years, but the old code still not delete.
> > > >
> > > > Bug: webrtc:7452
> > > > Change-Id: I0f75c680f71f0b2ce614de6cbd9f124c2a59d453
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264620
> > > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
> > > > Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
> > > > Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/main@{#37174}
> > >
> > > Bug: webrtc:7452
> > > Change-Id: Icabad23e72c8258a854b7809a93811161517266c
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265872
> > > Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> > > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > > Cr-Commit-Position: refs/heads/main@{#37236}
> >
> > Bug: webrtc:7452
> > Change-Id: Ide8fbd55fadd7aed9989053afff7c63c04f1320f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266023
> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > Owners-Override: Björn Terelius <terelius@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#37242}
>
> Bug: webrtc:7452
> Change-Id: I6946d0fc28cf4c08387e451e6a07765f7410ce7c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266980
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37356}
Bug: webrtc:7452
Change-Id: I1ef4004e89c8bea322bda0dc697a7ba45abeffcc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267067
Owners-Override: Björn Terelius <terelius@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37359}
2022-06-28 14:37:43 +00:00
ba121e044b
Roll chromium_revision 7e28d0a903..f591824604 (1018529:1018662)
...
Change log: 7e28d0a903..f5918246047e28d0a903..f5918246043680287225..374ba1e85b4e6d71ddc1..414d719418a1f80e1a70..e9ad577af3256ebd83f6..5cc521c392f0cf49c7ab..d8653cfba2https://chromium.googlesource.com/catapult.git/+log/17a97abb47..c76626ec30
* src/third_party/perfetto: 4d2a825326..8c074f877badac73487c..cb96a1b71d7e28d0a903..f591824604https://webrtc-review.googlesource.com/c/src/+/267083
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37358}
2022-06-28 14:33:46 +00:00
3f659b1b3c
Continue looking for frames after padding packets
...
In H264, reordered packets can cause a frame following padding to become stuck in the packet buffer.
A minimal example:
_, P, 1 - padding packet p and frame 1. Frame 1 has not been returned because of missing packet 0
0, P, 1 - when packet 0 arrives, FindFrames will stop incrementing i when it sees padding packet P, and frame 1 will never be returned
Bug: webrtc:14216
Change-Id: I78b76df9709fa8593c5025d647e2b868af3749f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266465
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37357}
2022-06-28 13:03:03 +00:00
db30009304
Reland "Reland "Delete old Android ADM.""
...
This reverts commit 38a28603fd7b2eec46a362105b225dd6f08b4137.
Reason for revert: Attempt to reland, now that WebRTC dependency cycle has been broken.
Original change's description:
> Revert "Reland "Delete old Android ADM.""
>
> This reverts commit 6e4d7e606c4327eaa9298193e22794fcb9b30218.
>
> Reason for revert: Still breaks downstream build (though in a different way this time)
>
> Original change's description:
> > Reland "Delete old Android ADM."
> >
> > This is a reland of commit 4ec3e9c98873520b3171d40ab0426b2f05edbbd2
> >
> > Original change's description:
> > > Delete old Android ADM.
> > >
> > > The schedule move Android ADM code to sdk directory have been around
> > > for several years, but the old code still not delete.
> > >
> > > Bug: webrtc:7452
> > > Change-Id: I0f75c680f71f0b2ce614de6cbd9f124c2a59d453
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264620
> > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
> > > Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
> > > Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> > > Cr-Commit-Position: refs/heads/main@{#37174}
> >
> > Bug: webrtc:7452
> > Change-Id: Icabad23e72c8258a854b7809a93811161517266c
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265872
> > Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#37236}
>
> Bug: webrtc:7452
> Change-Id: Ide8fbd55fadd7aed9989053afff7c63c04f1320f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266023
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Owners-Override: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37242}
Bug: webrtc:7452
Change-Id: I6946d0fc28cf4c08387e451e6a07765f7410ce7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266980
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37356}
2022-06-28 12:58:23 +00:00
a2476e3783
dcsctp: Enable message interleaving
...
This adds support to enable message interleaving in the stream scheduler
from the socket, proxied by the send queue.
It also adds socket unit tests to ensure that prioritization and
interleaving works. Also, send queue test has been added to validate the
integration of the stream scheduler. But the actual scheduling parts of
it will be tested in the stream scheduler unit tests.
Bug: webrtc:5696
Change-Id: Ic7d3d2dc28405c77a107f0148f0096882961eec7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262248
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37355}
2022-06-28 12:05:23 +00:00
08c7e75892
Detach RemoteEstimatorProxy from RemoteBitrateEstimator interface
...
Bug: None
Change-Id: I47b7c83320b0c7327c0d2ee59f7a0a30704cd331
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266540
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37354}
2022-06-28 11:31:23 +00:00
7769dc87d7
Detach legacy RtpRtcp from Module interface
...
Bug: webrtc:7219
Change-Id: I5faf8f68b043994a86d227926c13b07d0141f382
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267063
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37353}
2022-06-28 11:17:43 +00:00
91c05abd9b
Always include the actual encoder implementation when RTCVideoEncoderAV1 is used.
...
Bug: webrtc:13573, b/236813931
Change-Id: I943ce51dac23bcbd6efe10413cfa9478f4ce6f55
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266485
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37352}
2022-06-28 10:28:03 +00:00
ce80886bf2
Remove video_coding dependency on ProcessThread and Module
...
Bug: webrtc:7219
Change-Id: I360f7df5554389274fcaef64070b9441ce0ef984
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266486
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37351}
2022-06-28 10:04:23 +00:00
e58f1991dc
Add Timestamp -> AbsoluteSendTime conversion function
...
instead of ms -> AbsoluteSendTime helper
Bug: webrtc:13757
Change-Id: I57389a66a43b4f4838023f9c224a985f2cd57107
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266024
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37350}
2022-06-28 09:26:42 +00:00
58ecd42deb
Remove std::string version of some functions that are no longer needed.
...
The absl::string_view versions can now be made pure virtual due to
downstream client changes. The std::string versions in the base
classes are still needed by downstream users, but will be removed
eventually.
Bug: webrtc:13579
Change-Id: Id757a07380f0518edf407ff5d0644511eb1e53d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265980
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37349}
2022-06-28 09:06:02 +00:00
