43455f2814
Comment on PacketSocketFactory injection.
...
Document how PeerConnectionFactoryDependencies::packet_socket_factory
interacts with injected port allocator.
Bug: webrtc:7447
Change-Id: Id79b345c1b708944c84f466680c4b3fba77e4feb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266480
Commit-Queue: Niels Moller <nisse@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37298}
2022-06-22 08:29:41 +00:00
a09b921dd4
pc: flush getStats cache in addIceCandidate
...
BUG=webrtc:14190
Change-Id: I6faf35af7b124f4d5258204f7813cedcf3275f42
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265878
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37297}
2022-06-22 07:40:51 +00:00
d90b552712
Update WebRTC code version (2022-06-22T04:04:57).
...
Bug: None
Change-Id: Ic7faae12410f0be27632e0a96d516db15e36b99c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266462
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37296}
2022-06-22 06:42:42 +00:00
dcc3d046e2
pc: make codec comparison for static codecs case-insensitive
...
BUG=webrtc:14211,webrtc:14140
Change-Id: Ib51de4c8961a4cf7c71aea27a55c115613296aae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266371
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37295}
2022-06-22 04:16:52 +00:00
ac38249bf5
Roll chromium_revision efac8e341f..8d9ffcd097 (1016360:1016502)
...
Change log: efac8e341f..8d9ffcd097
Full diff: efac8e341f..8d9ffcd097
Changed dependencies
* src/third_party: 0f7256042f..f35ce53be1
* src/third_party/depot_tools: 9a3c4bc67c..39e4055004
* src/third_party/perfetto: 3d3f58658f..2b0a2135f0
* src/tools: ff5f0a8e7b..9a74d76d18
* src/tools/luci-go: git_revision:df39938896c4603fb2a214a2430450a85d9cca81..git_revision:5d9b6ecf87cdfb928e1112d2838d26bc7ede2b48
* src/tools/luci-go: git_revision:df39938896c4603fb2a214a2430450a85d9cca81..git_revision:5d9b6ecf87cdfb928e1112d2838d26bc7ede2b48
DEPS diff: efac8e341f..8d9ffcd097
/DEPS
No update to Clang.
BUG=None
Change-Id: I215f31e9b0028b7f977a9822fecc79f375324f00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266460
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37294}
2022-06-22 02:45:40 +00:00
e3342ef27f
Roll chromium_revision 18554d103e..efac8e341f (1016235:1016360)
...
Change log: 18554d103e..efac8e341f
Full diff: 18554d103e..efac8e341f
Changed dependencies
* src/base: 957ba2a101..6868b3234a
* src/buildtools/third_party/libc++abi/trunk: 2dba7d2cc4..92ef8d47d0
* src/ios: 9f69d49fd7..089bde8942
* src/testing: 7b1f11a4c8..47eac19cdf
* src/third_party: 0d4a31585e..0f7256042f
* src/third_party/freetype/src: 4b6f92e6b3..2848378be5
* src/third_party/gtest-parallel: e28fc0e83f..f4d65b5558
* src/third_party/perfetto: 5c85522e6e..3d3f58658f
* src/tools: beea5f845f..ff5f0a8e7b
DEPS diff: 18554d103e..efac8e341f
/DEPS
No update to Clang.
BUG=None
Change-Id: I58109239de67d91360663a9dd5d68863c0c0e73b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266425
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37293}
2022-06-21 20:18:00 +00:00
7edbf23700
Roll chromium_revision 8c32effd1d..18554d103e (1016084:1016235)
...
Change log: 8c32effd1d..18554d103e
Full diff: 8c32effd1d..18554d103e
Changed dependencies
* src/base: 80468780a0..957ba2a101
* src/build: 7741c85992..7eec98d540
* src/buildtools/linux64: git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006..git_revision:8883070fe77f9b484818e73e5892c08ca8a0fe7f
* src/buildtools/mac: git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006..git_revision:8883070fe77f9b484818e73e5892c08ca8a0fe7f
* src/buildtools/win: git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006..git_revision:8883070fe77f9b484818e73e5892c08ca8a0fe7f
* src/ios: e49ca2da86..9f69d49fd7
* src/testing: 18b27b9f5d..7b1f11a4c8
* src/third_party: a561306173..0d4a31585e
* src/third_party/freetype/src: 47103b2f19..4b6f92e6b3
* src/third_party/perfetto: b983faf1bf..5c85522e6e
* src/tools: 366e0ade9c..beea5f845f
DEPS diff: 8c32effd1d..18554d103e
/DEPS
No update to Clang.
BUG=None
Change-Id: I980f6cad042f460fb7462ea32b8f35ec837b7ecb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266424
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37292}
2022-06-21 17:10:59 +00:00
ac29b9c37f
APM Transient Suppressor (TS): wire-up RNN VAD, TS and AGC2
...
When the `WebRTC-Audio-TransientSuppressorVadMode-RnnVad` field trial
is set, APM now uses (i) its RNN VAD sub-module to compute the voice
probability, (ii) that probability for TS and (iii) a temporally
delayed version of it for AGC2 (the delay introduced by TS is taken
into account).
Bug: webrtc:13663
Change-Id: Ic0f245c3f00d318c19bb01d3dbc2d5176c90f851
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266362
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Hanna Silen <silen@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37291}
2022-06-21 14:08:17 +00:00
573b145ab5
Reland "Move injection of PacketSocketFactory from PC to PCF"
...
This is a reland of commit 905c3a6c73d293882ef11942066ccda52a9e14d1
Change from previous attempt is between ps#1 and ps#2: Use PeerConnectionFactoryInterface::Options to clear the `network_ignore_mask`.
Original change's description:
> Move injection of PacketSocketFactory from PC to PCF
>
> Injection via PeerConnectionDependecies was broken, in not accepting
> ownership of the injected object.
>
> Bug: webrtc:7447, webrtc:14204
> Change-Id: Ic53f05d51928b006fc1e46d502633d88471eb518
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266140
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37270}
Bug: webrtc:7447, webrtc:14204
Change-Id: Ic78ebec2e88a8c44699015c8c7a44e137f44253a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265982
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37290}
2022-06-21 10:28:39 +00:00
d6849d06c2
Comment fix for PeerConnectionFactoryDependencies::network_manager
...
Accidentally left out of
https://webrtc-review.googlesource.com/c/src/+/266361
Bug: webrtc:7447
Change-Id: Ic6696ec2e8d9b5139769ba2c53c819e25b6caba6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266365
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37289}
2022-06-21 09:44:58 +00:00
c1be89f696
Define Factory, Builder and Manager
...
Bug: none
Change-Id: I314295262c18319d3b0ad37a11641afafc83b006
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265864
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37288}
2022-06-21 09:39:59 +00:00
80b7c6befd
Delete Call dependency on ProcessThread as unused
...
Last usage or ProcessThread was removed in
https://webrtc-review.googlesource.com/c/src/+/265921
Bug: webrtc:7219
Change-Id: Ia46d9e2530cd0dbf56a5c0ca6e1bf0936fd62672
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266363
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37287}
2022-06-21 08:59:38 +00:00
bfd973f212
Roll chromium_revision c2285d20ad..8c32effd1d (1015959:1016084)
...
Change log: c2285d20ad..8c32effd1d
Full diff: c2285d20ad..8c32effd1d
Changed dependencies
* src/base: 4f56dc6ce7..80468780a0
* src/build: 9b1463e569..7741c85992
* src/ios: 04f2483c28..e49ca2da86
* src/testing: 26236c4e9a..18b27b9f5d
* src/third_party: 631be728ee..a561306173
* src/third_party/r8: 9ZYYzSVt4L6QGnf272Wm7wxsJ4VH77Dh2fel6JB9nOcC..iMLEt10uXASDfG2AlATR1fO8xYhBoF24nQvDDXLY6Q8C
* src/tools: ed4ed4571c..366e0ade9c
DEPS diff: c2285d20ad..8c32effd1d
/DEPS
Clang version changed llvmorg-15-init-13434-gbd9eed3a:llvmorg-15-init-13850-ge2913362
Details: c2285d20ad..8c32effd1d
/tools/clang/scripts/update.py
BUG=None
Change-Id: Ia16dbc63cb1b97cd0ee25f7234acf50443295049
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266421
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37286}
2022-06-21 08:48:28 +00:00
ae271ff05a
[DVQA] Add support for removing peer from analyzer instrumentation
...
Add support for removing peer from EncodedImageDataExtractor and
from VideoQualityAnalyzerInjectionHelper.
Bug: b/231397778
Change-Id: Ic33da18b7a68149ef68e5e4ba0ee7eabfb634973
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266364
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37285}
2022-06-21 08:27:38 +00:00
dcb5a5814e
Add NetworkManager to PeerConnectionFactoryDependencies
...
Bug: webrtc:7447
Change-Id: I5abe1c4a15b52e9f15bb3ccbf1919c88000c9828
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266361
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37284}
2022-06-21 07:54:18 +00:00
2b46a5870b
Add proxy access to some methods in Obj-C SDK
...
Most calls to C++ PeerConnection and related classes are proxied
to internal threads in WebRTC. However, there is no such thing
in the Obj-C SDK.
It would be nice to proxy methods in the Obj-C SDK as well.
RTCMediaStream and RTCVideoTrack have NSMutableArray members,
and it can throw NSRangeException when it has race conditions,
so that it would be a good starting point.
Also, remove some NSAsserts as its condition isn't a fatal error,
and it doesn't affect the production already.
Bug: None
Change-Id: I10b44a9c773d62a5c04c254986733a6b67d51617
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262840
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37283}
2022-06-21 07:02:08 +00:00
4d1ef54653
Update WebRTC code version (2022-06-21T04:05:14).
...
Bug: None
Change-Id: Id2470fe7f55f6778d8ede40be06ab2ade3611476
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266386
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37282}
2022-06-21 05:30:08 +00:00
86ebbdba50
[DVQA] Add ability to remove peer in the middle of the call.
...
Bug: b/231397778
Change-Id: I8c68cb6db9bcf28ab600e507b26203a0bb78b588
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265873
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37281}
2022-06-20 22:54:51 +00:00
76bf19314f
Roll chromium_revision 1bf77954ea..c2285d20ad (1015851:1015959)
...
Change log: 1bf77954ea..c2285d20ad
Full diff: 1bf77954ea..c2285d20ad
Changed dependencies
* src/build: 3463623f17..9b1463e569
* src/buildtools/linux64: git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52..git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006
* src/buildtools/mac: git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52..git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006
* src/buildtools/third_party/libunwind/trunk: 1644d070bf..b387062642
* src/buildtools/win: git_revision:e62d4e1938a45babc9afb6db543f388cd1802a52..git_revision:fcda46cf40422284f2e74b770da8b22f7f5d7006
* src/ios: f278005ce4..04f2483c28
* src/testing: 409f9dc815..26236c4e9a
* src/third_party: 364e22ce19..631be728ee
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b83d69ffe9..4ea19a6a70
* src/third_party/perfetto: faa478c787..b983faf1bf
* src/third_party/turbine: A5bkaoLBc1JYa6Xv31jYUCK5TnXYCbxRrA4FBPXXcWgC..RxaW8ZVJZ7rF3dbAGbL1OV6f9ZELjVeiiQbpkDsuxA4C
* src/tools: 7bb1ba7009..ed4ed4571c
DEPS diff: 1bf77954ea..c2285d20ad
/DEPS
No update to Clang.
BUG=None
Change-Id: Ia2c46988f31b49ca12335c6cebe65b3b02f914e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266381
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37280}
2022-06-20 18:28:30 +00:00
675dfb4a1f
Move receive side congestion controller periodic task to worker thread
...
This way call no longer needs dedicated process thread
Bug: webrtc:7219
Change-Id: I8ab677b1e6b909eeb726aefed5e6d10ce4bc43b7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265921
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37279}
2022-06-20 16:26:51 +00:00
c6014bcbb1
Optimize the AGC2 Biquad filter.
...
Bug: None
Change-Id: Idde77efd209be1687405d3f256ca52e2da640c1e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264561
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Christian Schuldt <cschuldt@google.com >
Cr-Commit-Position: refs/heads/main@{#37278}
2022-06-20 16:05:51 +00:00
0413fc969c
Revert "Remove FrameBuffer2Proxy"
...
This reverts commit de0d063767bbaffae7ab9b2c785bb862b387ae5c.
Reason for revert: Perf test regressions that need investigation.
Original change's description:
> Remove FrameBuffer2Proxy
>
> Bug: webrtc:14003
> Change-Id: I461a9159b33ca3693bcb59d94c2035093825588b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265866
> Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37253}
Bug: webrtc:14003
Change-Id: Ic7ef05e4021e8568eb8cfff13dc3e6753fbdec18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266340
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Auto-Submit: Evan Shrubsole <eshr@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37277}
2022-06-20 11:11:31 +00:00
dc26188d1b
Roll chromium_revision e864368211..1bf77954ea (1015724:1015851)
...
Change log: e864368211..1bf77954ea
Full diff: e864368211..1bf77954ea
Changed dependencies
* src/build: a1e0609cdd..3463623f17
* src/ios: c69f3f36ed..f278005ce4
* src/testing: c52dec1e69..409f9dc815
* src/third_party: b03fa9a0a1..364e22ce19
* src/third_party/freetype/src: f7daf9d293..47103b2f19
* src/tools: e986622653..7bb1ba7009
DEPS diff: e864368211..1bf77954ea
/DEPS
No update to Clang.
BUG=None
Change-Id: I7619e71802b40d30f092183385ab94ae517828d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266291
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37276}
2022-06-20 10:52:11 +00:00
0c1ad2992b
AudioProcessingImpl: Add a VAD submodule
...
Add a VoiceActivityDetectorWrapper submodule in AudioProcessingImpl
and enable injecting speech probability into GainController2.
Bug: webrtc:13663
Change-Id: I05e13b737d085b45ac8ce76660191867c56834c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265166
Commit-Queue: Hanna Silen <silen@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37275}
2022-06-20 10:44:41 +00:00
ff45105b42
Fix clearing of mouse cursor if display uses a scale factor
...
When a display uses a scale factor (different than 1.0) the previous
cursor position is not properly cleared during a CRD connection on
ChromeOS (see b/235191365).
The issue was that the fix for crbug.com/1323241 does not take device
scaling into account, so that fix would incorrectly not mark the
previous location of the mouse cursor as modified.
Adding proper boundary checks is hard and risky though, as the way the
position of the mouse cursor is reported seems to be platform dependent
(ChromeOS vs Linux vs ...).
So because crbug.com/1323241 only solves a theoretical crash that is rarely if
ever hit in the field, I decided to for now undo the fix for crbug.com/1323241.
A proper boundary check can then later be introduced without any pressure from
a looming release
Bug: chromium:1323241
Bug: b/235191365
Fixed: b/235191365
Test: Manually deployed
Change-Id: Ib09b6cc5e396bd52538332edfc4395ed80c6786e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265391
Reviewed-by: Alexander Cooper <alcooper@chromium.org >
Reviewed-by: Joe Downing <joedow@google.com >
Commit-Queue: Jeroen Dhollander <jeroendh@google.com >
Cr-Commit-Position: refs/heads/main@{#37274}
2022-06-20 09:51:13 +00:00
3627d57849
Revert "Move injection of PacketSocketFactory from PC to PCF"
...
This reverts commit 905c3a6c73d293882ef11942066ccda52a9e14d1.
Reason for revert: New test fails internal tests, with a similar problem as the failed android test: No networks are detected on the test bot.
Original change's description:
> Move injection of PacketSocketFactory from PC to PCF
>
> Injection via PeerConnectionDependecies was broken, in not accepting
> ownership of the injected object.
>
> Bug: webrtc:7447, webrtc:14204
> Change-Id: Ic53f05d51928b006fc1e46d502633d88471eb518
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266140
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37270}
Bug: webrtc:7447, webrtc:14204
Change-Id: Ib412d09699a48d8f5db27e2960e365b536ab3aa8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266146
Owners-Override: Niels Moller <nisse@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37273}
2022-06-20 09:50:11 +00:00
4a5a3da00a
Change VideoStreamConfig to use vector of scalability modes.
...
Each entry represents one simulcast stream.
Bug: webrtc:11607
Change-Id: If78ff334fdb99322deded57f0cbe7ebad7de5abc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265960
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37272}
2022-06-20 09:23:31 +00:00
3e60272da6
Delete channel_factory_interface.h
...
This file should have been deleted when its build target went away.
Bug: webrtc:13931
Change-Id: Ice007f771987fe085605413f89d36c6eb078a0c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266320
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37271}
2022-06-20 08:44:12 +00:00
905c3a6c73
Move injection of PacketSocketFactory from PC to PCF
...
Injection via PeerConnectionDependecies was broken, in not accepting
ownership of the injected object.
Bug: webrtc:7447, webrtc:14204
Change-Id: Ic53f05d51928b006fc1e46d502633d88471eb518
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266140
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37270}
2022-06-20 08:32:02 +00:00
03b38c18d5
Update WebRTC code version (2022-06-20T04:05:53).
...
Bug: None
Change-Id: I3989e561009e4c9bced39bb75453a2966d66d40c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266288
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37269}
2022-06-20 05:44:41 +00:00
117e692a7d
tls: add logging of expected/received hashes on failures
...
BUG=None
Change-Id: I8e9a4e69c520e1ee1edeb7f45f039f2cda400a50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265869
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37268}
2022-06-19 22:33:10 +00:00
6009ed95ec
Roll chromium_revision d34e04071c..e864368211 (1015622:1015724)
...
Change log: d34e04071c..e864368211
Full diff: d34e04071c..e864368211
Changed dependencies
* src/base: 7c4ac00b82..4f56dc6ce7
* src/build: 279085f47d..a1e0609cdd
* src/ios: 43f3d53fd1..c69f3f36ed
* src/testing: 987c9cc971..c52dec1e69
* src/third_party: 7e36c9ccd0..b03fa9a0a1
* src/third_party/freetype/src: d9b8a69e9a..f7daf9d293
* src/tools: 44a13be19e..e986622653
DEPS diff: d34e04071c..e864368211
/DEPS
No update to Clang.
BUG=None
Change-Id: I0086eba2822e7338031ca90bb4c874793ed0fd21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266242
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37267}
2022-06-19 08:26:30 +00:00
f81fd2f211
Update WebRTC code version (2022-06-19T04:03:34).
...
Bug: None
Change-Id: I9cbef50d6ff312e74f409da09f0b78adc382017a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266240
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37266}
2022-06-19 05:44:00 +00:00
130f2fd5c3
Fix missing visibility for new API targets.
...
Bug: webrtc:8733
Change-Id: I3fb1ac9a9941f7b8ad35a51be0e7b6840a2d9141
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266220
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37265}
2022-06-18 13:34:40 +00:00
2925e46bb9
Update WebRTC code version (2022-06-18T04:01:59).
...
Bug: None
Change-Id: I5f593f684aee31d06570cec59d2bd3523f3bd0e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266166
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37264}
2022-06-18 05:13:29 +00:00
73aebdb6e9
Roll chromium_revision fa5bdc9c93..d34e04071c (1015494:1015622)
...
Change log: fa5bdc9c93..d34e04071c
Full diff: fa5bdc9c93..d34e04071c
Changed dependencies
* src/build: 8550596909..279085f47d
* src/ios: 287b506403..43f3d53fd1
* src/testing: fd8546b5e2..987c9cc971
* src/third_party: 7e0f30f581..7e36c9ccd0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/483ed69769..b83d69ffe9
* src/third_party/depot_tools: 6cebde7ca2..9a3c4bc67c
* src/third_party/libyuv: 30f9b28048..e906ba9fe9
* src/tools: d98b8c4230..44a13be19e
DEPS diff: fa5bdc9c93..d34e04071c
/DEPS
No update to Clang.
BUG=None
Change-Id: Iff6bc36f6c2f7f88d5c9668637e9c141275ccb16
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266165
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37263}
2022-06-18 02:30:39 +00:00
74fca5ae3a
Roll chromium_revision fdbbdaa54a..fa5bdc9c93 (1015368:1015494)
...
Change log: fdbbdaa54a..fa5bdc9c93
Full diff: fdbbdaa54a..fa5bdc9c93
Changed dependencies
* src/base: 12c584a4d7..7c4ac00b82
* src/build: ee54c3671d..8550596909
* src/ios: 9a59f2a356..287b506403
* src/testing: f6a2ef0d95..fd8546b5e2
* src/third_party: d9b8f56e3b..7e0f30f581
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/110018c8ad..483ed69769
* src/third_party/perfetto: b9f4805cad..faa478c787
* src/tools: 30d0b3ea91..d98b8c4230
DEPS diff: fdbbdaa54a..fa5bdc9c93
/DEPS
No update to Clang.
BUG=None
Change-Id: I91e2de660d6ff0751362342c90d07d61c755c645
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266201
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37262}
2022-06-17 20:33:09 +00:00
01ed32589e
Introduce empty targets to split libjingle_peerconnection_api.
...
First step of the process to remove the last cycle in the build graph.
Bug: webrtc:8733
Change-Id: I5a0c987ce3d602d1cb30991b73b68a389f13cfba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265874
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37261}
2022-06-17 20:14:19 +00:00
f87cb81820
Roll chromium_revision af8ecb5d66..fdbbdaa54a (1015265:1015368)
...
Change log: af8ecb5d66..fdbbdaa54a
Full diff: af8ecb5d66..fdbbdaa54a
Changed dependencies
* src/base: 4c0f2a8705..12c584a4d7
* src/build: 7b855aae93..ee54c3671d
* src/ios: 6871ecf823..9a59f2a356
* src/testing: fdb2b2e62f..f6a2ef0d95
* src/third_party: 53cece9e9b..d9b8f56e3b
* src/third_party/freetype/src: 9c706dcca7..d9b8a69e9a
* src/third_party/perfetto: 678b18cbe3..b9f4805cad
* src/tools: b52372264d..30d0b3ea91
DEPS diff: af8ecb5d66..fdbbdaa54a
/DEPS
No update to Clang.
BUG=None
Change-Id: Iadc58d674374368df0390410bae638c4cdfcc3ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266200
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37260}
2022-06-17 17:04:49 +00:00
a3cb977679
in rtcp::TransportFeedback delete functions with time represented as raw int
...
Bug: webrtc:13757
Change-Id: I53c8ed21ac37a3aee13482c6bb68a0c5ee8fcbee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265681
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37259}
2022-06-17 13:03:49 +00:00
a116da5d03
test: fix usage of legacy media_type
...
since the check is done for the more modern "kind" attribute
BUG=None
Change-Id: I520b62f312348b006d8147ce7b2b483c78657b98
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266141
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37258}
2022-06-17 12:54:39 +00:00
93f9db7e8a
Wayland screensharing: implement stream restoration
...
Make use of "persist_mode" option in ScreenCast portal to restore
previously selected screen/window and avoid picking it again in yet
another xdg-desktop-portal dialog.
Bug: webrtc:13429
Change-Id: I3a0068091c2dd38003a7dff3f82b9cdb2ccd0f42
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263901
Commit-Queue: Jan Grulich <grulja@gmail.com >
Reviewed-by: Alexander Cooper <alcooper@chromium.org >
Cr-Commit-Position: refs/heads/main@{#37257}
2022-06-17 12:16:10 +00:00
ef159280b1
Add public visibility to pending_task_safety_flag
...
Bug: b/235812579
Change-Id: I9509fa04317876e0d550e473f0089093afa84a87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266145
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37256}
2022-06-17 11:54:19 +00:00
1fe14f2752
pc: invalidate stats cache when firing onicecandidate
...
https://w3c.github.io/webrtc-stats/#guidelines-for-getstats-results-caching-throttling
"When the state of the RTCPeerConnection visibly changes as a result of an API call, a promise resolving or an event firing, subsequent new getStats() calls must return up-to-date dictionaries for the affected objects."
BUG=webrtc:14190
Change-Id: I4560be22795f30e0369d573bda0100e490efb57b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265870
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#37255}
2022-06-17 11:26:18 +00:00
9f24225d43
Roll chromium_revision 9e5c3d7ac9..af8ecb5d66 (1014996:1015265)
...
Roll chromium_revision 9e5c3d7ac9..af8ecb5d66 (1014996:1015265) and
clobber win bots after libc++ issue
Change log: 9e5c3d7ac9..af8ecb5d66
Full diff: 9e5c3d7ac9..af8ecb5d66
Changed dependencies
* src/base: f52c9fe525..4c0f2a8705
* src/build: ef74652d92..7b855aae93
* src/buildtools: d909ea083b..34f9ff8fd5
* src/buildtools/third_party/libc++/trunk: 1a637088a3..b1269813ea
* src/ios: a69c4d03db..6871ecf823
* src/testing: 82d47662f3..fdb2b2e62f
* src/third_party: 67e164e2d3..53cece9e9b
* src/third_party/android_build_tools/aapt2: jziPmg_EUjoj-eSkO24eMaf5ylm449Q7BKO1-ga2tbgC..hf9C5IyJUUGaBnzqu60xiFJSyfAmjqjc_PiNXNVc9l0C
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/1e469e45a4..1f51cfc7d7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2b591cc800..110018c8ad
* src/third_party/depot_tools: 93fbd989e0..6cebde7ca2
* src/third_party/ffmpeg: abfc2628f2..b86aef09f3
* src/third_party/freetype/src: d6fc8c6ba0..9c706dcca7
* src/tools: 0296694954..b52372264d
* src/tools/luci-go: git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7..git_revision:df39938896c4603fb2a214a2430450a85d9cca81
* src/tools/luci-go: git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7..git_revision:df39938896c4603fb2a214a2430450a85d9cca81
DEPS diff: 9e5c3d7ac9..af8ecb5d66
/DEPS
No update to Clang.
BUG=b/236352196
Change-Id: Ib0481ce298c5aa53002c3c91249fea81a7ea095a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266144
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37254}
2022-06-17 11:23:29 +00:00
de0d063767
Remove FrameBuffer2Proxy
...
Bug: webrtc:14003
Change-Id: I461a9159b33ca3693bcb59d94c2035093825588b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265866
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37253}
2022-06-17 11:18:50 +00:00
8545ebae28
Add 420 and 422 10 bit h264 decoding.
...
422 10 bit format is called I210 in the code and implemented in I210Buffer, and 420 10-bit format format is using is using the already existing I010 format and implemented in I010Buffer.
Bug: webrtc:13826
Change-Id: I6b6ed65b9fbb295386ea20f751bd0badc49ef21b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256964
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37252}
2022-06-17 11:12:10 +00:00
142104183d
Disallow invokes from network thread to itself
...
https://webrtc-review.googlesource.com/c/src/+/265060 removed the last
case the network thread invokes itself, now we can use
DisallowAllInvokes on the network thread.
Bug: webrtc:12802
Change-Id: I262d65bb557e2976bab5b0d9e73756222b4e02ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266100
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37251}
2022-06-17 10:47:00 +00:00
ef9bcd17a5
Make webrtc units division by integer constexpr
...
std::round is not constexpr until c++23 and force conversion to floating point which is unnecessary for integer devision
For integer division change rounding to 'round down' from 'round to nearest' as less surprising.
Bug: webrtc:13756
Change-Id: I9c2382bafc9ddccb0f54d6e7bf8cac4f2a3175a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265863
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37250}
2022-06-17 10:34:09 +00:00
d970b0901b
measure decode time in TimeDelta instead of ms
...
increasing precision since summing up rounded values leads to
a rounding error, in particular for small frames which take very
little time to decode.
BUG=webrtc:12526,webrtc:13756
Change-Id: I647c702808856a002c746ed9f115aa9bcaddc1f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262810
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#37249}
2022-06-17 09:57:27 +00:00