zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,610 Commits 1 Branch 0 Tags
12aeeac6a51b59780379210e81033907a1f29c26
Commit Graph

10610 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
deadbeef
3f7219be70 Fixing issue where description contains empty ICE ufrag/pwd. 
The issue occurred when deserializing and then serializing a rejected
content description, which doesn't have the ICE ufrag/pwd in the first
place.

BUG=webrtc:5105

Review URL: https://codereview.webrtc.org/1534363002

Cr-Commit-Position: refs/heads/master@{#11134}
 2015-12-28 23:17:22 +00:00
Guo-wei Shieh
9faf154960 Reland 1531763006 
Enable IPv6 temporary address filtering on iOS.

We'll only use temporary address for IPv6. However, due to a bug in iOS sdk, the necessary headers are not included. This change copies the minimum necessary definitions such that we could retrieve the ip attributes.

BUG=webrtc:4343

Committed: https://crrev.com/29488c23644721c10a45eba74c67602b0262e582
Cr-Commit-Position: refs/heads/master@{#11114}

patch from issue 1531763006 at patchset 200001 (http://crrev.com/1531763006#ps200001)

TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1551703002 .

Cr-Commit-Position: refs/heads/master@{#11133}
 2015-12-28 22:07:05 +00:00
pbos
6d3f11c366 Roll gtest-parallel. 
Brings in fix that prevents disabled parameterized tests from running by
default.

BUG=webrtc:5280
TBR=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/1548373002

Cr-Commit-Position: refs/heads/master@{#11132}
 2015-12-28 21:11:09 +00:00
danilchap
f6975f4613 [rtp_rtcp] Lint errors cleaned from rtp_utility 
R=åsapersson
BUG=webrtc:5277

Review URL: https://codereview.webrtc.org/1539423003

Cr-Commit-Position: refs/heads/master@{#11131}
 2015-12-28 18:18:52 +00:00
kjellander
e0d56a7225 Roll chromium_revision a97fe0c..75c7843 (366958:366966) 
Change log: a97fe0c..75c7843
Full diff: a97fe0c..75c7843

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1544383002

Cr-Commit-Position: refs/heads/master@{#11130}
 2015-12-28 11:57:59 +00:00
kjellander
63193cefbf Roll chromium_revision a54fe37..a97fe0c (366930:366958) 
Change log: a54fe37..a97fe0c
Full diff: a54fe37..a97fe0c

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1550683004

Cr-Commit-Position: refs/heads/master@{#11129}
 2015-12-28 04:00:10 +00:00
kjellander
445e31521e Roll chromium_revision 083ad1e..a54fe37 (366925:366930) 
Change log: 083ad1e..a54fe37
Full diff: 083ad1e..a54fe37

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1547203002

Cr-Commit-Position: refs/heads/master@{#11128}
 2015-12-27 20:00:04 +00:00
kjellander
0e9f06f6d8 Roll chromium_revision e73d852..083ad1e (366918:366925) 
Change log: e73d852..083ad1e
Full diff: e73d852..083ad1e

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1545303002

Cr-Commit-Position: refs/heads/master@{#11127}
 2015-12-27 11:59:35 +00:00
kjellander
74d8a11a6a Roll chromium_revision e13537f..e73d852 (366904:366918) 
Change log: e13537f..e73d852
Full diff: e13537f..e73d852

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1549243002

Cr-Commit-Position: refs/heads/master@{#11126}
 2015-12-27 03:59:49 +00:00
kjellander
bbff0d339a Roll chromium_revision 0f24b97..e13537f (366898:366904) 
Change log: 0f24b97..e13537f
Full diff: 0f24b97..e13537f

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1550633002

Cr-Commit-Position: refs/heads/master@{#11125}
 2015-12-26 19:58:09 +00:00
kjellander
40a2f03f8c Roll chromium_revision c80b1b6..0f24b97 (366886:366898) 
Change log: c80b1b6..0f24b97
Full diff: c80b1b6..0f24b97

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1549163003

Cr-Commit-Position: refs/heads/master@{#11124}
 2015-12-26 11:57:47 +00:00
kjellander
ef776dfcf9 Roll chromium_revision 353749a..c80b1b6 (366864:366886) 
Change log: 353749a..c80b1b6
Full diff: 353749a..c80b1b6

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1550043002

Cr-Commit-Position: refs/heads/master@{#11123}
 2015-12-26 04:04:34 +00:00
kjellander
55e61593c4 Roll chromium_revision 244de00..353749a (366862:366864) 
Change log: 244de00..353749a
Full diff: 244de00..353749a

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1544253002

Cr-Commit-Position: refs/heads/master@{#11122}
 2015-12-25 20:02:26 +00:00
kjellander
848e7a1871 Roll chromium_revision 7f27756..244de00 (366849:366862) 
Change log: 7f27756..244de00
Full diff: 7f27756..244de00

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1549983002

Cr-Commit-Position: refs/heads/master@{#11121}
 2015-12-25 11:59:24 +00:00
kjellander
2c56d7fd7b Roll chromium_revision 67b3d7f..7f27756 (366832:366849) 
Change log: 67b3d7f..7f27756
Full diff: 67b3d7f..7f27756

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1549953002

Cr-Commit-Position: refs/heads/master@{#11120}
 2015-12-25 03:59:44 +00:00
kjellander
6f94a45d9f Roll chromium_revision 9beac25..67b3d7f (366816:366832) 
Change log: 9beac25..67b3d7f
Full diff: 9beac25..67b3d7f

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1547083002

Cr-Commit-Position: refs/heads/master@{#11119}
 2015-12-24 20:04:31 +00:00
kjellander
b26f18dd58 Roll chromium_revision 1417e01..9beac25 (366759:366816) 
Change log: 1417e01..9beac25
Full diff: 1417e01..9beac25

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1543363002

Cr-Commit-Position: refs/heads/master@{#11118}
 2015-12-24 12:03:27 +00:00
kjellander
f01f8c9fb5 Roll chromium_revision 2b7b555..1417e01 (366738:366759) 
Change log: 2b7b555..1417e01
Full diff: 2b7b555..1417e01

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1545003002

Cr-Commit-Position: refs/heads/master@{#11117}
 2015-12-23 20:00:55 +00:00
kjellander
c12f7f45b5 Roll chromium_revision 8a1fcdb..2b7b555 (366529:366738) 
Change log: 8a1fcdb..2b7b555
Full diff: 8a1fcdb..2b7b555

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1543903003

Cr-Commit-Position: refs/heads/master@{#11116}
 2015-12-23 12:01:03 +00:00
Guo-wei Shieh
a6c86b23fe Revert "Enable IPv6 temporary address filtering on iOS." 
This reverts commit 29488c23644721c10a45eba74c67602b0262e582.

This broke chromium.fyi bot.

TBR=pthatcher@webrtc.org
BUG=

Review URL: https://codereview.webrtc.org/1547883002 .

Cr-Commit-Position: refs/heads/master@{#11115}
 2015-12-23 04:17:37 +00:00
guoweis
29488c2364 Enable IPv6 temporary address filtering on iOS. 
We'll only use temporary address for IPv6. However, due to a bug in iOS sdk, the necessary headers are not included. This change copies the minimum necessary definitions such that we could retrieve the ip attributes.

BUG=webrtc:4343

Review URL: https://codereview.webrtc.org/1531763006

Cr-Commit-Position: refs/heads/master@{#11114}
 2015-12-23 00:46:48 +00:00
minyue
93c08b7438 Adding bit exactness test for Opus decoding in NetEq. 
Opus has become the mostly used codec in WebRTC. There, however, is no bit exactness test for Opus decoding in NetEq.

The new RTP file is generated by the following steps:
    1. Encode a clean RTP file with Opus
RTPencode resources/audio_coding/speech_mono_32_48kHz.pcm neteq_opus_raw.rtp 960 opus 1

    2. Adding jitter to the clean RTP file
RTPjitter neteq_opus_raw.rtp jitter.dat neteq_opus.rtp
(Note: jitter.dat does not exist in WebRTC resources folder. Check the source code for RTPjitter to know how to define such a file.)

BUG=webrtc:3987
TEST=observed Opus normal decoding and FEC decoding were used, listened to the reference output.

Review URL: https://codereview.webrtc.org/1515113002

Cr-Commit-Position: refs/heads/master@{#11113}
 2015-12-22 17:57:47 +00:00
danilchap
a72e7349d5 [rtp_rtcp] cleanup in RTCPSender class internals. 
PrepareReportBlock and AddReportBlock private functions merged:
  PrepareReportBlock moved report block from statistic to temporary structure
  AddReportBlock copied that temporary structure into temporary map right after.
  Thanks to rtcp packet classes that temporary structure is now unneccesary.

BUG=webrtc:5260
R=åsapersson

Review URL: https://codereview.webrtc.org/1538833002

Cr-Commit-Position: refs/heads/master@{#11112}
 2015-12-22 16:07:48 +00:00
danilchap
a8890a57a5 rtcp::Nack packet moved into own file and got Parse function 
Review URL: https://codereview.webrtc.org/1461623003

Cr-Commit-Position: refs/heads/master@{#11111}
 2015-12-22 11:43:10 +00:00
kjellander
53c317c4b9 Roll chromium_revision 4688e75..8a1fcdb (366364:366529) 
Change log: 4688e75..8a1fcdb
Full diff: 4688e75..8a1fcdb

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1543753003

Cr-Commit-Position: refs/heads/master@{#11110}
 2015-12-22 04:00:10 +00:00
honghaiz
cfb7f01fd6 Disable VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly 
due to flakiness on LinuxAsan.

BUG=webrtc:5382
TBR=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/1541923003

Cr-Commit-Position: refs/heads/master@{#11109}
 2015-12-21 21:35:00 +00:00
nisse
e6bf587259 Deleted VideoCapturer::screencast_max_pixels, together with 
VideoChannel::GetScreencastMaxPixels and VideoChannel::GetScreencastFps.

Unused in webrtc, also unused in everything indexed by google and chromium code search. With the exception of the magicflute plugin, which I'm told doesn't matter.

Review URL: https://codereview.webrtc.org/1532133002

Cr-Commit-Position: refs/heads/master@{#11108}
 2015-12-21 21:18:18 +00:00
honghaiz
db8cf50c59 Fix two problems in network.cc: 
1. It signals network changed events whenever there are more than one IP address in a network.
2. It does not signal network changed events if a network disconnects and connects again.
Also changed DumpNetworks for better debugging.

BUG=webrtc:5096

Review URL: https://codereview.webrtc.org/1421433003

Cr-Commit-Position: refs/heads/master@{#11107}
 2015-12-21 21:08:54 +00:00
danilchap
1227e8b345 [rtp_rtcp] time helper functions 
RTP timestams helper functions moved from rtp_utility
  added functions to deal with CompactNtp timestamps

R=åsapersson
BUG=webrtc:5260

Review URL: https://codereview.webrtc.org/1535113002

Cr-Commit-Position: refs/heads/master@{#11106}
 2015-12-21 19:06:56 +00:00
philipel
5908c71128 Lint fix for webrtc/modules/video_coding PART 3! 
Trying to submit all changes at once proved impossible since there were
too many changes in too many files. The changes to PRESUBMIT.py
will be uploaded in the last CL.
(original CL: https://codereview.webrtc.org/1528503003/)

BUG=webrtc:5309
TBR=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1540243002

Cr-Commit-Position: refs/heads/master@{#11105}
 2015-12-21 16:23:29 +00:00
kjellander
f5b1abf5b0 Roll chromium_revision c844be9..4688e75 (366322:366364) 
Change log: c844be9..4688e75
Full diff: c844be9..4688e75

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1533303002

Cr-Commit-Position: refs/heads/master@{#11104}
 2015-12-21 14:51:27 +00:00
Peter Boström
de94c132e0 Add webrtc/audio and webrtc/call to WATCHLISTS. 
Also adds current OWNERS to the corresponding watchlists.

BUG=
R=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1533093002 .

Cr-Commit-Position: refs/heads/master@{#11103}
 2015-12-21 13:30:01 +00:00
philipel
9d3ab61325 Lint fix for webrtc/modules/video_coding PART 2! 
Trying to submit all changes at once proved impossible since there were
too many changes in too many files. The changes to PRESUBMIT.py
will be uploaded in the last CL.
(original CL: https://codereview.webrtc.org/1528503003/)

BUG=webrtc:5309
TBR=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1543503002

Cr-Commit-Position: refs/heads/master@{#11102}
 2015-12-21 12:12:45 +00:00
stefan
ff483617a4 Step 1 to prepare call_test.* for combined audio/video tests. 
Also move (and clean up includes) rampup_tests.* to webrtc/call in preparation for combined audio/video ramp-up tests.

No functional changes.

BUG=webrtc:5263

Review URL: https://codereview.webrtc.org/1537273003

Cr-Commit-Position: refs/heads/master@{#11101}
 2015-12-21 11:14:05 +00:00
philipel
cce46fc108 Lint fix for webrtc/modules/video_coding PART 1! 
Trying to submit all changes at once proved impossible since there were
too many changes in too many files. The changes to PRESUBMIT.py
will be uploaded in the last CL.
(original CL: https://codereview.webrtc.org/1528503003/)

BUG=webrtc:5309
TBR=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1541803002

Cr-Commit-Position: refs/heads/master@{#11100}
 2015-12-21 11:04:57 +00:00
asapersson
53805324c0 Rename RTC_HISTOGRAM_* macros to RTC_HISTOGRAM_*_SPARSE_* to indicate that these are for infrequent updates. 
This implementation will be replaced by a faster one and sparse will be removed.

BUG=webrtc:5283

Review URL: https://codereview.webrtc.org/1530913002

Cr-Commit-Position: refs/heads/master@{#11099}
 2015-12-21 09:46:25 +00:00
peah
9fca7e18c3 A unittest that reports the statistics for the duration of an APM stream processing API call. 
BUG=webrtc:5099

Committed: https://crrev.com/880896ab0976bbf86a6753d0c900c70e51f421cb
Cr-Commit-Position: refs/heads/master@{#10786}

Review URL: https://codereview.webrtc.org/1436553004

Cr-Commit-Position: refs/heads/master@{#11098}
 2015-12-21 07:13:46 +00:00
kjellander
c693820f7f CQ: Add linux_libfuzzer_rel trybot as default. 
NOTRY=True
BUG=chromium:570439
TBR=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1540773002

Cr-Commit-Position: refs/heads/master@{#11097}
 2015-12-21 06:15:17 +00:00
kjellander
54bab12e1f Roll chromium_revision db567a8..c844be9 (366304:366322) 
Change log: db567a8..c844be9
Full diff: db567a8..c844be9

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1540813002

Cr-Commit-Position: refs/heads/master@{#11096}
 2015-12-21 03:59:08 +00:00
kjellander
2f042f26a3 Roll chromium_revision 1b6c421..db567a8 (365999:366304) 
I had to disable some Dtls12Both tests failing under MSan (see bug).
Notice those errors started happening in the range of
https://boringssl.googlesource.com/boringssl.git/+log/afd565f..9f897b2
while this CL brings in an even newer BoringSSL (that still has the same problem).

Change log: 1b6c421..db567a8
Full diff: 1b6c421..db567a8

Changed dependencies:
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/afd565f..afe57cb
* src/third_party/libyuv: 1019e45..1ccbf8f
* src/third_party/nss: a676aa0..aee1b12
DEPS diff: 1b6c421..db567a8/DEPS

No update to Clang.

NOTRY=True
BUG=webrtc:5381
TBR=torbjorng@webrtc.org, pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1533253002

Cr-Commit-Position: refs/heads/master@{#11095}
 2015-12-20 20:25:17 +00:00
ivoc
a4df27b671 Revert of Reland "Added option to specify a maximum file size when recording an AEC dump." (patchset #2 id:20001 of https://codereview.webrtc.org/1541633002/ ) 
Reason for revert:
Compile error on Android needs to be fixed before relanding.

Original issue's description:
> Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12afc8cc29fe9c59dea432b697b871a87.
>
> The revert of the original CL was commit 36d4c545007129446e551c45c17b25377dce89a4.
> Original review: https://codereview.webrtc.org/1413483003/
>
> The original CL changes a function on audio_processing.h that is used by Chrome, this CL adds back the old function.
>
> NOTRY=true
> TBR=glaznev@webrtc.org, henrik.lundin@webrtc.org, solenberg@google.com, henrikg@webrtc.org, perkj@webrtc.org
> BUG=webrtc:4741
>
> Committed: https://crrev.com/f4f5cb09277d5ef6aeac8341e5f54a055867803a
> Cr-Commit-Position: refs/heads/master@{#11093}

TBR=glaznev@webrtc.org,henrik.lundin@webrtc.org,solenberg@google.com,henrikg@webrtc.org,perkj@webrtc.org,kwiberg@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4741

Review URL: https://codereview.webrtc.org/1537213002

Cr-Commit-Position: refs/heads/master@{#11094}
 2015-12-19 18:14:18 +00:00
ivoc
f4f5cb0927 Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12afc8cc29fe9c59dea432b697b871a87. 
The revert of the original CL was commit 36d4c545007129446e551c45c17b25377dce89a4.
Original review: https://codereview.webrtc.org/1413483003/

The original CL changes a function on audio_processing.h that is used by Chrome, this CL adds back the old function.

NOTRY=true
TBR=glaznev@webrtc.org, henrik.lundin@webrtc.org, solenberg@google.com, henrikg@webrtc.org, perkj@webrtc.org
BUG=webrtc:4741

Review URL: https://codereview.webrtc.org/1541633002

Cr-Commit-Position: refs/heads/master@{#11093}
 2015-12-19 18:02:39 +00:00
deadbeef
bd7d8f7e2b Adding a MediaStream parameter to createSender. 
This will allow an app to create senders with the same stream id,
without SDP munging.

Review URL: https://codereview.webrtc.org/1538673002

Cr-Commit-Position: refs/heads/master@{#11092}
 2015-12-19 00:58:51 +00:00
minyue
92594a30ce Moving FFT on farend signal to where it is used in AEC (bit exact). 
Currently, FFT is performance when AEC buffers farend signal. This has some drawbacks
1. memory inefficiency: two ring buffers are needed;
2. computation inefficiency: if ringbuffer gets wrapped around, some FFT computation will be wasted;
3. accessibility: the main AEC function looses accessibility to the time-domain signal.

Therefore, this CL tries to buffer time domain data, which is buffered any way if a debugging macro is defined, and calculate the FFTs where they are actually used.

BUG=

Review URL: https://codereview.webrtc.org/1512573003

Cr-Commit-Position: refs/heads/master@{#11091}
 2015-12-18 23:31:19 +00:00
kjellander
4ff818e614 Make download_from_google_storage print less during runhooks. 
Add the --quiet flag to the download_from_google_storage runhooks
step to prevent it from spamming the console when all the files
are already downloaded.

NOTRY=True

Review URL: https://codereview.webrtc.org/1527713003

Cr-Commit-Position: refs/heads/master@{#11090}
 2015-12-18 20:29:33 +00:00
kjellander
740c367af3 iSAC: Remove unnecessary WEBRTC_LINUX define. 
I can only find one use in iSAC codebase:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc/modules/audio_coding/test/iSACTest.cc&l=19

It's the prime suspect for causing a compilation error for iOS failing to
include linux/net.h which is being included in
webrtc/voice_engine/voice_engine_defines.h

NOTRY=True

Review URL: https://codereview.webrtc.org/1539883002

Cr-Commit-Position: refs/heads/master@{#11089}
 2015-12-18 20:28:28 +00:00
tfarina
c155b16b22 remove deprecated StringToIP() methods from SocketAddress API 
This patch removes StringToIP() methods as fixes the TODO there and
there are no callers at the moment for these methods.

BUG=None
R=perkj@webrtc.org

Review URL: https://codereview.webrtc.org/1535993002

Cr-Commit-Position: refs/heads/master@{#11088}
 2015-12-18 16:13:16 +00:00
ivoc
36d4c54500 Revert of Added option to specify a maximum file size when recording an AEC dump. (patchset #5 id:120001 of https://codereview.webrtc.org/1413483003/ ) 
Reason for revert:
Breaks Chrome-FYI bots because of a change in the StartDebugRecording function in audio_processing.h, that is called from Chrome.

Original issue's description:
> Added option to specify a maximum file size when recording an AEC dump.
>
> For applications with a strict filesize limit for debug files,
> I added an option to specify a maximum filesize for AEC dumps. An
> existing unit test is extended to check that the feature works as
> advertised.
>
> BUG=webrtc:4741
> TBR=glaznev@webrtc.org
>
> Committed: https://crrev.com/ae2c5ad12afc8cc29fe9c59dea432b697b871a87
> Cr-Commit-Position: refs/heads/master@{#11081}

TBR=pthatcher@webrtc.org,henrik.lundin@webrtc.org,henrikg@webrtc.org,solenberg@webrtc.org,andrew@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org,glaznev@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4741

Review URL: https://codereview.webrtc.org/1533913004

Cr-Commit-Position: refs/heads/master@{#11087}
 2015-12-18 16:05:21 +00:00
Peter Boström
455a252453 Fix pointer compare-and-swap on Windows. 
Incorrect argument order, also added unittest which should've been there
in the first place.

Also renames AtomicLoadPtr to AcquireLoadPtr to match non-ptr version.

BUG=
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1537923003 .

Cr-Commit-Position: refs/heads/master@{#11086}
 2015-12-18 16:00:35 +00:00
tfarina
c1cd566cc6 delete basictypes.h header 
We have updated the uses of ARRAY_SIZE to arraysize in past patches:

5237aaf243
fa5d0dbd1e

BUG=None
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1537943002

Cr-Commit-Position: refs/heads/master@{#11085}
 2015-12-18 15:33:09 +00:00