2558c4e938
Remove ortc folder.
...
Since it is currently unused and not actively maintained, code under
ortc/ will be deleted by this CL.
Bug: webrtc:9824
Change-Id: I20f890b1a1e5e1dbd2b3949af916ae0a6bc8a032
Reviewed-on: https://webrtc-review.googlesource.com/c/102601
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25082}
2018-10-10 09:06:57 +00:00
88b68ace17
Create field trial for setting a minimum value for Opus encoder packet loss rate
...
Bug: webrtc:9848
Change-Id: I0663ee3af7729a220de7aff08cd74545e1a7409a
Reviewed-on: https://webrtc-review.googlesource.com/c/104800
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25081}
2018-10-10 08:52:56 +00:00
f08dd9db34
Disable flaky tests on mac perf bot
...
Bug: webrtc:9840
Change-Id: Ie95fdb7bc698604a85ad56242ba092c36a99002e
Reviewed-on: https://webrtc-review.googlesource.com/c/104801
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25080}
2018-10-10 08:40:04 +00:00
1bca65bdc9
Makes RtpSender indicate allocation and feedback status on packets.
...
Streams that are part of transport feedback are assumed to be part of
allocation. A SetAsPartOfAllocation method is introduced to be used by
media streams that are part of bitrate allocation but not included in
feedback.
This is part of a series of CLs that allows GoogCC to track sent bitrate
that is included in bitrate allocation but without transport feedback.
Bug: webrtc:9796
Change-Id: If7ac1ad3e6f3c28b2ada2aef1607a42689d899b2
Reviewed-on: https://webrtc-review.googlesource.com/c/104881
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25079}
2018-10-10 08:28:34 +00:00
81125f0aba
Implement (mostly) standards-compliant RTCIceTransportState.
...
In order to correctly implement RTCPeerConnectionState and RTCIceConnectionState the ice transports need to support RTCIceTransportState.
This CL adds an implementation parallel to the current non-standard IceTransportState. It's not currently used anywhere. The old implementation will remain in place until we're ready to switch RTCIceConnectionState over.
Bug: webrtc:9308
Change-Id: I30e2bbb5b4fafa410261bcd9d5e3b76c03435feb
Reviewed-on: https://webrtc-review.googlesource.com/c/103220
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25078}
2018-10-10 08:10:16 +00:00
5f35e961a0
Roll chromium_revision 476ae6d661..8a25f94ac2 (598136:598237)
...
Change log: 476ae6d661..8a25f94ac2
Full diff: 476ae6d661..8a25f94ac2
Changed dependencies
* src/build: cb53e61091..a5cd715c0d
* src/ios: b2d5467de7..90ab17ff89
* src/testing: 7dda069719..16faa10246
* src/third_party: 247b563466..a7b8fc61e7
* src/third_party/depot_tools: dce747620a..83bd7f4cd5
* src/tools: bd88e77f92..aace7db64d
DEPS diff: 476ae6d661..8a25f94ac2
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I07efe9500f84152287e5ef1489c59f1c5782b10d
Reviewed-on: https://webrtc-review.googlesource.com/c/104974
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#25077}
2018-10-10 07:34:32 +00:00
c87b8c194a
Moves GoogCC factory to API.
...
Bug: None
Change-Id: Ib5be0e984eff3a652504106552b0779be2c316ca
Reviewed-on: https://webrtc-review.googlesource.com/c/104941
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25076}
2018-10-10 06:11:36 +00:00
0d8c100e81
AEC3: Decrease the suppression during the echo-only case
...
This CL changes the tuning of the echo suppressor for the case when
there is echo only. The resulting effect is a slight increase of
transparency
Bug: webrtc:9844,chromium:893744
Change-Id: I5e6a867e0d03dc3a468a8f5cfa64103e001baae1
Reviewed-on: https://webrtc-review.googlesource.com/c/104760
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25075}
2018-10-10 05:18:54 +00:00
463c76451f
Roll chromium_revision cfe6e706d0..476ae6d661 (598018:598136)
...
Change log: cfe6e706d0..476ae6d661
Full diff: cfe6e706d0..476ae6d661
Changed dependencies
* src/base: f78e488b05..504683e395
* src/build: 802d6bb4cf..cb53e61091
* src/ios: 485076122a..b2d5467de7
* src/testing: af663e2fc9..7dda069719
* src/third_party: cf4b3be116..247b563466
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/30b1adb1ae..357c5c287b
* src/third_party/depot_tools: 71e3be7a50..dce747620a
* src/tools: 7a07cc4681..bd88e77f92
DEPS diff: cfe6e706d0..476ae6d661
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I22e0b68b375d9ae2b041cc156a35a80c54966322
Reviewed-on: https://webrtc-review.googlesource.com/c/104967
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#25074}
2018-10-10 00:48:14 +00:00
aabf204e6a
Remove container typedefs from RelayServer
...
Bug: webrtc:9732
Change-Id: I3845bef54e15cbb3f173f8a67a1b8cdba7ff7e31
Reviewed-on: https://webrtc-review.googlesource.com/c/104300
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25073}
2018-10-10 00:31:54 +00:00
11358fe9b9
Use unique_ptr in port_unittest
...
Bug: webrtc:9198
Change-Id: I8a86aff5aeccd411a6a31d0730a8662f1b7dc63c
Reviewed-on: https://webrtc-review.googlesource.com/c/104240
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25072}
2018-10-09 23:14:51 +00:00
13d392d0e8
AEC3: Utilize dominant nearend functionality to increase transparency
...
This CL utilizes the AEC3 ability to tailor the suppressor during
situations when the nearend dominates over the residual echo. This is
done by increasing the thresholds for transparent echo suppressor
behavior when the nearend is strong compared to the residual echo.
Bug: webrtc:9836, chromium:893744
Change-Id: Ic06569eefc7f2557b401db43b3ac84b299071294
Reviewed-on: https://webrtc-review.googlesource.com/c/104460
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25071}
2018-10-09 22:06:00 +00:00
3a3f0274ed
Roll chromium_revision 0cf8926390..cfe6e706d0 (597915:598018)
...
Change log: 0cf8926390..cfe6e706d0
Full diff: 0cf8926390..cfe6e706d0
Changed dependencies
* src/base: d56f13c86d..f78e488b05
* src/build: a7674eacc3..802d6bb4cf
* src/ios: 2aca6c09be..485076122a
* src/testing: 057800f0ac..af663e2fc9
* src/third_party: 677673b4c0..cf4b3be116
* src/third_party/icu: c52a2a250d..ccad447212
* src/tools: a71e9b5e0f..7a07cc4681
DEPS diff: 0cf8926390..cfe6e706d0
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia6d17fbbf07b8b5d1e23899e8ee2524238539539
Reviewed-on: https://webrtc-review.googlesource.com/c/104962
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#25070}
2018-10-09 19:34:01 +00:00
0378997db3
Adds flags indicating presence in allocation and feedback per packet.
...
This CL adds flags to the PacketOptions and PacktInfo struct that are
intended to be used to indicate if the packet belongs to a media stream
that is part of bitrate allocation as well as if it is included in
transport wide packet feedback.
This is part of a series of CLs that allows GoogCC to track sent bitrate
that is included in bitrate allocation but without transport feedback.
Bug: webrtc:9796
Change-Id: Icdf3e1e13d3f119574ee1b2c574f2d3329a7e303
Reviewed-on: https://webrtc-review.googlesource.com/c/104920
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25069}
2018-10-09 18:24:38 +00:00
30e2d6ee00
Moves locking outside function in RtpSender.
...
This CL moves the action of acquiring the lock outside
UpdateTransportSequenceNumber. This prepares for an upcoming CL where
the lock is used outside this call at the call sites and avoids the lock-unlock
overhead that would otherwise occur.
Also removing the const declaration as it modifies the state of
transport_sequence_number_allocator_.
Bug: webrtc:9796
Change-Id: I0bd4a0fd2fdbf6291867eb913690c61269eab8c5
Reviewed-on: https://webrtc-review.googlesource.com/c/102684
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25068}
2018-10-09 18:04:58 +00:00
789f459a06
Adds fields for unacknowledged data to transport feedback.
...
This CL adds fields to packet feedback structs to indicate the amount of
data that was sent prior to the represented packet without being part
packet feedback, but part of bitrate allocation.
This is part of a series of CLs that allows GoogCC to track sent bitrate
that is included in bitrate allocation but without transport feedback.
Bug: webrtc:9796
Change-Id: I716a5325e2b7022ba6b3f90653542caafb056793
Reviewed-on: https://webrtc-review.googlesource.com/c/104921
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25067}
2018-10-09 18:03:04 +00:00
20a49f3357
Don't try to use CN if voice codec isn't mono
...
Bug: chromium:878066
Change-Id: Iac6da4780a6da4fcfe2693d5cf826249a99f84c4
Reviewed-on: https://webrtc-review.googlesource.com/c/104601
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25066}
2018-10-09 16:09:50 +00:00
5fcc4de109
Roll chromium_revision f362b3e857..0cf8926390 (597811:597915)
...
Change log: f362b3e857..0cf8926390
Full diff: f362b3e857..0cf8926390
Changed dependencies
* src/ios: 615029c594..2aca6c09be
* src/testing: 59a5ad51de..057800f0ac
* src/third_party: 83b39c76d3..677673b4c0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9ec8468cfd..30b1adb1ae
* src/tools: bca1ce075f..a71e9b5e0f
DEPS diff: f362b3e857..0cf8926390
/DEPS
Clang version changed 343342:343880
Details: f362b3e857..0cf8926390
/tools/clang/scripts/update.py
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia9350901f9f59e16f74fd13171046934ecc96c80
Reviewed-on: https://webrtc-review.googlesource.com/c/104861
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#25065}
2018-10-09 15:44:35 +00:00
759f959984
Refactor tests with ConfigurableFrameSizeEncoder
...
Avoid using post_encode_callback, instead add a new callback function
to ConfigurableFrameSizeEncoder. Intention is to delete
post_encode_callback and the EncodedFrameObserver class in a later cl.
Bug: None
Change-Id: I79c103adf11c8915878b3f7cacf24c9b02dd6373
Reviewed-on: https://webrtc-review.googlesource.com/c/104840
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25064}
2018-10-09 15:15:34 +00:00
040f87f934
AEC3: Allow a more stable filter during double-talk
...
This is a new attempt to reduce the filter divergence
during double-talk without regressing in clock-drift
scenarios.
- The error_floor in decreased to allow for slow adaptation
when the filter performs well.
- The leakage_diverged is increased to allow for fast adaptation
when the shadow filter performs better.
- A new parameter, error_ceil, was added to stop the filter from
adapting too fast.
Bug: webrtc:9746,chromium:883264
Change-Id: Ie2868d2388b48412a192a004ec13f9eff34517b8
Reviewed-on: https://webrtc-review.googlesource.com/c/100460
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25063}
2018-10-09 14:09:26 +00:00
7730193a49
Remove SetExecutablePath, simplify ResourcePath
...
SetExecutablePath isn't used anymore.
Nobody was using the fancy select-per-platform functionality, and the
documentation was wrong anyway. In the cases somebody needed an
override per platform, they were using defines in their own test
instead. I think that is more verbose but more predictable and easy
to understand (see how it's done in audio_processing_unittest.cc
when loading output_data_mac, for instance).
Bug: webrtc:9792
Change-Id: I7289bf5883fe43852638922d7c7583eae0c08601
Reviewed-on: https://webrtc-review.googlesource.com/c/104482
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25062}
2018-10-09 14:01:16 +00:00
70045719ab
AEC3: Decrease the modelling of the reverb
...
This CL lowers the default reverb decay to better match the standard
rooms where calls are made.
Bug: webrtc:9843
Change-Id: I46f1a629ecfdd72561829326d4fa58ede8107b6c
Reviewed-on: https://webrtc-review.googlesource.com/c/104740
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25061}
2018-10-09 12:46:43 +00:00
d76a0fc5e9
Throttle the RTP decryption error messages in the SrtpSession and SrtpTransport
...
In order to avoid excessive logging when a large percentage of received packets are bad (e.g. when the same packets get sent several times).
Bug: webrtc:9839
Change-Id: I2daed89b170adf7252624bf0da9af5a980bacc17
Reviewed-on: https://webrtc-review.googlesource.com/c/104624
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Varga <erikvarga@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25060}
2018-10-09 12:10:55 +00:00
b674cd1038
Enable multithreading in libvpx VP9 decoder.
...
Set number of decode threads equal to number of available cores and
limit the maximum value to the maximum number of tiles possible for
HD resolution.
Bug: webrtc:9829, b/117291409
Change-Id: Ib5ccd5cc412011d4438258491efc060cdd050fc7
Reviewed-on: https://webrtc-review.googlesource.com/c/104064
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25059}
2018-10-09 11:48:37 +00:00
d0bc462556
Check if __IPHONE_OS_VERSION_MAX_ALLOWED is defined before reference
...
Unsafe reference is no longer sufficient with newer versions of XCode. See
https://bugs.chromium.org/p/webrtc/issues/detail?id=9457#c23
Bug: webrtc:9457
Change-Id: I58ca4456c0abd450b8c42fa87ba4129c772d370d
Reviewed-on: https://webrtc-review.googlesource.com/c/104700
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25058}
2018-10-09 08:13:02 +00:00
0414040724
Fix race condition for SupportsFlexfecWithMultithreadedH264/0 test.
...
Guard FakeEncode.last_frame_info_ against concurrent access.
Bug: webrtc:9833
Change-Id: Idf36cee15307a64cd79d85f0f65914b516fc6590
Reviewed-on: https://webrtc-review.googlesource.com/c/104500
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Yves Gerey <yvesg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25057}
2018-10-09 07:29:08 +00:00
bf47198225
Roll chromium_revision ba2e073e2c..f362b3e857 (597606:597811)
...
Change log: ba2e073e2c..f362b3e857
Full diff: ba2e073e2c..f362b3e857
Changed dependencies
* src/base: 2fb7110f70..d56f13c86d
* src/build: 903c1aad36..a7674eacc3
* src/ios: 16b982bffb..615029c594
* src/testing: b8fc89b06c..59a5ad51de
* src/third_party: b0604265cf..83b39c76d3
* src/third_party/libvpx/source/libvpx: 2beb5c9f91..ecc31d2878
* src/tools: fa79467ee4..bca1ce075f
DEPS diff: ba2e073e2c..f362b3e857
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org ,
BUG=None
Change-Id: I7cfc30ebaf32ba3cebd69fff8251594e8596ba2b
Reviewed-on: https://webrtc-review.googlesource.com/c/104780
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#25056}
2018-10-09 06:44:12 +00:00
4ff72140e6
Using TaskQueue for congestion controller by default.
...
This changed the field trial so the TaskQueue based congestion
controller is opt-out rather than opt-in. This prepares for removing
the legacy version of SendSideCongestionController.
Bug: webrtc:9586
Change-Id: I2cd1ca9d3f9b6e3797c856b180790c191653b0ef
Reviewed-on: https://webrtc-review.googlesource.com/c/104521
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25055}
2018-10-09 05:58:01 +00:00
4b14416c29
Roll chromium_revision 0cdd2e3eab..ba2e073e2c (597498:597606)
...
Change log: 0cdd2e3eab..ba2e073e2c
Full diff: 0cdd2e3eab..ba2e073e2c
Changed dependencies
* src/base: 226b8bac1f..2fb7110f70
* src/build: 63f397a2df..903c1aad36
* src/ios: 02ce4e5b29..16b982bffb
* src/testing: a8da99ff4c..b8fc89b06c
* src/third_party: 503cf2d8b5..b0604265cf
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4fc4281d21..9ec8468cfd
* src/tools: 8cfdea14be..fa79467ee4
DEPS diff: 0cdd2e3eab..ba2e073e2c
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic7e039b563d1489105d696e8d650020e2a169d9e
Reviewed-on: https://webrtc-review.googlesource.com/c/104682
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#25054}
2018-10-08 18:34:58 +00:00
e0c2e97474
Pass MediaTransportFactory to PeerConnectionFactory.
...
And use RTCConfiguration to enable/disable it on a per connection basis.
With the advent of MediaTransportInterface, we need to be able to enable
it on the per PeerConnection basis.
At this point PeerConnection will not take any action when the
MediaTransportInterface is set; this code will land a bit later, and
will be accompanied by the tests that verify correct setup (hence no tests right now).
At this point this is just a method stub to enable further development.
Bug: webrtc:9719
Change-Id: I1f77d650cb03bf1191aa0b35669cd32f1b68446f
Reviewed-on: https://webrtc-review.googlesource.com/c/103860
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Reviewed-by: Anton Sukhanov <sukhanov@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25053}
2018-10-08 18:11:06 +00:00
1e05486914
Added the new generic descriptor extension to WebRtcVideoEngine::GetCapabilities.
...
The extension was added behind the WebRTC-GenericDescriptorAdvertised field trial.
Bug: webrtc:9361
Change-Id: I84c2d54405e38fae6361dc326ad72495733584a6
Reviewed-on: https://webrtc-review.googlesource.com/c/104622
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25052}
2018-10-08 18:07:54 +00:00
ab09039d2a
Add comment that xcode version needs to be updated in two places
...
Bug: None
Change-Id: I6876c06079a06241fe8756941f1822d99c15fdcc
Reviewed-on: https://webrtc-review.googlesource.com/c/104483
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25051}
2018-10-08 13:42:33 +00:00
16fe3f290a
Revert "Export symbols needed by the Chromium component build (part 1)."
...
This reverts commit 99eea42fc1fe0be0ebed13c5eba7e1e42059bc5a.
Reason for revert:
lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::UnwrapTurnPacket(unsigned char const *, unsigned int, unsigned int *, unsigned int *)" (__imp_?UnwrapTurnPacket@cricket@@YA_NPBEIPAI1@Z)
>>> referenced by obj/services/network/network_service/socket_manager.obj:("virtual void __thiscall network::P2PSocketManager::DumpPacket(class base::span<unsigned char const, 4294967295>, bool)" (?DumpPacket@P2PSocketManager@network@@EAEXV?$span@$$CBE$0PPPPPPPP@@base@@_N@Z))
lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ValidateRtpHeader(unsigned char const *, unsigned int, unsigned int *)" (__imp_?ValidateRtpHeader@cricket@@YA_NPBEIPAI@Z)
>>> referenced by obj/services/network/network_service/socket_manager.obj:("virtual void __thiscall network::P2PSocketManager::DumpPacket(class base::span<unsigned char const, 4294967295>, bool)" (?DumpPacket@P2PSocketManager@network@@EAEXV?$span@$$CBE$0PPPPPPPP@@base@@_N@Z))
lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ApplyPacketOptions(unsigned char *, unsigned int, struct rtc::PacketTimeUpdateParams const &, unsigned __int64)" (__imp_?ApplyPacketOptions@cricket@@YA_NPAEIABUPacketTimeUpdateParams@rtc@@_K@Z)
>>> referenced by obj/services/network/network_service/socket_tcp.obj:("virtual void __thiscall network::P2PSocketTcp::DoSend(class net::IPEndPoint const &, class std::vector<signed char, class std::allocator<signed char>> const &, struct rtc::PacketOptions const &, struct net::NetworkTrafficAnnotationTag)" (?DoSend@P2PSocketTcp@network@@MAEXABVIPEndPoint@net@@ABV?$vector@CV?$allocator@C@std@@@std@@ABUPacketOptions@rtc@@UNetworkTrafficAnnotationTag@4@@Z))
>>> referenced by obj/services/network/network_service/socket_tcp.obj:("virtual void __thiscall network::P2PSocketStunTcp::DoSend(class net::IPEndPoint const &, class std::vector<signed char, class std::allocator<signed char>> const &, struct rtc::PacketOptions const &, struct net::NetworkTrafficAnnotationTag)" (?DoSend@P2PSocketStunTcp@network@@MAEXABVIPEndPoint@net@@ABV?$vector@CV?$allocator@C@std@@@std@@ABUPacketOptions@rtc@@UNetworkTrafficAnnotationTag@4@@Z))
lld-link: error: undefined symbol: "__declspec(dllimport) bool __cdecl cricket::ApplyPacketOptions(unsigned char *, unsigned int, struct rtc::PacketTimeUpdateParams const &, unsigned __int64)" (__imp_?ApplyPacketOptions@cricket@@YA_NPAEIABUPacketTimeUpdateParams@rtc@@_K@Z)
>>> referenced by obj/services/network/network_service/socket_udp.obj:("bool __thiscall network::P2PSocketUdp::DoSend(struct network::P2PSocketUdp::PendingPacket const &)" (?DoSend@P2PSocketUdp@network@@AAE_NABUPendingPacket@12@@Z))
Original change's description:
> Reland "Reland "Export symbols needed by the Chromium component build (part 1).""
>
> This reverts commit b49520bfc08f5c5832dda1d642125f0bb898f974.
>
> Reason for revert: Problem fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1261398 .
>
> Original change's description:
> > Revert "Reland "Export symbols needed by the Chromium component build (part 1).""
> >
> > This reverts commit 588f4642d1a29f7beaf28265dbd08728191b4c52.
> >
> > Reason for revert: Breaks WebRTC Chromium FYI Win Builder (dbg).
> > lld-link: error: undefined symbol: "__declspec(dllimport) __thiscall webrtc::Config::Config(void)" (__imp_??0Config@webrtc@@QAE@XZ)
> > [...]
> >
> > Original change's description:
> > > Reland "Export symbols needed by the Chromium component build (part 1)."
> > >
> > > This reverts commit 2ea9af227517556136fd629dd2663c0d75d77c7b.
> > >
> > > Reason for revert: The problem will be fixed by
> > > https://chromium-review.googlesource.com/c/chromium/src/+/1261122 .
> > >
> > > Original change's description:
> > > > Revert "Export symbols needed by the Chromium component build (part 1)."
> > > >
> > > > This reverts commit 9e24dcff167c4eb3555bf0ce6eaba090c10fbe53.
> > > >
> > > > Reason for revert: Breaks chromium.webrtc.fyi bots.
> > > >
> > > > Original change's description:
> > > > > Export symbols needed by the Chromium component build (part 1).
> > > > >
> > > > > This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h)
> > > > > to mark WebRTC symbols as visible from a shared library, this doesn't
> > > > > mean these symbols are part of the public API (please continue to refer
> > > > > to [1] for info about what is considered public WebRTC API).
> > > > >
> > > > > [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md
> > > > >
> > > > > Bug: webrtc:9419
> > > > > Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103505
> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > > > > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > > > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#24969}
> > > >
> > > > TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
> > > >
> > > > Change-Id: I01f6e18f0d2c0f0309cdaa6c943c3927e1f1f49f
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: webrtc:9419
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103720
> > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#24974}
> > >
> > > TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
> > >
> > > Change-Id: I83bbc7f550fc23e823c4d055e0a6f60c828960dd
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:9419
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/103740
> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#24980}
> >
> > TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
> >
> > Change-Id: I4b7cfe492f2c8eeda5c8ac52520e0cfc95ade9b0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:9419
> > Reviewed-on: https://webrtc-review.googlesource.com/c/103801
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#24983}
>
> TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:9419
> Change-Id: Id986a0a03cdc2818690337784396882af067f7fa
> Reviewed-on: https://webrtc-review.googlesource.com/c/104602
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25049}
TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
Change-Id: I6f58b9c90defccdb160307783fb55271ab424fa1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/104623
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25050}
2018-10-08 13:09:27 +00:00
99eea42fc1
Reland "Reland "Export symbols needed by the Chromium component build (part 1).""
...
This reverts commit b49520bfc08f5c5832dda1d642125f0bb898f974.
Reason for revert: Problem fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1261398 .
Original change's description:
> Revert "Reland "Export symbols needed by the Chromium component build (part 1).""
>
> This reverts commit 588f4642d1a29f7beaf28265dbd08728191b4c52.
>
> Reason for revert: Breaks WebRTC Chromium FYI Win Builder (dbg).
> lld-link: error: undefined symbol: "__declspec(dllimport) __thiscall webrtc::Config::Config(void)" (__imp_??0Config@webrtc@@QAE@XZ)
> [...]
>
> Original change's description:
> > Reland "Export symbols needed by the Chromium component build (part 1)."
> >
> > This reverts commit 2ea9af227517556136fd629dd2663c0d75d77c7b.
> >
> > Reason for revert: The problem will be fixed by
> > https://chromium-review.googlesource.com/c/chromium/src/+/1261122 .
> >
> > Original change's description:
> > > Revert "Export symbols needed by the Chromium component build (part 1)."
> > >
> > > This reverts commit 9e24dcff167c4eb3555bf0ce6eaba090c10fbe53.
> > >
> > > Reason for revert: Breaks chromium.webrtc.fyi bots.
> > >
> > > Original change's description:
> > > > Export symbols needed by the Chromium component build (part 1).
> > > >
> > > > This CL uses RTC_EXPORT (defined in rtc_base/system/rtc_export.h)
> > > > to mark WebRTC symbols as visible from a shared library, this doesn't
> > > > mean these symbols are part of the public API (please continue to refer
> > > > to [1] for info about what is considered public WebRTC API).
> > > >
> > > > [1] - https://webrtc.googlesource.com/src/+/HEAD/native-api.md
> > > >
> > > > Bug: webrtc:9419
> > > > Change-Id: I802abd32874d42d3aa5ecd3c8022e7cf5e043d99
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/103505
> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > > > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#24969}
> > >
> > > TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
> > >
> > > Change-Id: I01f6e18f0d2c0f0309cdaa6c943c3927e1f1f49f
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:9419
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/103720
> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#24974}
> >
> > TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
> >
> > Change-Id: I83bbc7f550fc23e823c4d055e0a6f60c828960dd
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:9419
> > Reviewed-on: https://webrtc-review.googlesource.com/c/103740
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#24980}
>
> TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
>
> Change-Id: I4b7cfe492f2c8eeda5c8ac52520e0cfc95ade9b0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:9419
> Reviewed-on: https://webrtc-review.googlesource.com/c/103801
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#24983}
TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9419
Change-Id: Id986a0a03cdc2818690337784396882af067f7fa
Reviewed-on: https://webrtc-review.googlesource.com/c/104602
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25049}
2018-10-08 12:54:06 +00:00
2e068e8b6f
Adds RTT based backoff trial to SendSideBandwidthEstimation.
...
Bug: webrtc:9718
Change-Id: Ic94dcd7612524d350f54d1907f843577b890badf
Reviewed-on: https://webrtc-review.googlesource.com/c/104122
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25048}
2018-10-08 12:36:06 +00:00
d2fb1bfeba
Generate module.modulemap file when building Mac Framework
...
Without this file, the Framework can't be used by Swift projects.
Bug: webrtc:9142
Change-Id: I8803ec8b194dc116e133257e205f4620bb34a692
Reviewed-on: https://webrtc-review.googlesource.com/c/103340
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25047}
2018-10-08 12:32:45 +00:00
e6708f31a0
Notify a rotation about autoroll CLs
...
Also don't keep dry-run-only CLs as work-in-progress.
No-Try: True
Bug: chromium:836566
Change-Id: I3008845396d09c751443755f96a5d571389e1d2e
Reviewed-on: https://webrtc-review.googlesource.com/c/104620
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25046}
2018-10-08 12:20:41 +00:00
75e3647a76
Switch usages of DefaultNetworkSimulationConfig to BuiltInNetworkBehaviorConfig
...
Bug: webrtc:9630
Change-Id: Ia0e0b5b4e1e3a8e687d1e7fe3bb600dbdda09efa
Reviewed-on: https://webrtc-review.googlesource.com/c/104561
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25045}
2018-10-08 12:19:31 +00:00
3a74239091
Fix compilation issues on media_transport_interface.h
...
Include api/video/encoded_image.h, and move constructors and
destructors to .cc file.
Bug: webrtc:9719
Change-Id: Ibecdc1151bf672155d3c09e13749ac39c921c3aa
Reviewed-on: https://webrtc-review.googlesource.com/c/104560
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25044}
2018-10-08 11:50:29 +00:00
788c51c858
Pass HeaderExtensionMap by reference in rtc_event_log2rtp_dump.
...
Bug: webrtc:8111
Change-Id: I0a64f92227e54aa1c180375bf406daaeac638fba
Reviewed-on: https://webrtc-review.googlesource.com/c/102640
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25043}
2018-10-08 10:52:27 +00:00
b6a8942fb4
Fix race condition for GetContributingSources test.
...
Bug: webrtc:9813
Change-Id: I44f50f9858217c8303862f3820db11dbd8736b6c
Reviewed-on: https://webrtc-review.googlesource.com/c/104121
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Yves Gerey <yvesg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25042}
2018-10-08 10:22:51 +00:00
666fb32d1f
Rename DefaultNetworkSimulationConfig into BuiltInNetworkBehaviorConfig.
...
It is done to better show what for this class exists and also restore
correspondence between config and interface, that is implemented by
configurable object.
Bug: webrtc:9630
Change-Id: I28456d1c792d67d9b2a405c8599054137a5d596a
Reviewed-on: https://webrtc-review.googlesource.com/c/104003
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25041}
2018-10-08 10:16:08 +00:00
6a8327fc82
Roll chromium_revision ccb83d4a55..0cdd2e3eab (597330:597498)
...
Change log: ccb83d4a55..0cdd2e3eab
Full diff: ccb83d4a55..0cdd2e3eab
Changed dependencies
* src/base: 0db61379d8..226b8bac1f
* src/build: 8bb9fef862..63f397a2df
* src/ios: d4e0105161..02ce4e5b29
* src/testing: 677e1ef262..a8da99ff4c
* src/third_party: dcfac1c5ed..503cf2d8b5
* src/tools: 731f63f312..8cfdea14be
DEPS diff: ccb83d4a55..0cdd2e3eab
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia37f07f965b85a76cec0cddaec10dc4d1535834e
Reviewed-on: https://webrtc-review.googlesource.com/c/104444
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#25040}
2018-10-08 09:43:55 +00:00
7c1744d3dc
Reland "Reland "Using units in SendSideBandwidthEstimation.""
...
This reverts commit a4de9c8b04ce9f7b1c4be639edd6cc4d3a9f07a1.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Reland "Using units in SendSideBandwidthEstimation.""
>
> This reverts commit e2cb26cb4fa2a3ce7c12636225ba9c720d7c7e56.
>
> Reason for revert: <INSERT REASONING HERE>
>
> Original change's description:
> > Reland "Using units in SendSideBandwidthEstimation."
> >
> > This reverts commit 917e5967a597fa8d6e6cae9ffccb21e3d35d553b.
> >
> > Reason for revert: Handling downstream use case.
> >
> > Original change's description:
> > > Revert "Using units in SendSideBandwidthEstimation."
> > >
> > > This reverts commit 35b5e5f3b0dc409bf571b3609860ad5bb8e00c29.
> > >
> > > Reason for revert: Breaks downstream project
> > >
> > > Original change's description:
> > > > Using units in SendSideBandwidthEstimation.
> > > >
> > > > This CL moves SendSideBandwidthEstimation to use the unit types
> > > > DataRate, TimeDelta and Timestamp. This prepares for upcoming changes.
> > > >
> > > > Bug: webrtc:9718
> > > > Change-Id: If10e329920dda037b53055ff3352ae7f8d7e32b8
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/104021
> > > > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > > > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#25029}
> > >
> > > TBR=terelius@webrtc.org ,srte@webrtc.org
> > >
> > > No-Try: True
> > > Bug: webrtc:9718
> > > Change-Id: Iaf470f1eec9911ee6fc7c1b4f5db9675d89d3780
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/104480
> > > Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> > > Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#25035}
> >
> > TBR=oprypin@webrtc.org ,terelius@webrtc.org ,srte@webrtc.org
> >
> > Change-Id: I0940791fcd1e196598b0f0a2ec779c49931ee5df
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:9718
> > Reviewed-on: https://webrtc-review.googlesource.com/c/104520
> > Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#25036}
>
> TBR=oprypin@webrtc.org ,terelius@webrtc.org ,srte@webrtc.org
>
> Change-Id: I6628771c79fc78dfd856649ae92232e95df63495
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:9718
> Reviewed-on: https://webrtc-review.googlesource.com/c/104540
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25037}
TBR=oprypin@webrtc.org ,terelius@webrtc.org ,srte@webrtc.org
Change-Id: If5473859cea725420afce11b6683fa0c70a29b0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9718
Reviewed-on: https://webrtc-review.googlesource.com/c/104501
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25039}
2018-10-08 09:02:03 +00:00
841c912ddd
Changed FakeVp8Encoder to write dimensions in payload.
...
Add FakeVp8Decoder that parse width and height from the payload.
Add unit test for testing that width and height is set when decoding frames.
Bug: none
Change-Id: Ifbfff4f62f99625309ce0ef21cf89c76448769d8
Reviewed-on: https://webrtc-review.googlesource.com/c/103140
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25038}
2018-10-08 08:37:38 +00:00
a4de9c8b04
Revert "Reland "Using units in SendSideBandwidthEstimation.""
...
This reverts commit e2cb26cb4fa2a3ce7c12636225ba9c720d7c7e56.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Reland "Using units in SendSideBandwidthEstimation."
>
> This reverts commit 917e5967a597fa8d6e6cae9ffccb21e3d35d553b.
>
> Reason for revert: Handling downstream use case.
>
> Original change's description:
> > Revert "Using units in SendSideBandwidthEstimation."
> >
> > This reverts commit 35b5e5f3b0dc409bf571b3609860ad5bb8e00c29.
> >
> > Reason for revert: Breaks downstream project
> >
> > Original change's description:
> > > Using units in SendSideBandwidthEstimation.
> > >
> > > This CL moves SendSideBandwidthEstimation to use the unit types
> > > DataRate, TimeDelta and Timestamp. This prepares for upcoming changes.
> > >
> > > Bug: webrtc:9718
> > > Change-Id: If10e329920dda037b53055ff3352ae7f8d7e32b8
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/104021
> > > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#25029}
> >
> > TBR=terelius@webrtc.org ,srte@webrtc.org
> >
> > No-Try: True
> > Bug: webrtc:9718
> > Change-Id: Iaf470f1eec9911ee6fc7c1b4f5db9675d89d3780
> > Reviewed-on: https://webrtc-review.googlesource.com/c/104480
> > Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#25035}
>
> TBR=oprypin@webrtc.org ,terelius@webrtc.org ,srte@webrtc.org
>
> Change-Id: I0940791fcd1e196598b0f0a2ec779c49931ee5df
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:9718
> Reviewed-on: https://webrtc-review.googlesource.com/c/104520
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25036}
TBR=oprypin@webrtc.org ,terelius@webrtc.org ,srte@webrtc.org
Change-Id: I6628771c79fc78dfd856649ae92232e95df63495
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9718
Reviewed-on: https://webrtc-review.googlesource.com/c/104540
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25037}
2018-10-08 08:27:29 +00:00
e2cb26cb4f
Reland "Using units in SendSideBandwidthEstimation."
...
This reverts commit 917e5967a597fa8d6e6cae9ffccb21e3d35d553b.
Reason for revert: Handling downstream use case.
Original change's description:
> Revert "Using units in SendSideBandwidthEstimation."
>
> This reverts commit 35b5e5f3b0dc409bf571b3609860ad5bb8e00c29.
>
> Reason for revert: Breaks downstream project
>
> Original change's description:
> > Using units in SendSideBandwidthEstimation.
> >
> > This CL moves SendSideBandwidthEstimation to use the unit types
> > DataRate, TimeDelta and Timestamp. This prepares for upcoming changes.
> >
> > Bug: webrtc:9718
> > Change-Id: If10e329920dda037b53055ff3352ae7f8d7e32b8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/104021
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#25029}
>
> TBR=terelius@webrtc.org ,srte@webrtc.org
>
> No-Try: True
> Bug: webrtc:9718
> Change-Id: Iaf470f1eec9911ee6fc7c1b4f5db9675d89d3780
> Reviewed-on: https://webrtc-review.googlesource.com/c/104480
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25035}
TBR=oprypin@webrtc.org ,terelius@webrtc.org ,srte@webrtc.org
Change-Id: I0940791fcd1e196598b0f0a2ec779c49931ee5df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9718
Reviewed-on: https://webrtc-review.googlesource.com/c/104520
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25036}
2018-10-08 08:26:09 +00:00
917e5967a5
Revert "Using units in SendSideBandwidthEstimation."
...
This reverts commit 35b5e5f3b0dc409bf571b3609860ad5bb8e00c29.
Reason for revert: Breaks downstream project
Original change's description:
> Using units in SendSideBandwidthEstimation.
>
> This CL moves SendSideBandwidthEstimation to use the unit types
> DataRate, TimeDelta and Timestamp. This prepares for upcoming changes.
>
> Bug: webrtc:9718
> Change-Id: If10e329920dda037b53055ff3352ae7f8d7e32b8
> Reviewed-on: https://webrtc-review.googlesource.com/c/104021
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25029}
TBR=terelius@webrtc.org ,srte@webrtc.org
No-Try: True
Bug: webrtc:9718
Change-Id: Iaf470f1eec9911ee6fc7c1b4f5db9675d89d3780
Reviewed-on: https://webrtc-review.googlesource.com/c/104480
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25035}
2018-10-08 08:21:18 +00:00
2e00abc98e
Reland "[cleanup] Remove useless includes."
...
Reason for reland: Downstream project fixed.
Original change's description:
> [cleanup] Remove useless includes.
>
> Manual cleanup guided by include-what-you-use diagnostic.
>
> Bug: webrtc:8311
> Change-Id: I00be03392cc7ee005101427ea7dc701621ccea68
> Reviewed-on: https://webrtc-review.googlesource.com/c/103320
> Commit-Queue: Yves Gerey <yvesg@webrtc.org >
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25013}
Bug: webrtc:8311
Change-Id: Id6ec4aeb798886a90ace640a190eaf16497ba31b
Reviewed-on: https://webrtc-review.googlesource.com/c/104120
Commit-Queue: Yves Gerey <yvesg@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25034}
2018-10-08 07:44:19 +00:00
4dc66c53d0
Move EncodedImage class to api/video/
...
Bug: webrtc:9378
Change-Id: I8fb3b19cad0ad428abc6c8e6b507180d461882ba
Reviewed-on: https://webrtc-review.googlesource.com/c/104002
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Peter Slatala <psla@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25033}
2018-10-08 07:37:10 +00:00