fa5d0dbd1e
cleanup: get rid of basicdefs.h include
...
The ARRAY_SIZE macro it defines is not used anymore, as all the usages
were converted to arraysize macro from arraysize.h.
BUG=None
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1443273002
Cr-Commit-Position: refs/heads/master@{#10640}
2015-11-13 22:37:43 +00:00
5237aaf243
Convert usage of ARRAY_SIZE to arraysize.
...
ARRAY_SIZE is the old version of arraysize and does not cover
all the cases in C++, arraysize is a copy of Chromium's
version and thus have wider coverage.
BUG=None
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1405023016
Cr-Commit-Position: refs/heads/master@{#10594}
2015-11-11 07:44:39 +00:00
a41ab9326c
Switch usage of _DEBUG macro to NDEBUG.
...
http://stackoverflow.com/a/29253284/5237416
BUG=None
R=tommi@webrtc.org
NOPRESUBMIT=true
Review URL: https://codereview.webrtc.org/1429513004
Cr-Commit-Position: refs/heads/master@{#10468}
2015-10-30 23:08:54 +00:00
0c4e06b4c6
Use suffixed {uint,int}{8,16,32,64}_t types.
...
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org , henrikg@webrtc.org , perkj@webrtc.org , solenberg@webrtc.org , stefan@webrtc.org , tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
2015-10-07 10:23:32 +00:00
3c089d751e
Add RTC_ prefix to contructormagic macros.
...
We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.
* DISALLOW_ASSIGN -> RTC_DISALLOW_ASSIGN
* DISALLOW_COPY_AND_ASSIGN -> RTC_DISALLOW_COPY_AND_ASSIGN
* DISALLOW_IMPLICIT_CONSTRUCTORS -> RTC_DISALLOW_IMPLICIT_CONSTRUCTORS
Related CL: https://codereview.webrtc.org/1335923002/
BUG=chromium:468375
NOTRY=true
Review URL: https://codereview.webrtc.org/1345433002
Cr-Commit-Position: refs/heads/master@{#9953}
2015-09-16 12:37:52 +00:00
e6cefb60f8
GYP variables for building expat, icu, libsrtp, usrsctp
...
This makes the build more flexible when linking against
prebuilt external libraries.
Use existing build_* variables for libyuv and json in talk/
(already in use in webrtc/).
Also make it possible to avoid building the GTK parts of the Linux build.
BUG=4242
R=andrew@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44179005
Cr-Commit-Position: refs/heads/master@{#9087}
2015-04-27 12:38:37 +00:00
ae0f0ee79e
Cleanup: Remove DISALLOW_EVIL_CONSTRUCTORS macro.
...
Just use the less-evil version, DISALLOW_COPY_AND_ASSIGN macro.
This should help with my TODO in
https://chromium.googlesource.com/chromium/src/+/master/base/macros.h#33
Tested on Linux with the following command lines:
$ rm -rf out/
$ gn gen //out/Debug --args='is_debug=true target_cpu="x64" build_with_chromium=false'
$ ninja -C out/Debug
BUG=None
TEST=see above
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50599004
Patch from Thiago Farina <tfarina@chromium.org >.
Cr-Commit-Position: refs/heads/master@{#8927}
2015-04-04 23:56:56 +00:00
00b8f6b364
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
...
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36229004
Cr-Commit-Position: refs/heads/master@{#8517}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:43:50 +00:00
7d2b6a9346
Enable Clang warning implicit-fallthrough and annotate the code.
...
BUG=4242
R=henrik.lundin@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34899004
Cr-Commit-Position: refs/heads/master@{#8187}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8187 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-28 18:38:13 +00:00
d7e34e1086
Make it easier to use external libyuv + cleanup GYP files.
...
It is now easier to use an external libyuv library.
Fix some GYP errors.
Remove the temporary webrtc_base target (depends on
https://codereview.chromium.org/865603002/ being landed
first).
BUG=4185
R=andresp@webrtc.org , andrew@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8154 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-26 19:17:26 +00:00
02c21dbef1
Make one OWNERS files for all of webrtc/libjingle so we don't need approval from webrtc/OWNERS every time we want to add a directory.
...
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7919 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-16 21:04:41 +00:00
18a3896bd2
Revert r7886:7887.
...
Broke build steps in other code that uses securetunnelsessionclient.cc
and others.
TBR=tommi@webrtc.org ,pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/36439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7890 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-15 07:03:04 +00:00
dee76f3b89
Move the obvious/easy Jingle-specific code into webrtc/libjingle.
...
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7886 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-12 21:04:42 +00:00
269fb4bc90
move xmpp and p2p to webrtc
...
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and
webrtc/p2p. Also makes libjingle use those version instead of the one in the talk folder.
BUG=3379
Review URL: https://webrtc-codereview.appspot.com/26999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7549 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 22:20:11 +00:00
28100cb388
Reverts r7459 "Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p."
...
BUG=N/A
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7472 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-17 22:03:39 +00:00
d1ba6d9cbf
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p.
...
BUG=3379
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27709005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7459 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-15 17:30:28 +00:00
