This is done for two reasons:
1. This will be useful in an upcoming CL, when all logging will be done with one function that accepts a std::unique_ptr<RtcEvent>.
2. Ensure no unnecessary copies when the compiler fails to optimize.
BUG=webrtc:8111
TBR=stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/3010273002
Cr-Commit-Position: refs/heads/master@{#19746}
This CL just removes a file from a presubmit check list because the
file is not there anymore.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/3012083002
Cr-Commit-Position: refs/heads/master@{#19745}
Reason for revert:
This change appears to break ulpfec, with severe regressions, e.g., for webrtc_perf_test FullStackTest.ForemanCifPlr5Ulpfec
Original issue's description:
> Reland of Use RtxReceiveStream. (patchset #1 id:1 of https://codereview.webrtc.org/3010983002/ )
>
> Reason for revert:
> Intend to fix perf failures and reland.
>
> Original issue's description:
> > Revert of Use RtxReceiveStream. (patchset #5 id:80001 of https://codereview.webrtc.org/3008773002/ )
> >
> > Reason for revert:
> > A few perf tests broken, including
> >
> > RampUpTest.UpDownUpAbsSendTimeSimulcastRedRtx
> > RampUpTest.UpDownUpTransportSequenceNumberRtx
> > RampUpTest.UpDownUpTransportSequenceNumberPacketLoss
> >
> >
> > Original issue's description:
> > > Use RtxReceiveStream.
> > >
> > > This also has the beneficial side-effect that when a media stream
> > > which is protected by FlexFEC receives an RTX retransmission, the
> > > retransmitted media packet is passed into the FlexFEC machinery,
> > > which should improve its ability to recover packets via FEC.
> > >
> > > BUG=webrtc:7135
> > >
> > > Review-Url: https://codereview.webrtc.org/3008773002
> > > Cr-Commit-Position: refs/heads/master@{#19649}
> > > Committed: 5c0f6c62ea
> >
> > TBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7135
> >
> > Review-Url: https://codereview.webrtc.org/3010983002
> > Cr-Commit-Position: refs/heads/master@{#19653}
> > Committed: 3c39c0137a
>
> TBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> BUG=webrtc:7135
>
> Review-Url: https://codereview.webrtc.org/3006063002
> Cr-Commit-Position: refs/heads/master@{#19715}
> Committed: 35713eaf56TBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/3007303002
Cr-Commit-Position: refs/heads/master@{#19744}
Reason for revert:
This has to be reverted to enable reverting cl https://codereview.webrtc.org/3006063002/, which seems to have broken ulpfec.
Original issue's description:
> Delete Rtx-related methods from RTPPayloadRegistry.
>
> Delete methods IsRtx, IsEncapsulated and RestoreOriginalPacket.
>
> BUG=webrtc:7135
>
> Review-Url: https://codereview.webrtc.org/3006993002
> Cr-Commit-Position: refs/heads/master@{#19739}
> Committed: 5b4b522641TBR=stefan@webrtc.org,danilchap@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/3011093002
Cr-Commit-Position: refs/heads/master@{#19742}
Previously the helper methods (like "CreateLocalAudioTrack") were using
hard-coded IDs. This means if you try to add two tracks to the same
PeerConnection you'll get an ID conflict. Tests were getting around
this by using APIs to explicitly add tracks with different IDs. But
this leaks an implementation detail of the helper methods, and is a
hassle.
So instead, just use random UUIDs from the helper methods. This is how
IDs are created in the real world, so it's pretty reasonable and allows
the tests to be made more readable.
BUG=None
Review-Url: https://codereview.webrtc.org/3011713002
Cr-Commit-Position: refs/heads/master@{#19736}
This is part of the work towards implementing Unified Plan.
In Unified Plan, an RtpSender/MediaStreamTrack can be a part of
multiple streams. This changes RtpSender to internally store
stream ids as a vector so that later CL's can update downstream
consumers to support multiple streams. For now, the vector can
only have exactly one element in it, but once the supporting code
has been updated the singular getter/setter will be removed and
any number of streams can be associated with an RtpSender.
Bug: webrtc:8183
Change-Id: I499a77ce79198861d35c91328b40ced2eb913cc0
Reviewed-on: https://chromium-review.googlesource.com/646712
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19733}
The FakeNetworkPipe use millisecond precision to calculate the delay induced by
the size of the packet being sent. The problem is that it rounds the delay down
to the closest millisecond which can cause a significant error in the actual
throughput. We keep track of that error to compensate the delay cause by
subsequent packets.
BUG=None
Review-Url: https://codereview.webrtc.org/3010653002
Cr-Commit-Position: refs/heads/master@{#19732}
* Add VideoProcessorIntegrationTestMediaCodec tests, including
a standard foreman test and a forced SW fallback test.
* Morph PlotVideoProcessorIntegrationTest into
VideoProcessorIntegrationTestParameterized. This test is intended
to be patched locally, depending on what metric is of interest.
It is run on the bots to ensure that it doesn't break.
* Remove the plot_videoprocessor_integrationtest binary. The test
above is instead moved to the modules_tests binary.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/3011043002
Cr-Commit-Position: refs/heads/master@{#19727}
Reason for revert:
Trying to fix the link error on the chromium FYI trybots.
Original issue's description:
> Revert of Decoupling rtc_base from Obj-C code (patchset #1 id:1 of https://codereview.webrtc.org/3004373002/ )
>
> Reason for revert:
> It breaks a chromium FYI trybot (the switch from rtc_static_library to rtc_source_set seems to be the problem).
>
> Original issue's description:
> > Reland of Decoupling rtc_base from Obj-C code (patchset #1 id:1 of https://codereview.webrtc.org/3008103002/ )
> >
> > Reason for revert:
> > Trying to reland after fixing downstream project.
> >
> > Original issue's description:
> > > Revert of Decoupling rtc_base from Obj-C code (patchset #8 id:140001 of https://codereview.webrtc.org/3001623003/ )
> > >
> > > Reason for revert:
> > > It breaks a downstream project.
> > >
> > > Original issue's description:
> > > > Decoupling rtc_base from Obj-C code
> > > >
> > > > The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
> > > > also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
> > > > for more information).
> > > >
> > > > To achieve this we have created 2 targets (rtc_base_objc and rtc_base_generic)
> > > > and rtc_base will act as a proxy between these targets (this way we can avoid a
> > > > circular dependency between rtc_base_generic and rtc_base_objc).
> > > >
> > > > BUG=webrtc:7743
> > > >
> > > > Review-Url: https://codereview.webrtc.org/3001623003
> > > > Cr-Commit-Position: refs/heads/master@{#19661}
> > > > Committed: a0a5b98937
> > >
> > > TBR=kjellander@webrtc.org,kwiberg@webrtc.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:7743
> > >
> > > Review-Url: https://codereview.webrtc.org/3008103002
> > > Cr-Commit-Position: refs/heads/master@{#19664}
> > > Committed: 791a8f611d
> >
> > TBR=kjellander@webrtc.org,kwiberg@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7743
> >
> > Review-Url: https://codereview.webrtc.org/3004373002
> > Cr-Commit-Position: refs/heads/master@{#19681}
> > Committed: a0c893f324
>
> TBR=kjellander@webrtc.org,kwiberg@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7743
>
> Review-Url: https://codereview.webrtc.org/3007183002
> Cr-Commit-Position: refs/heads/master@{#19688}
> Committed: 9c5e511806TBR=kjellander@webrtc.org,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7743
BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/3012823002
Cr-Commit-Position: refs/heads/master@{#19726}
CroppedDesktopFrame was broken by recent changes unexpectedly, it should be
covered by test cases to avoid this kind of accident.
Bug: chromium:761703
Change-Id: Ib95e4fe19a8bb9799db24fefd3ad154ddd15e53e
Reviewed-on: https://chromium-review.googlesource.com/651448
Commit-Queue: Zijie He <zijiehe@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19725}
Submitting this no_op change using chromium account to test changes related to non-googler and update last reviewed revision
BUG=None
TBR=kjellander@google.com
NOTRY=True
Review-Url: https://codereview.webrtc.org/3012023002
Cr-Commit-Position: refs/heads/master@{#19724}
Add RTC_DCHECKs that would ensure that PeerConnectionFactory::X_w() functions, intended to run on the worker_thread_, do so.
BUG=None
Review-Url: https://codereview.webrtc.org/3007153006
Cr-Commit-Position: refs/heads/master@{#19720}
Reason for revert:
This is not needed, since the script is run on the bot, not on a swarming task.
Original issue's description:
> Reland of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3008083004/ )
>
> Reason for revert:
> Now making sure the data attribute contents is not wiped for non-Android targets,
> which caused every test relying on resources to break.
>
> Original issue's description:
> > Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )
> >
> > Reason for revert:
> > Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554
> >
> > Edward: do you understand why? I'll run a full CQ set before relanding for sure.
> >
> > Original issue's description:
> > > Add //build/android/pylib/results/ to Android isolate packaging
> > >
> > > This is needed before relanding
> > > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> > >
> > > TESTED=
> > > I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
> > > is listed in the .isolated file:
> > > OUT=out/android-Release
> > > TEST=tools_unittests
> > > tools_webrtc/mb/mb.py isolate //$OUT $TEST
> > > tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
> > >
> > > BUG=chromium:717417
> > > NOTRY=True
> > >
> > > Review-Url: https://codereview.webrtc.org/3006103002
> > > Cr-Commit-Position: refs/heads/master@{#19695}
> > > Committed: f8ff0282c6
> >
> > TBR=ehmaldonado@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=chromium:717417
> >
> > Review-Url: https://codereview.webrtc.org/3008083004
> > Cr-Commit-Position: refs/heads/master@{#19696}
> > Committed: e5abac443a
>
> BUG=chromium:717417
>
> Review-Url: https://codereview.webrtc.org/3011023002
> Cr-Commit-Position: refs/heads/master@{#19707}
> Committed: 2e75bd4ed8TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:717417
Review-Url: https://codereview.webrtc.org/3011063002
Cr-Commit-Position: refs/heads/master@{#19717}
sync flag should only be true if:
* temporal layer > 0
* frame predics _only_ from tl0 (last)
Furthermore, flags should not predict from a buffer unless it has been
previously updated in the current iteration for the pattern.
I also added an experiment with an alternative pattern for a three
layer setup, where loose some efficieny by halving the pattern but
gain a little bit by updating arf for the top layer. The theory is that
this will cause fewer frame drops since we don't have as much
dependency on previous frames in the upper layer (which might not be
retransmitted).
BUG=webrtc:8162
Review-Url: https://codereview.webrtc.org/3003823003
Cr-Commit-Position: refs/heads/master@{#19716}
Reason for revert:
Intend to fix perf failures and reland.
Original issue's description:
> Revert of Use RtxReceiveStream. (patchset #5 id:80001 of https://codereview.webrtc.org/3008773002/ )
>
> Reason for revert:
> A few perf tests broken, including
>
> RampUpTest.UpDownUpAbsSendTimeSimulcastRedRtx
> RampUpTest.UpDownUpTransportSequenceNumberRtx
> RampUpTest.UpDownUpTransportSequenceNumberPacketLoss
>
>
> Original issue's description:
> > Use RtxReceiveStream.
> >
> > This also has the beneficial side-effect that when a media stream
> > which is protected by FlexFEC receives an RTX retransmission, the
> > retransmitted media packet is passed into the FlexFEC machinery,
> > which should improve its ability to recover packets via FEC.
> >
> > BUG=webrtc:7135
> >
> > Review-Url: https://codereview.webrtc.org/3008773002
> > Cr-Commit-Position: refs/heads/master@{#19649}
> > Committed: 5c0f6c62ea
>
> TBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7135
>
> Review-Url: https://codereview.webrtc.org/3010983002
> Cr-Commit-Position: refs/heads/master@{#19653}
> Committed: 3c39c0137aTBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/3006063002
Cr-Commit-Position: refs/heads/master@{#19715}
Original issue's description:
> Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
>
> Reason for revert:
> Breaks google3 project.
>
> Original issue's description:
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> >
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue.
> >
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3007473002
> > Cr-Commit-Position: refs/heads/master@{#19666}
> > Committed: f33cee7534TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
NOPRESUBMIT=true
NOTRY=True
BUG=webrtc:8142, webrtc:8143, webrtc:8145
Review-Url: https://codereview.webrtc.org/3012783002
Cr-Commit-Position: refs/heads/master@{#19712}
Reason for revert:
Now making sure the data attribute contents is not wiped for non-Android targets,
which caused every test relying on resources to break.
Original issue's description:
> Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )
>
> Reason for revert:
> Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554
>
> Edward: do you understand why? I'll run a full CQ set before relanding for sure.
>
> Original issue's description:
> > Add //build/android/pylib/results/ to Android isolate packaging
> >
> > This is needed before relanding
> > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> >
> > TESTED=
> > I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
> > is listed in the .isolated file:
> > OUT=out/android-Release
> > TEST=tools_unittests
> > tools_webrtc/mb/mb.py isolate //$OUT $TEST
> > tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
> >
> > BUG=chromium:717417
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/3006103002
> > Cr-Commit-Position: refs/heads/master@{#19695}
> > Committed: f8ff0282c6
>
> TBR=ehmaldonado@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:717417
>
> Review-Url: https://codereview.webrtc.org/3008083004
> Cr-Commit-Position: refs/heads/master@{#19696}
> Committed: e5abac443a
BUG=chromium:717417
Review-Url: https://codereview.webrtc.org/3011023002
Cr-Commit-Position: refs/heads/master@{#19707}
* Reorder and rename members of FrameStatistic.
* Rename corresponding temp variables used in the summary calculations.
* Make Stats class less structy.
* Try to enforce consistent frame numbers at all times.
* Remove VideoProcessor::FrameInfo struct and use the Stats class
for keeping track of encode/decode start times, etc.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/3011923002
Cr-Commit-Position: refs/heads/master@{#19703}
other macros (e.g. GUARDED_BY) rename postpone to followup CL
since it touches codebase wider
BUG=webrtc:8198
Review-Url: https://codereview.webrtc.org/3004393002
Cr-Commit-Position: refs/heads/master@{#19701}
