zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
29,043 Commits 1 Branch 0 Tags
39bab5afb51a40f77fdaab1ea38b9136acae9035
Commit Graph

10 Commits

Author SHA1 Message Date
Mirko Bonadei
317a1f09ed Use std::make_unique instead of absl::make_unique. 
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.

This CL has been created with the following steps:

git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt

diff --new-line-format="" --unchanged-line-format="" \
  /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
  uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
  /tmp/only_make_unique.txt /tmp/memory.txt | \
  xargs grep -l "absl/memory" > /tmp/add-memory.txt

git grep -l "\babsl::make_unique\b" | \
  xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"

git checkout PRESUBMIT.py abseil-in-webrtc.md

cat /tmp/add-memory.txt | \
  xargs sed -i \
  's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>

cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
  xargs sed -i '/#include "absl\/memory\/memory.h"/d'

git ls-files | grep BUILD.gn | \
  xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'

python tools_webrtc/gn_check_autofix.py \
  -m tryserver.webrtc -b linux_rel

# Repead the gn_check_autofix step for other platforms

git ls-files | grep BUILD.gn | \
  xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format

Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29209}
 2019-09-17 15:47:29 +00:00
Artem Titov
fedd625e0c Change 2g network pc audio test to more realistic network 
Bug: webrtc:10138
Change-Id: I6f4b23fe702d26dbbeed05d0d09b79a9a966e40c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147728
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28752}
 2019-08-02 22:28:02 +00:00
Artem Titov
cbc91efaa0 Improve low bandwidth audio test instrumentatin, fix PC test 
Bug: webrtc:10138
Change-Id: I1d72fcac642064e569f6aac259fd0b6e0cf5c8b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146603
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28644}
 2019-07-23 11:54:10 +00:00
Mirko Bonadei
2ab97f6f8e Migrate WebRTC test infra to ABSL_FLAG. 
This is the last CL required to migrate WebRTC to ABSL_FLAG, rtc::Flag
will be removed soon after this one lands.

Bug: webrtc:10616
Change-Id: I2807cec39e28a2737d2c49e2dc23f2a6f98d08f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145727
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28606}
 2019-07-19 06:54:04 +00:00
Artem Titov
52e240e2c1 Use 16000Hz audio in PC test when specified 
Bug: webrtc:10138
Change-Id: Iea28aef07de45f244ed4d3813dc0531068f6d4b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144567
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28531}
 2019-07-10 17:49:23 +00:00
Artem Titov
b1f2d60456 Reland "Fix collection of audio metrics from PC test framework for audio test" 
This is a reland of 2d0880b56954f57548deea51dfa678b80dbf618f

To fix perf bot issue reading of perf results file was updated. Now perf
results file will be generated by each test and then returned via output to
the python script, which will get it and put into final file.

Original change's description:
> Fix collection of audio metrics from PC test framework for audio test
>
> Bug: webrtc:10138
> Change-Id: I18a8509a0cdc4ed1db6894c7540d5c0a155d6233
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144784
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28514}

Bug: webrtc:10138
Change-Id: I1347f09427736362a2d550612b48e09c06cfb1d1
No-Presubmit: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145201
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28527}
 2019-07-10 15:21:30 +00:00
Mirko Bonadei
4876cb21c8 Revert "Fix collection of audio metrics from PC test framework for audio test" 
This reverts commit 2d0880b56954f57548deea51dfa678b80dbf618f.

Reason for revert: Breaks perf tests (e.g. https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Android32%20(L%20Nexus4)/1470).

Original change's description:
> Fix collection of audio metrics from PC test framework for audio test
> 
> Bug: webrtc:10138
> Change-Id: I18a8509a0cdc4ed1db6894c7540d5c0a155d6233
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144784
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28514}

TBR=oprypin@webrtc.org,ossu@webrtc.org,titovartem@webrtc.org

Change-Id: Id45abfbb0de47d95fe6cb396b1c29efb97a43797
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10138
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144883
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28519}
 2019-07-09 20:09:14 +00:00
Artem Titov
2d0880b569 Fix collection of audio metrics from PC test framework for audio test 
Bug: webrtc:10138
Change-Id: I18a8509a0cdc4ed1db6894c7540d5c0a155d6233
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144784
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28514}
 2019-07-09 13:08:53 +00:00
Artem Titov
4a126e45c3 Rename tests to prevent clashing with old audio test 
Bug: webrtc:10138
Change-Id: Ice785dad8646d28b2a2a7faa5d852679db41fbaa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144783
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28507}
 2019-07-08 14:57:57 +00:00
Artem Titov
c8263e0638 Introduce PC level audio quality test. 
Add PC level audio quality test as separate file but into the same
binary as low_bandwidth_audio_test.cc

Bug: webrtc:10138
Change-Id: I3bb7df4130ab62c21a82881cd9f57b936f3cc11d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144621
Reviewed-by: Minyue Li <minyue@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28493}
 2019-07-05 11:41:38 +00:00