3a087a839a
Transform encoded frame in RTPSenderVideo.
...
This change is part of the implementation of the Insertable Streams Web
API: https://github.com/alvestrand/webrtc-media-streams/blob/master/explainer.md
Design doc for WebRTC library changes:
http://doc/1eiLkjNUkRy2FssCPLUp6eH08BZuXXoHfbbBP1ZN7EVk
Bug: webrtc:11380
Change-Id: I491ecefc60d184b75128799274c7d7efcf907d2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169128
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30666}
2020-03-03 08:17:49 +00:00
83762b21db
Use NetworkToHost32 instead of HostToNetwork32 to translate PPID.
...
Note that this wasn't actually making a difference since both do the
same thing effectively.
Bug: webrtc:11386
Change-Id: I49d84d363dce12eabeb3770b40abdfdb674a05ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169433
Commit-Queue: Taylor <deadbeef@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30665}
2020-03-03 01:51:51 +00:00
d084ea93b6
BoundedInlineVector: Add resize() method
...
Bug: webrtc:11391
Change-Id: I34d659d0e295617e9058393d4d1b510111a78b83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169520
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30664}
2020-03-02 20:55:28 +00:00
c126937564
BoundedInlineVector: Vector class of bounded size with inline allocation
...
Selling point is that it never touches the heap. Intended use case is
cheaply returning a variable, bounded, and small number of things from
a function.
Specifically, there are situations where we'd like to return things like
ArrayView<ArrayView<float>>
where we currently have to allocate an array of ArrayView<float> for
the outer ArrayView to point to, which is a bother; however, although
the outer ArrayView is of variable size, that size is statically
guaranteed to not exceed some small constant. After this CL, we'll be
able to instead return
BoundedInlineVector<ArrayView<float>, kSmallConstant>
which is much more convenient. We already had the option of returning e.g.
std::vector<ArrayView<float>>
but that would bloat our binary with code to handle heap allocations
in places we'd rather be lean and mean.
https://godbolt.org/z/r-vcPj demonstrates that the overhead compared to
a raw C array + a size is ~zero.
Bug: webrtc:11391
Change-Id: Ifb6d937193052588be641aa62cc67ba0ec64ded6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168944
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30663}
2020-03-02 20:45:58 +00:00
f52d3ed084
Adds transport overhead to route changes in scenario tests.
...
Bug: webrtc:9510
Change-Id: Iadc67420c9db085f4ae6325a1861fd78d9faa5a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169362
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30662}
2020-03-02 15:32:19 +00:00
ae92244054
Clean VP8 header parser
...
The old implementation has undefined behavior in it (unaligned read of uint32_t)
Now it's closer to the reference implementation:
https://tools.ietf.org/html/rfc6386#section-20.2
Also, added some comments and named some variables to make it more clear, that the
parser actually does.
Bug: chromium:1057551
Change-Id: I84c1912867e2794502e8a63302c938a0cbab2c4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169545
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30661}
2020-03-02 15:05:48 +00:00
7d3f602dbc
Make scenario tests more tolerant on iOS.
...
Making these tests run shorter broke them on iOS. I think we can just
be more tolerant on iOS.
This also tried to re-enable the test on dbg; hopefully the increased
tolerance is enough.
Bug: None
Change-Id: Ic8c54dd46b0f5cb219b0c16da81c9486f6c45f10
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169440
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30660}
2020-03-02 14:21:08 +00:00
b03422a737
Remove deprecated method onEncodingBitrate.
...
Bug: webrtc:11341
Change-Id: Id299d8000fc8e24725aba3e5b261fdd87af2aa86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169544
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30659}
2020-03-02 12:54:58 +00:00
109e23c9ce
Increase accepted PSNR range for SimTimeEncoding test
...
Currently IOS64 Release bot produces PSNR value 35.2
Bug: webrtc:11395
Change-Id: I2eef9ca7afdf074c74eec12aa48952ecf0d02281
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169543
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30658}
2020-03-02 12:42:42 +00:00
db5d7e470f
Cleanup: Use common IP overhead definitions in test and prod code
...
This avoid duplication. As part of this moving the overhead calculation
to the IP address class so it's easier to find and more natural to use.
Bug: webrtc:9883
Change-Id: If4d865f445bc1a302572896932966ce30294e339
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169445
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30657}
2020-03-02 11:36:58 +00:00
61f74d91f8
Reland "Expose can_trickle_ice_candidates on PeerConnection"
...
This reverts commit cb8c40138ca170f841bc45fa6771cdfc4b966e5f.
Reason for revert: Added missing default.
Original change's description:
> Revert "Expose can_trickle_ice_candidates on PeerConnection"
>
> This reverts commit c6a65c8866487c6adc0a7bb472d3bad9389501f9.
>
> Reason for revert: Breaks downstream due to missing default
>
> Original change's description:
> > Expose can_trickle_ice_candidates on PeerConnection
> >
> > Bug: chromium:708484
> > Change-Id: I9a40e75066341f0d9f965bd3718bfcb3f0459533
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169450
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Taylor <deadbeef@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30653}
>
> TBR=deadbeef@webrtc.org ,hta@webrtc.org
>
> Change-Id: Iaa5b977c4237715a8a5127cf167cf6512a3f7059
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:708484
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169540
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30655}
TBR=deadbeef@webrtc.org ,hta@webrtc.org
Change-Id: I608da7781f158b4b02dd226d4dcd5615c4935fa8
Bug: chromium:708484
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169541
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30656}
2020-03-02 11:35:53 +00:00
cb8c40138c
Revert "Expose can_trickle_ice_candidates on PeerConnection"
...
This reverts commit c6a65c8866487c6adc0a7bb472d3bad9389501f9.
Reason for revert: Breaks downstream due to missing default
Original change's description:
> Expose can_trickle_ice_candidates on PeerConnection
>
> Bug: chromium:708484
> Change-Id: I9a40e75066341f0d9f965bd3718bfcb3f0459533
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169450
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Taylor <deadbeef@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30653}
TBR=deadbeef@webrtc.org ,hta@webrtc.org
Change-Id: Iaa5b977c4237715a8a5127cf167cf6512a3f7059
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:708484
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169540
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30655}
2020-03-02 10:14:14 +00:00
412a31bbf8
Insert frame transformer between Depacketizer and Decoder.
...
Add a new API in RTReceiverInterface, to be called from the browser side
to insert a frame transformer between the Depacketizer and the Decoder.
The frame transformer is passed from RTReceiverInterface through the
library to be eventually set in RtpVideoStreamReceiver, where the frame
transformation will occur in the follow-up CL
https://webrtc-review.googlesource.com/c/src/+/169130 .
This change is part of the implementation of the Insertable Streams Web
API: https://github.com/alvestrand/webrtc-media-streams/blob/master/explainer.md
Design doc for WebRTC library changes:
http://doc/1eiLkjNUkRy2FssCPLUp6eH08BZuXXoHfbbBP1ZN7EVk
Bug: webrtc:11380
Change-Id: I6b73cd16e3907e8b7709b852d6a2540ee11b4fed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169129
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30654}
2020-03-02 08:33:44 +00:00
c6a65c8866
Expose can_trickle_ice_candidates on PeerConnection
...
Bug: chromium:708484
Change-Id: I9a40e75066341f0d9f965bd3718bfcb3f0459533
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169450
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Taylor <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30653}
2020-03-02 05:19:16 +00:00
a08b2384a3
Roll chromium_revision 45a3ae9739..73a396877b (745356:745464)
...
Change log: 45a3ae9739..73a396877b
Full diff: 45a3ae9739..73a396877b
Changed dependencies
* src/base: 9e6778c686..63ecbb77ca
* src/build: edf827134e..2b17c86521
* src/ios: bf84cd889e..2a438f6dab
* src/testing: 84515eeaa4..22bc9c2523
* src/third_party: 4e52e2df5a..ac875ae539
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/21c99c4478..03a5e99059
* src/third_party/freetype/src: 141da02816..216e077600
* src/tools: 5a867d538f..b011cd9830
DEPS diff: 45a3ae9739..73a396877b
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic881d6229217865ecc22c9b7cdfcc5945b302833
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169431
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30652}
2020-02-28 17:19:44 +00:00
c8958e5a4f
Add RTC_EXPORT to VCMEncodedFrame
...
This is needed to be able to use webrtc::video_coding::EncodedFrame
is unit tests in Chromium.
TBR=tommi@webrtc.org
Bug: webrtc:11380
Change-Id: Idb3b0ab667a548f5a968e02a8efd91f02585c3f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169451
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30651}
2020-02-28 16:59:10 +00:00
c028df05ac
Extract BWE stats collection.
...
Extract collection of BWE stats from DefaultVideoQualityAnalyzer to
separate class to prepare for migration on new GetStats API and simplify
quality analyzer.
Bug: webrtc:11381
Change-Id: I0e7e2d7e40b467d7a42633a72a7ffc49ebcb0237
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169444
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30650}
2020-02-28 16:49:20 +00:00
4f3c4fcb1f
Temporary debug logging for SingleProcessEncodedImageDataInjector
...
Bug: None
Change-Id: Idb482c002ed41b9ad750109fd3497425003be11b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169448
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30649}
2020-02-28 15:28:40 +00:00
9f215a7a3f
Thread affinity fix for scenario test SetMuted.
...
This is to satisfy a thread checker in AudioSendStream.
Bug: webrtc:9510
Change-Id: I5ba03562fcdc3e93d77707e41220b82b99581470
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169343
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30648}
2020-02-28 15:20:39 +00:00
cabed431f8
Adds stable target rate to GoogCC debug output.
...
Bug: webrtc:9510
Change-Id: I99bcc469f758d645d7db180f48b5d1eb623c1117
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169360
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30647}
2020-02-28 15:13:50 +00:00
0fb07f8c90
Deprecate use of cricket::MediaContentDescription::Copy
...
One should use a std::unique_ptr to the object, as returned
by Clone() instead, not a naked pointer.
Bug: webrtc:10701
Change-Id: I10ab309207f2cb5aec83a6d09336699ed7b26f50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169342
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30646}
2020-02-28 10:03:49 +00:00
5f999a777d
Allow to negotiate dependency descriptor rtp header extension
...
Without exposing it in capabilities:
this extension is not stable enough to expose it by default,
but already in working state so with munge sdp can be experimented with.
Bug: webrtc:10342
Change-Id: I6bac123325a90431e4769e86da79638869e36cfc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168961
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30645}
2020-02-28 09:27:51 +00:00
ff61f3a555
Fix + test copying of fixed-sized ArrayView rvalues
...
Previously, only lvalues were tested, and only lvalues worked.
Bug: webrtc:11389
Change-Id: I524e9d63e0840c3ba274dbe2062d78f72d79019d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169347
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30644}
2020-02-28 09:26:11 +00:00
6038383565
[Overuse] Separate getting adaptation target from applying it.
...
This CL takes us one step closer to being able to evaluate alternative
possible adaptation targets (e.g. multi-stream adaptation) by exposing
the target separately from applying it.
This is a refactoring of OnResourceUnderuse() and OnResourceOveruse().
Prior to this CL, the target resolution or frame rate was calculated
inside these methods and applied if possible. This CLs makes these two
steps (calculating a usable target + applying it) separate methods.
After this CL, the target is expressed as AdaptationTarget and is
calculated and returned by GetAdaptUpTarget() and GetAdaptDownTarget().
The target is only returned if it can be applied - and CanAdaptUp() +
CanAdaptDown() are merged with these methods.
Applying the target happens at ApplyAdaptationTarget().
Bug: webrtc:11222
Change-Id: I8e488be1d1590c23848db816d49a7738562e176d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169100
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@google.com >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30643}
2020-02-28 09:00:31 +00:00
e77912ba8c
Insert frame transformer between Encoded and Packetizer.
...
Add a new API in RTPSenderInterface, to be called from the browser side
to insert a frame transformer between the Encoded and the Packetizer.
The frame transformer is passed from RTPSenderInterface through the
library to be eventually set in RTPSenderVideo, where the frame
transformation will occur in the follow-up CL
https://webrtc-review.googlesource.com/c/src/+/169128 .
Insertable Streams Web API explainer:
https://github.com/alvestrand/webrtc-media-streams/blob/master/explainer.md
Design doc for WebRTC library changes:
http://doc/1eiLkjNUkRy2FssCPLUp6eH08BZuXXoHfbbBP1ZN7EVk
Bug: webrtc:11380
Change-Id: I46cd0d8a798c2736c837e90cbf90d8901c7d27fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169127
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30642}
2020-02-28 07:43:13 +00:00
c62e4c5dc7
Test copying of variable-sized ArrayView rvalues
...
Previously, only lvalues were tested.
Bug: webrtc:11389
Change-Id: I4067c8bfc40c52de0622a6f58a5c7b7805b0fa7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169346
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30641}
2020-02-28 07:27:33 +00:00
63288e382a
Whitespace change to kick bots.
...
Testing recipe change.
Change-Id: Ided1943e202d48952be0e3e79f0655293d8b879a
Tbr: mbonadei@webrtc.org
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169131
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30640}
2020-02-28 06:44:59 +00:00
56c2179a88
Roll chromium_revision dcd1a26c92..45a3ae9739 (745220:745356)
...
Change log: dcd1a26c92..45a3ae9739
Full diff: dcd1a26c92..45a3ae9739
Changed dependencies
* src/build: 105e1cad64..edf827134e
* src/ios: 0ebbdea2fe..bf84cd889e
* src/testing: c133113bbd..84515eeaa4
* src/third_party: 34974f4583..4e52e2df5a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9db20bb343..21c99c4478
* src/third_party/depot_tools: a4f9aa0375..1e247059f4
* src/tools: 508e296745..5a867d538f
DEPS diff: dcd1a26c92..45a3ae9739
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I389f6332f2f090c752ee412c267c4029de514f90
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169425
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30639}
2020-02-28 04:34:58 +00:00
b5eeba1bb3
Roll chromium_revision 4ed2234c93..dcd1a26c92 (745105:745220)
...
Change log: 4ed2234c93..dcd1a26c92
Full diff: 4ed2234c93..dcd1a26c92
Changed dependencies
* src/base: 78cf08a9fd..9e6778c686
* src/build: 1dcd443e5c..105e1cad64
* src/ios: b23239ac0b..0ebbdea2fe
* src/testing: 37a373421d..c133113bbd
* src/third_party: add37e4154..34974f4583
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/65dd8440ec..9db20bb343
* src/third_party/depot_tools: 29d5cf85ac..a4f9aa0375
* src/third_party/r8: -oXGY8FjY2ZuIBHoGAByn8N6Vn2b0wB2QO8Ct_169XoC..C28ypVbWD-R2M9x9fH7QniIsYjJrKoUhxqEV_cZR4qgC
* src/tools: 6626fe5a5c..508e296745
DEPS diff: 4ed2234c93..dcd1a26c92
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I0f3fd98c3aab321b1c73abaccfab708b13a98712
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169422
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30638}
2020-02-27 22:59:29 +00:00
e3e07bf979
Introduce frame transformer interfaces for Insertable Streams Web API.
...
Define FrameTransformerInterface for transforming encoded frames, and
TransformedFrameCallback for receiving transformed frames.
The FrameTransformerInterface will be implemented on the browser side,
and will be set in WebRTC sender and receiver in follow up CLs:
- Sender: https://webrtc-review.googlesource.com/c/src/+/169127
- Receiver: https://webrtc-review.googlesource.com/c/src/+/169129/1
Insertable Streams Web API explainer:
https://github.com/alvestrand/webrtc-media-streams/blob/master/explainer.md
Design doc for WebRTC library changes:
http://doc/1eiLkjNUkRy2FssCPLUp6eH08BZuXXoHfbbBP1ZN7EVk
Bug: webrtc:11380
Change-Id: Icf8ff159feb604f006e18157660f13d300a08b2b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169126
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30637}
2020-02-27 20:41:59 +00:00
a16da49a2b
Roll chromium_revision 4f8e062e9c..4ed2234c93 (744969:745105)
...
Change log: 4f8e062e9c..4ed2234c93
Full diff: 4f8e062e9c..4ed2234c93
Changed dependencies
* src/base: 0810102150..78cf08a9fd
* src/build: 05fc2f579a..1dcd443e5c
* src/ios: 8ea4906aef..b23239ac0b
* src/testing: 679c15290d..37a373421d
* src/third_party: 923473234f..add37e4154
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/50148dbfcb..65dd8440ec
* src/third_party/depot_tools: 005269a513..29d5cf85ac
* src/third_party/freetype/src: 5b1a37af56..141da02816
* src/third_party/r8: C28ypVbWD-R2M9x9fH7QniIsYjJrKoUhxqEV_cZR4qgC..-oXGY8FjY2ZuIBHoGAByn8N6Vn2b0wB2QO8Ct_169XoC
* src/tools: 827d9498cc..6626fe5a5c
DEPS diff: 4f8e062e9c..4ed2234c93
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic2fcf85725916b7d00f460500e7e52aeb4d99cd7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169420
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30636}
2020-02-27 18:36:16 +00:00
729310aa18
iSAC fixed|float encoder fuzzers
...
Bug: webrtc:11388
Change-Id: I5910492ef9471aa193aa50ef5e14b4b66cb6542a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169365
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30635}
2020-02-27 18:26:05 +00:00
02b76bd40b
Opus Encoder fuzzer: separate target for FuzzAudioEncoder
...
Move FuzzAudioEncoder to a separate target to make it available for
other encoders.
Bug: webrtc:11388
Change-Id: I8b9a0f810791880eedb129b55eb33f154790e48f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169364
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30634}
2020-02-27 16:13:15 +00:00
7c1ac76f52
Adds binary proto ANA support in scenario tests.
...
This makes it easier to reuse existing audio network adaptation
configurations in the scenario framework.
Bug: webrtc:9510
Change-Id: I06ab08684d449fef7fffe265d1078738d526a43d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169363
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30633}
2020-02-27 14:53:59 +00:00
8ad3427d7f
Use the last video stream for scenario tests stats.
...
This makes slightly more sense when looking at video resolution etc.
Bug: webrtc:9510
Change-Id: I49d39cac23d2f5d7ca09f2a27152c7519ea639f1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169344
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30632}
2020-02-27 14:52:54 +00:00
14273de88b
Make ProcessThread be a TaskQueue implementation
...
That would allow to switch components from relying on ProcessThreads to
relying on TaskQueue one by one, without introducing new threads.
Bug: webrtc:6289
Change-Id: I18fe5d679d4d4d0ddf4a11900c9814eb570284d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167533
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30631}
2020-02-27 14:29:03 +00:00
a7382f7879
iSAC API wrapper unit test fix
...
Use speech content instead of white noise and enable target vs measured
bitrate tests.
Bug: webrtc:11360
Change-Id: If8c8e73f943eda14efeb22ba406c7a1bed7d32b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168660
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30630}
2020-02-27 14:27:23 +00:00
4a6f81829b
Add ability to enable AV sync in PC level tests
...
Bug: webrtc:11381
Change-Id: I223ff0a2b81632ee7cbbac5b722bb6a7d5f72f7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168959
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30629}
2020-02-27 14:22:23 +00:00
8e7d4bfeef
Remove deprecated "description" field of cricket::ContentInfo
...
Bug: webrtc:10701
Change-Id: I631616fefb59b49603e0a98267b3e58d93edfb50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169122
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30628}
2020-02-27 14:13:03 +00:00
c93595b4b9
Allow REMB messages to be sent immediately in RtcpTransceiver
...
This cl add a configuration flag to allow REMB messages to be sent immediately when the bitrate value have changed.
The remb message is still included in all following compound packets.
Bug: None
Change-Id: I9f71d30cddbccd095e1d2971247c731bd1727d32
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169221
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30627}
2020-02-27 13:48:05 +00:00
eed48b86ed
Disable PeerScenarioQualityTest.PsnrIsCollected on windows.
...
Disabled due to flakiness.
Bug: webrtc:10839
Change-Id: I651aca6efef4083b4ee008956becab9aa8167121
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169361
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30626}
2020-02-27 13:18:25 +00:00
3e1b7f39f3
Roll chromium_revision 7c2b6c4e24..4f8e062e9c (744850:744969)
...
Change log: 7c2b6c4e24..4f8e062e9c
Full diff: 7c2b6c4e24..4f8e062e9c
Changed dependencies
* src/base: 939efba686..0810102150
* src/build: 64097b6e76..05fc2f579a
* src/ios: 0a878cc0fb..8ea4906aef
* src/testing: 1081f7ab93..679c15290d
* src/third_party: 272246ca95..923473234f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9abfc467c7..50148dbfcb
* src/third_party/depot_tools: b847c567e7..005269a513
* src/tools: fcb0116c59..827d9498cc
DEPS diff: 7c2b6c4e24..4f8e062e9c
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I5d9c0910a053f080df0cb5bf64d1773b6c396c6d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169320
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30625}
2020-02-27 09:02:01 +00:00
40b764a6ba
VideoSendStreamTest: remove unused array and member.
...
Bug: none
Change-Id: I9049be00ba461e5212406c9a5b51c67ba98240ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168947
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30624}
2020-02-27 08:38:51 +00:00
361a0c6ed3
Roll chromium_revision 95bde2f246..7c2b6c4e24 (744714:744850)
...
Change log: 95bde2f246..7c2b6c4e24
Full diff: 95bde2f246..7c2b6c4e24
Changed dependencies
* src/base: 40ae03169d..939efba686
* src/build: 5a6102c439..64097b6e76
* src/ios: 1c90c5b85d..0a878cc0fb
* src/testing: ffcff1e39a..1081f7ab93
* src/third_party: fbb52cb4f6..272246ca95
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/17f4e8b9da..9abfc467c7
* src/third_party/depot_tools: 2a9042f8a7..b847c567e7
* src/tools: 7bbf7f1b3a..fcb0116c59
DEPS diff: 95bde2f246..7c2b6c4e24
/DEPS
Clang version changed c29003813ab9bd6ea7b6de40ea8f1fe21979f13f:61f538d37b80eb589f8990f0b4513d702704ea38
Details: 95bde2f246..7c2b6c4e24
/tools/clang/scripts/update.py
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I10edb5184c529f52e79f6e6b5aac9d042f3416c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169280
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30623}
2020-02-27 00:44:47 +00:00
e952b78c28
Reland "Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."""""
...
This is a reland of c8496e9814ad2681b372946f143d1acb45475c7e
Original change's description:
> Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""""
>
> This is a reland of 703a5d76d9ba8e7984509cc7bf70fb4ed84ef6be
>
> Original change's description:
> > Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."""
> >
> > This is a reland of af51be7869994a299451e22e6382ae641767b26d
> >
> > Original change's description:
> > > Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""
> > >
> > > This is a reland of a0adf3d4409036d095480e9bfa0fc06990362f84
> > >
> > > Original change's description:
> > > > Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."
> > > >
> > > > This is a reland of e7153012682ccd3d1eacc18f802cab7820e3bad3
> > > >
> > > > Original change's description:
> > > > > Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate entension version 1.5.
> > > > >
> > > > > Bug: chromium:396091
> > > > > Change-Id: Ia1b36c771632c536bb8d15322461b479fabc409e
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148768
> > > > > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org >
> > > > > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#29083}
> > > >
> > > > Bug: chromium:396091
> > > > Change-Id: I0d9171ae5f340e0489e4b45ce5d97bc52b0a4904
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156067
> > > > Commit-Queue: Tommi <tommi@webrtc.org >
> > > > Reviewed-by: Tommi <tommi@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#29655}
> > >
> > > Bug: chromium:396091
> > > Change-Id: I47525911095fabc6cee613d03b0d83134b95b084
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158900
> > > Reviewed-by: Tomas Gunnarsson <tommi@chromium.org >
> > > Reviewed-by: Tommi <tommi@webrtc.org >
> > > Commit-Queue: Tommi <tommi@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30032}
> >
> > Bug: chromium:396091
> > Change-Id: I03702c8ea935bb5fe1797defda1ba6b279b95217
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165724
> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
> > Commit-Queue: Jamie Walch <jamiewalch@chromium.org >
> > Cr-Commit-Position: refs/heads/master@{#30461}
>
> TBR=jamiewalch@chromium.org ,tommi@webrtc.org
>
> Bug: chromium:396091
> Change-Id: If9bd5e7b35240acc4dd528397926ba663fe2affc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168760
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30548}
Bug: chromium:396091
Change-Id: I6892d4bb49cdffe655c238c99e981c4927c9e6fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169200
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Commit-Queue: Jamie Walch <jamiewalch@chromium.org >
Cr-Commit-Position: refs/heads/master@{#30622}
2020-02-26 20:35:54 +00:00
206d467507
Roll chromium_revision 0bba1cecba..95bde2f246 (744590:744714)
...
Change log: 0bba1cecba..95bde2f246
Full diff: 0bba1cecba..95bde2f246
Changed dependencies
* src/base: 4147871d4f..40ae03169d
* src/build: a96077686b..5a6102c439
* src/ios: d3454c3f1c..1c90c5b85d
* src/testing: bdd545bcc8..ffcff1e39a
* src/third_party: 92d82c7dc5..fbb52cb4f6
* src/third_party/r8: -oXGY8FjY2ZuIBHoGAByn8N6Vn2b0wB2QO8Ct_169XoC..C28ypVbWD-R2M9x9fH7QniIsYjJrKoUhxqEV_cZR4qgC
* src/tools: 08a61489f6..7bbf7f1b3a
DEPS diff: 0bba1cecba..95bde2f246
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I7c92a9b85af2f325234274d8ce0b0e7c24598057
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169204
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30621}
2020-02-26 18:38:04 +00:00
9731a14ff8
Improve logging for UpdateActiveSimulcastLayers.
...
Bug: None
Change-Id: I56d14421044749e9bb89754a72a989820c025600
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169220
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30620}
2020-02-26 16:24:46 +00:00
4f34d78c85
Report available instead of encoding bitrate to VideoEncoderSelector.
...
The encoding bitrate might be limited depending on the current encoder.
Bug: webrtc:11341
Change-Id: I734fce12734b1e703e7948847cdb1365c08a137b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169123
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30619}
2020-02-26 15:56:36 +00:00
e6994bc1f5
Whitespace change to kick bots.
...
Testing recipe change.
Change-Id: I48d12c73223a5b169c23a07221b4edaf72a23d6a
Tbr: mbonadei@webrtc.org
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169124
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30618}
2020-02-26 12:07:50 +00:00
85a926dc53
Roll chromium_revision 159524df35..0bba1cecba (744393:744590)
...
Change log: 159524df35..0bba1cecba
Full diff: 159524df35..0bba1cecba
Changed dependencies
* src/base: 6b1c2593d6..4147871d4f
* src/build: f72a4dc3b7..a96077686b
* src/ios: ad035281a5..d3454c3f1c
* src/testing: ab141ecfcd..bdd545bcc8
* src/third_party: a052689a93..92d82c7dc5
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d2b5e78019..17f4e8b9da
* src/third_party/depot_tools: 9aa1a9673a..2a9042f8a7
* src/third_party/icu: 9f4020916e..49ee7b1d18
* src/tools: 10de713ef5..08a61489f6
DEPS diff: 159524df35..0bba1cecba
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I0337638808176501be7154cad7fc52ab23dcefff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169039
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30617}
2020-02-26 10:35:54 +00:00