54999d411b
rtcp::Dlrr block moved into own file and got Parse function
...
BUG=webrtc:5260
Review URL: https://codereview.webrtc.org/1453973005
Cr-Commit-Position: refs/heads/master@{#11044}
2015-12-16 09:56:22 +00:00
29e2f9385b
Fix NoiseSuppression initialization behavior. This was changed when removing the ProcessingComponent inheritance in https://codereview.webrtc.org/1507683006/ .
...
BUG=webrtc:5298
Review URL: https://codereview.webrtc.org/1523323002
Cr-Commit-Position: refs/heads/master@{#11043}
2015-12-16 09:18:23 +00:00
45fd9fe92c
New macro: RTC_DEPRECATED (for annotating deprecated functions)
...
Review URL: https://codereview.webrtc.org/1494133003
Cr-Commit-Position: refs/heads/master@{#11042}
2015-12-16 09:09:25 +00:00
ed644d8c07
Roll chromium_revision bff4606..6e5b8cb (365226:365419)
...
Change log: bff4606..6e5b8cb
Full diff: bff4606..6e5b8cb
Changed dependencies:
* src/third_party/libvpx_new/source/libvpx: 2383154..ecb8dff
DEPS diff: bff4606..6e5b8cb
/DEPS
No update to Clang.
TBR=marpan@webrtc.org , stefan@webrtc.org ,
Review URL: https://codereview.webrtc.org/1530823002
Cr-Commit-Position: refs/heads/master@{#11041}
2015-12-16 04:30:19 +00:00
eb45981165
Restoring behavior where PeerConnection tracks changes to MediaStreams.
...
If a MediaStream is added to a PeerConnection, and later a track
is added to the MediaStream, a new RtpSender will now be created for
that track, and it will appear in subsequent offers.
Similarly, removed tracks will remove RtpSenders.
BUG=webrtc:5265
Review URL: https://codereview.webrtc.org/1507973003
Cr-Commit-Position: refs/heads/master@{#11040}
2015-12-16 03:24:50 +00:00
44f0819978
Fixing bug where "mid" wasn't preserved across re-offers.
...
Review URL: https://codereview.webrtc.org/1529673002
Cr-Commit-Position: refs/heads/master@{#11039}
2015-12-16 00:20:15 +00:00
c1316a1e51
Fix HPF initialization behavior. This was changed when removing the ProcessingComponent inheritance in https://codereview.webrtc.org/1490333004/ .
...
BUG=webrtc:5298
Review URL: https://codereview.webrtc.org/1525983003
Cr-Commit-Position: refs/heads/master@{#11038}
2015-12-16 00:07:32 +00:00
95d9851a6c
Add speech encoder to the encoder stack specification struct
...
BUG=webrtc:5028
Review URL: https://codereview.webrtc.org/1527933002
Cr-Commit-Position: refs/heads/master@{#11037}
2015-12-15 22:21:40 +00:00
7eb914debb
Fix incorrect comment
...
Review URL: https://codereview.webrtc.org/1524663004
Cr-Commit-Position: refs/heads/master@{#11036}
2015-12-15 22:20:29 +00:00
78315b9813
Reland of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1528043002/ )
...
Reason for revert:
Found missing public_configs that broke Chromium libfuzzer build.
Original issue's description:
> Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ )
>
> Reason for revert:
> Suspect this is breaking the build:
> https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio
>
> Original issue's description:
> > Base webrtc fuzzers on a template.
> >
> > Removes noisy dependencies on webrtc_fuzzer_main and removal of
> > find_bad_constructs, removes 1-6 lines of gn per fuzzer target.
> >
> > BUG=webrtc:4771
> > R=kjellander@webrtc.org
> >
> > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f
> > Cr-Commit-Position: refs/heads/master@{#11022}
>
> TBR=kjellander@webrtc.org ,pbos@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4771
>
> Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42
> Cr-Commit-Position: refs/heads/master@{#11032}
TBR=kjellander@webrtc.org ,tommi@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4771
Review URL: https://codereview.webrtc.org/1522003005 .
Cr-Commit-Position: refs/heads/master@{#11035}
2015-12-15 20:58:00 +00:00
f9945b2d1a
Only try to pair protocol matching candidates for creating connections.
...
If the local port and the remote candidate's protocols do not match,
do not even try to pair them.
This avoids printing out confusing logs like
"Attempt to change a remote candidate..." in p2ptransportchannel
when two remote candidates have the same port number but different
protocols.
BUG=
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1516613002 .
Cr-Commit-Position: refs/heads/master@{#11034}
2015-12-15 20:20:22 +00:00
949028fbf1
Make LevelEstimation not a ProcessingComponent.
...
BUG=webrtc:5355
Review URL: https://codereview.webrtc.org/1523483002
Cr-Commit-Position: refs/heads/master@{#11033}
2015-12-15 19:39:49 +00:00
5e0218c66e
Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ )
...
Reason for revert:
Suspect this is breaking the build:
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio
Original issue's description:
> Base webrtc fuzzers on a template.
>
> Removes noisy dependencies on webrtc_fuzzer_main and removal of
> find_bad_constructs, removes 1-6 lines of gn per fuzzer target.
>
> BUG=webrtc:4771
> R=kjellander@webrtc.org
>
> Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f
> Cr-Commit-Position: refs/heads/master@{#11022}
TBR=kjellander@webrtc.org ,pbos@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4771
Review URL: https://codereview.webrtc.org/1528043002
Cr-Commit-Position: refs/heads/master@{#11032}
2015-12-15 18:24:05 +00:00
51254331cc
Android: Refactor renderers to allow apps to inject custom shaders
...
This CL:
* Abstracts the functions in GlRectDrawer to an interface.
* Adds viewport location as argument to the draw() functions, because this information may be needed by some shaders. This also moves the responsibility of calling GLES20.glViewport() to the drawer.
* Moves uploadYuvData() into a separate helper class.
* Adds new SurfaceViewRenderer.init() function and new VideoRendererGui.create() function that takes a custom drawer as argument. Each YuvImageRenderer in VideoRendererGui now has their own drawer instead of a common one.
BUG=b/25694445
R=nisse@webrtc.org , perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1520243003 .
Cr-Commit-Position: refs/heads/master@{#11031}
2015-12-15 15:22:38 +00:00
91941ae493
rtcp::VoipMetric block moved into own file and got Parse function
...
Review URL: https://codereview.webrtc.org/1452733002
Cr-Commit-Position: refs/heads/master@{#11030}
2015-12-15 15:06:44 +00:00
32d989b3f2
Disable transport sequence numbers for audio.
...
Since this isn't fully wired up yet it shouldn't be part of the
SendSideBwe experiment yet.
BUG=webrtc:5263
R=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1523283002 .
Cr-Commit-Position: refs/heads/master@{#11029}
2015-12-15 14:55:20 +00:00
10aea22c84
Roll chromium_revision 53970fd..bff4606 (365141:365226)
...
Change log: 53970fd..bff4606
Full diff: 53970fd..bff4606
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1524143002
Cr-Commit-Position: refs/heads/master@{#11028}
2015-12-15 13:37:57 +00:00
377b5e622f
enabled cpplint for the webrtc/modules/rtp_rtcp directory
...
BUG=webrtc:5277
R=kjellander@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1528863002
Cr-Commit-Position: refs/heads/master@{#11027}
2015-12-15 12:33:51 +00:00
6eca7e3c37
Add a 'remote' property to MediaSourceInterface. Also adding an implementation to the relevant sources we have (audio/video) and an extra check where we're casting a source into a local audio source :(
...
Additionally:
* Moving all implementation inside RemoteAudioTrack into AudioTrack and remove RemoteAudioTrack.
* AddSink/RemoveSink are now on all audio sources (like they are for video sources).
While doing this I found that some of our tests are broken :) and fixed them. They were broken because AudioTrack didn't previously do much such as updating its state.
BUG=chromium:569526
Review URL: https://codereview.webrtc.org/1522903002
Cr-Commit-Position: refs/heads/master@{#11026}
2015-12-15 12:27:20 +00:00
6db6cdc604
[rtp_rtcp] fixed lint errors in rtp_rtcp module that are not fixed in other CLs
...
BUG=webrtc:5277
R=mflodman
Review URL: https://codereview.webrtc.org/1513303003
Cr-Commit-Position: refs/heads/master@{#11025}
2015-12-15 10:54:50 +00:00
9638143033
Reland of Made EglBase an abstract class and cleaned up. (patchset #1 id:1 of https://codereview.webrtc.org/1522073002/ )
...
Reason for revert:
Clients have been updated.
Original issue's description:
> Revert of Made EglBase an abstract class and cleaned up. (patchset #4 id:60001 of https://codereview.webrtc.org/1526463002/ )
>
> Reason for revert:
> Revert due breaking other clients.
>
> Original issue's description:
> > Made EglBase an abstract class and cleaned up.
> > Adds EglBase10 that implemenents EglBase for EGL 1.0
> >
> > BUG=webrtc:4993
> > TBR=glaznew@webrtc.org
> >
> > Committed: https://crrev.com/3207916f35ded33f586774e2c98d4d0089fe3c6e
> > Cr-Commit-Position: refs/heads/master@{#11011}
>
> TBR=magjed@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4993
>
> Committed: https://crrev.com/e22e1cb399748112f308b488e7535754ef6b807d
> Cr-Commit-Position: refs/heads/master@{#11013}
TBR=magjed@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4993
Review URL: https://codereview.webrtc.org/1522303004
Cr-Commit-Position: refs/heads/master@{#11024}
2015-12-15 10:48:13 +00:00
e005cf2c93
[rtp_rtcp] SSRCDatabase class cleaned (including all lint errors)
...
BUG=webrtc:5277
R=mflodman
Review URL: https://codereview.webrtc.org/1507313005
Cr-Commit-Position: refs/heads/master@{#11023}
2015-12-15 09:59:50 +00:00
5ea3da2cbb
Base webrtc fuzzers on a template.
...
Removes noisy dependencies on webrtc_fuzzer_main and removal of
find_bad_constructs, removes 1-6 lines of gn per fuzzer target.
BUG=webrtc:4771
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1524993002 .
Cr-Commit-Position: refs/heads/master@{#11022}
2015-12-15 09:46:27 +00:00
8f09f170e6
Simple CL to fix lint errors in webrtc/modules/remote_bitrate_estimator. Added the lint check for the folder to the presubmit script.
...
BUG=webrtc:5310
Review URL: https://codereview.webrtc.org/1520513003
Cr-Commit-Position: refs/heads/master@{#11021}
2015-12-15 08:52:03 +00:00
498ae00f39
Disable ThreadTest.ThreeThreadsInvoke on DrMemory bots.
...
BUG=webrtc:5199
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1524073002 .
Cr-Commit-Position: refs/heads/master@{#11020}
2015-12-15 08:46:18 +00:00
47a740bc5e
[rtp_rtcp] lint errors about rand() usage fixed.
...
rand() usage replaced with new Random class, which also makes it clearer what interval random number is in.
BUG=webrtc:5277
R=mflodman
Review URL: https://codereview.webrtc.org/1519503002
Cr-Commit-Position: refs/heads/master@{#11019}
2015-12-15 08:30:12 +00:00
2d36b9233e
Roll chromium_revision 10bf0e1..53970fd (365000:365141)
...
Change log: 10bf0e1..53970fd
Full diff: 10bf0e1..53970fd
Changed dependencies:
* src/tools/gyp: 70ee80e..b85ad3e
DEPS diff: 10bf0e1..53970fd
/DEPS
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1522153004
Cr-Commit-Position: refs/heads/master@{#11018}
2015-12-15 05:07:05 +00:00
158879305b
Fixing flaky LocalP2PTestSctpDataChannel test.
...
SCTP data channels are closed asynchronously in-band, unlike RTP
data channels, so the test must be slightly modified.
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1527833003
Cr-Commit-Position: refs/heads/master@{#11017}
2015-12-15 03:32:38 +00:00
c9be00797e
Fixing and re-enabling some flaky PeerConnection tests.
...
BUG=webrtc:3362
Review URL: https://codereview.webrtc.org/1512763003
Cr-Commit-Position: refs/heads/master@{#11016}
2015-12-15 02:28:04 +00:00
bd292465ee
Reland of Free SCTP data channels asynchronously in PeerConnection. (patchset #1 id:1 of https://codereview.webrtc.org/1513143003/ )
...
Original issue's description:
> Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset #3 id:40001 of https://codereview.webrtc.org/1492383002/ )
>
> Reason for revert:
> Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread implementation on Chromium.
>
> Original issue's description:
> > Free SCTP data channels asynchronously in PeerConnection.
> >
> > This is needed so that the data channel isn't deleted while one of its
> > own methods is on the call stack.
> >
> > BUG=565048
> >
> > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> > Cr-Commit-Position: refs/heads/master@{#10923}
>
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565048
>
> Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137
> Cr-Commit-Position: refs/heads/master@{#10977}
BUG=565048
Review URL: https://codereview.webrtc.org/1516943002
Cr-Commit-Position: refs/heads/master@{#11015}
2015-12-15 02:15:33 +00:00
82ccfcf5ca
Remove unused and rarely used LOG_ macros.
...
BUG=
Review URL: https://codereview.webrtc.org/1522053002
Cr-Commit-Position: refs/heads/master@{#11014}
2015-12-14 16:22:21 +00:00
e22e1cb399
Revert of Made EglBase an abstract class and cleaned up. (patchset #4 id:60001 of https://codereview.webrtc.org/1526463002/ )
...
Reason for revert:
Revert due breaking other clients.
Original issue's description:
> Made EglBase an abstract class and cleaned up.
> Adds EglBase10 that implemenents EglBase for EGL 1.0
>
> BUG=webrtc:4993
> TBR=glaznew@webrtc.org
>
> Committed: https://crrev.com/3207916f35ded33f586774e2c98d4d0089fe3c6e
> Cr-Commit-Position: refs/heads/master@{#11011}
TBR=magjed@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4993
Review URL: https://codereview.webrtc.org/1522073002
Cr-Commit-Position: refs/heads/master@{#11013}
2015-12-14 14:43:39 +00:00
40f349fdda
[rtp_rtcp] Lint errors cleared from rtp_rtcp/test
...
except rand() function that is subject of CL#1519503002
and namespace that is fixed in CL#1506823002
BUG=webrtc:5277
R=mflodman
Review URL: https://codereview.webrtc.org/1511413005
Cr-Commit-Position: refs/heads/master@{#11012}
2015-12-14 14:39:41 +00:00
3207916f35
Made EglBase an abstract class and cleaned up.
...
Adds EglBase10 that implemenents EglBase for EGL 1.0
BUG=webrtc:4993
TBR=glaznew@webrtc.org
Review URL: https://codereview.webrtc.org/1526463002
Cr-Commit-Position: refs/heads/master@{#11011}
2015-12-14 14:21:19 +00:00
03960d92dd
Roll chromium_revision 4bc4277..10bf0e1 (364953:365000)
...
Change log: 4bc4277..10bf0e1
Full diff: 4bc4277..10bf0e1
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1523733002
Cr-Commit-Position: refs/heads/master@{#11010}
2015-12-14 12:38:21 +00:00
bc14164aad
Revert of Add APK targets to build libjingle tests for Android. (patchset #10 id:180001 of https://codereview.webrtc.org/1511633002/ )
...
Reason for revert:
Breaks bots.
Original issue's description:
> Add APK targets to build libjingle_peerconnection_unittests for Android.
>
> BUG=webrtc:2365
>
> The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/
>
> Committed: https://crrev.com/a78c0211fd50369a75a962385db6163bd8ded239
> Cr-Commit-Position: refs/heads/master@{#11007}
TBR=kjellander@webrtc.org ,tommi@webrtc.org ,perkj@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:2365
Review URL: https://codereview.webrtc.org/1521993002
Cr-Commit-Position: refs/heads/master@{#11009}
2015-12-14 12:31:22 +00:00
b2f80e3a28
rtp_rtcp/test/BWEStandAlone deleted as obsolete
...
BUG=webrtc:5277
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1525573002
Cr-Commit-Position: refs/heads/master@{#11008}
2015-12-14 11:21:51 +00:00
a78c0211fd
Add APK targets to build libjingle_peerconnection_unittests for Android.
...
BUG=webrtc:2365
The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/
Review URL: https://codereview.webrtc.org/1511633002
Cr-Commit-Position: refs/heads/master@{#11007}
2015-12-14 10:41:37 +00:00
17821db197
Wire up bandwidth limitation info to GetStats and adapt_reason.
...
The input resolution (output from video_adapter) can be further scaled down or higher video layer(s) can be dropped due to bitrate constraints.
BUG=webrtc:4112
Review URL: https://codereview.webrtc.org/1502173002
Cr-Commit-Position: refs/heads/master@{#11006}
2015-12-14 10:08:19 +00:00
ac921d7365
Add "x"s in the end of a stripped IPv6 address string.
...
This makes it clearer that the IP address has been stripped.
BUG=chromium:254329
Review URL: https://codereview.webrtc.org/1516163003
Cr-Commit-Position: refs/heads/master@{#11005}
2015-12-14 10:07:08 +00:00
38bb8ad1ca
Add test for verifying configured key frame interval for VP9.
...
BUG=
Review URL: https://codereview.webrtc.org/1498053002
Cr-Commit-Position: refs/heads/master@{#11004}
2015-12-14 09:41:27 +00:00
e5ae6f8237
Correcting the check for the return code produced by
...
AudioProcessing::ProcessReverseStream().
Before the change, only -1 was considered to be an error.
Allthough the error code scheme for AudioProcessing definitely
could be discussed, the current scheme have many error codes that
differ from -1 and thus were not caught by the old code.
BUG=webrtc:5237
Review URL: https://codereview.webrtc.org/1515073004
Cr-Commit-Position: refs/heads/master@{#11003}
2015-12-14 07:02:40 +00:00
1d5c19d23e
Address comments from code review 1505253004
...
(https://codereview.webrtc.org/1505253004/ )
BUG=
Review URL: https://codereview.webrtc.org/1523603002
Cr-Commit-Position: refs/heads/master@{#11002}
2015-12-14 06:54:35 +00:00
4759bfb2a4
Roll chromium_revision 7de03ed..4bc4277 (364770:364953)
...
Change log: 7de03ed..4bc4277
Full diff: 7de03ed..4bc4277
Changed dependencies:
* src/third_party/usrsctp/usrsctplib: Moved from
https://chromium.googlesource.com/external/usrsctplib.git/+/36444a9
to https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+/c60ec8b
DEPS diff: 7de03ed..4bc4277
/DEPS
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1521303003
Cr-Commit-Position: refs/heads/master@{#11001}
2015-12-14 06:40:53 +00:00
aa32c3e537
Update API for Objective-C RTCIceServer
...
BUG=
Review URL: https://codereview.webrtc.org/1499653003
Cr-Commit-Position: refs/heads/master@{#11000}
2015-12-14 03:58:19 +00:00
cb95f54ee4
Remove pointless move() to fix build on clang/win.
...
Fixes:
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
^
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: note: remove std::move call here
ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
^~~~~~~~~~
R=thakis@chromium.org
TBR=thakis@chromium.org
Review URL: https://codereview.webrtc.org/1517253004 .
Cr-Commit-Position: refs/heads/master@{#10999}
2015-12-12 15:54:41 +00:00
66679dcc04
Update WARN_UNUSED_RESULT macro to match Chromium's version.
...
It also matches the one in webrtc/base/common.h
BUG=None
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1516423004
Cr-Commit-Position: refs/heads/master@{#10998}
2015-12-12 13:47:24 +00:00
be26c07cb5
Roll gtest-parallel.
...
BUG=
R=kwiberg@webrtc.org
Review URL: https://codereview.webrtc.org/1519153002
Cr-Commit-Position: refs/heads/master@{#10997}
2015-12-12 09:45:28 +00:00
b798f3883c
Roll chromium_revision 710285b..7de03ed (364599:364770)
...
Change log: 710285b..7de03ed
Full diff: 710285b..7de03ed
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1520583007
Cr-Commit-Position: refs/heads/master@{#10996}
2015-12-12 08:24:09 +00:00
f888bb58da
Support for unmixed remote audio into tracks.
...
BUG=chromium:121673
R=solenberg@webrtc.org
Review URL: https://codereview.webrtc.org/1505253004 .
Cr-Commit-Position: refs/heads/master@{#10995}
2015-12-12 00:37:14 +00:00