Commit Graph

37913 Commits

Author SHA1 Message Date
219ec71702 [PCLF] Replace MetricsLoggerAndExporter with MetricsLogger
Bug: b/246095034
Change-Id: I06b3b4eb43a3555b359e3c1aee332d5d05d1e567
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276601
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38181}
2022-09-23 14:36:28 +00:00
7b0f4a211a Introduce MetricsLogger to separate logging and export logic
Bug: b/246095034
Change-Id: If870016b87126feefb9c63b1544091f0855e169f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276600
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38180}
2022-09-23 14:00:07 +00:00
3ab76d945c Use non-recursive mutex in rtc::Thread
With rtc::Thread::Clear removed, there are no longer calls to external code while holding the mutex and thus it doesn't need to be recursive.

Bug: webrtc:11567
Change-Id: If350684be0bfcbc33806019bd986138905aec66d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276542
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38179}
2022-09-23 11:59:57 +00:00
0deda15c96 Reland "RtpEncodingParameters::request_resolution patch 1"
This reverts commit b625101da8d798c936cfd695505a5514644158b0.

Reason for revert: Found problem that was specific how
configuration is handled for VP9. A 1-line change in webrtc_video_engine.cc line 3715.
Thanks Rasmus and great that this was tested!

Original change's description:
> Revert "RtpEncodingParameters::request_resolution patch 1"
>
> This reverts commit ef7359e679e579ccb79afacf5c42e8c6020124e2.
>
> Reason for revert: Breaks downstream test
>
> Original change's description:
> > RtpEncodingParameters::request_resolution patch 1
> >
> > This patch adds RtpEncodingParameters::request_resolution
> > with documentation and plumming. No behaviour is changed yet.
> >
> > Bug: webrtc:14451
> > Change-Id: I1f4f83a312ee8c293e3d8f02b950751e62048304
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276262
> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> > Reviewed-by: Henrik Boström <hbos@webrtc.org>
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> > Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#38172}
>
> Bug: webrtc:14451
> Change-Id: I4b9590e23ec38e9e1c2e51a4600ef96b129439f2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276541
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
> Owners-Override: Björn Terelius <terelius@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38176}

Bug: webrtc:14451
Change-Id: Ica9b74180bce22d09bf289126bb5ac137bf9eb70
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276543
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38178}
2022-09-23 11:48:19 +00:00
f5808fc4c5 Enable support for both new and old perf metrics export APIs
Make it possible to use both APIs inside same test and have consistent
export results to the Chrome Perf Dashboard and stdout.

Bug: b/246095034
Change-Id: I924088a2ddcb04981e56bbeb4544ac317833fb98
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276540
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38177}
2022-09-23 11:24:57 +00:00
b625101da8 Revert "RtpEncodingParameters::request_resolution patch 1"
This reverts commit ef7359e679e579ccb79afacf5c42e8c6020124e2.

Reason for revert: Breaks downstream test

Original change's description:
> RtpEncodingParameters::request_resolution patch 1
>
> This patch adds RtpEncodingParameters::request_resolution
> with documentation and plumming. No behaviour is changed yet.
>
> Bug: webrtc:14451
> Change-Id: I1f4f83a312ee8c293e3d8f02b950751e62048304
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276262
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38172}

Bug: webrtc:14451
Change-Id: I4b9590e23ec38e9e1c2e51a4600ef96b129439f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276541
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Owners-Override: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38176}
2022-09-23 08:27:47 +00:00
25e4156e3e Add Fuchsia platform deps
Bug: b/232740856
Change-Id: Ia0c14753262f2d66e2bb2aa794ecf5124a016835
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38175}
2022-09-23 07:49:47 +00:00
aed9fa28dc Update WebRTC code version (2022-09-23T04:11:42).
Bug: None
Change-Id: Ibc612471a49d0052dade4d7981caa18fe1a80387
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276524
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38174}
2022-09-23 05:14:47 +00:00
9790e546fc Adapt generate_sslroots.py to work with different openssl versions
Command [1] on openssl 1.1.1m and newer generates output
containing "unsigned char the_(subject_name|public_key|certificate)"
records, making it incompatible with current version of the script
that relies on "unsigned char XXX_".

This patch handles both cases by using regular expression so as
to match strings and provide an adequate replacement.

[1] - openssl x509 -in <path-to-cacert.pem> -noout -C

Bug: webrtc:11710
Change-Id: I46b87d2980ec2dd26660b93fcf9019254950ce12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257420
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38173}
2022-09-22 15:15:20 +00:00
ef7359e679 RtpEncodingParameters::request_resolution patch 1
This patch adds RtpEncodingParameters::request_resolution
with documentation and plumming. No behaviour is changed yet.

Bug: webrtc:14451
Change-Id: I1f4f83a312ee8c293e3d8f02b950751e62048304
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276262
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38172}
2022-09-22 14:16:20 +00:00
42f5fe540c Roll chromium_revision e120330982..2fe18c5940 (1050012:1050141)
Change log: e120330982..2fe18c5940
Full diff: e120330982..2fe18c5940

Changed dependencies
* src/base: ceb3ee4665..0efc92e419
* src/build: 7f9e4937ff..7fcdda4d2b
* src/ios: 27c681822d..17d8594fb9
* src/testing: 6ebcf5bed6..9df4b2c558
* src/third_party: c22e103639..3deedbc463
* src/third_party/androidx: 57GvG50OUQda15ok8arvlweTpZAfD2QHyBuSpD1-LY0C..b_Q5YZffVu01kaZODWwf-JnDH9QK1dox5RHMfSJ8LDQC
* src/third_party/perfetto: b2829a1f2f..768b3f2265
* src/tools: 7239be320c..35efe9a8f5
DEPS diff: e120330982..2fe18c5940/DEPS

No update to Clang.

BUG=None

Change-Id: Iec0d089a38c875aa0277d0a24ed05d5b224e2320
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276329
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38171}
2022-09-22 12:38:32 +00:00
636dc3d208 Implement RTCOutboundRtpStreamStats.targetBitrate for video
Spec: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-targetbitrate

Bug: webrtc:13394
Change-Id: I4749b38088a24d1a775137d5fe2c65f96effd185
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276380
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38170}
2022-09-22 12:37:30 +00:00
6a49fb2d5f [DVQA] Fix: cpu_usage was exported as cpu_usage_% before
Bug: b/246095034
Change-Id: I082865fadf69f11ec05dec32e5ec22deaef98db7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276400
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38169}
2022-09-22 11:50:20 +00:00
8e0fc17204 Add a video codec timeout error code
Reporting timeouts is useful for native hw backed codec implementations.
The value is in sync with VideoCodecStatus.java in the Android sdk.

Bug: b/185740707
Change-Id: I9a08a1303586c677be53aaa4f39455f42e519996
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276042
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Auto-Submit: Linus Nilsson <lnilsson@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38168}
2022-09-22 10:49:10 +00:00
27b04c8203 Update WebRTC code version (2022-09-22T04:02:49).
Bug: None
Change-Id: I53e9f835f629d7065410c02d70f8defcaee104b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276324
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38167}
2022-09-22 06:39:50 +00:00
29a0e2716c Roll chromium_revision 314904fc7b..e120330982 (1049894:1050012)
Change log: 314904fc7b..e120330982
Full diff: 314904fc7b..e120330982

Changed dependencies
* src/base: 281cd0d741..ceb3ee4665
* src/build: f94ac0b924..7f9e4937ff
* src/buildtools/third_party/libunwind/trunk: 77b82eb53f..7ff728a977
* src/ios: 7ac550586b..27c681822d
* src/testing: db89dffa3f..6ebcf5bed6
* src/third_party: 55be2905eb..c22e103639
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0a4b3b9b9c..5b90d5e756
* src/third_party/perfetto: 40b17af5c5..b2829a1f2f
* src/tools: 7ba9528c49..7239be320c
DEPS diff: 314904fc7b..e120330982/DEPS

No update to Clang.

BUG=None

Change-Id: Ic59250e9d87e103fd56bda1e3dc54f0451cd0b59
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276323
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38166}
2022-09-22 02:41:30 +00:00
a53bfdbe1c Roll chromium_revision cf0596b83b..314904fc7b (1049743:1049894)
Change log: cf0596b83b..314904fc7b
Full diff: cf0596b83b..314904fc7b

Changed dependencies
* src/base: c63de037b5..281cd0d741
* src/build: 02d11d1f80..f94ac0b924
* src/buildtools: dea2dd1d45..b79692f320
* src/buildtools/third_party/libc++/trunk: cec1dd0bf6..a4dc7f17ca
* src/ios: 6aa9a21b3d..7ac550586b
* src/testing: 25f94b2ea6..db89dffa3f
* src/third_party: 211f9164cc..55be2905eb
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/19009c51bf..04989786e9
* src/third_party/depot_tools: 0d126c974c..08bb5c487f
* src/third_party/perfetto: 3a9f96aecc..40b17af5c5
* src/tools: 8fccbbc4ad..7ba9528c49
DEPS diff: cf0596b83b..314904fc7b/DEPS

No update to Clang.

BUG=None

Change-Id: I0c79e98b88315c7c3521ec98de6e251908694456
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276322
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38165}
2022-09-21 23:26:10 +00:00
f5042567c0 Roll chromium_revision 6eebdbd552..cf0596b83b (1049590:1049743)
Change log: 6eebdbd552..cf0596b83b
Full diff: 6eebdbd552..cf0596b83b

Changed dependencies
* src/base: fe13802294..c63de037b5
* src/build: 621ff0c805..02d11d1f80
* src/ios: e82cdb2893..6aa9a21b3d
* src/testing: aacd752afe..25f94b2ea6
* src/third_party: 3b51b4632a..211f9164cc
* src/third_party/harfbuzz-ng/src: fa471043fc..56c4670935
* src/third_party/libyuv: f71c83552d..f9fda6e7d8
* src/third_party/r8/d8: vKZR8R88hGbFuOFG9Z_QBBK7TqYCAub34XjJ2TAwhW4C..Qn31g4m2cofkyvGgm46Uzkzds5DKdNYrdPePwRkVnv4C
* src/tools: 316dabacc6..8fccbbc4ad
DEPS diff: 6eebdbd552..cf0596b83b/DEPS

No update to Clang.

BUG=None

Change-Id: Ib45d1ed1937dcd0d6d478950c2187dfb0652f295
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276320
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38164}
2022-09-21 19:22:39 +00:00
f68a06c34b [PCLF] Cleanup old video dumping API
Bug: b/240540206
Change-Id: I1184f3f73a6de430e7103783b8959d8ff222e31e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270485
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38163}
2022-09-21 16:58:22 +00:00
7b3d61ccf0 Add test coverage for P2PTransportChannel refactor (#8/8)
This converts all P2PTransportChannel unit tests to parameterized tests, with a string parameter for the field_trials which is used to enable the refactor. This adds a variation of each existing test using the refactored code path.

Tests are initialized twice, once for legacy and refactored path each, to strike a balance between file name length and descriptiveness.

Bug: webrtc:14367, webrtc:14131
Change-Id: I0469550d571ed389804eb486fe5bd22504e59373
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275303
Commit-Queue: Sameer Vijaykar <samvi@google.com>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38162}
2022-09-21 16:49:02 +00:00
3680605caa [PCLF] Enable exporting of perf metric via new API
Bug: b/246095034
Change-Id: I05f28e5dfc6df793c035110f89d9ac40783687f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276267
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38161}
2022-09-21 15:55:09 +00:00
cbad8add12 Delete rtc::Message and rtc::MessageHandler
Bug: webrtc:9702
Change-Id: I5b9a42264b2a84acce9096b21102233b4ed2f5ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276261
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38160}
2022-09-21 15:15:30 +00:00
65ab3460f5 PCLF: Pass all frames to OnFrameEncoded, even if discarded by SFU
If we don't pass the frames to OnFrameEncoded, we can't see the frames
being sent in the SVC tests. We want to check the frames even if the
SFU would discard them later.

Bug: webrtc:11607
Change-Id: I5b9c6a86c0966047efa7be088f90e83e01f7900b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273350
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38159}
2022-09-21 15:06:39 +00:00
f7bc5429b8 [PCLF] Fix test case for network metrics exported through new API
Bug: b/246095034
Change-Id: Ie3415c7119d5554c0f39670de199b0a545949121
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276266
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38158}
2022-09-21 14:06:52 +00:00
d95345484d [PCLF] Fix exported test case for audio analyzer through new metrics API
Bug: b/246095034
Change-Id: I94592e65f1bd33e82af83bf4f839351efcc42e62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276265
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38157}
2022-09-21 14:05:50 +00:00
8da280282b [DVQA] Fix: allow export cpu_usage through new perf metrics API
Bug: b/246095034
Change-Id: I646ec0b1adf6d1285eb7c39ff65c4a68395bd6aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276264
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38156}
2022-09-21 13:31:22 +00:00
45c6f5e2e1 Change StdoutMetricsExporter format to improve readability
Change from
<test case>/<metric name>

to
<test case> / <metric name>

to increase readability when <test case> itself contains "/" or
<metric name> contains "/"

Bug: b/246095034
Change-Id: If870fdcac37275aecf87e7d57e8aada05a5ef454
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276263
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38155}
2022-09-21 13:30:11 +00:00
b2ccd85269 Roll chromium_revision d6e44055b0..6eebdbd552 (1049465:1049590)
Change log: d6e44055b0..6eebdbd552
Full diff: d6e44055b0..6eebdbd552

Changed dependencies
* src/base: 2f2e9d2c35..fe13802294
* src/ios: d78428f0ea..e82cdb2893
* src/testing: 246612cc20..aacd752afe
* src/third_party: b5cbeea4e0..3b51b4632a
* src/tools: 4a2b520355..316dabacc6
DEPS diff: d6e44055b0..6eebdbd552/DEPS

No update to Clang.

BUG=None

Change-Id: Ib44fd2ec203f74c4975b0c11385892bb4d5a0c9d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276221
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38154}
2022-09-21 13:24:01 +00:00
bc4796af94 Add the dependency descriptor for H.264 temporal scalability
And validate it using svc_e2e_tests.

Bug: webrtc:13961
Change-Id: Ie7edcf5a0684f46e4d26155b77cebbebbd46d21f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269541
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38153}
2022-09-21 12:18:23 +00:00
8eeb9b03a8 RtpPacketInfo: deprecated ctors and getter removed
Bug: webrtc:10739, b/246753278
Change-Id: I04d8a7886a7a1be7e155300a0c0ff3266fe6f28b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275944
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38152}
2022-09-21 12:00:56 +00:00
a18144182d Dont send probe if NetworkStateEstimate.link_capacity_upper=DataRate::Zero
Bug: webrtc:14392
Change-Id: I7df34239f3f9ef27a26d04a16e6f3edf3e45d4bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276183
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38151}
2022-09-21 11:59:46 +00:00
d44e3410b6 Delete rtc::Thread functions that use rtc::MessageHandler
Bug: webrtc:9702
Change-Id: I6fc8aa8a793caf19d62a149db1861c352c609255
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275774
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38150}
2022-09-21 11:33:47 +00:00
52dd1a566a Reland "Add an active ICE controller that wraps a legacy controller (#7/n)"
This is a reland of commit 6326c9c201c7331d68c9beb0a93f6f6e21063cd2

Original change's description:
> Add an active ICE controller that wraps a legacy controller (#7/n)
>
> The wrapping ICE controller will allow existing ICE controller implementations to migrate to the active interface, and eventually deprecate the legacy interface.
>
> Follow-up CL has unit tests for P2PTransportChannel using the new wrapping controller.
>
> Bug: webrtc:14367, webrtc:14131
> Change-Id: I6c517449ff1e503e8268a7ef91afda793723fdeb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275302
> Reviewed-by: Per Kjellander <perkj@webrtc.org>
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
> Commit-Queue: Sameer Vijaykar <samvi@google.com>
> Cr-Commit-Position: refs/heads/main@{#38130}

Bug: webrtc:14367, webrtc:14131
Change-Id: I5662595db1df8c06b3acac9b39749f236906fa7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276044
Auto-Submit: Sameer Vijaykar <samvi@google.com>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38149}
2022-09-21 11:02:26 +00:00
2f650fa822 JitterEstimator: remove unnecessary helper functions
Move functionality to closer where the values are used instead,
as per previous CL comment.

Bug: webrtc:14151
Change-Id: I6b7ca02da197420a1f5da930ba87021e6f557444
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275204
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38148}
2022-09-21 10:42:57 +00:00
d795c8bd16 [PCLF] Add possibility to use new perf metrics api in CrossMediaMetricsReporter
Bug: b/246095034
Change-Id: I8d6dd352cb12ee2b729bb534a1646b178fe0b6db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276181
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38147}
2022-09-21 08:33:20 +00:00
86f2022f0e [PCLF] Add possibility to use new perf metrics api in NetworkQualityMetricsReporter
Bug: b/246095034
Change-Id: I5198d73aaf2b32b59c9c15504628d0edd2bd9885
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276201
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38146}
2022-09-21 08:26:10 +00:00
e11d5e378c [DVQA] Add ability to export metrics with MetricsLoggerAndExporter
Bug: b/246095034
Change-Id: Ibbadd11ff27f65cc128efd891eace89df3c59316
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276101
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38145}
2022-09-21 08:15:30 +00:00
2d1907bfd2 [PCLF] Add possibility to use new perf metrics api in DefaultAudioQualityAnalyzer
Bug: b/246095034
Change-Id: I045fd739ac31c0f13ee46adc831063d9773c39c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38144}
2022-09-21 08:13:40 +00:00
c9f66907fc [PCLF] Add possibility to use new perf metrics api in StatsBasedNetworkQualityMetricsReporter
Bug: b/246095034
Change-Id: Iaba2b0656978552482754d8170afe356f3715f6a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276200
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38143}
2022-09-21 08:01:20 +00:00
164bb2fcca [PCLF] Add possibility to use new perf metrics api in VideoQualityMetricsReporter
Bug: b/246095034
Change-Id: Ia7a50404750538a65042562bd80f0cb88f78ab90
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276102
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38142}
2022-09-21 07:25:10 +00:00
a5d2c7ecd6 Introduce PrintResultProxyMetricsExporter for migration from old to new API
Bug: b/246095034
Change-Id: I7597ddad84c4b2af1d59e38c558b1f0f56bd3f4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276047
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38141}
2022-09-21 06:52:30 +00:00
8647a87aad Roll chromium_revision 27f761b8fc..d6e44055b0 (1049360:1049465)
Change log: 27f761b8fc..d6e44055b0
Full diff: 27f761b8fc..d6e44055b0

Changed dependencies
* src/base: a36f116e19..2f2e9d2c35
* src/build: 962a85627c..621ff0c805
* src/buildtools: 9e95466b9c..dea2dd1d45
* src/buildtools/third_party/libc++/trunk: d128f2b2f6..cec1dd0bf6
* src/ios: dec108b07b..d78428f0ea
* src/testing: ba5ed6fc05..246612cc20
* src/third_party: 6babc0d677..b5cbeea4e0
* src/third_party/android_build_tools/manifest_merger: tAZpJUnwhFBJmu1ctEKYMLJp7l3qJufDu7ByW6waq3QC..XhGZiPc3z6aGVUr2C_t4rtWPdqtON_KEjj1eAl4ubgAC
* src/tools: 6bb1f4a7a0..4a2b520355
DEPS diff: 27f761b8fc..d6e44055b0/DEPS

No update to Clang.

BUG=None

Change-Id: If97c4be806436cb4b67fad97c82d597d491f13a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276141
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38140}
2022-09-21 04:45:10 +00:00
f22c6b4a07 Simplify creation of SvcTestParameters in pc/test/svc_e2e_tests.cc
No functional changes are intended.

Bug: None
Change-Id: I361b04da5ed22e12951d8bcc1d16e4e4d00985d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275901
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#38139}
2022-09-21 01:13:10 +00:00
f8adc56343 Roll chromium_revision 3b9b8275bb..27f761b8fc (1049219:1049360)
Change log: 3b9b8275bb..27f761b8fc
Full diff: 3b9b8275bb..27f761b8fc

Changed dependencies
* src/base: a1736115d5..a36f116e19
* src/build: b4d6d93f62..962a85627c
* src/ios: 5a6fe0dd19..dec108b07b
* src/testing: 15fe4b1792..ba5ed6fc05
* src/third_party: 4d9712dee1..6babc0d677
* src/third_party/depot_tools: 18bdadc98a..0d126c974c
* src/tools: 1d27568595..6bb1f4a7a0
DEPS diff: 3b9b8275bb..27f761b8fc/DEPS

No update to Clang.

BUG=None

Change-Id: I6e6e81506259daf50599211f1d1734d34ece3bad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276082
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38138}
2022-09-20 22:25:50 +00:00
539c1da98d Rename Metric Units: kTimeMs->kMilliseconds and kSizeInBytes->kBytes
Rename C++ API units to match new proto format units in metric.proto

Bug: b/246095034
Change-Id: Ice5d388a080c474f275ef597f98fac1bcb98cf49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276100
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38137}
2022-09-20 21:54:21 +00:00
bffecb3894 Roll chromium_revision 67615457cd..3b9b8275bb (1049045:1049219)
Change log: 67615457cd..3b9b8275bb
Full diff: 67615457cd..3b9b8275bb

Changed dependencies
* src/base: eb60d06a1c..a1736115d5
* src/build: 29d79901a5..b4d6d93f62
* src/ios: 492b2d9a6c..5a6fe0dd19
* src/testing: b1e0054153..15fe4b1792
* src/third_party: ed98dfc1db..4d9712dee1
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fcf15b9b7b..0a4b3b9b9c
* src/third_party/perfetto: c47b09bb32..3a9f96aecc
* src/third_party/r8/d8: 9D5mlKXcvEeq8EeDZf3NXnhO5BuGy0eDy5q1hLou4WwC..vKZR8R88hGbFuOFG9Z_QBBK7TqYCAub34XjJ2TAwhW4C
* src/tools: 9ffddbc42e..1d27568595
DEPS diff: 67615457cd..3b9b8275bb/DEPS

No update to Clang.

BUG=None

Change-Id: Idfae71bfb54113a10105ef871525c80ae153426a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276080
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38136}
2022-09-20 19:06:30 +00:00
01f3841e38 Fix: convert mean and stddev values when exporting to CPD
Also simplify exporter implementation

Bug: b/246095034
Change-Id: I656f17f7ee63d26445f3e420f3d22c52f336fa21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276049
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38135}
2022-09-20 18:40:30 +00:00
a3253e35b1 Fix test name in StdoutMetricsExporterTest
Bug: b/246095034
Change-Id: I645cc8de065ce34af49bb1c4cd633e3d7ef64bda
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276048
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38134}
2022-09-20 17:51:40 +00:00
a163ea4515 Add tests for H264 SVC support
The tests require H264 to be enabled using the proprietary_codecs
GN args.gn option.

Bug: webrtc:11607, webrtc:13961
Change-Id: I22dc3d94c844873ac12b9dce8e88a97f4fcf7657
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276046
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#38133}
2022-09-20 17:27:12 +00:00
c69188d15a AudioProcessingImpl: Add input volume unit tests
Bug: webrtc:7494
Change-Id: I5a32359cacfb7cd6b610ae13b95f92283c761362
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275500
Commit-Queue: Hanna Silen <silen@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38132}
2022-09-20 15:29:59 +00:00