This is the first step towards getting rid of gflags as a dependency.
It has been causing us extra work for a long time since it's not present
in Chromium as one example.
BUG=webrtc:7644
NOTRY=True
Review-Url: https://codereview.webrtc.org/2874403003
Cr-Commit-Position: refs/heads/master@{#18157}
Add AdaptCounter class which holds the number of downgrade counts per degradation way (resolution/fps) and reason (cpu/quality).
BUG=webrtc:7607
Review-Url: https://codereview.webrtc.org/2871623002
Cr-Commit-Position: refs/heads/master@{#18156}
For every failing test, the solution was either to do a "has IPv4" check
before the test is run, or avoid depending on real network interfaces
altogether.
This specifically fixes rtc_unittests, peerconnection_unittests, and
webrtc_nonparallel_tests.
BUG=None
Review-Url: https://codereview.webrtc.org/2881973002
Cr-Commit-Position: refs/heads/master@{#18155}
This header is only included by .S files and they are not parsed by
GN, so no other changes are required.
BUG=webrtc:7617
Review-Url: https://codereview.webrtc.org/2883033002
Cr-Commit-Position: refs/heads/master@{#18154}
This header was not tracked by a GN target and in the discussion on
https://bugs.chromium.org/p/webrtc/issues/detail?id=7617 we decided
to also move it under webrtc/base.
I checked in chromium code search and it seems safe to move it
without creating a stub header in webrtc/system_wrappers.
BUG=webrtc:7617
Review-Url: https://codereview.webrtc.org/2882673002
Cr-Commit-Position: refs/heads/master@{#18151}
This CL moves the residual echo detector to reside outside of
the band-scheme in APM. The benefit of this is that the
residual echo detector will then no longer enforce the
band-splitting to be used when it is the only active component
inside APM.
This CL also introduces diagnostic dumping of data inside the
residual echo detector.
BUG=webrtc:6220, webrtc:6183
Review-Url: https://codereview.webrtc.org/2884593002
Cr-Commit-Position: refs/heads/master@{#18150}
This will avoid failing with a non-zero exit code when git commit
fails due to no changes to be rolled.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2883833003
Cr-Commit-Position: refs/heads/master@{#18146}
It's diverged enough from the original version that we no longer
benefit from keeping the old formatting.
BUG=NONE
Review-Url: https://codereview.webrtc.org/2854533002
Cr-Commit-Position: refs/heads/master@{#18129}
The crash occurs if a slot causes the very next slot in iteration order
to be disconnected.
Relanding after fixing a race condition that this CL revealed. Previously
the race resulted in an invalidated iterator, but now it will result in the
iterator being modified, so TSan catches it.
BUG=webrtc:7527
Review-Url: https://codereview.webrtc.org/2846593005
Cr-Commit-Position: refs/heads/master@{#18124}
Since we now have a directory for this kind of checks, let's move this
to that location.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2870393006
Cr-Commit-Position: refs/heads/master@{#18122}
There were too many assumptions of the fact that the check was running
on Linux.
BUG=webrtc:7635
NOTRY=True
Review-Url: https://codereview.webrtc.org/2878733004
Cr-Commit-Position: refs/heads/master@{#18120}
VirtualSocketServer and Sha1Digest (from rtc_base)
md5.h and md5.cc (from rtc_base_approved, Md5Digest was moved earlier)
BUG=None
Review-Url: https://codereview.webrtc.org/2875933002
Cr-Commit-Position: refs/heads/master@{#18119}
The "ice_server_url" key is always present in AppRTC server's JSON response but may be empty if no ICE server is wanted.
BUG=webrtc:7636
Review-Url: https://codereview.webrtc.org/2878673002
Cr-Commit-Position: refs/heads/master@{#18118}
Reason for revert:
Re-land the original CL because the reverting it didn't fix the problem.
Original issue's description:
> Revert of Make AudioSinkInterface::Data hold a const pointer to the audio buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2873803002/ )
>
> Reason for revert:
> Reverted because it possibly breaks the internal project.
>
> Original issue's description:
> > Make AudioSinkInterface::Data hold a const pointer to the audio buffer.
> >
> > This is in preparation for https://codereview.webrtc.org/2750783004/, where
> > requiring a non-const pointer for AudioSinkInterface would force an unmuting
> > and zeroing of every frame.
> >
> > BUG=webrtc:7343
> >
> > Review-Url: https://codereview.webrtc.org/2873803002
> > Cr-Commit-Position: refs/heads/master@{#18107}
> > Committed: 38605965bd
>
> TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7343
>
> Review-Url: https://codereview.webrtc.org/2877013002
> Cr-Commit-Position: refs/heads/master@{#18112}
> Committed: c904634823TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7343
Review-Url: https://codereview.webrtc.org/2880663003
Cr-Commit-Position: refs/heads/master@{#18113}
Reason for revert:
Reverted because it possibly breaks the internal project.
Original issue's description:
> Make AudioSinkInterface::Data hold a const pointer to the audio buffer.
>
> This is in preparation for https://codereview.webrtc.org/2750783004/, where
> requiring a non-const pointer for AudioSinkInterface would force an unmuting
> and zeroing of every frame.
>
> BUG=webrtc:7343
>
> Review-Url: https://codereview.webrtc.org/2873803002
> Cr-Commit-Position: refs/heads/master@{#18107}
> Committed: 38605965bdTBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7343
Review-Url: https://codereview.webrtc.org/2877013002
Cr-Commit-Position: refs/heads/master@{#18112}
