zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
37,812 Commits 1 Branch 0 Tags
6a1320c2c0d260518c1ddc0c3593d2769be15bb3
Commit Graph

37812 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Peter Kasting
2f1a4370d5 Avoid sending wide strings to narrow streams. 
This overload was removed in C++20.

Bug: chromium:1284275
Change-Id: I67a25ae23fa111e4972d1b207f1c078da13d86a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269440
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#37630}
 2022-07-27 19:08:19 +00:00
landrey
21e0706ddf Fix auto roller. Add new webrtc only dependency 
Bug: b/240372657
Change-Id: Ib298d0cc122115e57838e8aca87935ef2e239b4d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269217
Auto-Submit: Andrey Logvin <landrey@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#37629}
 2022-07-27 16:53:05 +00:00
landrey
6f24817158 Manual roll of DEPS file to update package names 
Bug: b/240372657
Change-Id: I666c55c82cba1d49bb0923cfdecbe1143a639dc8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269205
Auto-Submit: Andrey Logvin <landrey@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#37628}
 2022-07-27 15:16:45 +00:00
Danil Chapovalov
300a230f16 Delete inter arrival jitter rtcp packet as unused 
WebRTC doesn't produces such packet and ignores it when receive.

Bug: None
Change-Id: I4af8cb3308cb2422808bdfc420a85fa175085bfb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269181
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37627}
 2022-07-27 14:53:05 +00:00
Erik Språng
23370f22c1 Remove unused field trial WebRTC-ReducedJitterDelayKillSwitch. 
Bug: None
Change-Id: I8747e63d5c237dce6516b69db95035728ca9965c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269206
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37626}
 2022-07-27 13:28:35 +00:00
Henrik Boström
808a8fc29e TrackMediaInfoMap: Use rtc::ArrayView in Initialize. 
Drive-by improvement as suggested in
https://webrtc-review.googlesource.com/c/src/+/269404.

Bug: webrtc:14289
Change-Id: Ib6579916cb4ab1076c1522275b318859400b731e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269202
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37625}
 2022-07-27 11:28:25 +00:00
Henrik Boström
fc67b455e6 [ModernStats] Replace uses of std::unique_ptr<> with absl::optional<>. 
Optional better describes "optionality" so let's do it for the sake of
style. But a side-effect of switching to optional may be better memory
locality than std::unique_ptr<>. (Anecdotally I saw a pprof suggesting a
significant amount of time being spent allocating/reading these maps.
This CL is unlikely to make the difference but it can't hurt.)

Bug: webrtc:14289
Change-Id: I7dcea9625b95c2f1a23e7d9595d27b58883570e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269404
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37624}
 2022-07-27 11:18:41 +00:00
Erik Språng
16ddaa71c7 Remove legacy WebRTCFakeNetwork field trials. 
This CL removes the old WebRTC-FakeNetwork(Send|Receive)[Param] field
trials. Instead, use the paremterized WebRTC-FakeNetworkSendConfig and
WebRTC-FakeNetworkSendConfig.

As an example, instead of WebRTC-FakeNetworkSendLossPercent/5/ you can
use WebRTC-FakeNetworkSendConfig/loss_percent:5/

Bug: webrtc:14238
Change-Id: Ib0021c5425e59688a5043a6285d9baccf2234a3d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269405
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37623}
 2022-07-27 07:33:15 +00:00
webrtc-version-updater
cbe64b5e49 Update WebRTC code version (2022-07-27T04:05:01). 
Bug: None
Change-Id: Iae818a01254a133c2be139302dcadaccf672a31b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269501
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37622}
 2022-07-27 05:13:14 +00:00
chromium-webrtc-autoroll
575a3cbbf5 Roll chromium_revision 4382d0306b..0296d79495 (1028104:1028209) 
Change log: 4382d0306b..0296d79495
Full diff: 4382d0306b..0296d79495

Changed dependencies
* src/base: 1abd7d8ef6..0f9274b716
* src/build: 8ec71a44aa..a5cca5e606
* src/ios: 9b650ef18f..24175a4d25
* src/testing: 7b036c0031..a31fb65100
* src/third_party: 598f979b9d..6d1441fadf
* src/third_party/fuchsia-sdk/sdk: version:9.20220722.3.1..version:9.20220726.0.1
* src/third_party/perfetto: e19e4f253f..edae25d0fa
* src/tools: 06a2e8dacd..2cfd4231f3
DEPS diff: 4382d0306b..0296d79495/DEPS

No update to Clang.

BUG=None

Change-Id: Ib8b7efd4a88eab7c63e29e254e1c7cc4fe5c7bf3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269485
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37621}
 2022-07-26 13:22:19 +00:00
Erik Språng
93b107d0f0 Remove unused field trial WebRTC-JitterUpperBound 
Bug: webrtc:9898
Change-Id: I89f2baca9b96fc00fc73d24086e7c6f5ed8307a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269401
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37620}
 2022-07-26 10:21:04 +00:00
Danil Chapovalov
6e7c2685e3 Allow recursive check for RTC_DCHECK_RUN_ON macro 
instead of using Lock/Unlock attributes, use Assert attribute to annotate code is running on certain task queue or thread.

Such check better matches what is checked, in particular allows to
recheck (and thus better document) currently used task queue

Bug: None
Change-Id: I5bc1c397efbc8342cf7915093b578bb015c85651
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269381
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37619}
 2022-07-26 09:27:23 +00:00
Erik Språng
a3f2e72008 Fix potential UAF in unit test. 
In WebRtcVideoChannelBaseTest.EncoderSelectorSwitchCodec a mock encoder
selecter or stack allocated and then registered with the channel.
Since this test uses real-time clocks/threads, there is a chance that
the selector callback will be called after the mock goes out of scope,
but before the test had time to be torn down.

This CL fixes that by simply de-registering the callback before the
end of the test.

Bug: b/239855550
Change-Id: Ibb38a914933494fd04c963b9a13f2cc4aee160d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269402
Auto-Submit: Erik Språng <sprang@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37618}
 2022-07-26 09:19:34 +00:00
Erik Språng
5793ed8ff9 Remove unused field trial WebRTC-SendBufferSizeBytes 
Bug: webrtc:9637
Change-Id: Ie4bf5caa3977f1824f6dc1014b1feacf6ebfe670
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269386
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37617}
 2022-07-26 07:26:14 +00:00
chromium-webrtc-autoroll
7494da36e5 Roll chromium_revision 9112d51f0c..4382d0306b (1027915:1028104) 
Change log: 9112d51f0c..4382d0306b
Full diff: 9112d51f0c..4382d0306b

Changed dependencies
* src/base: 9e20f19139..1abd7d8ef6
* src/build: 177d0c1f25..8ec71a44aa
* src/ios: d915cc44c8..9b650ef18f
* src/testing: 1fe32c0d6a..7b036c0031
* src/third_party: 4b1db57011..598f979b9d
* src/third_party/android_deps/libs/com_google_android_material_material: version:2@1.6.0-alpha01.cr1..version:2@1.7.0-alpha02.cr1
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1157c80fa7..03071f1766
* src/third_party/perfetto: e4d93e430c..e19e4f253f
* src/tools: c4b62b440c..06a2e8dacd
DEPS diff: 9112d51f0c..4382d0306b/DEPS

Clang version changed llvmorg-15-init-15652-g89a99ec9:llvmorg-15-init-17529-ga210f404
Details: 9112d51f0c..4382d0306b/tools/clang/scripts/update.py

BUG=None

Change-Id: I6914455ba1295ecf2d8d6323b0bcc495a32401a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269480
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37616}
 2022-07-26 05:13:04 +00:00
chromium-webrtc-autoroll
e768606729 Roll chromium_revision 9f7913411b..9112d51f0c (1027779:1027915) 
Change log: 9f7913411b..9112d51f0c
Full diff: 9f7913411b..9112d51f0c

Changed dependencies
* src/base: a8f3439577..9e20f19139
* src/build: 0c1cd20316..177d0c1f25
* src/ios: 980eb3c5b4..d915cc44c8
* src/testing: a0e4a2f46b..1fe32c0d6a
* src/third_party: cb65df5ccd..4b1db57011
* src/third_party/freetype/src: 275b116b40..9a00282efc
* src/third_party/perfetto: 049a4290ea..e4d93e430c
* src/tools: 9cc9e08ce1..c4b62b440c
DEPS diff: 9f7913411b..9112d51f0c/DEPS

No update to Clang.

BUG=None

Change-Id: I18b056d803e2357680ae21d8e3d0c6b19c4c62ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269369
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37615}
 2022-07-25 21:13:08 +00:00
Erik Språng
d460c31309 Make sure VideoStream target bitrate is not higher than max. 
Bug: webrtc:14017
Change-Id: Ic59811f4ec84e429839440cea8a70c05d7795cc4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269388
Auto-Submit: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37614}
 2022-07-25 20:34:48 +00:00
Danil Chapovalov
8743db9865 Cleanup congestion controller min bitrate 
Replace helper functions with the constant

Remove option to set min bitrate in RemoteBitrateEstimator as unused:
ReceivedSideCongestionController is the only user of the
RemoteBitrateEstimator interface, and it always sets the same value
right after construction that RemoteBitreateEstimators already use.

Bug: None
Change-Id: If179fdd72b1ded6ad1fd0a6dfffc97b302153322
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269383
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37613}
 2022-07-25 17:31:28 +00:00
chromium-webrtc-autoroll
491e4e06aa Roll chromium_revision f99b8dca37..9f7913411b (1027650:1027779) 
Change log: f99b8dca37..9f7913411b
Full diff: f99b8dca37..9f7913411b

Changed dependencies
* src/base: 27d6f84380..a8f3439577
* src/build: fc63bd6317..0c1cd20316
* src/buildtools: 1732a39f26..af18ab7c6f
* src/buildtools/third_party/libc++/trunk: 476d5aefd9..6c8f712bc4
* src/ios: ac4975df42..980eb3c5b4
* src/testing: 1647ea28d7..a0e4a2f46b
* src/third_party: daa217beda..cb65df5ccd
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/192679c021..1157c80fa7
* src/third_party/perfetto: c9aa8a4ab3..049a4290ea
* src/tools: 76090733e4..9cc9e08ce1
DEPS diff: f99b8dca37..9f7913411b/DEPS

No update to Clang.

BUG=None

Change-Id: I61b09c5b200d8e84ab5852bf2d61c0c6297d0012
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269367
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37612}
 2022-07-25 17:06:47 +00:00
Erik Språng
06a6f3f818 Make PrioritizedPacketQueue the default. 
Keeping the field trial around as a kill-switch for another milestone.

Bug: webrtc:11340
Change-Id: I3285baefab176f541cbb5ed3bacbc669d3e8836f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269384
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37611}
 2022-07-25 16:24:58 +00:00
Tommi
ed6b586b62 Make OnEncodedFrame and OnDecodableFrameTimeout expectations consistent. 
Fix call in FrameBuffer3Proxy to OnDecodableFrameTimeout to match with
FrameBuffer2Proxy and how OnEncodedFrame is called.

Bug: none
Change-Id: I6f5f18bd9a425aa55f5826654b24c2c0ee5af5f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269302
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37610}
 2022-07-25 13:43:48 +00:00
Danil Chapovalov
fc22dfa727 In RemoteEstimatorProxy treat zero arrival time as valid 
Inserting packet with zero arrival time may trigger inconsistent state in the internal map where packet sometimes treated as received, but sometimes treated as not received.

Bug: chromium:1346959
Change-Id: I0809e41a873103dcd62528358e64794c1d3cb28f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269382
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37609}
 2022-07-25 13:08:19 +00:00
Diep Bui
5edefa87f7 Update loss based bwe 2 to handle low bandwidth networks and no delay signal. 
1. Add loss threshold for high bandwidth preference. If the average loss ratio is less than the threshold, then the model prefers higher bandwidth candidates. Otherwise, it prefers lower bandwidth candidates. Before, it always prefers higher bandwidth candidate. The default value is 0.99, means it always prefers high bandwidth candidates.

2. Only increase the estimate if the inherent loss (random loss) is equal to/greater than the average loss. If the inherent loss is less than the average loss, then it is oversending, thus should not increase the estimate.

Bug: webrtc:12707
Change-Id: I37eb536679ca29e017a4a47703b417efd4d103ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269101
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37608}
 2022-07-25 10:45:47 +00:00
Ali Tofigh
82c29716c0 Adopt absl::string_view in modules/audio_device/ 
Bug: webrtc:13579
Change-Id: I6e8a90281a9d70a40364b6df5fee4f0a55b4a797
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269060
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37607}
 2022-07-25 10:35:17 +00:00
chromium-webrtc-autoroll
3fada3563a Roll chromium_revision dc77fbfd37..f99b8dca37 (1027538:1027650) 
Change log: dc77fbfd37..f99b8dca37
Full diff: dc77fbfd37..f99b8dca37

Changed dependencies
* src/base: 2de94b0dd5..27d6f84380
* src/build: 40005c3f92..fc63bd6317
* src/buildtools: 20863d3b27..1732a39f26
* src/buildtools/third_party/libc++/trunk: ae6c9d1fb4..476d5aefd9
* src/ios: b0ffd53adc..ac4975df42
* src/third_party: d0d988eee4..daa217beda
* src/third_party/perfetto: 86c920c317..c9aa8a4ab3
* src/tools: 89e99b2a07..76090733e4
DEPS diff: dc77fbfd37..f99b8dca37/DEPS

No update to Clang.

BUG=None

Change-Id: Id65ee6fe3df2cac755d6c016bc44d11d9226c317
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269363
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37606}
 2022-07-25 08:28:58 +00:00
webrtc-version-updater
06fefc9dba Update WebRTC code version (2022-07-25T04:04:11). 
Bug: None
Change-Id: I0153a24d262a0c573787cc7611d6e20c3012b188
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269361
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37605}
 2022-07-25 05:25:37 +00:00
webrtc-version-updater
8c8445cd9c Update WebRTC code version (2022-07-24T04:02:10). 
Bug: None
Change-Id: Id7ab8a11c50729df27c79921db59536d25058fb9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269324
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37604}
 2022-07-24 05:09:19 +00:00
chromium-webrtc-autoroll
1985c0ab8f Roll chromium_revision 4804befd52..dc77fbfd37 (1027430:1027538) 
Change log: 4804befd52..dc77fbfd37
Full diff: 4804befd52..dc77fbfd37

Changed dependencies
* src/build: c72a259385..40005c3f92
* src/buildtools: fe57e98eeb..20863d3b27
* src/buildtools/third_party/libc++/trunk: eb79671bfb..ae6c9d1fb4
* src/ios: ed3af9c3d7..b0ffd53adc
* src/testing: ffa317a6c2..1647ea28d7
* src/third_party: 5f708a2f53..d0d988eee4
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3384fbd903..192679c021
* src/third_party/depot_tools: f353dc3e88..2cd48234f1
* src/third_party/fuchsia-sdk/sdk: version:9.20220720.2.1..version:9.20220722.3.1
* src/third_party/perfetto: 209791f79d..86c920c317
* src/tools: 0e82a37d48..89e99b2a07
DEPS diff: 4804befd52..dc77fbfd37/DEPS

No update to Clang.

BUG=None

Change-Id: Ia8275965f49e58ac5f485e34f4e405bf29fbed8a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269296
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37603}
 2022-07-23 12:38:56 +00:00
Ali Tofigh
98bfd99151 Use consistent syntax for constructing std::strings from absl::string_views 
Bug: webrtc:13579
Change-Id: Ifaf9901972a39217accd9ef0111f01de9f074058
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269080
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37602}
 2022-07-23 00:18:31 +00:00
chromium-webrtc-autoroll
eeb79b834d Roll chromium_revision b6003440dd..4804befd52 (1027323:1027430) 
Change log: b6003440dd..4804befd52
Full diff: b6003440dd..4804befd52

Changed dependencies
* src/base: 2977e97eed..2de94b0dd5
* src/build: 8cfe21f530..c72a259385
* src/buildtools: 8b46ec0615..fe57e98eeb
* src/buildtools/third_party/libc++/trunk: 49e658031b..eb79671bfb
* src/buildtools/third_party/libc++abi/trunk: b954e3e656..039323b945
* src/ios: 9557be2976..ed3af9c3d7
* src/testing: c59377e722..ffa317a6c2
* src/third_party: 06437b0f4f..5f708a2f53
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/07e4a3d3cc..3384fbd903
* src/third_party/depot_tools: 0ba2fd429d..f353dc3e88
* src/tools: 7a964b5690..0e82a37d48
DEPS diff: b6003440dd..4804befd52/DEPS

No update to Clang.

BUG=None

Change-Id: Ieab3611690f3aa0ce32bc691a61653127baa56c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269287
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37601}
 2022-07-22 23:00:36 +00:00
Danil Chapovalov
7e8299b62e In rtc::Thread delete legacy implementation of the task queue 
Bug: webrtc:14245
Change-Id: Ic0ad82f0eb2186367e794bbdc122de5b2f49204a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268902
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37600}
 2022-07-22 19:48:22 +00:00
chromium-webrtc-autoroll
f8e91dfdf4 Roll chromium_revision 2692c279ce..b6003440dd (1027214:1027323) 
Change log: 2692c279ce..b6003440dd
Full diff: 2692c279ce..b6003440dd

Changed dependencies
* src/base: 07c729620c..2977e97eed
* src/build: 1d40290874..8cfe21f530
* src/ios: aec23f8c08..9557be2976
* src/testing: 9222b02eb9..c59377e722
* src/third_party: cc269b9765..06437b0f4f
* src/tools: 3ecc8d80e0..7a964b5690
DEPS diff: 2692c279ce..b6003440dd/DEPS

No update to Clang.

BUG=None

Change-Id: I93c297056cf01dd0e27e2bd1869a50a8ca4559dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269285
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37599}
 2022-07-22 18:30:25 +00:00
chromium-webrtc-autoroll
08492a1990 Roll chromium_revision 3123edb9d3..2692c279ce (1027099:1027214) 
Change log: 3123edb9d3..2692c279ce
Full diff: 3123edb9d3..2692c279ce

Changed dependencies
* src/base: f818b8017b..07c729620c
* src/build: d98ebc53dd..1d40290874
* src/buildtools: a657f8c643..8b46ec0615
* src/buildtools/third_party/libc++/trunk: 3e55cfbd1a..49e658031b
* src/ios: c14e4a2c77..aec23f8c08
* src/third_party: 4dec558726..cc269b9765
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b0098bb784..07e4a3d3cc
* src/third_party/perfetto: 361efbf9aa..209791f79d
* src/tools: 7a17048dd4..3ecc8d80e0
DEPS diff: 3123edb9d3..2692c279ce/DEPS

No update to Clang.

BUG=None

Change-Id: Ifc8bc97da26b8409a968755d8195187c51ae0a34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269283
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37598}
 2022-07-22 14:56:35 +00:00
Tommi
6b9302eb59 Remove handling in SetRecvParameters that's dead code. 
`stream_` will always be non-null when SetRecvParameters is called.

For the flexfec stream, the condition won't happen since `IsCompleteAndEnabled` doesn't consider `rtp.extension` state.

As is, this code just adds apparent complexity to SetRecvParameters.

Bug: none
Change-Id: Ie2386905bd8a338669629c7bc5f0abb39bd36d22
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269245
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37597}
 2022-07-22 13:43:35 +00:00
philipel
f012bfaf96 Use Video{Encoder, Decoder}FactoryTemplate instead of Internal{Encoder, Decoder}Factory. 
Bug: webrtc:13573
Change-Id: Id0e46a9b6053dedae3cbf0e5581768868900630b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269247
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37596}
 2022-07-22 12:07:25 +00:00
Henrik Boström
a5cc0accfb Add DEPRECATED prefix to track stats IDs. 
There's no way to add a deprecation warning unique to using
RTCMediaStreamTrackStats, but we could signal to users that it is
deprecated by adding "DEPRECATED_" to its ID.

This could break apps with hardcoded assumptions about what the stats
IDs are, but apps doing this are using the API incorrectly anyway, so
if anyone is affected by this change that would be a good time to
remove any dependency on this (see https://crbug.com/webrtc/10656
regading the fact that IDs should be unpredictable).

Bug: webrtc:14175
Change-Id: I6242c4efc08e9570420c00af5aaf491b1af819f1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269004
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37595}
 2022-07-22 11:34:46 +00:00
Mirko Bonadei
082d270b31 Remove leftover from previous cleanup. 
See https://webrtc-review.googlesource.com/c/src/+/269180.

A default ctor was left behind in the version without logs enabled.

Bug: None
Change-Id: I27826928fe702c1d50f6ed823def9f5f0bb9aee8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269248
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37594}
 2022-07-22 11:03:07 +00:00
webrtc-version-updater
1e3ab4878f Update WebRTC code version (2022-07-22T04:05:13). 
Bug: None
Change-Id: Ifcd9a4f5f241d78f039515117c8f16ee459a58af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269262
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37593}
 2022-07-22 05:51:16 +00:00
chromium-webrtc-autoroll
8bacdb5cb4 Roll chromium_revision 3da4dee071..3123edb9d3 (1026992:1027099) 
Change log: 3da4dee071..3123edb9d3
Full diff: 3da4dee071..3123edb9d3

Changed dependencies
* src/base: a6feb8b11a..f818b8017b
* src/build: 4d3cf60e6a..d98ebc53dd
* src/buildtools: d4d55fbf05..a657f8c643
* src/buildtools/third_party/libc++/trunk: 88bf407048..3e55cfbd1a
* src/ios: 23f5789a11..c14e4a2c77
* src/testing: 3516657cdb..9222b02eb9
* src/third_party: 3b97867316..4dec558726
* src/third_party/breakpad/breakpad: c4c43b80ea..afc8daa2de
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/dd1a8cd9c4..b0098bb784
* src/tools: b909595fc6..7a17048dd4
DEPS diff: 3da4dee071..3123edb9d3/DEPS

No update to Clang.

BUG=None

Change-Id: I2cf6575b5de3303eb340d79f68d212faff9b1b94
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269261
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37592}
 2022-07-22 04:32:27 +00:00
chromium-webrtc-autoroll
15087b2137 Roll chromium_revision 0f7279573c..3da4dee071 (1026859:1026992) 
Change log: 0f7279573c..3da4dee071
Full diff: 0f7279573c..3da4dee071

Changed dependencies
* src/base: 3d3a5fc325..a6feb8b11a
* src/build: 918b804ee4..4d3cf60e6a
* src/ios: b6b463b851..23f5789a11
* src/testing: aa10da843b..3516657cdb
* src/third_party: 0ec74d4211..3b97867316
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4c50669a2f..dd1a8cd9c4
* src/third_party/perfetto: c223598255..361efbf9aa
* src/tools: d903290acb..b909595fc6
DEPS diff: 0f7279573c..3da4dee071/DEPS

No update to Clang.

BUG=None

Change-Id: Id05424764b5aba18c54ddbb3007131dd6f7d1172
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269226
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37591}
 2022-07-21 22:36:55 +00:00
Austin Orion
de4fd2f9ef WindowCapturerWinGdi shouldn't deliver SUCCESS and nullptr. 
Consumers expect the frame to be valid if Result::SUCCESS is delivered.
If the frame is nullptr, we should deliver ERROR_TEMPORARY instead.

Bug: webrtc:14265
Change-Id: If94a3ead38d7657d7b90bbe046256be697312216
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269223
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#37590}
 2022-07-21 21:03:24 +00:00
chromium-webrtc-autoroll
32632a80e3 Roll chromium_revision abe412afe7..0f7279573c (1026730:1026859) 
Change log: abe412afe7..0f7279573c
Full diff: abe412afe7..0f7279573c

Changed dependencies
* src/base: 468bdcb9c7..3d3a5fc325
* src/build: bed2979286..918b804ee4
* src/ios: 0b68b671ca..b6b463b851
* src/testing: fc01b2b000..aa10da843b
* src/third_party: 24f89f2000..0ec74d4211
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/abcd8ba23e..4c50669a2f
* src/third_party/depot_tools: 39e33e6eca..0ba2fd429d
* src/tools: f6d83033bb..d903290acb
DEPS diff: abe412afe7..0f7279573c/DEPS

No update to Clang.

BUG=None

Change-Id: I2326e2d0fbe39ade721d18a7a83f09b3b3973ae5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269224
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37589}
 2022-07-21 18:25:44 +00:00
Artem Titov
1031a4f54c Introduce method to simplify creation of ideal emulated network 
Bug: b/239799175
Change-Id: I3b082cdeea7748b2f642a864598916bcadf3ec39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269240
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37588}
 2022-07-21 14:32:17 +00:00
Diep Bui
9804aa5f6a Avoid fraction_loss overflowing when packet loss is negative in send_side_bandwidth_estimation.cc. 
Update an affected unit test by the change in goog_cc.

Bug: webrtc:14272
Change-Id: I83e97530c861b126bed876d57f6d4f91aa45de7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269002
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37587}
 2022-07-21 14:31:04 +00:00
chromium-webrtc-autoroll
dc5cf31cad Roll chromium_revision 17f3d023e1..abe412afe7 (1026586:1026730) 
Change log: 17f3d023e1..abe412afe7
Full diff: 17f3d023e1..abe412afe7

Changed dependencies
* src/base: 8b89bf39bb..468bdcb9c7
* src/build: be25fb2945..bed2979286
* src/buildtools: a4506d5d63..d4d55fbf05
* src/ios: be664f05e1..0b68b671ca
* src/testing: 426cc41296..fc01b2b000
* src/third_party: 6f9af62c05..24f89f2000
* src/third_party/depot_tools: 6967a96b04..39e33e6eca
* src/third_party/harfbuzz-ng/src: c88a6a9ec3..fa471043fc
* src/tools: 5837d28649..f6d83033bb
DEPS diff: 17f3d023e1..abe412afe7/DEPS

No update to Clang.

BUG=None

Change-Id: I91d62538675077619335af67cb2ed503f70ce9f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269220
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37586}
 2022-07-21 12:56:34 +00:00
Byoungchan Lee
e044ec572a Don't print warning for tasks running 1ms earlier than planned. 
Bug: webrtc:12889
Change-Id: I33faa986130f2d7ae049466c303ef29b643d97ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268920
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37585}
 2022-07-21 11:44:35 +00:00
Mirko Bonadei
5afcc9afae Remove deprecated LogMessage ctor. 
This ctor has been deprecated for a while and it should be unused
by WebRTC clients.

Bug: None
Change-Id: I7d33ae24eefafe48924011f55fb53150b717d593
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269180
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37584}
 2022-07-21 10:33:15 +00:00
Danil Chapovalov
be5258e61d Optimize adding many consecutive missing packets to rtcp TransportFeedback 
Bug: chromium:1342840
Change-Id: I894157af2ed4f8b9dc97ccb8613cbf18db09f95a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269100
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37583}
 2022-07-21 10:15:25 +00:00
Mirko Bonadei
054ea47379 Move common test flags to a separate library. 
This enables the possibility to use these flags from other main
functions.

Bug: b/217701950, b/238157120
Change-Id: I6e9f09c4be39b2ac690c8e6b6da380ef3c81f460
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269140
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37582}
 2022-07-21 09:52:54 +00:00
Mirko Bonadei
507e3bc406 Remove redundant close(). 
Bug: None
Change-Id: I975f14a4308530e37cc3faba67d8545ed3feffa8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269005
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37581}
 2022-07-21 09:49:14 +00:00