bbc8fc165c
Roll chromium_revision d3d85d6b43..6669f72cdc (1074816:1075042)
...
Change log: d3d85d6b43..6669f72cdc
Full diff: d3d85d6b43..6669f72cdc
Changed dependencies
* src/base: 41677446eb..6e71e09519
* src/build: 9c35b43202..8961725eee
* src/testing: 60d1ee9478..1a716cbded
* src/third_party: a6efa878cf..73f7282fa2
* src/third_party/androidx: ocp0y0IgrnQisPklXhrCVp0gzN79IpD6ooyCwFpNIlcC..0lQn_nLBNlXd0NzCrQC3IUe3JECb_xi20aRJ3bac0hcC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2b857d73ff..cce68bc50e
* src/third_party/depot_tools: 30e3ce8b1c..2fc7e1ffd5
* src/third_party/perfetto: 4f6803dfe0..28b1da6e19
* src/tools: 1f8033911d..fff0ab378c
DEPS diff: d3d85d6b43..6669f72cdc
/DEPS
No update to Clang.
BUG=None
Change-Id: I1d968340be85cdb4031b1adf9572bf93fa7ea20c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284822
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38715}
2022-11-23 07:33:07 +00:00
19d96365b2
Update WebRTC code version (2022-11-23T04:04:56).
...
Bug: None
Change-Id: I1b9eeddbc4fa14c57314faf0e953a00d6b88534f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284820
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38714}
2022-11-23 05:56:37 +00:00
447b9f3fde
Unvirtualize more wasteful functions
...
Cleaning up instances of virtual functions with no overrides.
Savings of 1.4kb for chrome.dll file.
Note: These are the savings for Windows, relocation savings are
probably larger on other platforms.
GN args for builds:
use_goma=true
is_debug=false
target_cpu="x64"
use_lld=false
fatal_linker_warnings=false
symbol_level=2
dcheck_always_on = false
pe_summarize analysis pre-change -> change:
Size of out\Default\chrome.dll is 188.844544 MB
Size of out\SessionDescription\chrome.dll is 188.843520 MB
Memory size change from out\Default\chrome.dll
to out\SessionDescription\chrome.dll
.text: -704 bytes change
.rdata: -512 bytes change
.pdata: -48 bytes change
.reloc: -168 bytes change
Total change: -1432 bytes
Bug: chromium:1371503
Change-Id: I51ad0a8acf3595fc499dbbcde2fab2d1bdf90fb9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283940
Commit-Queue: Ivan Rosales <rosalesi@google.com >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38713}
2022-11-22 22:44:21 +00:00
8a8c455cce
Roll chromium_revision e6090767ac..d3d85d6b43 (1074663:1074816)
...
Change log: e6090767ac..d3d85d6b43
Full diff: e6090767ac..d3d85d6b43
Changed dependencies
* src/base: a7d382c97b..41677446eb
* src/build: 00b05f4262..9c35b43202
* src/ios: 93196a4539..866ec86ecb
* src/testing: b5de475a1c..60d1ee9478
* src/third_party: a27a0809a9..a6efa878cf
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c996ebbd3d..2b857d73ff
* src/third_party/perfetto: 51908f273f..4f6803dfe0
* src/tools: ce8c4663d8..1f8033911d
DEPS diff: e6090767ac..d3d85d6b43
/DEPS
No update to Clang.
BUG=None
Change-Id: Ia3a13bd9a5fb042d3f665a6a82f537f469efa1d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284761
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38712}
2022-11-22 20:52:47 +00:00
2c2d2c75b5
Roll chromium_revision f2dad4225a..e6090767ac (1074534:1074663)
...
Change log: f2dad4225a..e6090767ac
Full diff: f2dad4225a..e6090767ac
Changed dependencies
* src/base: dfd53becd8..a7d382c97b
* src/build: b9179a2e57..00b05f4262
* src/ios: e571bff1fe..93196a4539
* src/testing: 6a779efd18..b5de475a1c
* src/third_party: d11fab37a6..a27a0809a9
* src/third_party/androidx: wadwYbL62ON5yAaCD6gfqhvdQa4GugesoP8EXOOWDecC..ocp0y0IgrnQisPklXhrCVp0gzN79IpD6ooyCwFpNIlcC
* src/third_party/perfetto: c5fb93e710..51908f273f
* src/third_party/r8: zJXokrYtEiaa-jjRGetxUuWf3Zkv_G7Fvl5oCXkhBAsC..6IAjJKfUwjFSLKQ31fxSTeXHZXcsGeoUlMKBcirZTbUC
* src/tools: 3a307285aa..ce8c4663d8
DEPS diff: f2dad4225a..e6090767ac
/DEPS
No update to Clang.
BUG=None
Change-Id: Ia7b3a3b93ce5e18e9f5df31d1981624af9c53b96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284740
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38711}
2022-11-22 16:45:27 +00:00
27fed4513f
InputVolumeController: Make speech_probability non-optional
...
Make the argument speech_probability non-optional in
InputVolumeController::Process() and
MonoInputVolumeController::Process().
Additional clean-up: Remove the flag enabled in the
config. Add unit tests for MonoInputVolumeController.
Bug: webrtc:7494
Change-Id: Ie28af77dc628bf71d09ce1ff033d39031f77a21e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283700
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Hanna Silen <silen@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38710}
2022-11-22 15:19:02 +00:00
310e0624aa
Add Cisco AnyConnect IPSec MAC to VPN detection
...
and set the underlying type to unknown for mac-based detection.
BUG=webrtc:13097,webrtc:13172
Co-authored by: amir.pirogovsky@microsoft.com
Change-Id: I177214f9eb5c2990faa65262f77b3d0ce9d5eab7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284500
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@microsoft.com >
Cr-Commit-Position: refs/heads/main@{#38709}
2022-11-22 11:55:26 +00:00
0c56aef5d5
Remove iSAC from NetEQ tests
...
Bug: webrtc:14450, chromium:1387892
Change-Id: I44e1ff1a5dd717072a0e8f6afa6e53e96920ea2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284460
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38708}
2022-11-22 11:41:00 +00:00
c6ae33fb07
Replace dash by underscore in the command line argument before absl flag parsing.
...
The expected behavior is to have something similar than python:
https://docs.python.org/dev/library/argparse.html#dest :
"Any internal - characters will be converted to _ characters to make sure the string is a valid attribute name".
This allows to catch chromium arguments like 'isolated-script-test-output' that previously needed some preprocessing done for example in flags_compatibility.py.
This CL also fixes a fuchsia specific issue where the test runner needs a 'isolated-script-test-output' argument but then pass the argument to WebRTC that expects a 'isolated_script_test_output' argument. Thus calling flags_compatibility before the test_runner fails and there is not much room to change the argument in between the test runner and the test.
Change-Id: I48a591743fa50484a0ec584a3f9e97d9e0fd25ef
Bug: webrtc:14694
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284541
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38707}
2022-11-22 11:03:33 +00:00
a3a3b6d798
[Stats] If remote-inbound-rtp has no RTT, leave it undefined.
...
Bug: webrtc:14692
Change-Id: I49878449cd91b590f1aedef7676c3715d563ac61
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284660
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Auto-Submit: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38706}
2022-11-22 10:52:49 +00:00
dd35e244ce
Roll chromium_revision aa00dc7b8d..f2dad4225a (1074405:1074534)
...
Change log: aa00dc7b8d..f2dad4225a
Full diff: aa00dc7b8d..f2dad4225a
Changed dependencies
* src/base: 91d4e978ab..dfd53becd8
* src/build: 9d41dd2f4a..b9179a2e57
* src/buildtools: 09154d65c3..3c8fef071e
* src/ios: 3729499250..e571bff1fe
* src/testing: f1b0402eac..6a779efd18
* src/third_party: 0f427325f3..d11fab37a6
* src/third_party/androidx: rcmLvPaPceZwa6euMzenA2gxol6Va8xNr2W9njQb6moC..wadwYbL62ON5yAaCD6gfqhvdQa4GugesoP8EXOOWDecC
* src/third_party/depot_tools: d06e475934..30e3ce8b1c
* src/third_party/perfetto: 0febe43447..c5fb93e710
* src/tools: 8f3e77576c..3a307285aa
DEPS diff: aa00dc7b8d..f2dad4225a
/DEPS
No update to Clang.
BUG=None
Change-Id: Ia556611320e672219a1e74b1217411719778adfd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284680
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38705}
2022-11-22 10:33:10 +00:00
ca0481751d
Update WebRTC code version (2022-11-22T04:11:16).
...
Bug: None
Change-Id: Ic786aa73441762b9fa4ba3e6deb123e104f2967c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284626
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38704}
2022-11-22 05:31:29 +00:00
768cb4464e
Roll chromium_revision 4735e42471..aa00dc7b8d (1074281:1074405)
...
Change log: 4735e42471..aa00dc7b8d
Full diff: 4735e42471..aa00dc7b8d
Changed dependencies
* src/base: 6e78afa4d1..91d4e978ab
* src/build: dc9a99294b..9d41dd2f4a
* src/ios: 99365834d0..3729499250
* src/testing: d960080f35..f1b0402eac
* src/third_party: b5b162a598..0f427325f3
* src/third_party/androidx: QQCBJDbCcTJd-GDm4CHpjKdcXKjbHP9ebzyHDuU2x-4C..rcmLvPaPceZwa6euMzenA2gxol6Va8xNr2W9njQb6moC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/39d570c940..c996ebbd3d
* src/third_party/perfetto: f5b6c4ed86..0febe43447
* src/tools: 9ba2d12de7..8f3e77576c
DEPS diff: 4735e42471..aa00dc7b8d
/DEPS
No update to Clang.
BUG=None
Change-Id: I993f34f5bfeb1abff854e31baf6bfa7cefd8df40
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284624
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38703}
2022-11-22 03:02:22 +00:00
918eb19303
Fix crash when Opus maxptime < 20ms.
...
A follow up cl will be created to better handle nullopt frame length range in AudioSendStream.
Note that maxptime is still not used for setting the frame length (only ptime is).
Bug: chromium:1109337
Change-Id: Id21fd8c76a6c4a0c85719a955116f8d16001a3d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284501
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38702}
2022-11-22 01:21:24 +00:00
b2556d7716
Roll chromium_revision b8e1994ea3..4735e42471 (1074125:1074281)
...
Change log: b8e1994ea3..4735e42471
Full diff: b8e1994ea3..4735e42471
Changed dependencies
* src/base: ad09c820b8..6e78afa4d1
* src/build: bd893617b2..dc9a99294b
* src/ios: 2f2a1d1612..99365834d0
* src/testing: 6917a6ceb4..d960080f35
* src/third_party: 40a3010b90..b5b162a598
* src/third_party/androidx: QywWz1_m6w-DIah4IXQ3I27LDjKgn9kUMTP1SEJgigUC..QQCBJDbCcTJd-GDm4CHpjKdcXKjbHP9ebzyHDuU2x-4C
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/1ee71185a2..f0518d4511
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b898eb3e06..39d570c940
* src/third_party/libyuv: fe9ced6e3c..8713ba3f0b
* src/third_party/perfetto: d8f0dc3d20..f5b6c4ed86
* src/third_party/r8: vqsrb5_6fg9u-aSAqrcJiG7q2GOG66_39vdYTKgHmHgC..zJXokrYtEiaa-jjRGetxUuWf3Zkv_G7Fvl5oCXkhBAsC
* src/tools: be0e76ad10..9ba2d12de7
DEPS diff: b8e1994ea3..4735e42471
/DEPS
Clang version changed llvmorg-16-init-10467-g1239d37b:llvmorg-16-init-10736-ged9638c4
Details: b8e1994ea3..4735e42471
/tools/clang/scripts/update.py
BUG=None
Change-Id: I583e96256fcb5b2d74094647bea0b7bb09c480c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284622
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38701}
2022-11-21 23:23:02 +00:00
6894beaaed
Merge "ANDROID: arch.h: Add RISC-V support" am: 28cc9bf0d7 am: 1245db555f am: 2980a6c26e
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311087
Change-Id: I77e8e948915eca26e182ad96d600d88aa2b7cdb9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 23:10:26 +00:00
7346973eb1
Merge "UPSTREAM: Add preprocessor support for additional architectures" am: 4c19de0b71 am: 8b44512470 am: b44d4398c2
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311086
Change-Id: Ifae5c0914831be770b1efb63c348cca8eba6f36d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 23:06:59 +00:00
2980a6c26e
Merge "ANDROID: arch.h: Add RISC-V support" am: 28cc9bf0d7 am: 1245db555f
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311087
Change-Id: Iebf6c40a946302bc64dce856d617a1ea0e1a4927
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 22:01:27 +00:00
b44d4398c2
Merge "UPSTREAM: Add preprocessor support for additional architectures" am: 4c19de0b71 am: 8b44512470
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311086
Change-Id: I7afb943cd9ede2a7ca51d2dac2b717dadc0f2289
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 22:01:07 +00:00
1245db555f
Merge "ANDROID: arch.h: Add RISC-V support" am: 28cc9bf0d7
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311087
Change-Id: I6549a7c983b4eabef6118f6ca785be72e46189c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 20:42:56 +00:00
8b44512470
Merge "UPSTREAM: Add preprocessor support for additional architectures" am: 4c19de0b71
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311086
Change-Id: I08743a90a3ea43bf4a33b62db80956e83a21cb85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 20:40:46 +00:00
28cc9bf0d7
Merge "ANDROID: arch.h: Add RISC-V support"
2022-11-21 20:01:10 +00:00
4c19de0b71
Merge "UPSTREAM: Add preprocessor support for additional architectures"
2022-11-21 20:00:30 +00:00
440df4bfa5
Roll chromium_revision 864ce8538c..b8e1994ea3 (1074019:1074125)
...
Change log: 864ce8538c..b8e1994ea3
Full diff: 864ce8538c..b8e1994ea3
Changed dependencies
* src/base: 0849ff6ab4..ad09c820b8
* src/ios: 5f55810d9d..2f2a1d1612
* src/testing: d5ad5f5098..6917a6ceb4
* src/third_party: 84fcab6453..40a3010b90
* src/third_party/freetype/src: 4e6906cc5d..1c44de209c
* src/third_party/perfetto: 06921e5027..d8f0dc3d20
* src/tools: 0606cce9cc..be0e76ad10
DEPS diff: 864ce8538c..b8e1994ea3
/DEPS
No update to Clang.
BUG=None
Change-Id: Ide671a25744baba9da061dafc233e179718f1938
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284620
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38700}
2022-11-21 18:43:33 +00:00
74aefcb6d2
ANDROID: arch.h: Add RISC-V support
...
Trivial patch to add support for RISC-V. `__riscv__` is the deprecated
definition available on older toolchains.
Bug: None
Link: https://webrtc-review.googlesource.com/c/src/+/222481
[adelva: cherry-picked back with conflict in AUTHORS only]
Change-Id: I0a028de8aedfd18e69c3260f3b810e7502ae4b10
2022-11-21 18:07:32 +00:00
300242bf56
UPSTREAM: Add preprocessor support for additional architectures
...
- _M_ARM is used by Microsoft [1]
- __riscv and __riscv_xlen are defined by [2]
- __sparc and __sparc__ are documented at [3]
- __MIPSEB__, __PPC__, __PPC64__ are documented at [3] and used in
Chromium's build/build_config.h [4]
Note: Chromium assumes that all PowerPC architectures are 64-bit. This
is in fact not true.
[1]: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160
[2]: feca479356 (cc-preprocessor-definitions)
[3]: https://sourceforge.net/p/predef/wiki/Architectures/
[4]: https://source.chromium.org/chromium/chromium/src/+/master:build/build_config.h;drc=e12bf2e5ff1eacb9aca3e9a26bdeebdbdad5965a
Bug: webrtc:12312
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198241
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Timothy Gu <timothygu@chromium.org >
Cr-Commit-Position: refs/heads/master@{#32897}
[adelva: cherry-picked back with no conflicts]
Change-Id: I05da28acdebd627c7ba7aaa8c1fe5f47fa22d15b
2022-11-21 18:07:07 +00:00
d168353cb8
Roll chromium_revision d2b892f876..864ce8538c (1073911:1074019)
...
Change log: d2b892f876..864ce8538c
Full diff: d2b892f876..864ce8538c
Changed dependencies
* src/base: b04aec6033..0849ff6ab4
* src/ios: 02a30364c6..5f55810d9d
* src/testing: ed6b90bc8a..d5ad5f5098
* src/third_party: 636baa52d8..84fcab6453
* src/tools: 12bfdef0e2..0606cce9cc
DEPS diff: d2b892f876..864ce8538c
/DEPS
No update to Clang.
BUG=None
Change-Id: I451024dd7fa5075daf837a8e8604fd189d007f00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284520
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38699}
2022-11-21 13:48:53 +00:00
d8c4de7172
Remame VideoSendStream::UpdateActiveSimulcastLayers to StartPerRtpStream
...
VideoSendStreamImpl::Start and VideoSendStream::Start are not used by PeerConnections, only StartPerRtpStream.
Therefore this cl:
- Change implementation of VideoSendStream::Start to use VideoSendStream::StartPerRtpStream. VideoSendstream::Start is kept for convenience.
- Remove VideoSendStreamImpl::Start() since it was only used by tests that use call and is confusing.
- RtpVideoSender::SetActive is removed/changed to RtpVideoSender::Stop(). For normal operations RtpVideoSender::SetActiveModules is used.
Bug: none
Change-Id: I43b153250b07c02fe63c84e3c4cec18d4ec0d47a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283660
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38698}
2022-11-21 12:41:39 +00:00
d742382eb0
Limit numer of pending probes.
...
Created probes are currently timed out after 5s. But to be safe, also limit the number of pending probes to 5.
Bug: webrtc:14392, b/259541308
Change-Id: Ibf630704ffe14cb165ab849b881cf75857376f82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284080
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38697}
2022-11-21 12:40:36 +00:00
79beaa7f38
APM tests: check that the applied input volume is recommended
...
when volume emulation is used or when neither an input volume
controller nor volume emulation are used.
This CL adds 3 tests, 2 of which currently fail because APM
behaves in an undesired way. In [1] the behavior is fixed and
the tests are enabled.
A DCHECK in `AudioProcessingImpl::set_stream_analog_level` has
been removed since a more robust behavior can be obtained - namely,
that expected in the disabled unit tests added in this CL.
[1] https://webrtc-review.googlesource.com/c/src/+/281185
Bug: webrtc:14581
Change-Id: I29d2c000cd1baf90606487afd9a4042e6f487834
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281184
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38696}
2022-11-21 10:35:23 +00:00
987ebe6b49
Add Fuchsia filesystem specific handling
...
This unlocks many tests, at least locally.
Bug: b/232740856
Change-Id: Icd8d099aabf6f81906d7c6b3b40f47b501496c6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284141
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38695}
2022-11-21 10:27:26 +00:00
538fa81328
Add collection of EmulatedNetworkNode stats to stats collector
...
Bug: b/240540204
Change-Id: I9c2c2c35d0c3b6a99205e24d8b367fa7dab5d917
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283760
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38694}
2022-11-21 09:46:34 +00:00
6d91a718c8
[DVQA] Allow processing of frames dropped by decoder
...
Bug: b/257402861
Change-Id: I4d495c33c162c4e3a0afef5b83adf19b6d79dfce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284160
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38693}
2022-11-21 09:19:04 +00:00
bbdb768989
Roll chromium_revision b1f886001e..d2b892f876 (1073790:1073911)
...
Change log: b1f886001e..d2b892f876
Full diff: b1f886001e..d2b892f876
Changed dependencies
* src/base: f0fb099681..b04aec6033
* src/ios: 271782c391..02a30364c6
* src/testing: 6b4bdff82e..ed6b90bc8a
* src/third_party: 695b477e4f..636baa52d8
* src/third_party/freetype/src: 0f43a0e7eb..4e6906cc5d
* src/tools: c26f5558f7..12bfdef0e2
DEPS diff: b1f886001e..d2b892f876
/DEPS
No update to Clang.
BUG=None
Change-Id: Ie4767964d75e2a119a330b3a732befda055f2206
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284421
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38692}
2022-11-21 05:16:57 +00:00
cb683099e1
Update WebRTC code version (2022-11-20T04:03:01).
...
Bug: None
Change-Id: I1cad2e1eb4d398ef6dff11da0045063d29a28803
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284224
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38691}
2022-11-20 05:18:04 +00:00
77ca50c3e4
Roll chromium_revision 25ef2f60df..b1f886001e (1073689:1073790)
...
Change log: 25ef2f60df..b1f886001e
Full diff: 25ef2f60df..b1f886001e
Changed dependencies
* src/base: a881dc199f..f0fb099681
* src/ios: 752ac57699..271782c391
* src/testing: f58fba0a44..6b4bdff82e
* src/third_party: f0b85f1f06..695b477e4f
* src/tools: f32846a2ac..c26f5558f7
DEPS diff: 25ef2f60df..b1f886001e
/DEPS
No update to Clang.
BUG=None
Change-Id: Ic37dde769c369427a6c3239d284564da4f0000d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284223
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38690}
2022-11-20 02:27:31 +00:00
e0bb181371
Roll chromium_revision 6f40a624da..25ef2f60df (1073579:1073689)
...
Change log: 6f40a624da..25ef2f60df
Full diff: 6f40a624da..25ef2f60df
Changed dependencies
* src/base: e4818296e9..a881dc199f
* src/build: fd2ddb8728..bd893617b2
* src/ios: fb131b2bd8..752ac57699
* src/testing: c6300c1ef8..f58fba0a44
* src/third_party: 042227f235..f0b85f1f06
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/79ba9244e5..b898eb3e06
* src/third_party/icu: da07448619..1b7d391f05
* src/third_party/perfetto: 4b8bdfdfe3..06921e5027
* src/tools: d4ed5c2a74..f32846a2ac
DEPS diff: 6f40a624da..25ef2f60df
/DEPS
No update to Clang.
BUG=None
Change-Id: Ib4cb2d91dd6f14f3513d1b1704133689edf9872b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284180
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38689}
2022-11-19 02:45:03 +00:00
c61ffddc8b
Roll chromium_revision 6c3a8ff45b..6f40a624da (1073341:1073579)
...
Change log: 6c3a8ff45b..6f40a624da
Full diff: 6c3a8ff45b..6f40a624da
Changed dependencies
* src/base: 56ffff54e0..e4818296e9
* src/build: dc2384c048..fd2ddb8728
* src/ios: c382aa6fcc..fb131b2bd8
* src/testing: b220cb9132..c6300c1ef8
* src/third_party: 87e8d187a7..042227f235
* src/third_party/depot_tools: 1f67d5573f..d06e475934
* src/third_party/perfetto: 6c5c80b3c6..4b8bdfdfe3
* src/third_party/r8: SRv8kr_t534yPmvzQnKEBqgw_lidewzTdKnAKoWYkz0C..vqsrb5_6fg9u-aSAqrcJiG7q2GOG66_39vdYTKgHmHgC
* src/tools: ff6e72b94e..d4ed5c2a74
DEPS diff: 6c3a8ff45b..6f40a624da
/DEPS
No update to Clang.
BUG=None
Change-Id: I5bc9a366c3b288f08943beeba59e2511f6c18a4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283888
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38688}
2022-11-18 22:55:30 +00:00
78b466a0d1
AGC1: remove unused field trial WebRTC-UseLegacyDigitalGainApplier
...
Bug: webrtc:14685
Change-Id: I7c9e07c56f20bd9c4b8848787d0b6e4f9785af60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283764
Reviewed-by: Hanna Silen <silen@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38687}
2022-11-18 21:58:04 +00:00
4440426792
[DVQA] Add QP metric to the video analyzer.
...
Bug: b/240540204
Change-Id: I43fbb779bac10e27f2607ce1545476b1389d7c69
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283763
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38686}
2022-11-18 20:06:20 +00:00
bf28277774
InputVolumeController: Add configurable speech probability aggregation
...
Make speech probability threshold configurable by replacing
kSpeechProbabilitySilenceThreshold with speech_probability_threshold in
InputVolumeController::Config.
Make the processing more robust against outliers in speech probability
estimaton by computing an aggregate speech activity over a speech
segment. In MonoInputVolumeController::Process(), use the passed
non-empty speech probabilities to compute the speech activity over the
speech segment and only allow updates for segments with a high enough
ratio of speech frames. Pass RMS error and speech probability for every
frame in Process(): If rms_error_dbfs is empty, volume updates are not
allowed; if speech_probability is empty, the frame counts as a non-
speech frame.
Remove startup_min_volume from the config since it's no longer used
after https://webrtc-review.googlesource.com/c/src/+/282821 .
Bug: webrtc:7494
Change-Id: I0ab81b03371496315348f552133aa9909bd36f26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283523
Commit-Queue: Hanna Silen <silen@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38685}
2022-11-18 19:37:05 +00:00
f45f823541
Actually build frame_analyzer when not on Chromium.
...
Bug: None
Change-Id: I44eaa9c3f6b0d6c86990cc08dde6aee2cac82c5c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284140
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38684}
2022-11-18 17:32:33 +00:00
dd18f9f8c2
APM: remove WebRTC.Audio.ApmRuntimeSettingCannotEnqueue
...
The histogram definition is removed in crrev.com/c/4030265.
Bug: chromium:1272685
Change-Id: Id689cf4324ca17bef8a7d07d58d8534bae7b2178
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283664
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38683}
2022-11-18 14:55:22 +00:00
1571258ca6
Fix a couple bugs in Fuchsia screen capture.
...
1. Use ComponentContext::Create instead of
ComponentContext::CreateAndServeOutgoingDirectory. We're not
actually serving an outgoing directory here, and trying to causes
conflicts when this code is linked into a Fuchsia component.
2. Mark the whole screen as having been updated on each frame. Some
codecs were assuming that nothing on the screen was changing, and
so only the first frame would be shared.
Change-Id: Icb02a2cc097947b85cceddec49291e666257ed81
Bug: webrtc:14681
Bug: webrtc:14682
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283920
Reviewed-by: Alexander Cooper <alcooper@chromium.org >
Reviewed-by: Sarah Pham <smpham@google.com >
Commit-Queue: Hunter Freyer <hjfreyer@google.com >
Cr-Commit-Position: refs/heads/main@{#38682}
2022-11-18 14:53:09 +00:00
5c297eb7a9
Roll chromium_revision d88f4d4807..6c3a8ff45b (1073228:1073341)
...
Change log: d88f4d4807..6c3a8ff45b
Full diff: d88f4d4807..6c3a8ff45b
Changed dependencies
* src/build: 316bdbb4f8..dc2384c048
* src/ios: e78e9dfc41..c382aa6fcc
* src/testing: 8685a9c466..b220cb9132
* src/third_party: 639dff812c..87e8d187a7
* src/third_party/perfetto: 6f7678ba37..6c5c80b3c6
* src/tools: df48fb93ea..ff6e72b94e
DEPS diff: d88f4d4807..6c3a8ff45b
/DEPS
No update to Clang.
BUG=None
Change-Id: If48b7751a576008b672b0dec15dee144ef9ece7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284042
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38681}
2022-11-18 14:31:49 +00:00
7dc590e0b7
Fix CallPerfTest
tests
...
iSAC has been removed, the tests now use Opus which requires min/max
bitrate to be set.
Bug: webrtc:14450
Change-Id: I872764b1ebb9115e314f146749fe710a7665ad62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284060
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38680}
2022-11-18 12:37:33 +00:00
858864dcb4
Do not compile frame_analyzer on component builds.
...
No-Try: True
Bug: None
Change-Id: I8a7f62ee3a35c344c3a95c1b1b018dd07e1de00e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284120
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38679}
2022-11-18 12:32:58 +00:00
63dda507f5
Revert "Do not compile frame_analyzer on component builds."
...
This reverts commit 892e61cd1e4186049ab65da7ca60bc6a2e05c16e.
Reason for revert: Needs more work.
Original change's description:
> Do not compile frame_analyzer on component builds.
>
> Bug: None
> Change-Id: I1e66c26d8e9717bc43cf6037852ec2e23b466339
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284061
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38675}
Bug: None
Change-Id: I9afe8a057f98e49cf4fbe64b947e04796e40f89d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284100
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38678}
2022-11-18 12:20:41 +00:00
34f4ec26e3
Fix the loss based bwe state.
...
When best candidate estimate increases above the delay based estimate, the state should be DelayBasedEstimate because the final esimate is bounded by delay based bwe anyway.
Bug: webrtc:12707
Change-Id: I0bcae684b33e5f1e9a7c57cb32c431b4eb58fd35
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283802
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Diep Bui <diepbp@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38677}
2022-11-18 11:50:39 +00:00
6eb1e709da
Reland "[DVQA] Create separate BUILD.gn file for video analyzer"
...
This reverts commit 76793c300fdd87fa8fd8be3dd2e5faf8c1916e96.
Reason for revert: Can't cleanly revert the old one. A forward fix will be provided.
Original change's description:
> Revert "[DVQA] Create separate BUILD.gn file for video analyzer"
>
> This reverts commit 116c0a53d4a35c6dee857eb4cc2b6ae233a0427c.
>
> Reason for revert: Breaks bot: https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_compile_dbg_ng/1415352/overview
>
>
> Original change's description:
> > [DVQA] Create separate BUILD.gn file for video analyzer
> >
> > Bug: None
> > Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
> > No-try: True
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
> > Commit-Queue: Artem Titov <titovartem@webrtc.org >
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#38662}
>
> Bug: None
> Change-Id: Ieeb8c569560cb9d60d0c4d3c1268fa57f56b8157
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284000
> Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38672}
Bug: None
Change-Id: I74506eaa6a1060bf87e651881c86b4f576f447ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284020
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38676}
2022-11-18 11:43:45 +00:00