892e61cd1e
Do not compile frame_analyzer on component builds.
...
Bug: None
Change-Id: I1e66c26d8e9717bc43cf6037852ec2e23b466339
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284061
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38675}
2022-11-18 11:28:39 +00:00
3d9b5590c2
Move field trial from BasicNetworkManager to NetworkManagerBase
...
Bug: webrtc:14306
Change-Id: I9bba38090a77a40f599eaa680da3cf60810b0337
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283801
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Diep Bui <diepbp@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38674}
2022-11-18 10:39:04 +00:00
7404f07ad9
Sync target rates
...
Cache target bit- and framerate in a frame_num -> rates map and fetch
the rates accociated with the current frame when needed. This solves
the issue when wrong target rates may be used due to frames buffering
in encoder.
Bug: b/254447893
Change-Id: I369c8d8e71234c957dc2362b055061d12cec818f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283841
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38673}
2022-11-18 10:22:01 +00:00
76793c300f
Revert "[DVQA] Create separate BUILD.gn file for video analyzer"
...
This reverts commit 116c0a53d4a35c6dee857eb4cc2b6ae233a0427c.
Reason for revert: Breaks bot: https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_compile_dbg_ng/1415352/overview
Original change's description:
> [DVQA] Create separate BUILD.gn file for video analyzer
>
> Bug: None
> Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
> No-try: True
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38662}
Bug: None
Change-Id: Ieeb8c569560cb9d60d0c4d3c1268fa57f56b8157
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284000
Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38672}
2022-11-18 09:18:32 +00:00
41a0702886
Add new FYI bots to LKGR.
...
Bug: b/259076774
Change-Id: I85fef09668f0f6323b9fa17c9527154804192658
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#38671}
2022-11-18 08:15:57 +00:00
5214c2e7ff
Roll chromium_revision a5656eee8a..d88f4d4807 (1073122:1073228)
...
Change log: a5656eee8a..d88f4d4807
Full diff: a5656eee8a..d88f4d4807
Changed dependencies
* src/base: 2f1b850ecc..56ffff54e0
* src/testing: 839c76c372..8685a9c466
* src/third_party: 902a3397c9..639dff812c
* src/third_party/depot_tools: aad574d446..1f67d5573f
* src/third_party/perfetto: 3c036ab6b2..6f7678ba37
* src/tools: faef00b2b0..df48fb93ea
DEPS diff: a5656eee8a..d88f4d4807
/DEPS
No update to Clang.
BUG=None
Change-Id: Ie21d75dbfc87839d627e558392d4b957211b1829
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283886
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38670}
2022-11-18 06:44:03 +00:00
1ce8e73b1c
Roll chromium_revision 1548aaf181..a5656eee8a (1072908:1073122)
...
Change log: 1548aaf181..a5656eee8a
Full diff: 1548aaf181..a5656eee8a
Changed dependencies
* src/base: b11ec75f96..2f1b850ecc
* src/build: 9d94f67d27..316bdbb4f8
* src/buildtools/reclient: re_client_version:0.85.0.91db7be-gomaip..re_client_version:0.86.0.25feac0-gomaip
* src/ios: c05e8ff521..e78e9dfc41
* src/testing: 51c2e5c98c..839c76c372
* src/third_party: 0da83e0702..902a3397c9
* src/third_party/depot_tools: fe46d759b5..aad574d446
* src/third_party/perfetto: 209aac9ddf..3c036ab6b2
* src/tools: 8bb4bbb0e4..faef00b2b0
DEPS diff: 1548aaf181..a5656eee8a
/DEPS
No update to Clang.
BUG=None
Change-Id: Ibc109bc588cd15ba07243b8888df4e5984e4bc24
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283845
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38669}
2022-11-18 00:41:03 +00:00
170316d229
Trigger bots
...
No-Try: True
Bug: None
Change-Id: I8250ae5d20d75d67fe46dd5c7069d4a609ed3a9c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283900
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38668}
2022-11-17 21:29:53 +00:00
4f6642e366
Roll chromium_revision a7e348ff0b..1548aaf181 (1072775:1072908)
...
Change log: a7e348ff0b..1548aaf181
Full diff: a7e348ff0b..1548aaf181
Changed dependencies
* src/base: 0e107d728b..b11ec75f96
* src/build: a6b135f6dc..9d94f67d27
* src/ios: 483caa8160..c05e8ff521
* src/testing: 23e1170c36..51c2e5c98c
* src/third_party: 42191a7862..0da83e0702
* src/third_party/androidx: sfkd_7g8xAywUG-eSpRzB7GAqVc2NCrY1kQoBLGRVKkC..QywWz1_m6w-DIah4IXQ3I27LDjKgn9kUMTP1SEJgigUC
* src/third_party/perfetto: a3e39a91c2..209aac9ddf
* src/tools: 3dcc6c027c..8bb4bbb0e4
DEPS diff: a7e348ff0b..1548aaf181
/DEPS
No update to Clang.
BUG=None
Change-Id: Ife0342616180e74ce2e01514dc1979bad4e134c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283881
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38667}
2022-11-17 18:49:04 +00:00
1d17f73471
Roll chromium_revision 860957b646..a7e348ff0b (1072671:1072775)
...
Change log: 860957b646..a7e348ff0b
Full diff: 860957b646..a7e348ff0b
Changed dependencies
* src/base: 2d1d07fa07..0e107d728b
* src/ios: 5c7df1d8aa..483caa8160
* src/testing: 1f8966e6e2..23e1170c36
* src/third_party: c3da0f2e4e..42191a7862
* src/third_party/androidx: EVyo1fY0G8ksQeheveyA3ozISCvDG5fejcsZrQ53EZgC..sfkd_7g8xAywUG-eSpRzB7GAqVc2NCrY1kQoBLGRVKkC
* src/third_party/depot_tools: fadcbfdb27..fe46d759b5
* src/third_party/perfetto: b25d8d9bb1..a3e39a91c2
* src/tools: 3dcab21933..3dcc6c027c
DEPS diff: 860957b646..a7e348ff0b
/DEPS
No update to Clang.
BUG=None
Change-Id: I81f73e6e11f78c335712f185ef8b891ecbfdcd6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283860
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38666}
2022-11-17 15:03:35 +00:00
17887eb04a
Reland "[ACM] iSAC audio codec removed"
...
This is a reland of commit b46c4bf27ba5c417fcba7f200d80fa4634e7e1a1
Original change's description:
> [ACM] iSAC audio codec removed
>
> Note: this CL has to leave behind one part of iSAC, which is its VAD
> currently used by AGC1 in APM. The target visibility has been
> restricted and the VAD will be removed together with AGC1 when the
> time comes.
>
> Tested: see https://chromium-review.googlesource.com/c/chromium/src/+/4013319
>
> Bug: webrtc:14450
> Change-Id: I69cc518b16280eae62a1f1977cdbfa24c08cf5f9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282421
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38652}
Bug: webrtc:14450
Change-Id: Ia22c4d7724b6022238235fede93e36e570a49376
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283843
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38665}
2022-11-17 12:52:35 +00:00
e158b77427
Make PacingController circuit breaker configurable.
...
We have seen a few instances in a down-stream project where the circuit
breaker is still triggering and causing issues.
This CL makes the threshold configurable and adds more debug logging to
try and get to the bottom of this rarely occuring bug.
Bug: webrtc:11340, b/258509536
Change-Id: I92674d446b926ad66538ff9c8be2a32a3d95b057
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283762
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38664}
2022-11-17 12:26:24 +00:00
5dd548261f
APM: Signal error on unsupported sample rates
...
This CL adds more explicit tests for unsupported sample rates in the WebRTC audio processing module (APM). Rates are restricted to the range [8000, 384000] Hz. Rates outside this range are handled as best as possible, depending on the format.
Tested: bitexact on a large number of aecdumps
Bug: chromium:1332484, chromium:1334991
Change-Id: I9639d03dc837e1fdff64d1f9d1fff0edc0fb299f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276920
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38663}
2022-11-17 12:12:04 +00:00
116c0a53d4
[DVQA] Create separate BUILD.gn file for video analyzer
...
Bug: None
Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
No-try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38662}
2022-11-17 11:53:44 +00:00
408f0be5c2
APM: remove WebRTC.Audio.Agc.DigitalGain* histograms from AGC1
...
Bug: chromium:1308676
Change-Id: Ib8d8f78a9ee9ac424495017455a5bc6aa400d8ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283663
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Hanna Silen <silen@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38661}
2022-11-17 11:10:44 +00:00
9eb1ff3ac0
Revert "video_layer_allocation: clean up unused code"
...
This reverts commit 05b58ad77e79efc5b4750f40b5092f945f0fff4d.
Reason for revert: UB because the shift exponent (-2) is negative
(UB happens at this line https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/rtp_rtcp/source/rtp_video_layers_allocation_extension.cc;l=279;drc=05b58ad77e79efc5b4750f40b5092f945f0fff4d ).
Original change's description:
> video_layer_allocation: clean up unused code
>
> remove unused support for more than four spatial layer descriptions
> of temporal layers
>
> BUG=webrtc:12000
>
> Change-Id: I087bcd020897898636bdf9c838abafa8c73c53f3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281320
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
> Commit-Queue: Philipp Hancke <phancke@microsoft.com >
> Reviewed-by: Per Kjellander <perkj@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38646}
Bug: webrtc:12000, webrtc:14678
Change-Id: Ib94a0dead98aeb84af9b91c0ca6ad0893e8f2874
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283840
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38660}
2022-11-17 09:58:29 +00:00
c30835c712
Remove deprecated AddPeer method.
...
Change-Id: Icd15dc4d7d79276734260fb11932d9ede8dbbf23
Bug: webrtc:14627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283661
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#38659}
2022-11-17 09:00:21 +00:00
2405298a28
Roll chromium_revision 2fd3808a0e..860957b646 (1072560:1072671)
...
Change log: 2fd3808a0e..860957b646
Full diff: 2fd3808a0e..860957b646
Changed dependencies
* src/base: 87ea13b25d..2d1d07fa07
* src/ios: c030f9b439..5c7df1d8aa
* src/testing: 404d10e36f..1f8966e6e2
* src/third_party: 0c347f5fad..c3da0f2e4e
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/db897bb206..79ba9244e5
* src/third_party/depot_tools: 25cf78395c..fadcbfdb27
* src/third_party/perfetto: 31d7f4d967..b25d8d9bb1
* src/tools: 09317a515a..3dcab21933
DEPS diff: 2fd3808a0e..860957b646
/DEPS
No update to Clang.
BUG=None
Change-Id: Ifa4a88565e89742928451a47a47f8f6040147d77
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283788
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38658}
2022-11-17 08:37:55 +00:00
ef005bc924
Unwrap the presentation timestamp before calling aom_codec_encode in LibaomAv1Encoder.
...
Bug: webrtc:14673
Change-Id: I0358fed5ac0839994482c5fb049c13e442f82c82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283701
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38657}
2022-11-17 08:32:18 +00:00
d3d1dfd8f2
Roll chromium_revision 00e7560e02..2fd3808a0e (1072315:1072560)
...
Change log: 00e7560e02..2fd3808a0e
Full diff: 00e7560e02..2fd3808a0e
Changed dependencies
* src/base: 0ac42ade73..87ea13b25d
* src/build: 4cc6d1aa2f..a6b135f6dc
* src/buildtools: bbb2301eef..09154d65c3
* src/buildtools/third_party/libc++/trunk: 81925935fd..cd0a050474
* src/ios: 5593bf80b6..c030f9b439
* src/testing: 51a4617f34..404d10e36f
* src/third_party: a8a40fa887..0c347f5fad
* src/third_party/androidx: krelcrYOcHkMcS_4oxzOl4ya1ady7UK4lOj118kjMTEC..EVyo1fY0G8ksQeheveyA3ozISCvDG5fejcsZrQ53EZgC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c8506af0cf..db897bb206
* src/third_party/depot_tools: 63fea808b0..25cf78395c
* src/third_party/libvpx/source/libvpx: 5245f6e9cb..605350bd5b
* src/tools: 01bf990e5a..09317a515a
DEPS diff: 00e7560e02..2fd3808a0e
/DEPS
No update to Clang.
BUG=None
Change-Id: I2f776ee379de824adc03b2ac00f2b2b55ba37089
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283784
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38656}
2022-11-17 02:51:32 +00:00
fbeb76ab51
Revert "[ACM] iSAC audio codec removed"
...
This reverts commit b46c4bf27ba5c417fcba7f200d80fa4634e7e1a1.
Reason for revert: breaks a downstream project
Original change's description:
> [ACM] iSAC audio codec removed
>
> Note: this CL has to leave behind one part of iSAC, which is its VAD
> currently used by AGC1 in APM. The target visibility has been
> restricted and the VAD will be removed together with AGC1 when the
> time comes.
>
> Tested: see https://chromium-review.googlesource.com/c/chromium/src/+/4013319
>
> Bug: webrtc:14450
> Change-Id: I69cc518b16280eae62a1f1977cdbfa24c08cf5f9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282421
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38652}
Bug: webrtc:14450
Change-Id: Ice138004e84e8c5f896684e8d01133d4b2a77bb7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283800
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38655}
2022-11-16 20:40:52 +00:00
cb2b133bf0
Ignore write-compiled-tests-json-to-writable-path flag.
...
Change-Id: Ic084a9a1eb77bde1eda6439d7aafe1c208f0595d
Bug: webrtc:14677
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283761
Owners-Override: Jeremy Leconte <jleconte@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38654}
2022-11-16 19:28:53 +00:00
cd4456e336
Roll chromium_revision d0a7f261ef..00e7560e02 (1072160:1072315)
...
Change log: d0a7f261ef..00e7560e02
Full diff: d0a7f261ef..00e7560e02
Changed dependencies
* src/base: cc47026402..0ac42ade73
* src/build: 91eb84e37e..4cc6d1aa2f
* src/ios: 0f3c8e2571..5593bf80b6
* src/testing: 7504d21120..51a4617f34
* src/third_party: 9b390d0879..a8a40fa887
* src/third_party/androidx: 06CY8QJEKQvLc6nEso6R3iTnrmW1NDVyz5Mmsu5y5_MC..krelcrYOcHkMcS_4oxzOl4ya1ady7UK4lOj118kjMTEC
* src/third_party/perfetto: d74cb19ee8..31d7f4d967
* src/third_party/r8: -NUQfUfOV_01dV0d71XGUoe7FpVrH5M31W17eU8pLd0C..SRv8kr_t534yPmvzQnKEBqgw_lidewzTdKnAKoWYkz0C
* src/tools: 09c4890cad..01bf990e5a
DEPS diff: d0a7f261ef..00e7560e02
/DEPS
Clang version changed llvmorg-16-init-10289-g094c0ecc:llvmorg-16-init-10467-g1239d37b
Details: d0a7f261ef..00e7560e02
/tools/clang/scripts/update.py
BUG=None
Change-Id: Icf9b401c9274c88b7adc98171da2e4568a232767
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283780
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38653}
2022-11-16 18:50:02 +00:00
b46c4bf27b
[ACM] iSAC audio codec removed
...
Note: this CL has to leave behind one part of iSAC, which is its VAD
currently used by AGC1 in APM. The target visibility has been
restricted and the VAD will be removed together with AGC1 when the
time comes.
Tested: see https://chromium-review.googlesource.com/c/chromium/src/+/4013319
Bug: webrtc:14450
Change-Id: I69cc518b16280eae62a1f1977cdbfa24c08cf5f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282421
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38652}
2022-11-16 16:42:55 +00:00
6aa755c201
Remove FrameCombiner stats
...
Stop logging WebRTC.Audio.AudioMixer.* histograms.
Bug: chromium:1308711, chromium:1328289
Change-Id: Iba1c89a112842c532d99900cd54aee7f38f759fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283680
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38651}
2022-11-16 15:39:24 +00:00
b301b58b3f
Rename CI Android testers.
...
This makes it easier to update devices in th e future (avoiding multiple
CLs to change names, etc..).
Bug: b/259076774
Change-Id: I20ae940823978fbae84495d266345e4990184130
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283720
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38650}
2022-11-16 15:38:21 +00:00
99543ae75f
Revert "Remove backwards compatibility functions in openssl"
...
This reverts commit 4db5b979b749ce1141d1406391499715e697f34d.
Reason for revert: Breaks downstream project
Original change's description:
> Remove backwards compatibility functions in openssl
>
> After changing base functions to a CHECK instead of an =0, these
> are no longer needed.
>
> Bug: webrtc:14632
> Change-Id: If3f1a62905cf433486f4974b2153c9210d1e045b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283542
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38643}
Bug: webrtc:14632
Change-Id: I4c0ec753285fab882f60b059b3d34f772bf5f7e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283721
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38649}
2022-11-16 14:24:11 +00:00
52b0ef7926
InputVolumeController: Make input volume update wait frames configurable
...
Replace kUpdateInputVolumeWaitFrames with
update_input_volume_wait_frames in InputVolumeController::Config.
Also, fix an off-by-one error in the frame count to give a better
readability for non-zero wait frames. Now
update_input_volume_wait_frames_ = 100 allows updates every 100 frames
instead of every 101 frames. Effectively, this makes
update_input_volume_wait_frames = 0 and 1 to behave similarly (i.e.,
they now both allow updates after every frame).
Bug: webrtc:7494
Change-Id: I597f7e88895a4dcd365dc6dee526acb9d971b2fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282863
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Hanna Silen <silen@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38648}
2022-11-16 13:48:54 +00:00
91e6987f66
Add a service account for the Android Perf bots.
...
Change-Id: I02446fbca310a70172160d4bf345428413094bda
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283662
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38647}
2022-11-16 13:20:14 +00:00
05b58ad77e
video_layer_allocation: clean up unused code
...
remove unused support for more than four spatial layer descriptions
of temporal layers
BUG=webrtc:12000
Change-Id: I087bcd020897898636bdf9c838abafa8c73c53f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281320
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@microsoft.com >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38646}
2022-11-16 13:07:35 +00:00
11be12118b
Roll chromium_revision d8a5ccea61..d0a7f261ef (1072044:1072160)
...
Change log: d8a5ccea61..d0a7f261ef
Full diff: d8a5ccea61..d0a7f261ef
Changed dependencies
* src/base: 0d7efe3150..cc47026402
* src/build: dc9ae81874..91eb84e37e
* src/ios: 68b752280a..0f3c8e2571
* src/testing: 1658580c21..7504d21120
* src/third_party: 9cae3e38af..9b390d0879
* src/third_party/androidx: S-O8vat1G6foJoqAgxU92SlGn71HS1Kw31OCiSEf1aUC..06CY8QJEKQvLc6nEso6R3iTnrmW1NDVyz5Mmsu5y5_MC
* src/third_party/freetype/src: 47e61d02e6..0f43a0e7eb
* src/tools: 1b040888a4..09c4890cad
DEPS diff: d8a5ccea61..d0a7f261ef
/DEPS
No update to Clang.
BUG=None
Change-Id: I489fee1b920ea409b9cc86fb26a952dbdf70d441
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283643
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38645}
2022-11-16 12:52:22 +00:00
45c882e4be
Allow maxptime equal to minptime in the SDP.
...
The DCHECK crashes debug builds running some applications such as Webex.
Bug: None
Change-Id: I0061286c4c1d04964678a00014896f1fccd4685d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276460
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38644}
2022-11-16 10:54:03 +00:00
4db5b979b7
Remove backwards compatibility functions in openssl
...
After changing base functions to a CHECK instead of an =0, these
are no longer needed.
Bug: webrtc:14632
Change-Id: If3f1a62905cf433486f4974b2153c9210d1e045b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283542
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38643}
2022-11-16 10:09:33 +00:00
e844aad41a
Convert StreamInterfaceChannel to new API
...
Bug: webrtc:14632
Change-Id: I5c78fe6903680c65efde5d09a8988b97256a22ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283526
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38642}
2022-11-16 10:01:28 +00:00
7ccd88f3e5
Convert SocketStream to use new StreamInterface API
...
Bug: webrtc:14632
Change-Id: I09a6799a9b70f073dde5b7074e4431570c8c9c67
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283543
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38641}
2022-11-16 09:55:47 +00:00
3e0658beec
Convert FifoBuffer to new StreamInterface API
...
Bug: webrtc:14632
Change-Id: Id6d17d0402c5e3a0e24258c7afa38ca34e7ab227
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283541
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38640}
2022-11-16 09:53:16 +00:00
dd4c4068d9
Convert MemoryStream to use new StreamInterface
...
Bug: webrtc:14632
Change-Id: Id6a7e011a6102e829a14de246d07a9aab1e6934f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283620
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38639}
2022-11-16 09:51:42 +00:00
da4c102cbd
Refactor some config plumbing in call/.
...
Address perkj's comments left in
https://webrtc-review.googlesource.com/c/src/+/283420 . I was a bit
trigger-happy with the submit button.
Bug: chromium:1354491
Change-Id: Ifd052f75af3763b0b52807c31ea790e3efee921d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283521
Reviewed-by: Erik Språng <sprang@webrtc.org >
Auto-Submit: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38638}
2022-11-16 09:18:40 +00:00
e085366aca
Fix some minor issues with the android bots.
...
* Use the same logdog_butler as Chromium instead of redefining one.
* Use luci-auth to prevent "local auth - HTTP 400" errors.
Change-Id: I2a0d1393f9f0e1e41b2bcc9a9fec2c50c19675f3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#38637}
2022-11-16 09:09:25 +00:00
d2811761e3
Probe when bandwidth is loss limited and the estimate is increasing.
...
Add loss_limited_probe_scale as a scale factor which decides how much we should probe when bandwidth is loss limited.
Bug: webrtc:12707
Change-Id: I194b2b40c9a7861d82b61585bcaf484ab228eedb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281360
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Diep Bui <diepbp@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38636}
2022-11-16 08:34:55 +00:00
34cdb1f53c
Update WebRTC code version (2022-11-16T04:16:11).
...
Bug: None
Change-Id: I9820a3c7a3b00298d2f508a40056c3ba8e5d50dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283582
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38635}
2022-11-16 05:50:11 +00:00
4185a91592
Roll chromium_revision 2a7d079c94..d8a5ccea61 (1071929:1072044)
...
Change log: 2a7d079c94..d8a5ccea61
Full diff: 2a7d079c94..d8a5ccea61
Changed dependencies
* src/build: 03e92e66ac..dc9ae81874
* src/ios: a78479eedd..68b752280a
* src/testing: ceea53318e..1658580c21
* src/third_party: b2c37036a0..9cae3e38af
* src/third_party/androidx: iNoaT9ZH8Kb09RzWBoB2EOHFJriOyGU8Lrl8b1lLftQC..S-O8vat1G6foJoqAgxU92SlGn71HS1Kw31OCiSEf1aUC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/51caf6b3c7..c8506af0cf
* src/third_party/depot_tools: 8de7b2d51b..63fea808b0
* src/third_party/perfetto: 5048c2cc76..d74cb19ee8
* src/tools: 1857bf3a43..1b040888a4
DEPS diff: 2a7d079c94..d8a5ccea61
/DEPS
No update to Clang.
BUG=None
Change-Id: Ia5268e0c85de51ca7dbeeb1f303a88204d05481f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283583
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38634}
2022-11-16 05:11:45 +00:00
82c8e4af7c
Roll chromium_revision b40f8acc71..2a7d079c94 (1071778:1071929)
...
Change log: b40f8acc71..2a7d079c94
Full diff: b40f8acc71..2a7d079c94
Changed dependencies
* src/base: c2af4cf927..0d7efe3150
* src/build: 805d76ce61..03e92e66ac
* src/ios: 27b1b2066b..a78479eedd
* src/testing: 37551da20c..ceea53318e
* src/third_party: f217d79138..b2c37036a0
* src/third_party/perfetto: 3692281b7c..5048c2cc76
* src/tools: 3fd9d9e9d8..1857bf3a43
DEPS diff: b40f8acc71..2a7d079c94
/DEPS
No update to Clang.
BUG=None
Change-Id: Iffc0c2508469fd52205b7e68a2f2c90809d18175
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283581
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38633}
2022-11-16 02:46:03 +00:00
c40cf325b7
Remove flag PaceAtLossBaseBweWhenLoss as it is not used.
...
Change-Id: Ie08745e302c1fe582d4ed3b86e96d7a95d021d78
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283361
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Diep Bui <diepbp@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38632}
2022-11-15 23:34:04 +00:00
1b8f2d59c4
Roll chromium_revision e8dc2013b5..b40f8acc71 (1071546:1071778)
...
Change log: e8dc2013b5..b40f8acc71
Full diff: e8dc2013b5..b40f8acc71
Changed dependencies
* src/base: d95e0b6a1c..c2af4cf927
* src/build: 5bd2e64d76..805d76ce61
* src/buildtools: 02b18cf1ec..bbb2301eef
* src/buildtools/third_party/libc++/trunk: 3fc0bf23fe..81925935fd
* src/ios: 9084c54366..27b1b2066b
* src/testing: d4740ae9e1..37551da20c
* src/third_party: 5e5ccc3d7f..f217d79138
* src/third_party/androidx: V3PkSsCDMLdnBiK-JYZxKE7daw8w47BkJbUGE8Yw1MUC..iNoaT9ZH8Kb09RzWBoB2EOHFJriOyGU8Lrl8b1lLftQC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/670186d696..51caf6b3c7
* src/third_party/perfetto: 008a2ca9b9..3692281b7c
* src/third_party/r8: Sbfuk7zCRoVjO5aIbd3nmDH8TcDZPNFY2k7srra6NIcC..-NUQfUfOV_01dV0d71XGUoe7FpVrH5M31W17eU8pLd0C
* src/tools: 83cdfec2bd..3fd9d9e9d8
DEPS diff: e8dc2013b5..b40f8acc71
/DEPS
No update to Clang.
BUG=None
Change-Id: I1731ef23553b835d81ab5071a9645cb7884367b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283560
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38631}
2022-11-15 20:43:23 +00:00
2803ca27fb
Remove virtual from wasteful functions
...
I've been working with SizeBench (binary size analysis tool) and it
reported that 39 virtual functions were not overridden. Removed
virtual keyword from each. SizeBench estimated waste 2.1kb. Change
made chrome.dll 5.3kb smaller. Since these 39 virtual functions
are never overridden, they are wasteful.
Note: These are the savings for Windows, relocation savings are probably larger on other platforms.
GN args for builds:
use_goma=true
is_debug=false
target_cpu="x64"
use_lld=false
fatal_linker_warnings=false
symbol_level=2
dcheck_always_on = false
pe_summarize analysis pre-change -> change:
Size of out\Default\chrome.dll is 187.205120 MB
Size of out\MediaContentDescription\chrome.dll is 187.199488 MB
Memory size change from out\Default\chrome.dll to
out\MediaContentDescription\chrome.dll
.text: -2624 bytes change
.rdata: -1984 bytes change
.pdata: -48 bytes change
.reloc: -644 bytes change
Total change: -5300 bytes
Bug: chromium:1371503
Change-Id: Ib33829fada54abdf8fed33ec96f11a03ce6fcb68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281442
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Ivan Rosales <rosalesi@google.com >
Cr-Commit-Position: refs/heads/main@{#38630}
2022-11-15 19:46:52 +00:00
954cf1f853
Update mixins (copying ones removed by Chromium).
...
Bug: None
Change-Id: I7fe81736c27d0d3091d24553cb8a17286bdb9c27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283540
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38629}
2022-11-15 16:47:30 +00:00
76bd5a80ea
Migrate WebRTC postsubmit to Walleye (from Bullhead).
...
Bug: b/259076774
Change-Id: I9237a454bf88427bc03f8e4d801c126b259a2231
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283460
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#38628}
2022-11-15 16:10:55 +00:00
acabb3641b
pc: Add asynchronous RtpSender::SetParameters() call
...
As the synchronous version only posts a task to recreate the encoder
later, it is not possible to catch errors and state changes that
could appear then.
The asynchronous version of SetParameters() aims to solve this by
providing a callback to wait for the completion of the encoder
reconfiguration, allowing any error to be propagate and subsequent
getParameters() call to have up to date information.
Bug: webrtc:11607
Change-Id: I5548e75aa14a97f8d9c0c94df1e72e9cd40887b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278420
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38627}
2022-11-15 15:31:40 +00:00
7d8d64323c
Bound loss based estimate by upper link capacity when bandwidth is loss limited.
...
Motivation: loss based ramp-up can be incorrect when (1) bandwidth is loss limited, and (2) delay based estimate might be incorrect due to no delay signals. Therefore, bounding the loss based estimate by the delay based estimate is not much helpful in those cases.
Thus strengthening the bounding logic by using upper link capacity is one of solutions to avoid incorrect ramp-up.
Without the change: screen/qmLedxapJWvUTmn
With the change: screen/8sQcksWa6CptywK
Bug: webrtc:12707
Change-Id: I32ba82693b3ffa83cbb89c2cc9690fe16fb10c78
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283085
Commit-Queue: Diep Bui <diepbp@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38626}
2022-11-15 14:53:05 +00:00