Commit Graph

37788 Commits

Author SHA1 Message Date
818163b939 Update WebRTC code version (2022-08-08T04:02:58).
Bug: None
Change-Id: If61b7921fad21309cb298ecd2e4266e20593c51c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270861
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37706}
2022-08-08 06:42:45 +00:00
2bb8306b40 Roll chromium_revision 82fcff7645..502fb88343 (1032284:1032384)
Change log: 82fcff7645..502fb88343
Full diff: 82fcff7645..502fb88343

Changed dependencies
* src/buildtools: a0c1db7a1f..792b1bcdcb
* src/buildtools/third_party/libc++/trunk: d3b184e377..a5da9d82f5
* src/ios: e192e69f02..8f1a1c38e7
* src/third_party: ee28845106..0a55c309e4
* src/third_party/androidx: oQVmxoZfDdo9Mj05wSSn9d3L7V49brnXoS-_uhaTmO4C..pGixzD_GPP5LYpq_3Ynl0_u7lAK5-APenoVgA7rTxI0C
* src/third_party/fuchsia-sdk/sdk: version:9.20220805.3.1..version:9.20220806.1.1
* src/third_party/r8: 2hvl2k3joC-JDLAwGjZsfj41stBLPQ0yTXoLLdc0JycC..IBW3UYermEa3GRA8TK8U8l7zQEPKBCQOt8d4K4QAHtsC
* src/tools: 5cdd4ab709..1329f8fa5d
DEPS diff: 82fcff7645..502fb88343/DEPS

Clang version changed llvmorg-16-init-572-gdde41c6c:llvmorg-16-init-907-g8b740747
Details: 82fcff7645..502fb88343/tools/clang/scripts/update.py

BUG=None

Change-Id: Idd307389a987558575b63d7bdfb1628e2bc7bf99
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270837
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37705}
2022-08-07 20:22:05 +00:00
d60aca679e Roll chromium_revision 10023f69e9..82fcff7645 (1032179:1032284)
Change log: 10023f69e9..82fcff7645
Full diff: 10023f69e9..82fcff7645

Changed dependencies
* src/build: 39974c5487..b1868b3db9
* src/ios: 05b460102b..e192e69f02
* src/testing: 2bd3867047..6194595a2d
* src/third_party: 1c808c4992..ee28845106
* src/third_party/androidx: gAsD4l8EoP_W0IH5vzedZ1tyN3-wAP8-fqkaS_mX6rcC..oQVmxoZfDdo9Mj05wSSn9d3L7V49brnXoS-_uhaTmO4C
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d4a09458ea..1c7fc8f4bd
* src/third_party/fuchsia-sdk/sdk: version:9.20220805.2.1..version:9.20220805.3.1
* src/third_party/r8: MQolCMavu5-KSAcEH_GUHAmKTQ1g5ydGaNBmKfh7czkC..2hvl2k3joC-JDLAwGjZsfj41stBLPQ0yTXoLLdc0JycC
* src/tools: 83783e5c8f..5cdd4ab709
DEPS diff: 10023f69e9..82fcff7645/DEPS

No update to Clang.

BUG=None

Change-Id: Ia80afbfd9424a47171bdfe58b11b34ac957f720b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270822
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37704}
2022-08-06 14:57:14 +00:00
c9734b75f6 Update WebRTC code version (2022-08-06T04:06:06).
Bug: None
Change-Id: I13f6d17702826042edf570567018cedf1151ec39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270801
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37703}
2022-08-06 05:52:33 +00:00
43570da849 Roll chromium_revision 3317fac197..10023f69e9 (1031940:1032179)
Change log: 3317fac197..10023f69e9
Full diff: 3317fac197..10023f69e9

Changed dependencies
* src/base: 684ef53310..e96a1f68e7
* src/build: 106487a141..39974c5487
* src/buildtools: d8dba7f2b7..a0c1db7a1f
* src/buildtools/third_party/libc++/trunk: a47a05b6a0..d3b184e377
* src/ios: bd521b8467..05b460102b
* src/testing: 5f6b03f7eb..2bd3867047
* src/third_party: cc18a8be41..1c808c4992
* src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib: version:2@1.7.0.cr1..version:2@1.7.10.cr1
* src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_common: version:2@1.7.0.cr1..version:2@1.7.10.cr1
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/dcdf418945..d4a09458ea
* src/third_party/fuchsia-sdk/sdk: version:9.20220805.1.1..version:9.20220805.2.1
* src/third_party/perfetto: c7072e645e..f44970fbda
* src/tools: 49e8ad1ccd..83783e5c8f
DEPS diff: 3317fac197..10023f69e9/DEPS

No update to Clang.

BUG=None

Change-Id: I806e9c6b34e1312b3d54f1fd2ee6595f002b9a97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270761
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37702}
2022-08-06 01:00:43 +00:00
3900f21702 Make nack history configurable.
This allows for `config_.rtp.nack.rtp_history_ms` to be modified
without deleting and recreating video receive streams.

Bug: webrtc:11993
Change-Id: I8ba132b22fe0e6de03d1c42fc38a570cbe138817
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269301
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37701}
2022-08-05 22:58:43 +00:00
cfe1ab7ed2 Roll chromium_revision 1093aeb892..3317fac197 (1031789:1031940)
Change log: 1093aeb892..3317fac197
Full diff: 1093aeb892..3317fac197

Changed dependencies
* src/base: 91286a48e7..684ef53310
* src/build: 664331e40d..106487a141
* src/buildtools: 56cc5bc223..d8dba7f2b7
* src/buildtools/third_party/libc++/trunk: e3598c2dc0..a47a05b6a0
* src/buildtools/third_party/libunwind/trunk: c5d3129a8b..47974e9376
* src/ios: 15c4bf6d3b..bd521b8467
* src/testing: 230a11a4ba..5f6b03f7eb
* src/third_party: b93dd8afa9..cc18a8be41
* src/third_party/fuchsia-sdk/sdk: version:9.20220804.2.1..version:9.20220805.1.1
* src/third_party/perfetto: cb46e0562e..c7072e645e
* src/tools: d934b81af5..49e8ad1ccd
DEPS diff: 1093aeb892..3317fac197/DEPS

No update to Clang.

BUG=None

Change-Id: I2b53ed6a205f21135c77b787d9d004715dd744d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270727
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37700}
2022-08-05 16:33:33 +00:00
3bfafb5cab Reenable WebRTC PushResampler format checks on Windows clang debug builds
The referenced bug is fixed and issues like this haven't been observed for a long time.

Follow up CL to https://webrtc-review.googlesource.com/c/src/+/268769/comments/8777e26e_0356bffb

Bug: chromium:615050
Change-Id: I8f9e5db5a1b9c787867598e973a367a5c5e367df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269761
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37699}
2022-08-05 11:03:08 +00:00
15b2ca7e77 Clean up VCMFrameInformation
* Removes unused userData
* Switches render time to a timestamp.

Bug: None
Change-Id: If6e055e9f5486081a850691f6c481c89b59d5de2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270580
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37698}
2022-08-05 11:00:37 +00:00
da6291e85d WebRTC voice engine: Remove duplicate and confusing logs
The line "No audio processing module present [...]" has mislead people several times (see linked bug for one example) and does not add any information that cannot already relatively easily be inferred from platform configuration.

Other removed lines are duplicate (already logged via AudioOptions::ToString()) or never runs (ApplyOptions always returns true + empty #elif).

Bug: b/238780321#comment34
Change-Id: Ie0fbd6675ec963c1180a7f614ec74bba5e850777
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270483
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37697}
2022-08-05 10:10:47 +00:00
e94b175c42 Attach video sink only after VideoSendStream is started.
By attaching the sink when all is set up, we make it possible for an
application to listen for that event - and only then start producing
frames. Otherwise frames risk being dropped during the setup phase.

Bug: webrtc:14276
Change-Id: I0a906681fc526b0ee88c60a842afb0d68e21de14
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270660
Auto-Submit: Erik Språng <sprang@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37696}
2022-08-05 08:52:47 +00:00
7ed05c00bb Update WebRTC code version (2022-08-05T04:04:19).
Bug: None
Change-Id: I192dc0a208921b513f41ba4f5d1fd1b3e515465e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270721
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37695}
2022-08-05 07:19:26 +00:00
043a80320c Map the stopped transceiver direction on Android
Fixes IllegalArgumentException when native calls fromNativeIndex.

Bug: webrtc:14320
Change-Id: I0f0717852abd009e17c6f67639f1bf2262df8dfd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270622
Commit-Queue: Xavier Lepaul‎ <xalep@webrtc.org>
Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37694}
2022-08-05 07:03:16 +00:00
a0e090ff5a Added an API to disable VolumeLogger on Android.
Change-Id: Ib16c9e02fe18e1d6628f2192a21c53515753bcde
Bug: webrtc:14321
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270621
Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org>
Commit-Queue: Xavier Lepaul‎ <xalep@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37693}
2022-08-05 06:59:37 +00:00
5bb566cf1e Roll chromium_revision 246841c6cf..1093aeb892 (1031679:1031789)
Change log: 246841c6cf..1093aeb892
Full diff: 246841c6cf..1093aeb892

Changed dependencies
* src/base: 63b71b0e43..91286a48e7
* src/ios: 96b9b405e9..15c4bf6d3b
* src/testing: 3e4bb012ca..230a11a4ba
* src/third_party: 16988ac384..b93dd8afa9
* src/third_party/fuchsia-sdk/sdk: version:9.20220804.0.1..version:9.20220804.2.1
* src/third_party/libyuv: 9892d70c96..d53f1beecd
* src/tools: ee10a59e4a..d934b81af5
DEPS diff: 246841c6cf..1093aeb892/DEPS

No update to Clang.

BUG=None

Change-Id: I57235e2ec3716cbde6e194be8bbbb64599dd00e4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270722
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37692}
2022-08-05 06:50:37 +00:00
1943f3e9fa Roll chromium_revision 5b86557451..246841c6cf (1031490:1031679)
Change log: 5b86557451..246841c6cf
Full diff: 5b86557451..246841c6cf

Changed dependencies
* src/base: 91c6b3a09e..63b71b0e43
* src/build: a81206dde3..664331e40d
* src/ios: faf11bf765..96b9b405e9
* src/testing: 7192eb9ac4..3e4bb012ca
* src/third_party: eae2472ed1..16988ac384
* src/third_party/perfetto: 28de3d8549..cb46e0562e
* src/third_party/r8: 8RiUzjctgueOdfuqGNeXwdR_7AGlMwPM9A01M3uKD88C..MQolCMavu5-KSAcEH_GUHAmKTQ1g5ydGaNBmKfh7czkC
* src/tools: 7c43fff6e5..ee10a59e4a
DEPS diff: 5b86557451..246841c6cf/DEPS

No update to Clang.

BUG=None

Change-Id: Ic32a3eb9ce038309cfcb28c91aa4abe040612bf0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270700
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37691}
2022-08-05 00:36:06 +00:00
57a7c2fece Roll chromium_revision 84d7c32650..5b86557451 (1031369:1031490)
Change log: 84d7c32650..5b86557451
Full diff: 84d7c32650..5b86557451

Changed dependencies
* src/base: 6f6c64ff5a..91c6b3a09e
* src/build: 0ad6539347..a81206dde3
* src/ios: 20c4d49b4a..faf11bf765
* src/testing: 915a8eb0cc..7192eb9ac4
* src/third_party: 2123fbd574..eae2472ed1
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/97daa816fc..dcdf418945
* src/third_party/freetype/src: dcb5fc5bcd..90e1e39f50
* src/third_party/fuchsia-sdk/sdk: version:9.20220803.3.1..version:9.20220804.0.1
* src/third_party/libyuv: 98ec7c28d5..9892d70c96
* src/third_party/perfetto: 470bc189f5..28de3d8549
* src/tools: 0ae528e2c3..7c43fff6e5
DEPS diff: 84d7c32650..5b86557451/DEPS

No update to Clang.

BUG=None

Change-Id: Ida4293fd3bf567139b770080f1999cdb35f0b444
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270623
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37690}
2022-08-04 14:32:06 +00:00
b0a57d8e61 Option to pack unstripped .so into libwebrtc.aar
Bug: webrtc:12508
Change-Id: I12e9e9efabc9e8669cad1ff6be9919fef5027da7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270423
Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org>
Commit-Queue: Xavier Lepaul‎ <xalep@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37689}
2022-08-04 13:31:45 +00:00
e644a4bde0 [WebRtcVideoReceiveStream] Add SetLossNotificationEnabled
...to allow for turning on/off loss notifications for video receive
streams without tearing down and recreating the whole stream.

Bug: webrtc:11993
Change-Id: Ia961bd343ce816ffe3414f11e3a58bb3c235307c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269252
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37688}
2022-08-04 11:59:57 +00:00
39ff241eac Add test for VP9 temporal shift to VideoSendStreamTest.
Bug: webrtc:13960
Change-Id: Ibd856df05ed8b1ee0714df6fbef000aa8f105c40
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269760
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37687}
2022-08-04 08:54:16 +00:00
76f17a146f Roll chromium_revision 37e6feabf4..84d7c32650 (1031229:1031369)
Change log: 37e6feabf4..84d7c32650
Full diff: 37e6feabf4..84d7c32650

Changed dependencies
* src/base: 83c3b82412..6f6c64ff5a
* src/build: ba5f61d439..0ad6539347
* src/ios: e74dc7b4ed..20c4d49b4a
* src/testing: 609411237d..915a8eb0cc
* src/third_party: cf86a7918c..2123fbd574
* src/third_party/android_build_tools/aapt2: hf9C5IyJUUGaBnzqu60xiFJSyfAmjqjc_PiNXNVc9l0C..nSnWUNu6ssPA-kPMvFQj4JjDXRWj2iubvvjfT1F6HCMC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/b95124305a..adaa322b63
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/47a2365de2..97daa816fc
* src/third_party/fuchsia-sdk/sdk: version:9.20220803.1.1..version:9.20220803.3.1
* src/tools: 3cf8a7b6f7..0ae528e2c3
DEPS diff: 37e6feabf4..84d7c32650/DEPS

No update to Clang.

BUG=None

Change-Id: I7a69c2616e658851a235e85d578afc614d8727a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270540
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37686}
2022-08-04 07:17:55 +00:00
cc76c567ab Roll chromium_revision beee8267c9..37e6feabf4 (1031002:1031229)
Change log: beee8267c9..37e6feabf4
Full diff: beee8267c9..37e6feabf4

Changed dependencies
* src/base: e6aabe4cb0..83c3b82412
* src/build: 6423f04a6f..ba5f61d439
* src/buildtools/linux64: git_revision:9ef321772ecc161937db69acb346397e0ccc484d..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044
* src/buildtools/mac: git_revision:9ef321772ecc161937db69acb346397e0ccc484d..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044
* src/buildtools/third_party/libunwind/trunk: 012c3438e0..c5d3129a8b
* src/buildtools/win: git_revision:9ef321772ecc161937db69acb346397e0ccc484d..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044
* src/ios: 0622f2176e..e74dc7b4ed
* src/testing: 48be0fd309..609411237d
* src/third_party: c293196758..cf86a7918c
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7f8536d0bb..47a2365de2
* src/third_party/fuchsia-sdk/sdk: version:9.20220802.3.1..version:9.20220803.1.1
* src/third_party/perfetto: ce19ce7576..470bc189f5
* src/third_party/r8: fyrZX7YFSdaFh8Uqs1iTtsYtS8351A4ndoz7WiIIrDgC..8RiUzjctgueOdfuqGNeXwdR_7AGlMwPM9A01M3uKD88C
* src/tools: c2974f15f5..3cf8a7b6f7
DEPS diff: beee8267c9..37e6feabf4/DEPS

No update to Clang.

BUG=None

Change-Id: I3904b4af805f5a840ebf1feea852e467181c1005
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270456
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37685}
2022-08-03 22:40:45 +00:00
2ed6fc2217 In Vp9 encoder wrapper force key frame on svc controller request
Bug: chromium:1349761
Change-Id: I865a251ea87b0946ff0247cba5c3bf1e098dffab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270482
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37684}
2022-08-03 19:15:45 +00:00
821b92a66e Fix LogLineRef for when logging is disabled.
No-Try: True
Bug: b/238157120
Change-Id: Id8dd096884ba5808c78ea93f1886ca259d4573ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270484
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37683}
2022-08-03 15:16:54 +00:00
3bd444ffdb Clarify and extend test support for certain sample rates in audio processing
Sample rates not divisible by 100, in particular 11025 Hz and 22050 Hz, have long been used with APM in Chrome, but the support has never been stated explicitly.

This CL makes minor modifications to the APM API to clarify how rates are handled when 10 ms is not an integer number of samples. Unit tests are also extended to cover this case better.

This does not update all references to 10 ms and implicit floor(sample_rate/100) computations, but it does at least take us closer to a correct API.

Note that not all code needs to support these sample rates. For example, audio processing submodules only need to operate on the native APM rates 16000, 32000, 48000.

Bug: chromium:1332484
Change-Id: I1dad15468f6ccb9c0d4d09c5819fe87f8388d5b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268769
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37682}
2022-08-03 14:26:36 +00:00
da2afbd70c Remove sigslot usage from DtmfProviderInterface
Bug: webrtc:11943
Change-Id: I452efbb099affc10e9197573fa0e40094a0d90ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270420
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37681}
2022-08-03 14:16:35 +00:00
9582f7548c [WebRtcVideoReceiveStream] Split initial config and reconfiguration.
This is a step towards getting rid of reconfiguration via tearing down
and reconstructing receive streams when parts of the configuration
change at runtime.

Bug: webrtc:11993
Change-Id: I337e523f17805b75826ddbd75bd3d0eb6e910bd8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269250
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37680}
2022-08-03 14:05:24 +00:00
73f0c21640 Fix const correctness.
Bug: b/238157120
Change-Id: I2887b5be48d841c9ff915d669fb623b77f1e21d1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270481
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37679}
2022-08-03 13:53:14 +00:00
07eaddf939 Inline assert in RTC_DCHECK_RUN_ON macro
clangd ignores ASSERT_EXCLUSIVE_LOCK macro attached to an inline function in header, thus IDEs relying on clangd issue false positive warnings about members acceesses without the check of the current sequence.
Attaching assert attribute to an inlined lambda function seems to solve that issue

Bug: None
Change-Id: I6199fee26061aa4223f2e3ea7b7b14bb5820c0bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270480
Reviewed-by: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37678}
2022-08-03 13:28:28 +00:00
70ed471836 Test logging also with Windows paths.
Bug: None
Change-Id: Ic5d52b90d3a3f245bd9d2f56cda85b0cc1a1ef8d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270460
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37677}
2022-08-03 13:23:46 +00:00
47114f25e3 Roll chromium_revision 88bd4f95d9..beee8267c9 (1030881:1031002)
Change log: 88bd4f95d9..beee8267c9
Full diff: 88bd4f95d9..beee8267c9

Changed dependencies
* src/base: 2cf9e16a5d..e6aabe4cb0
* src/build: c8168ef10e..6423f04a6f
* src/ios: fdc902ca9b..0622f2176e
* src/testing: 3787411136..48be0fd309
* src/third_party: 52189c0bdd..c293196758
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2a52133e52..7f8536d0bb
* src/third_party/perfetto: f8af68b972..ce19ce7576
* src/tools: 66b2c39f3e..c2974f15f5
DEPS diff: 88bd4f95d9..beee8267c9/DEPS

No update to Clang.

BUG=None

Change-Id: Icbc39c689ad4603cb320523f9a9b5416f01b78b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270451
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37676}
2022-08-03 12:44:35 +00:00
d2209256ab [PCLF] Introduce export_frame_ids option for video dump
Bug: b/240540206
Change-Id: I2d09be585804aa38b0bbc9e7b34dcd8f91f58846
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270425
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37675}
2022-08-03 11:39:05 +00:00
4c269322d6 Reland "Remove FrameBuffer2Proxy"
This is a reland of commit de0d063767bbaffae7ab9b2c785bb862b387ae5c

Original change's description:
> Remove FrameBuffer2Proxy
>
> Bug: webrtc:14003
> Change-Id: I461a9159b33ca3693bcb59d94c2035093825588b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265866
> Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37253}

Bug: webrtc:14003
Change-Id: I2df8484894452010dfa7fc2aea64d60298116300
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266493
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37674}
2022-08-03 11:01:18 +00:00
5fbe42a0b3 Clean up FieldTrials unit tests
This renames the tests to also capture the expected outcome of the test
along with some minor code cleanups. Some tests have also been added or
extended to tests more invariants.

Bug: None
Change-Id: I0bc733026118eb90646929b164bfc148665556a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267169
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Auto-Submit: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37673}
2022-08-03 10:05:44 +00:00
96191f8e68 Fine grain LogSink APIs.
The goal of this CL is to create a new LogSink::OnLogMessage API which
propagates the source location of the log to the log sinks.

Bug: b/238157120
Change-Id: I5a12bf80fd9c5569ed7aa1ef9185eee58830b19f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269249
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37672}
2022-08-03 10:01:20 +00:00
85bb04c7ba Update WebRTC code version (2022-08-03T04:03:46).
Bug: None
Change-Id: I140e85c6a264e0738cfa8999e8932982662cd295
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270447
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37671}
2022-08-03 05:46:14 +00:00
2d20d64cb0 Roll chromium_revision e039fb69c1..88bd4f95d9 (1030769:1030881)
Change log: e039fb69c1..88bd4f95d9
Full diff: e039fb69c1..88bd4f95d9

Changed dependencies
* src/base: 27507f9137..2cf9e16a5d
* src/build: e821e4d06b..c8168ef10e
* src/ios: 2b9dec4289..fdc902ca9b
* src/testing: f3b028f87a..3787411136
* src/third_party: 144e47ec74..52189c0bdd
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/81c03c3de9..2a52133e52
* src/third_party/freetype/src: d53c114165..dcb5fc5bcd
* src/third_party/fuchsia-sdk/sdk: version:9.20220802.1.1..version:9.20220802.3.1
* src/third_party/libyuv: b028453ba6..98ec7c28d5
* src/tools: db5b4e68e8..66b2c39f3e
DEPS diff: e039fb69c1..88bd4f95d9/DEPS

No update to Clang.

BUG=None

Change-Id: Ie6a9612a2c1b2d8c8f70918188aba52813e2e9a0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270446
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37670}
2022-08-03 04:37:45 +00:00
67acb91599 Roll chromium_revision c695005957..e039fb69c1 (1030652:1030769)
Change log: c695005957..e039fb69c1
Full diff: c695005957..e039fb69c1

Changed dependencies
* src/base: 4a723eb39f..27507f9137
* src/build: 5c3bc82e74..e821e4d06b
* src/ios: 7159259797..2b9dec4289
* src/testing: 7d2f854951..f3b028f87a
* src/third_party: 70512cf946..144e47ec74
* src/tools: 1c9552fc24..db5b4e68e8
DEPS diff: c695005957..e039fb69c1/DEPS

Clang version changed llvmorg-15-init-17529-ga210f404:llvmorg-16-init-572-gdde41c6c
Details: c695005957..e039fb69c1/tools/clang/scripts/update.py

BUG=None

Change-Id: I1f7889b0fd00bf33a0cbace9d7bf052b031ed487
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270443
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37669}
2022-08-02 23:05:54 +00:00
47be1493b6 Remove unused field trial WebRTC-VP8ScreenshareTemporalLayers.
Bug: webrtc:9477
Change-Id: I5419653fea369ad253c4815f2b961db7e92b332b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269203
Auto-Submit: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37668}
2022-08-02 20:15:54 +00:00
2189415be3 Roll chromium_revision 4fff7d553e..c695005957 (1030494:1030652)
Change log: 4fff7d553e..c695005957
Full diff: 4fff7d553e..c695005957

Changed dependencies
* src/base: feb65a503a..4a723eb39f
* src/build: 4527ab500e..5c3bc82e74
* src/ios: de78d0ec39..7159259797
* src/testing: 03d22b4428..7d2f854951
* src/third_party: 9ac8c9aef2..70512cf946
* src/third_party/freetype/src: a18ad83e8b..d53c114165
* src/third_party/fuchsia-sdk/sdk: version:9.20220801.2.1..version:9.20220802.1.1
* src/third_party/r8: 5xaODYedSIJ21XAwZcpj4pG3NuVyKXrw43631PdtgK0C..fyrZX7YFSdaFh8Uqs1iTtsYtS8351A4ndoz7WiIIrDgC
* src/tools: d06fb78650..1c9552fc24
DEPS diff: 4fff7d553e..c695005957/DEPS

No update to Clang.

BUG=None

Change-Id: I1dc6521e83243bcd384be0f63cb8d6778d697963
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270441
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37667}
2022-08-02 18:41:19 +00:00
dfc4d81fd3 [WebRtcVideoReceiveStream] Construct flexfec stream on demand.
...for payload type changes and avoid recreating the main video stream.

Bug: webrtc:11993
Change-Id: I03e44ff25d88caeb082a2e44b2e802d3b9392feb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269244
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37666}
2022-08-02 16:33:04 +00:00
72bc2e24cc [PCLF] Introduce VideoDumpOptions API to better control video dumping
This CL propose a new API for video dumps in PCLF also removing
differences between p2p and multipeer usage of API.

Bug: b/240540206
Change-Id: Id4d32cc98250500949b3f9e2cf2e86c4bdce7efb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270400
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37665}
2022-08-02 15:13:04 +00:00
a204ad210d clean up misc TimeDelta use
follow-up from https://webrtc-review.googlesource.com/c/src/+/262810

* replace Time::Millis(0) and TimeDelta::Millis(0) with ::Zero()
* drop unnecessary webrtc namespace from some TimeDeltas
* make TimeDelta do the unit conversion for stats

BUG=webrtc:13756

Change-Id: Ic60625ae0fc7959a47a6be9f5051851feaf76373
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265875
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37664}
2022-08-02 13:52:36 +00:00
175d77ce77 Roll chromium_revision 37771fc5bc..4fff7d553e (1030366:1030494)
Change log: 37771fc5bc..4fff7d553e
Full diff: 37771fc5bc..4fff7d553e

Changed dependencies
* src/base: e2855e8b9d..feb65a503a
* src/build: b1d3dcea6a..4527ab500e
* src/ios: 8b01b97a44..de78d0ec39
* src/testing: 0260b894e7..03d22b4428
* src/third_party: fd5911272d..9ac8c9aef2
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/682d9b1d88..81c03c3de9
* src/third_party/fuchsia-sdk/sdk: version:9.20220801.1.1..version:9.20220801.2.1
* src/tools: a75f817bb1..d06fb78650
DEPS diff: 37771fc5bc..4fff7d553e/DEPS

No update to Clang.

BUG=None

Change-Id: Id8597da1ae0f65e36deb1a87f79daddb8d9a59cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270362
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37663}
2022-08-02 12:36:44 +00:00
6397fb4f6c Move TaskQueuePacedSender::EnqueuePackets tracing onto the task queue.
This should avoid any potential race in static initialization for the
tracing logic.

Bug: webrtc:12715
Change-Id: Ic91d8e5fbd9b45a91e7e7a9e76226fc558e00c4b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270381
Auto-Submit: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37662}
2022-08-02 12:26:34 +00:00
185f10c082 [WebRtcVideoReceiveStream] Add ability to config flexfec post init.
Bug: webrtc:11993
Change-Id: I35d7e645e18b7cb4a86645ea52c8958063f13d3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269243
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37661}
2022-08-02 11:37:26 +00:00
5e13d0599c Request refresh frame after unpausing encoder with native frame drop.
If a "normal" software buffer frame is dropped during paused state, we
store it as a pending frame and try encoding it after the pause state is
lifted. However, native frames are dropped entirely since keeping e.g.
texture handles for long time periods can lead to side effects.

Work around this by requesting a refresh frame after unpausing if the
dropped frame flag is set.

Bug: webrtc:14276
Change-Id: I9edd1e99454e082bcfe29f3d9041026dd8a390d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270220
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37660}
2022-08-02 11:35:16 +00:00
ca85194e40 Remove unused sigslot::repeater
Bug: webrtc:11943
Change-Id: I7a98038983edd8a14e741b204fc0e3a64741b3ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270380
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37659}
2022-08-02 10:17:38 +00:00
1e589eb77f Modify GetBestIP to prefer global IPv6 addresses to the link local IPv6 addresses.
The change is behind the flag WebRTC-PreferGlobalIPv6ToLinkLocal.

Bug: webrtc:14306
Change-Id: Id2cae2e510fcfd007016e79ae4bd46947101d0fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269762
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37658}
2022-08-02 10:16:35 +00:00
496ad52cb2 UpdateCurrentDelay should update delay with rounding errors
Some of the timestamps input into UpdateCurrentDelay are not truncated
to milliseconds and thus a small negative delay can result. This means
the delay will not update when it should have.

Bug: webrtc:14168
Change-Id: I5293339b6a39201c680854e9596b717025ee8dc1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266370
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37657}
2022-08-02 08:47:54 +00:00